- 14 Jun, 2018 2 commits
-
-
Tobias Klauser authored
Follow the convertion (https://golang.org/s/generatedcode) for generated code. Change-Id: If06c4d5c3974a163ff75a9acc7141292eb43b7ef Reviewed-on: https://go-review.googlesource.com/118818 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Tobias Klauser authored
Follow the convertion (https://golang.org/s/generatedcode) for generated code. Change-Id: I27899b24366d5c0d2c5574b5eaf3d7e0babc8909 Reviewed-on: https://go-review.googlesource.com/118820 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 13 Jun, 2018 3 commits
-
-
Michael Stapelberg authored
Change-Id: I280fc3b2cd3402c40f2840d152bac2fa288f48a0 Reviewed-on: https://go-review.googlesource.com/118661 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Tobias Klauser authored
Change-Id: I7005494cbb955804c9f5bbcecf148fd77808a0b9 Reviewed-on: https://go-review.googlesource.com/118615 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Tobias Klauser authored
Change-Id: I4e3101b4689e8e94fbae6634975d10c8bb6b8a31 Reviewed-on: https://go-review.googlesource.com/118616 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 12 Jun, 2018 1 commit
-
-
Matt Layher authored
The code has been regenerated using the updated software versions. Change-Id: Ic2af968d4d8cbf3ab31e5bca1d6640642eb7115a Reviewed-on: https://go-review.googlesource.com/118255 Run-TryBot: Matt Layher <mdlayher@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
-
- 11 Jun, 2018 2 commits
-
-
Thanabodee Charoenpiriyakij authored
TOKEN_ALL_ACCESS was changed at some stage by Microsoft. Fixes golang/go#25775 Change-Id: I002200ad4c5188d19ac3c500f571dd13ea1fbafc Reviewed-on: https://go-review.googlesource.com/117815 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
-
Tobias Klauser authored
Implement socketcall and rawsocketcall in addition to seek (already introduced in CL 100076) to support compiling with gccgo on linux/386 Change-Id: Iaa51aa159a4743ae0e394f541ff196e2d28aa27f Reviewed-on: https://go-review.googlesource.com/117697 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 10 Jun, 2018 1 commit
-
-
Tobias Klauser authored
The calls to use were removed in CL 36715. Change-Id: I9f664d57e2595e932d702fdf6318d377e93e428a Reviewed-on: https://go-review.googlesource.com/117455 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 06 Jun, 2018 3 commits
-
-
Ian Lance Taylor authored
Current versions of gccgo report a redefinition error for both a declaration and definition, as of https://golang.org/cl/93083. Fix the last change to work with this. Change-Id: Iae6a664fcc9fe97d4e3b7845a05dab3a8ad56830 Reviewed-on: https://go-review.googlesource.com/116776 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Alex Vaghin authored
It uses __get_cpuid_count, provided by cpuid.h. The xgetbv is implemented after its counterpart in cpu_x86.s. Change-Id: I97624d7da67ab4ec3c9a53b0bfc4dfcdf7d12c87 Reviewed-on: https://go-review.googlesource.com/116155Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Tobias Klauser authored
Add a CacheLinePad struct type that has a size of cacheLineSize. This can be used for padding structs in order to avoid false sharing. Fixes golang/go#25203 Change-Id: I6b6daf91ea0e9c50428ffa053035429c3921b461 Reviewed-on: https://go-review.googlesource.com/111775 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 25 May, 2018 3 commits
-
-
Tobias Klauser authored
On some builders TestStatx occassionally fails when comparing atime between Statx and Stat/Lstat. --- FAIL: TestStatx (0.00s) syscall_linux_test.go:365: Statx: returned stat atime does not match Lstat Fix it by dropping the atime comparison, it's enough to verify Statx working correctly by comparing ctime and mtime. Also, not all filesystems support atime. Change-Id: I7da68bd20b9b21274c4993aa2c4241395d2c933a Reviewed-on: https://go-review.googlesource.com/114616 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Tobias Klauser authored
CL 114518 introduced Nfgenmsg as a type alias which breaks the build on Go <= 1.9. Fix it by making Nfgenmsg a type like all others in x/sys/unix Updates golang/go#25561 Fixes golang/go#25563 Change-Id: I9950be857e34e7e3ca79c71fced9663a0cac9b63 Reviewed-on: https://go-review.googlesource.com/114596 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Michael Stapelberg authored
Change-Id: I55efe06ec81e891ec3872405ba75c7eb9ce4e635 Reviewed-on: https://go-review.googlesource.com/114518Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 24 May, 2018 4 commits
-
-
Tobias Klauser authored
Like on linux, lsetxattr on symlinks returns EPERM. Change-Id: I6dfc59484e1826872af54579dd6ec02705c816da Reviewed-on: https://go-review.googlesource.com/114535 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Tobias Klauser authored
The mkfifo syscall is disallowed on android and iOS. sched_setaffinity is disallowed on android. Skip all tests which use them. /usr/bin does not exist on android. Use /system/bin in TestGetwd instead, like TestChdirAndGetwd in the os package. Like linux, android does not support Fchmodat with flags != 0. Adjust TestFchmodat accordingly. TestDevices might stat some device files which are not accessible, skip those. iOS cannot exec subprocesses, thus skip TestPassFD. Fixes golang/go#25535 Change-Id: Ic764b9152f0a7b703ad4f47fdb1a9a5e94718154 Reviewed-on: https://go-review.googlesource.com/114395 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Tobias Klauser authored
Instead, add a small test verify Major, Minor and Mkdev using arbitrary numbers. Leave TestDevices on Linux as its major/minor numbers are guaranteed stable. Updates golang/go#25528 Updates golang/go#25535 Change-Id: Ic105211660d80f9b3508ca9d518e9fac3b7e3beb Reviewed-on: https://go-review.googlesource.com/114396 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
pytimer authored
Fixes golang/go#25485 Change-Id: Ic00df1f86591c00fa88cddcb03c7ced0c6bdb0c1 Reviewed-on: https://go-review.googlesource.com/114215 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
-
- 23 May, 2018 3 commits
-
-
Tobias Klauser authored
Updates golang/go#14456 Change-Id: I04632ef1d302e938a2cc373eb90f600f01404380 Reviewed-on: https://go-review.googlesource.com/114198 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Hana Kim authored
Fixes golang/go#25529 Change-Id: Ifb7060106608fab0c87ce4596c9f16c14bde6205 Reviewed-on: https://go-review.googlesource.com/114093Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Hana Kim authored
The test uses hardcoded numbers specific to one Solaris variant or version. It's not guaranteed that they are stable over time or across variants. Fixes golang/go#25528 Change-Id: I148bd4d8264b802f07a2e886b99e76a40824af35 Reviewed-on: https://go-review.googlesource.com/114092Reviewed-by: Aram Hăvărneanu <aram@mgk.ro> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 22 May, 2018 5 commits
-
-
Tobias Klauser authored
Based on the tests in github.com/pkg/xattr Change-Id: I3af73ad538877da042602708248063c218260a2e Reviewed-on: https://go-review.googlesource.com/114135 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Hana Kim authored
https://storage.googleapis.com/go-build-log/489a6b5c/misc-vet-vetall_c1e51035.log cmd/vendor/golang.org/x/sys/windows/asm_windows_amd64.s:12: [amd64] loadlibrary: wrong argument size 8; expected $...-24 Change-Id: I02e7c53216e2c55d0d062e50f72984228c214e23 Reviewed-on: https://go-review.googlesource.com/114082Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
irfan sharif authored
It's only when dest is set to NULL that the OS X implementations of getxattr() and listxattr() return the current sizes of the named attributes. An empty byte array is not sufficient. To maintain the same behaviour as the linux implementation, we wrap around the system calls and pass in NULL when dest is empty. The parameters for the OS X implementation of setxattr() vary slightly compared to the linux system call, specifically the 'position' parameter: linux: int setxattr( const char *path, const char *name, const void *value, size_t size, int flags ); darwin: int setxattr( const char *path, const char *name, void *value, size_t size, u_int32_t position, int options ); 'position' specifies the offset within the extended attribute. In the current implementation, only the resource fork extended attribute makes use of this argument. For all others, position is reserved. We simply default to setting it to zero. If that's needed by the package user, a function with a different name needs to be implemented instead. Similarly for removexattr(), we wrap around and explicitly zero out the options provided. We do so for interoperability with the linux variant. If options are needed by the package user, a function with a different name needs to be implemented instead. Fixes golang/go#14456 Change-Id: I2581e1fa8dc9324bced7fda7f8ada10fe2ede3f5 Reviewed-on: https://go-review.googlesource.com/113995Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Filippo Valsorda authored
Change-Id: I0a16c77437e4ed68cc19eda41bb9b64ab4376fd0 Reviewed-on: https://go-review.googlesource.com/114075 Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
-
Tobias Klauser authored
CL 112696 changed mkerrors.sh to add filesystem magic constants on linux. This leads to the unrelated AUDIT_RECORD_MAGIC constant being added on darwin. Avoid this by explicity excluding it in mkerrors.sh. Change-Id: I5a73797e5e9a1a92cb39f96f360fdb48982a7741 Reviewed-on: https://go-review.googlesource.com/114095 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 14 May, 2018 1 commit
-
-
Tobias Klauser authored
Change-Id: I4f2fd8a7c899403f545d8dc73fec2ebbb0b322c0 Reviewed-on: https://go-review.googlesource.com/113035 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 11 May, 2018 2 commits
-
-
Brad Fitzpatrick authored
Fixes golang/go#25354 Change-Id: Ic74005ed26792a78354ffe76f567e9a009eabe9a Reviewed-on: https://go-review.googlesource.com/112738 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
-
Tobias Klauser authored
Fixes golang/go#25341 Change-Id: I79cb4c77b771e005eb27d4e495ac6a7491e2e66e Reviewed-on: https://go-review.googlesource.com/112696 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 10 May, 2018 1 commit
-
-
Hana (Hyang-Ah) Kim authored
Found in https://storage.googleapis.com/go-build-log/300ed876/misc-vet-vetall_dd96a388.log cmd/vendor/golang.org/x/sys/windows/asm_windows_386.s:9: [386] getprocaddress: wrong argument size 8; expected $...-16 cmd/vendor/golang.org/x/sys/windows/asm_windows_386.s:12: [386] loadlibrary: wrong argument size 4; expected $...-12 cmd/vendor/golang.org/x/sys/windows/svc/service.go:337: cmd/vendor/golang.org/x/sys/windows.SERVICE_TABLE_ENTRY composite literal uses unkeyed fields cmd/vendor/golang.org/x/sys/windows/svc/service.go:338: cmd/vendor/golang.org/x/sys/windows.SERVICE_TABLE_ENTRY composite literal uses unkeyed fields cmd/vendor/golang.org/x/sys/windows/svc/debug/service.go:34: cmd/vendor/golang.org/x/sys/windows/svc.ChangeRequest composite literal uses unkeyed fields cmd/vendor/golang.org/x/sys/windows/svc/mgr/config.go:124: cmd/vendor/golang.org/x/sys/windows.SERVICE_DESCRIPTION composite literal uses unkeyed fields Change-Id: Ic08cfcc802aac89cfa1eb98661ec556c844e8013 Reviewed-on: https://go-review.googlesource.com/112557Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 09 May, 2018 1 commit
-
-
Hana (Hyang-Ah) Kim authored
From https://storage.googleapis.com/go-build-log/ebe363d0/misc-vet-vetall_b459ec91.log cmd/vendor/golang.org/x/sys/unix/asm_dragonfly_amd64.s:16: [amd64] Syscall: wrong argument size 64; expected $...-56 cmd/vendor/golang.org/x/sys/unix/asm_dragonfly_amd64.s:19: [amd64] Syscall6: wrong argument size 88; expected $...-80 cmd/vendor/golang.org/x/sys/unix/asm_dragonfly_amd64.s:22: [amd64] Syscall9: wrong argument size 112; expected $...-104 cmd/vendor/golang.org/x/sys/unix/asm_dragonfly_amd64.s:25: [amd64] RawSyscall: wrong argument size 64; expected $...-56 cmd/vendor/golang.org/x/sys/unix/asm_dragonfly_amd64.s:28: [amd64] RawSyscall6: wrong argument size 88; expected $...-80 Change-Id: I5c2264154e819a124aade5d18d261b7934b0090a Reviewed-on: https://go-review.googlesource.com/112556Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 07 May, 2018 1 commit
-
-
Tobias Klauser authored
The messages contain no format string, so there is no need to use t.Fatalf. Change-Id: I29098c04797f919784b732af84a63fbaed671558 Reviewed-on: https://go-review.googlesource.com/111776 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 04 May, 2018 1 commit
-
-
Tobias Klauser authored
Add ErrnoName and SignalName to get errno and signal name strings from syscall.Errno and syscall.Signal values, respectively. This repurposes the errors and signals vars (because they are not used within x/sys/unix currently) and turns them into slices of struct, containing errno/signal number, name and description. ErrnoName and SignalName can then be trivially implemented using sort.Search. Renaming errors to errorList additionaly allows to avoid package aliases for the errors package. Fixes golang/go#25134 Change-Id: Ie195872793f44c437f0f175ccfaa13a2546338c5 Reviewed-on: https://go-review.googlesource.com/110875 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 01 May, 2018 1 commit
-
-
Alex Brainman authored
Second argument of servicemain is a pointer. See https://msdn.microsoft.com/en-us/library/windows/desktop/ms685138(v=vs.85).aspx So amd64 assembler code should use MOVQ to read that value. I probably copied 386 assembler code into amd64 and did not adjust the code. Broken code was used to pass parameters to the service, so add some tests to verify that parameter passing works. Fixes golang/go#24575 Change-Id: I89f8cad026ea13f8a5d78ff3e24b7236e27fc91f Reviewed-on: https://go-review.googlesource.com/110160 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 30 Apr, 2018 2 commits
-
-
Andreas Auernhammer authored
This CL introduces a new cpu package for CPU/platform feature detection. The cpu package is basically a copy of `internal/cpu` of the standard library. Revision: bf86aec25972f3a100c3aa58a6abcbcc35bdea49 This CL does not export ARM64 and PPC64 feature detection since at the moment ARM64/PPC64 requires standard library support. Updates golang/go#24843 Change-Id: I11bc1ca60b116e902c941b5887c00870dbb1f899 Reviewed-on: https://go-review.googlesource.com/107015Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Tobias Klauser authored
The stat syscall is disallowed by Android's seccomp policy on linux/amd64. Use the fstatat syscall with AT_FDCWD and zero flags to achieve the same behavior. CL 109835 did the same for package syscall. Change-Id: Iaa7d0dbf17ade4803f59b4361973ce627bcb65b4 Reviewed-on: https://go-review.googlesource.com/110061 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 27 Apr, 2018 1 commit
-
-
Jason A. Donenfeld authored
This is yet another syscall that needs to be changed around for Android's seccomp. We already do this in MIPS64 and ARM64, but apparently forgot about AMD64. Change-Id: I42c8a4653a55d4714dacfaf7add14012f428c992 Reviewed-on: https://go-review.googlesource.com/109835Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 25 Apr, 2018 1 commit
-
-
Ian Lance Taylor authored
Change-Id: If795a53b8532c35731f18b9a94ca8c53a4bc23c2 Reviewed-on: https://go-review.googlesource.com/109357 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 20 Apr, 2018 1 commit
-
-
Matt Layher authored
These types and constants are taken from hdreg.h, and will enable querying and manipulation of block devices on Linux. Fixes golang/go#24971 Change-Id: Iafe8f81ba7ab9f1e127743dab6a9fb1912874a5c Reviewed-on: https://go-review.googlesource.com/108455 Run-TryBot: Matt Layher <mdlayher@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
-