- 27 Jul, 2018 4 commits
-
-
Ian Lance Taylor authored
The Linux kernel faccessat system call does not take a flags parameter. The flag parameter to the C library faccessat function is implemented in C. The unix.Faccessat function takes a flags parameter. In older releases we have passed the flags parameter to the kernel, which ignored it. In CL 119495 we started returning an error if any flags were set. That seems clearly better than ignoring them, but it turns out that some code was using the flags. The code was previously subtly broken. Now it is obviously broken. That is better, but we can do better still: we can implement the flags as the C library does. That is what this CL does. Change-Id: I02d4bb981ebd39eb35e47c6e5281f85eaea68016 Reviewed-on: https://go-review.googlesource.com/126516 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
For manipulating Linux partitions with the BLKPG ioctl. Change-Id: I2196038ccfc39ecd6926817c3b310d0837220095 Reviewed-on: https://go-review.googlesource.com/125642 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Jeet Parekh authored
Keeps the documentation in sync with syscall package. Copies the changes from CL https://golang.org/cl/126035. Change-Id: I778725fd7d5e96ddf839d33e1d220e5a12e2d24f GitHub-Last-Rev: 4b30513126d7ffbca31640a6120a2259b6a226db GitHub-Pull-Request: golang/sys#12 Reviewed-on: https://go-review.googlesource.com/126435Reviewed-by: Austin Clements <austin@google.com>
-
David Wimmer authored
Change the Pipe() function to use the pipe() syscall (which has a unique calling convention on linux/mips) instead of using pipe2(). This allows it to work on kernels <2.6.27 when pipe2() was introduced. Change-Id: I088886e66b594232869d8b88c6e1a630c76188a3 Reviewed-on: https://go-review.googlesource.com/126176Reviewed-by: Vladimir Stefanovic <vladimir.stefanovic@mips.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 24 Jul, 2018 1 commit
-
-
Brad Fitzpatrick authored
Change-Id: I42e59149e58bd928d9beb2c6665ce186b377d2a1 Reviewed-on: https://go-review.googlesource.com/125640 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 15 Jul, 2018 1 commit
-
-
madiganz authored
Added configuration options for a windows service recovery settings. New configurations include modifying the reboot message, or command to be run when a service fails, and getting the current reboot message or command. Fixes golang/go#23239 Change-Id: I3e501d66e97745b7536fd654aee2bba488083e6d Reviewed-on: https://go-review.googlesource.com/122579 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
-
- 09 Jul, 2018 2 commits
-
-
Alexander Menzhinsky authored
Add the SockaddrRFCOMM type and the ability to accept BTPROTO_L2CAP and BTPROTO_RFCOMM protocol sockets. Fixes golang/go#22211 Change-Id: I580b526c5392b90663499af0f2ebe6f55b1f8154 Reviewed-on: https://go-review.googlesource.com/122457 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
-
Tobias Klauser authored
This way we'll get the correct generated code comments. Change-Id: I273cd16dcce99b49b6df0b86fc191b3ff5d7167a Reviewed-on: https://go-review.googlesource.com/122458 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 07 Jul, 2018 1 commit
-
-
Kropekk authored
Added all remaining file attributes constants present on Windows OS. According to: https://docs.microsoft.com/en-gb/windows/desktop/FileIO/file-attribute-constants Fixes golang/go#25979 Change-Id: Ie8cb9edfbd37b3121066b291e4e2a01573c63087 Reviewed-on: https://go-review.googlesource.com/122236 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
-
- 06 Jul, 2018 1 commit
-
-
Tobias Klauser authored
Somehow they were not included in CL 119495. No functional change, faccessat was just moved. Change-Id: I954a37109ff2287de14cdf657bd309cae96671de Reviewed-on: https://go-review.googlesource.com/122297 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 04 Jul, 2018 1 commit
-
-
Zachary Madigan authored
Added configuration options for a windows service recovery settings. Current configurations include modifying actions taken when a service fails, setting the reset period, and getting the current recovery settings. Updates golang/go#23239 Change-Id: I4e91b2068122731e6eba3332afb0fe300b298c97 Reviewed-on: https://go-review.googlesource.com/104635 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
-
- 27 Jun, 2018 1 commit
-
-
Ian Lance Taylor authored
Fixes golang/go#26078 Change-Id: Ie5a8c7028a755bc7a8d56abc4736a5f61ef91ce5 Reviewed-on: https://go-review.googlesource.com/121175 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 26 Jun, 2018 1 commit
-
-
Tobias Klauser authored
Some file systems don't support sub-second time stamp resolution. Handle these correctly by only checking nanoseconds in case Mtim.Nsec is zero. Fixes golang/go#26034 Change-Id: I1ab400b8e09b5cfdac6b70a33f676770a48180b1 Reviewed-on: https://go-review.googlesource.com/120816 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: jimmy frasche <soapboxcicero@gmail.com>
-
- 25 Jun, 2018 1 commit
-
-
Tobias Klauser authored
If the underlying filesystem doesn't support atime or was mounted with the noatime mount option, TestUtimesNanoAt fails when comparing atime: --- FAIL: TestUtimesNanoAt (0.00s) syscall_linux_test.go:144: UtimesNanoAt: wrong atime: {1111 0} syscall_linux_test.go:147: UtimesNanoAt: wrong mtime: {3333 0} FAIL FAIL golang.org/x/sys/unix 0.376s Fix it by dropping the atime comparison, it's enough to verify UtimesNanoAt working correctly by comparing mtime. Fixes golang/go#26034 Change-Id: Id868f9d4c6a856a99ae930a46bfe91bd64ca8570 Reviewed-on: https://go-review.googlesource.com/120562 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 22 Jun, 2018 1 commit
-
-
Tobias Klauser authored
The ustat syscall has been deprecated on Linux for a long time and the upcoming glibc 2.28 will remove ustat.h and it can no longer be used to to generate the Ustat_t wrapper type. Since Linux still provides the syscall, let's not break this functionality and add a private copy of struct ustat so Ustat_t can still be generated. Updates golang/go#25990 Change-Id: I74cf405ce6df92da36f1ee900ab6d98997d8f994 Reviewed-on: https://go-review.googlesource.com/120295 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 20 Jun, 2018 1 commit
-
-
Thanabodee Charoenpiriyakij authored
Currently Linux faccessat(2) syscall implementation doesn't support the flags parameter. As per discuss in golang/go#25845, permit the same flags as glibc [1]. [1] https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/faccessat.c;h=ea42b2303ff4b2d2d6548ea04376fb265f773436;hb=HEAD Fixes golang/go#25845 Change-Id: I390ba14b2816283399472f3572967b19d0a36042 Reviewed-on: https://go-review.googlesource.com/119495 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 19 Jun, 2018 2 commits
-
-
Tobias Klauser authored
On linux/arm64 we used to manually define syscall numbers for some deprecated syscalls. Most of them are unused by now anyhow. Convert the remaining syscall wrappers using them to implement the respective functionality using a non-deprecated syscall (in the same way glibc does it): - Implement EpollCreate using EpollCreate1 and additionally check that the passed size argument is larger than 0. - Implement Futimesat and utimes using utimensat. Also change futimesat on the other geese to take a string instead of *byte and let the generated wrapper do the BytePtrFromString conversion. - Return ENOSYS from Ustat. The ustat syscall has been deprecated for a long time in favor of fstatfs and statfs. Even glibc will deprecate ustat in the upcoming 2.28 release [1]. [1] https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=d51fa09544f03899b7ff5a80569db088c3c23c28;hb=HEAD#l90 Change-Id: I7ea38a3cd394b0875f17443b14e107fd9c70350d Reviewed-on: https://go-review.googlesource.com/119655 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Tobias Klauser authored
Change-Id: Ie720f7c4d496e67f2a81de379374c2ec1f95bb96 Reviewed-on: https://go-review.googlesource.com/119556 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 16 Jun, 2018 1 commit
-
-
Alex Brainman authored
This CL is a copy of CL 106275 (see CL 106275 for details). It introduces CertInfo, CertTrustListInfo and CertRevocationCrlInfo types. It uses pointers to new types instead of uintptr in CertContext, CertSimpleChain and CertRevocationInfo. CertRevocationInfo, CertChainPolicyPara and CertChainPolicyStatus types have uintptr field that can be pointer to many different things (according to Windows API). So this CL introduces Pointer type to be used for those cases. Fixes golang/go#25797 Change-Id: I7797ddc6daf3e67b7eab69ab9fbf4d51650f8b6a Reviewed-on: https://go-review.googlesource.com/118797Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 15 Jun, 2018 1 commit
-
-
Tobias Klauser authored
Regenerated with go tip to get the generated code comment following the convention (https://golang.org/s/generatedcode). Change-Id: Ie1365ecfa532b940bf7cfc8579c4cbda71cf7f76 Reviewed-on: https://go-review.googlesource.com/118817 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
-
- 14 Jun, 2018 2 commits
-
-
Tobias Klauser authored
Follow the convertion (https://golang.org/s/generatedcode) for generated code. Change-Id: If06c4d5c3974a163ff75a9acc7141292eb43b7ef Reviewed-on: https://go-review.googlesource.com/118818 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Tobias Klauser authored
Follow the convertion (https://golang.org/s/generatedcode) for generated code. Change-Id: I27899b24366d5c0d2c5574b5eaf3d7e0babc8909 Reviewed-on: https://go-review.googlesource.com/118820 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 13 Jun, 2018 3 commits
-
-
Michael Stapelberg authored
Change-Id: I280fc3b2cd3402c40f2840d152bac2fa288f48a0 Reviewed-on: https://go-review.googlesource.com/118661 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Tobias Klauser authored
Change-Id: I7005494cbb955804c9f5bbcecf148fd77808a0b9 Reviewed-on: https://go-review.googlesource.com/118615 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Tobias Klauser authored
Change-Id: I4e3101b4689e8e94fbae6634975d10c8bb6b8a31 Reviewed-on: https://go-review.googlesource.com/118616 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 12 Jun, 2018 1 commit
-
-
Matt Layher authored
The code has been regenerated using the updated software versions. Change-Id: Ic2af968d4d8cbf3ab31e5bca1d6640642eb7115a Reviewed-on: https://go-review.googlesource.com/118255 Run-TryBot: Matt Layher <mdlayher@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
-
- 11 Jun, 2018 2 commits
-
-
Thanabodee Charoenpiriyakij authored
TOKEN_ALL_ACCESS was changed at some stage by Microsoft. Fixes golang/go#25775 Change-Id: I002200ad4c5188d19ac3c500f571dd13ea1fbafc Reviewed-on: https://go-review.googlesource.com/117815 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
-
Tobias Klauser authored
Implement socketcall and rawsocketcall in addition to seek (already introduced in CL 100076) to support compiling with gccgo on linux/386 Change-Id: Iaa51aa159a4743ae0e394f541ff196e2d28aa27f Reviewed-on: https://go-review.googlesource.com/117697 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 10 Jun, 2018 1 commit
-
-
Tobias Klauser authored
The calls to use were removed in CL 36715. Change-Id: I9f664d57e2595e932d702fdf6318d377e93e428a Reviewed-on: https://go-review.googlesource.com/117455 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 06 Jun, 2018 3 commits
-
-
Ian Lance Taylor authored
Current versions of gccgo report a redefinition error for both a declaration and definition, as of https://golang.org/cl/93083. Fix the last change to work with this. Change-Id: Iae6a664fcc9fe97d4e3b7845a05dab3a8ad56830 Reviewed-on: https://go-review.googlesource.com/116776 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Alex Vaghin authored
It uses __get_cpuid_count, provided by cpuid.h. The xgetbv is implemented after its counterpart in cpu_x86.s. Change-Id: I97624d7da67ab4ec3c9a53b0bfc4dfcdf7d12c87 Reviewed-on: https://go-review.googlesource.com/116155Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Tobias Klauser authored
Add a CacheLinePad struct type that has a size of cacheLineSize. This can be used for padding structs in order to avoid false sharing. Fixes golang/go#25203 Change-Id: I6b6daf91ea0e9c50428ffa053035429c3921b461 Reviewed-on: https://go-review.googlesource.com/111775 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 25 May, 2018 3 commits
-
-
Tobias Klauser authored
On some builders TestStatx occassionally fails when comparing atime between Statx and Stat/Lstat. --- FAIL: TestStatx (0.00s) syscall_linux_test.go:365: Statx: returned stat atime does not match Lstat Fix it by dropping the atime comparison, it's enough to verify Statx working correctly by comparing ctime and mtime. Also, not all filesystems support atime. Change-Id: I7da68bd20b9b21274c4993aa2c4241395d2c933a Reviewed-on: https://go-review.googlesource.com/114616 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Tobias Klauser authored
CL 114518 introduced Nfgenmsg as a type alias which breaks the build on Go <= 1.9. Fix it by making Nfgenmsg a type like all others in x/sys/unix Updates golang/go#25561 Fixes golang/go#25563 Change-Id: I9950be857e34e7e3ca79c71fced9663a0cac9b63 Reviewed-on: https://go-review.googlesource.com/114596 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Michael Stapelberg authored
Change-Id: I55efe06ec81e891ec3872405ba75c7eb9ce4e635 Reviewed-on: https://go-review.googlesource.com/114518Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 24 May, 2018 4 commits
-
-
Tobias Klauser authored
Like on linux, lsetxattr on symlinks returns EPERM. Change-Id: I6dfc59484e1826872af54579dd6ec02705c816da Reviewed-on: https://go-review.googlesource.com/114535 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Tobias Klauser authored
The mkfifo syscall is disallowed on android and iOS. sched_setaffinity is disallowed on android. Skip all tests which use them. /usr/bin does not exist on android. Use /system/bin in TestGetwd instead, like TestChdirAndGetwd in the os package. Like linux, android does not support Fchmodat with flags != 0. Adjust TestFchmodat accordingly. TestDevices might stat some device files which are not accessible, skip those. iOS cannot exec subprocesses, thus skip TestPassFD. Fixes golang/go#25535 Change-Id: Ic764b9152f0a7b703ad4f47fdb1a9a5e94718154 Reviewed-on: https://go-review.googlesource.com/114395 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Tobias Klauser authored
Instead, add a small test verify Major, Minor and Mkdev using arbitrary numbers. Leave TestDevices on Linux as its major/minor numbers are guaranteed stable. Updates golang/go#25528 Updates golang/go#25535 Change-Id: Ic105211660d80f9b3508ca9d518e9fac3b7e3beb Reviewed-on: https://go-review.googlesource.com/114396 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
pytimer authored
Fixes golang/go#25485 Change-Id: Ic00df1f86591c00fa88cddcb03c7ced0c6bdb0c1 Reviewed-on: https://go-review.googlesource.com/114215 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
-
- 23 May, 2018 1 commit
-
-
Tobias Klauser authored
Updates golang/go#14456 Change-Id: I04632ef1d302e938a2cc373eb90f600f01404380 Reviewed-on: https://go-review.googlesource.com/114198 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-