• Matthew Dempsky's avatar
    cmd/internal/gc: remove namebuf variable · 8b3670ff
    Matthew Dempsky authored
    namebuf was a global char buffer in the C version of gc, which was
    useful for providing common storage for constructing symbol and file
    names.  However, now that it's just a global Go string and the string
    data is dynamically allocated anyway, it doesn't serve any purpose
    except to force extra write barriers everytime it's assigned to.
    
    Also, introduce Lookupf(fmt, args...) as shorthand for
    Lookup(fmt.Sprintf(fmt, args...)), which was a very common pattern for
    using namebuf.
    
    Passes "go build -toolexec 'toolstash -cmp' -a std".
    
    Notably, this CL shrinks 6g's text section by ~15kB:
    
    $ size toolstash/6g tool/linux_amd64/6g
       text	   data	    bss	    dec	    hex	filename
    4600805	 605968	 342988	5549761	 54aec1	toolstash/6g
    4585547	 605968	 342956	5534471	 547307	tool/linux_amd64/6g
    
    Change-Id: I98abb44fc7f43a2e2e48425cc9f215cd0be37442
    Reviewed-on: https://go-review.googlesource.com/7080Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    8b3670ff
init.go 3.33 KB