• Chris Farmiloe's avatar
    xml: match Marshal's XMLName behavior in Unmarshal · 55751a38
    Chris Farmiloe authored
    When xml.Marshal is called on a struct it will happily
    reflect the information in the "tag" of an XMLName member
    regardless of the type to give the struct a tag-name in
    it's XML form. This is backed up by the documentation which
    says:
    
    However xml.Unmarshal *does* care about the XMLName field
    being of type xml.Name, and currently returns the error
    "field XMLName does not have type xml.Name" if you have it
    set to something else.
    
    This is firstly inconsistant with xml.Marshal but it also
    makes it impossible to use xml.Marshal alongside other
    Marshallers (like json/bson) without poluting the state's
    namespace with XMLName fields. Inorder to exclude fields
    from other Marshallers the convention has been started to
    tag fields as "omitempty"; which will cause the field not
    to display if it is at it's "zero" state, XMLName cannot
    have such as zero-state since it is a struct, so it is nicer
    to use a pointer/bool value for XMLName so it can be easily
    excluded when I want to Marshal my struct by some other
    wire format.
    
    Attached is the proposed minor change, that simply stops
    erring if it can't set the name on the XMLName field, which
    is just optional metadata anyway.
    Fixes #2265.
    
    R=rsc
    CC=golang-dev
    https://golang.org/cl/5067044
    55751a38
read_test.go 11 KB