- 15 May, 2012 10 commits
-
-
Russ Cox authored
Also add -n -x flags to doc, fmt, vet. Also shorten unknown command error. Fixes #3612. Fixes #3613. R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/6211053
-
Jan Ziak authored
R=golang-dev, for.go.yong CC=golang-dev https://golang.org/cl/6197080
-
Russ Cox authored
Before: ./x.go:6: first argument to append must be slice; have nil After: ./x.go:6: first argument to append must be typed slice; have untyped nil Fixes #3616. R=ken2 CC=golang-dev https://golang.org/cl/6209067
-
Joel Sing authored
Update/correct NetBSD signal handling - most of this is needed due to the correctly generated runtime definitions. R=golang-dev, m4dh4tt3r, rsc CC=golang-dev https://golang.org/cl/6195079
-
Joel Sing authored
Fix and regenerate runtime defs for NetBSD. Whilst the mcontext struct can be handled across architectures, the registers are provided as defines that index an array, rather than as members of the struct. Since these are architecture dependent, include them via a defs_netbsd_<arch>.go file. R=golang-dev, m4dh4tt3r, rsc CC=golang-dev https://golang.org/cl/6190070
-
Jan Ziak authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6206056
-
Dmitriy Vyukov authored
Parallel GC needs to know in advance how many helper threads will be there. Hopefully it's the last patch before I can tackle parallel sweep phase. The benchmarks are unaffected. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6200064
-
Joel Sing authored
Fix types/names so that these functions work with the generated syscall/z* files. R=golang-dev, m4dh4tt3r CC=golang-dev https://golang.org/cl/6201078
-
Joel Sing authored
Set the TLS base using the _lwp_setprivate() syscall, instead of via sysarch(). NetBSD tracks the pointer passed to _lwp_setprivate() and restores this value when restoring mcontext. If sysarch() is used directly, restoring an mcontext trashes the FS/GS value, resulting in a segfault when we next try to access the TLS. R=golang-dev, r CC=golang-dev https://golang.org/cl/6206062
-
Brad Fitzpatrick authored
Empty parts can be either of the form: a) "--separator\r\n", header (w/ trailing 2xCRLF), \r\n "--separator"... or b) "--separator\r\n", header (w/ trailing 2xCRLF), "--separator"... We never handled case b). In fact the RFC seems kinda vague about it, but browsers seem to do a), and App Engine's synthetic POST bodies after blob uploads is of form b). So handle them both, and add a bunch of tests. (I can't promise these are the last fixes to multipart, especially considering its history, but I'm growing increasingly confident at least, and I've never submitted a multipart CL with known bugs outstanding, including this time.) R=golang-dev, adg CC=golang-dev https://golang.org/cl/6212046
-
- 14 May, 2012 7 commits
-
-
David Symonds authored
R=r CC=golang-dev https://golang.org/cl/6203076
-
Jan Mercl authored
Unbalanced extra right parenthesis produced an internal error instead of a more descriptive one. Fixes #3406. R=r, rsc CC=golang-dev https://golang.org/cl/6201063
-
Joel Sing authored
Fix mkerrors.sh so that it works on NetBSD. Remove directory mode bits from types - this already appears in errors. Regenerate the z* files now that cgo is working. R=golang-dev, m4dh4tt3r, r CC=golang-dev https://golang.org/cl/6201077
-
Michael Gehring authored
certLen was decoded incorrectly if length > 2^16-1. R=golang-dev, agl CC=golang-dev https://golang.org/cl/6197077
-
Adam Langley authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/6188076
-
Dmitriy Vyukov authored
No perf/semantic changes, merely improves code health. There were several questions as to why Once.Do uses atomic.CompareAndSwap to do a store. R=golang-dev, r CC=golang-dev https://golang.org/cl/6208057
-
David Symonds authored
R=adg CC=golang-dev https://golang.org/cl/6208051
-
- 13 May, 2012 1 commit
-
-
David Symonds authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6120047
-
- 11 May, 2012 2 commits
-
-
Dmitriy Vyukov authored
The change accidentally come in with this revision: https://code.google.com/p/go/source/detail?spec=svn345cbca96c5550f2e89bc727703301933802923c&r=14c38c23c819a17021b1808cf4a34ef3a1a17db5 R=golang-dev CC=golang-dev https://golang.org/cl/6195073
-
Dmitriy Vyukov authored
This is factored out part of: https://golang.org/cl/5279048/ (parallel GC) R=bsiegert, mpimenov, rsc, minux.ma, r CC=golang-dev https://golang.org/cl/5986054
-
- 10 May, 2012 4 commits
-
-
Shenghou Ma authored
we can't add the division result to n during iteration, because it might turn n into NaN or Inf. R=golang-dev, rsc, iant, iant CC=golang-dev https://golang.org/cl/6197045
-
Joel Sing authored
Use correct syscall numbers and arguments for NetBSD. Provide a trampoline for signal returns (using signal API 3). R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6209048
-
Joel Sing authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6198063
-
Joel Sing authored
Manually repair/update z* files for netbsd - this allows Go to compile again on 386. R=golang-dev, rsc, minux.ma CC=golang-dev https://golang.org/cl/6194064
-
- 09 May, 2012 4 commits
-
-
Marcel van Lohuizen authored
Also set maxContractLen automatically. Note that the table size is much bigger than it needs to be. Optimization is best done, though, when the language specific tables are added. R=r CC=golang-dev https://golang.org/cl/6167044
-
Francisco Souza authored
go help remote used to reference "go help importpath", which has changed to "go help packages". Fixes #3598. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6201065
-
Nigel Tao authored
Tested manually. Fixes #3554. Before: $ cd $GOROOT/src/pkg $ go list io io $ go list io/... io io/ioutil $ cd $GOROOT/src/pkg/io $ go list . io $ go list ./... io/ioutil After: $ cd $GOROOT/src/pkg $ go list io io $ go list io/... io io/ioutil $ cd $GOROOT/src/pkg/io $ go list . io $ go list ./... io io/ioutil $ go list ././... io io/ioutil $ go list ././.././io/... io io/ioutil $ go list ../image image $ go list ../image/... image image/color image/draw image/gif image/jpeg image/png $ go list ../.../template html/template text/template $ cd $GOROOT/src/pkg $ go list ./io io $ go list ./io/... io io/ioutil $ go list ./.../pprof net/http/pprof runtime/pprof $ go list ./compress can't load package: package compress: no Go source files in /home/nigeltao/go/src/pkg/compress $ go list ./compress/... compress/bzip2 compress/flate compress/gzip compress/lzw compress/zlib $ cd $GOROOT/src/pkg/code.google.com $ go list ./p/leveldb-go/... code.google.com/p/leveldb-go/leveldb code.google.com/p/leveldb-go/leveldb/crc code.google.com/p/leveldb-go/leveldb/db code.google.com/p/leveldb-go/leveldb/memdb code.google.com/p/leveldb-go/leveldb/memfs code.google.com/p/leveldb-go/leveldb/record code.google.com/p/leveldb-go/leveldb/table code.google.com/p/leveldb-go/manualtest/filelock $ go list ./p/.../truetype code.google.com/p/freetype-go/example/truetype code.google.com/p/freetype-go/freetype/truetype $ go list ./p/.../example warning: "./p/.../example" matched no packages $ go list ./p/.../example/... code.google.com/p/freetype-go/example/freetype code.google.com/p/freetype-go/example/gamma code.google.com/p/freetype-go/example/raster code.google.com/p/freetype-go/example/round code.google.com/p/freetype-go/example/truetype code.google.com/p/x-go-binding/example/imgview code.google.com/p/x-go-binding/example/xgb R=rsc CC=golang-dev https://golang.org/cl/6194056
-
Nigel Tao authored
These files change from exactly 10003 bytes long to 100003: a digit, a '.', 100k digits, and a '\n'. The magic constants in compress/flate/deflate_test.go change since deflateInflateStringTests checks that the compressed form of e.txt is not 'too large'. I'm not exactly sure how these numbers were originally calculated (they were introduced in codereview 5554066 "make lazy matching work"); perhaps krasin@golang.org can comment. My change was to increase the first one (no compression) to a tight bound, and multiply all the others by 10. Benchcmp numbers for compress/flate and compress/lzw below. LZW's window size of 4096 is less than 10k, so shows no significant change. Flate's window size is 32768, between 10k and 100k, and so the .*1e5 and .*1e6 benchmarks show a dramatic drop, since the compressed forms are no longer a trivial forward copy of 10k digits repeated over and over, but should now be more representative of real world usage. compress/flate: benchmark old MB/s new MB/s speedup BenchmarkDecodeDigitsSpeed1e4 16.58 16.52 1.00x BenchmarkDecodeDigitsSpeed1e5 68.09 18.10 0.27x BenchmarkDecodeDigitsSpeed1e6 124.63 18.35 0.15x BenchmarkDecodeDigitsDefault1e4 17.21 17.12 0.99x BenchmarkDecodeDigitsDefault1e5 118.28 19.19 0.16x BenchmarkDecodeDigitsDefault1e6 295.62 20.52 0.07x BenchmarkDecodeDigitsCompress1e4 17.22 17.17 1.00x BenchmarkDecodeDigitsCompress1e5 118.19 19.21 0.16x BenchmarkDecodeDigitsCompress1e6 295.59 20.55 0.07x BenchmarkEncodeDigitsSpeed1e4 8.18 8.19 1.00x BenchmarkEncodeDigitsSpeed1e5 43.22 12.84 0.30x BenchmarkEncodeDigitsSpeed1e6 80.76 13.48 0.17x BenchmarkEncodeDigitsDefault1e4 6.29 6.19 0.98x BenchmarkEncodeDigitsDefault1e5 31.63 3.60 0.11x BenchmarkEncodeDigitsDefault1e6 52.97 3.24 0.06x BenchmarkEncodeDigitsCompress1e4 6.20 6.19 1.00x BenchmarkEncodeDigitsCompress1e5 31.59 3.59 0.11x BenchmarkEncodeDigitsCompress1e6 53.18 3.25 0.06x compress/lzw: benchmark old MB/s new MB/s speedup BenchmarkDecoder1e4 21.99 22.09 1.00x BenchmarkDecoder1e5 22.77 22.71 1.00x BenchmarkDecoder1e6 22.90 22.90 1.00x BenchmarkEncoder1e4 21.04 21.19 1.01x BenchmarkEncoder1e5 22.06 22.06 1.00x BenchmarkEncoder1e6 22.16 22.28 1.01x R=rsc CC=golang-dev, krasin https://golang.org/cl/6207043
-
- 08 May, 2012 2 commits
-
-
Nigel Tao authored
The testdata/e.txt input is repeated on the longer benchmarks, but the length of that data is less than flate's window size, so the numbers are essentially measuring the performance of a trivial compression. A follow-up CL will add more data to testdata/e.txt. Sample output on my laptop (linux, amd64): BenchmarkDecodeDigitsSpeed1e4 5000 603153 ns/op 16.58 MB/s BenchmarkDecodeDigitsSpeed1e5 1000 1465602 ns/op 68.23 MB/s BenchmarkDecodeDigitsSpeed1e6 200 8036050 ns/op 124.44 MB/s BenchmarkDecodeDigitsDefault1e4 5000 581796 ns/op 17.19 MB/s BenchmarkDecodeDigitsDefault1e5 2000 846653 ns/op 118.11 MB/s BenchmarkDecodeDigitsDefault1e6 500 3385782 ns/op 295.35 MB/s BenchmarkDecodeDigitsCompress1e4 5000 581180 ns/op 17.21 MB/s BenchmarkDecodeDigitsCompress1e5 2000 846209 ns/op 118.17 MB/s BenchmarkDecodeDigitsCompress1e6 500 3386174 ns/op 295.32 MB/s BenchmarkDecodeTwainSpeed1e4 5000 643563 ns/op 15.54 MB/s BenchmarkDecodeTwainSpeed1e5 500 5418408 ns/op 18.46 MB/s BenchmarkDecodeTwainSpeed1e6 50 52277520 ns/op 19.13 MB/s BenchmarkDecodeTwainDefault1e4 5000 583551 ns/op 17.14 MB/s BenchmarkDecodeTwainDefault1e5 500 4443428 ns/op 22.51 MB/s BenchmarkDecodeTwainDefault1e6 50 41862080 ns/op 23.89 MB/s BenchmarkDecodeTwainCompress1e4 5000 583490 ns/op 17.14 MB/s BenchmarkDecodeTwainCompress1e5 500 4426356 ns/op 22.59 MB/s BenchmarkDecodeTwainCompress1e6 50 41657940 ns/op 24.01 MB/s BenchmarkEncodeDigitsSpeed1e4 2000 1230907 ns/op 8.12 MB/s BenchmarkEncodeDigitsSpeed1e5 1000 2319129 ns/op 43.12 MB/s BenchmarkEncodeDigitsSpeed1e6 100 12378950 ns/op 80.78 MB/s BenchmarkEncodeDigitsDefault1e4 1000 1597865 ns/op 6.26 MB/s BenchmarkEncodeDigitsDefault1e5 500 3163458 ns/op 31.61 MB/s BenchmarkEncodeDigitsDefault1e6 100 18770240 ns/op 53.28 MB/s BenchmarkEncodeDigitsCompress1e4 1000 1603461 ns/op 6.24 MB/s BenchmarkEncodeDigitsCompress1e5 500 3168766 ns/op 31.56 MB/s BenchmarkEncodeDigitsCompress1e6 100 18855830 ns/op 53.03 MB/s BenchmarkEncodeTwainSpeed1e4 1000 1338049 ns/op 7.47 MB/s BenchmarkEncodeTwainSpeed1e5 500 7341622 ns/op 13.62 MB/s BenchmarkEncodeTwainSpeed1e6 50 67484600 ns/op 14.82 MB/s BenchmarkEncodeTwainDefault1e4 1000 1778399 ns/op 5.62 MB/s BenchmarkEncodeTwainDefault1e5 100 23261810 ns/op 4.30 MB/s BenchmarkEncodeTwainDefault1e6 10 243533600 ns/op 4.11 MB/s BenchmarkEncodeTwainCompress1e4 1000 1795469 ns/op 5.57 MB/s BenchmarkEncodeTwainCompress1e5 50 29447140 ns/op 3.40 MB/s BenchmarkEncodeTwainCompress1e6 5 321686800 ns/op 3.11 MB/s ok compress/flate 89.246s R=rsc, r CC=golang-dev https://golang.org/cl/6195055
-
Nigel Tao authored
I'm not sure where the BOM came from, originally. http://www.gutenberg.org/files/74/74.txt doesn't have it, although a fresh download of that URL gives me "\r\n"s instead of plain "\n"s, and the extra line "Character set encoding: ASCII". Maybe Project Gutenberg has changed their server configuration since we added that file to the Go repo. Anyway, this change is just manually excising the BOM from the start of the file, leaving pure ASCII. R=r, bradfitz CC=golang-dev, krasin, rsc https://golang.org/cl/6197061
-
- 07 May, 2012 7 commits
-
-
Russ Cox authored
Fixes #3589. R=golang-dev, iant CC=golang-dev https://golang.org/cl/6190044
-
Ian Lance Taylor authored
R=r CC=golang-dev https://golang.org/cl/6202046
-
Jean-Marc Eurin authored
This adds restoring the window position so that the buffer doesn't jump around after the erase/copy. R=sameer CC=golang-dev https://golang.org/cl/5981055
-
Sameer Ajmani authored
R=golang-dev, rsc CC=golang-dev, jme, jmeurin https://golang.org/cl/6192057
-
Sameer Ajmani authored
R=golang-dev, rsc CC=golang-dev, jme https://golang.org/cl/6197058
-
Marcel van Lohuizen authored
dictates a CJK rune is only part of a certain specified range if it is explicitly defined in the Unicode Codepoint Database. Fixed the code and some of the tests accordingly. R=r CC=golang-dev https://golang.org/cl/6160044
-
Marcel van Lohuizen authored
Replace hard-coded version strings with unicode.Version. R=r, r CC=golang-dev https://golang.org/cl/6163045
-
- 04 May, 2012 3 commits
-
-
Ian Lance Taylor authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6196047
-
Shenghou Ma authored
This is a follow-up to CL 5978051. Use kernel cas64 helper if we can, fallback to LDREXD/STREXD if we are on ARMv6 or higher, and to lock-emulated cas64 if on ARMv5. A future CL will fix {Add,Load,Store}{Int,Uint}64 and issue 3331. R=bradfitz, rsc CC=golang-dev https://golang.org/cl/6034048
-
Shenghou Ma authored
Decode AT_RANDOM, AT_HWCAP, and AT_PLATFORM. This CL only make use of AT_RANDOM, but future CLs will make use of the others. R=dave, rsc CC=golang-dev https://golang.org/cl/5978051
-