- 24 Sep, 2012 6 commits
-
-
Russ Cox authored
Minor tweaks to avoid assuming that int is always 32 bits. Update #2188. R=golang-dev, r CC=golang-dev https://golang.org/cl/6553062
-
Russ Cox authored
Can tell this doesn't get run very often, but it is still important for when you've broken everything else. R=golang-dev, r CC=golang-dev https://golang.org/cl/6547065
-
Russ Cox authored
This CL fixes code that incorrectly assumes that int is 32 bits wide. Specifically, the socketpair system call expects a pointer to a pair of int32s, not a pair of ints. Fix this inside the wrappers without changing the APIs. Update #2188. R=golang-dev, r CC=golang-dev https://golang.org/cl/6552063
-
Rob Pike authored
Change the grammar so that field access is a proper operator. This introduces a new node, ChainNode, into the public (but actually internal) API of text/template/parse. For compatibility, we only use the new node type for the specific construct, which was not parseable before. Therefore this should be backward-compatible. Before, .X.Y was a token in the lexer; this CL breaks it out into .Y applied to .X. But for compatibility we mush them back together before delivering. One day we might remove that hack; it's the simple TODO in parse.go/operand. This change also provides grammatical distinction between f and (f) which might permit function values later, but not now. Fixes #3999. R=golang-dev, dsymonds, gri, rsc, mikesamuel CC=golang-dev https://golang.org/cl/6494119
-
Russ Cox authored
The code was trying to interpret a uint32 n as a signed quantity and then store it in an int. For this, int(n) currently works, but when int becomes 64 bits one must write int(int32(n)) instead, to get the 32-bit sign extension. Update #2188. R=golang-dev, nigeltao CC=golang-dev https://golang.org/cl/6551068
-
Alex Brainman authored
Fixes #3917. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6553061
-
- 23 Sep, 2012 7 commits
-
-
Akshat Kumar authored
After each line, ast.Print would do a zero-length write, which would hit the boundary condition on Plan 9 when reading over pipes (since message boundaries are preserved). This change makes sure we only do positive- length writes. R=rsc, rminnich, dave, r CC=golang-dev https://golang.org/cl/6558046
-
Uriel Mangado authored
This was misleading and often confusing for new users. Leaving the actual weekly release history page for historical reference. R=golang-dev, rsc, adg CC=golang-dev https://golang.org/cl/6555053
-
Russ Cox authored
Today, if run.go doesn't understand a test header line it just ignores the test, making it too easy to write or edit tests that are not actually being run. - expand errorcheck to accept flags, so that bounds.go and escape*.go can run. - create a whitelist of skippable tests in run.go; skipping others is an error. - mark all skipped tests at top of file. Update #4139. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6549054
-
Rémy Oudompheng authored
Revision 63f7abcae015 introduced a bug caused by code assuming registers started at X5, not X0. Fixes #4138. R=rsc CC=golang-dev, remy https://golang.org/cl/6558043
-
Shenghou Ma authored
R=rsc, r CC=golang-dev https://golang.org/cl/6552061
-
Rob Pike authored
When I was a lad (and well past), users were in /usr; now they're somewhere else, I'm told. Kids today. Fixes #4122. R=golang-dev, dsymonds, rsc CC=golang-dev https://golang.org/cl/6552060
-
Russ Cox authored
Fixes #3670. R=ken2 CC=golang-dev https://golang.org/cl/6542058
-
- 22 Sep, 2012 6 commits
-
-
Rob Pike authored
- remove ambiguous 'it' - use a lower-case PackageName in the example R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6552057
-
Russ Cox authored
The width was not being set on the address, which meant that the optimizer could not find variables that overlapped with it and mark them as having had their address taken. This let to the compiler believing variables had been set but never used and then optimizing away the set. Fixes #4129. R=ken2 CC=golang-dev https://golang.org/cl/6552059
-
Russ Cox authored
Fixes #4047. R=iant, r CC=golang-dev https://golang.org/cl/6500065
-
Joel Sing authored
Use the debug data for enums on windows. Fixes #4120. R=alex.brainman CC=golang-dev https://golang.org/cl/6545047
-
Joel Sing authored
Add support for processing the COFF symbol table. R=alex.brainman CC=golang-dev https://golang.org/cl/6551045
-
Russ Cox authored
Fixes #4082. R=dsymonds CC=golang-dev https://golang.org/cl/6545055
-
- 21 Sep, 2012 10 commits
-
-
Rob Pike authored
Fixes #4114. R=golang-dev, iant, rsc, iant, devon.odell CC=golang-dev https://golang.org/cl/6553050
-
Andrew Gerrand authored
R=rsc, r CC=gobot, golang-dev https://golang.org/cl/6532049
-
Andrew Gerrand authored
These talks have been moved to the go.talks sub-repository: https://code.google.com/p/go.talks R=rsc, r CC=gobot, golang-dev https://golang.org/cl/6529052
-
Rémy Oudompheng authored
R=rsc, golang-dev CC=golang-dev https://golang.org/cl/6528044
-
Russ Cox authored
Fixes #2446. R=ken2 CC=golang-dev https://golang.org/cl/6557044
-
Jan Ziak authored
R=rsc CC=golang-dev https://golang.org/cl/6554043
-
Shenghou Ma authored
We only pass lower 32 bits of file offset to asm routine. R=r, dave, rsc CC=golang-dev https://golang.org/cl/6499118
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/6548046
-
Russ Cox authored
*** There is an API change here: the introduction of the LatinOffset int in the RangeTable struct. *** * Avoid checking Latin range multiple times for non-Latin runes. * Use linear search when it is faster than binary search. go test -calibrate runs the calibration for where the linear/binary crossover should be. benchmark old MB/s new MB/s speedup BenchmarkFields 36.27 41.43 1.14x BenchmarkFieldsFunc 36.23 41.38 1.14x The speedup here is evenly split between the linear scans and the LatinOffset change. Both are about 1.07x. R=r CC=bradfitz, gobot, golang-dev https://golang.org/cl/6526048
-
Joel Sing authored
OpenBSD now requires ELF binaries to have a PT_NOTE that identifies it as an OpenBSD binary. Refactor the existing NetBSD ELF signature code and implement support for OpenBSD ELF signatures. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6489131
-
- 20 Sep, 2012 9 commits
-
-
Mikio Hara authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6546044
-
Dmitriy Vyukov authored
Tests behavior of Once when initialization function panics. R=golang-dev, r CC=golang-dev https://golang.org/cl/6554047
-
Lucio De Re authored
The calculation of datsize is redundant. R=golang-dev, seed, rsc CC=golang-dev https://golang.org/cl/6503122
-
Dmitriy Vyukov authored
Otherwise they sum up between GCs. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6535048
-
Andrew Harding authored
R=golang-dev, agl CC=golang-dev https://golang.org/cl/6535057
-
Adam Langley authored
Previously we tried to parse email constraints as the maximum base distance (which is unused and must be omitted according to RFC 5280) because they share the same tag number. Rather than complicate the code further, this CL just ignores the unused values. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6552044
-
Adam Langley authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/6544044
-
Joel Sing authored
Always process the DWARF info, even when the const value is determined using the debug data block. This ensures that the injected enum is removed and future loads of the same constant do not trigger inconsistent definitions. Add tests for issues 2470 and 4054. Fixes #4054. R=golang-dev, fullung, dave, rsc, minux.ma CC=golang-dev https://golang.org/cl/6501101
-
Alex Brainman authored
R=golang-dev, r, minux.ma, dave, bradfitz CC=golang-dev https://golang.org/cl/6532052
-
- 19 Sep, 2012 2 commits
-
-
David Symonds authored
In a range loop, the presence of a value implies the presence of a key. However, the presence of a value as an *ast.Ident does not imply that the key is also an *ast.Ident, thus leading to a panic any time the two argument form is used where the key is not an identifier. R=golang-dev, adg, r CC=golang-dev https://golang.org/cl/6540045
-
David Symonds authored
Previously, an import block such as import ( "net" "stack" ) would not permit ":Drop stack" to work because we were aborting the scan early, which is only correct when Import is in operation. R=golang-dev, franciscossouza CC=golang-dev https://golang.org/cl/6532053
-