Commits · 12f8660d4c396da8f6e69f0c6a661a53086f4bd9 · go / golang

03 Nov, 2009 8 commits

use default styler when there is no other given · 12f8660d

Robert Griesemer authored Nov 03, 2009

(No visual change yet since the comments for
exported code snippets - as shown on the pkg
page - are not yet formatted using the standard
comment intersperse mechanism in the printer.
This is a TODO in the printer.)

R=rsc
http://go/go-review/1016031

12f8660d

fix build · 929e27e3
Rob Pike authored Nov 03, 2009
```
R=gri
http://go/go-review/1017014
```
929e27e3

- show recursive package directory structure in package pages · be56b957

Robert Griesemer authored Nov 03, 2009

- removed some underbars in section headings for better looks
- various minor tweaks

R=rsc
http://go/go-review/1018026

be56b957

split printer.go into two files; it has become too large: · 6e98b7f0

Robert Griesemer authored Nov 03, 2009

- nodes.go implements ast node formatting
- printer.go implements the core printing functionality
  and public interface

No code changes except for updating the import clauses
and adding a top-level comment to nodes.go.

R=rsc
http://go/go-review/1016026

6e98b7f0

forgot to count newlines when scanning white space. · 120d0b50
Rob Pike authored Nov 03, 2009
```
also fix a error-printing bug in godoc.

R=gri
http://go/go-review/1016030
```
120d0b50

package net cleanup · c83b8386

Russ Cox authored Nov 03, 2009

added ReadFrom/WriteTo for packet protocols like UDP.
simplified the net.Conn interface.
added new net.PacketConn interface for packet protocols.
implemented proper UDP listener.

cleaned up LocalAddr/RemoteAddr methods - cache in netFD.

threw away various unused methods.

an interface change:
introduced net.Addr as a network address interface,
to avoid conversion of UDP host:port to string and
back for every ReadFrom/WriteTo sequence.

another interface change:
since signature of Listener.Accept was changing anyway,
dropped the middle return value, because it is available
as c.RemoteAddr().  (the Accept signature predates the
existence of that method.)

Dial and Listen still accept strings, but the proto-specific
versions DialTCP, ListenUDP, etc. take net.Addr instead.

because the generic Dial didn't change and because
no one calls Accept directly (only indirectly via the http
server), very little code will be affected by these interface
changes.

design comments welcome.

R=p
CC=go-dev, r
http://go/go-review/1018017

c83b8386

crypto/tls (part 1) · 6e8184d8

Adam Langley authored Nov 03, 2009

Rather than drop everything into a single, huge review, I've included
some simple bits of code here.

R=rsc
CC=go-dev
http://go/go-review/1016029

6e8184d8

recompress go_talk.pdf by running through ghostscript. · ba1424ba
Russ Cox authored Nov 03, 2009
```
was 1153 kB now 247 kB

R=r
http://go/go-review/1018025
```
ba1424ba

02 Nov, 2009 29 commits

pdf cleanup: fix links, remove internal references. · 9339e075
Rob Pike authored Nov 02, 2009
```
fix link in spec.

R=rsc
CC=go-dev
http://go/go-review/1017013
```
9339e075
fix divide by zero in old glibc dynamic loader · 6334b499
Russ Cox authored Nov 02, 2009
```
R=r
CC=iant
http://go/go-review/1018024
```
6334b499

Set LANG to control sorting. This affects the order in which · 74a52ee7

Ian Lance Taylor authored Nov 02, 2009

tests are processed, and thus the run.out output.  The default
LANG on Fedora 10, en_US.utf8, causes the tests to be sorted
differently--e.g., arrayindex1.go and arrayindex.go are sorted
in the opposite order.

R=r, rsc
http://go/go-review/1018022

74a52ee7

remove goroutines from template parsing. · 236a9de9
Rob Pike authored Nov 02, 2009
```
fix up one usage to take advantage.

R=rsc
CC=go-dev
http://go/go-review/1018023
```
236a9de9
Define constants for sizes of Sym structures. · f32cde88
Ian Lance Taylor authored Nov 02, 2009
```
R=rsc, agl
http://go/go-review/1016028
```
f32cde88

Fix cgo for GCC 4.4 · 72ec930f

Adam Langley authored Nov 02, 2009

Firstly, with -Werror, GCC switched to printing warnings starting
with "error:". Widening the string matches solves this as the messages
are otherwise unchanged.

Secondly, GCC 4.4 outputs DWARF sections with with NUL bytes in all
the offsets and requires the relocation section for .debug_info to be
processed in order to result in valid DWARF data. Thus we add minimal
handling for relocation sections, which is sufficient for our needs.

BUG=1
Fixes #1.

R=rsc, iant
CC=go-dev
http://go/go-review/1017003

72ec930f

We should not silently permit a named type to match an unnamed · 6358cac7
Ian Lance Taylor authored Nov 02, 2009
```
type.  This is OK in a conversion but not in an assignment.

R=rsc
http://go/go-review/1016024
```
6358cac7
use the new routine regexp.MustCompile to clean up some code that uses global regexps. · a8246510
Rob Pike authored Nov 02, 2009
```
R=rsc, gri
CC=go-dev
http://go/go-review/1016025
```
a8246510

rietveld does not like code reviews with subjects longer than 100 characters, so… · 9c132158

Russ Cox authored Nov 02, 2009

rietveld does not like code reviews with subjects longer than 100 characters, so trim the line pulled out of the description to avoid the limit.

R=r
http://go/go-review/1016027

9c132158

eliminate goroutine from testing/regexp too. · cd82d490
Rob Pike authored Nov 02, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1018021
```
cd82d490
Split constant time functions into crypto/subtle. · ad67a866
Adam Langley authored Nov 02, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1018020
```
ad67a866
do not emit USED for global x when compiling "_ = x;" · d0024898
Russ Cox authored Nov 02, 2009
```
R=ken@golang.org
CC=r
http://go/go-review/1018019
```
d0024898

Recognize gccgo error message. · 102357f0

Ian Lance Taylor authored Nov 02, 2009

runtime.go:19:10: error: reference to undefined identifier ‘runtime.printbool’

R=rsc
http://go/go-review/1018018

102357f0

take goroutines out of regexp so they can be created · acc54b6c
Rob Pike authored Nov 02, 2009
```
during initialization.

R=rsc
CC=go-dev
http://go/go-review/1016023
```
acc54b6c
cleaning up bug132 · e6f85af2
Robert Griesemer authored Nov 02, 2009
```
R=rsc
http://go/go-review/1017012
```
e6f85af2

- initial steps towards showing directory tree instead of · 49d295d5

Robert Griesemer authored Nov 02, 2009

  just a single directory
- all pieces present but not well integrated
- directory tree served at the moment under /tree

R=rsc
http://go/go-review/1018016

49d295d5

- collect line comments for methods in interfaces · b6735211

Robert Griesemer authored Nov 02, 2009

  (previously not shown in godoc)
- simplify parsing of struct types (match code structure for parsing interface types)

R=rsc, r
http://go/go-review/1016019

b6735211

nil pointer checks in 8g. · 9dd2e1e3

Russ Cox authored Nov 02, 2009

fix nil pointer check in 6g.
was dereferencing after the ADD;
dereference before instead.

R=ken@golang.org
CC=iant
http://go/go-review/1016022

9dd2e1e3

reverse the arguments to io.Copy so the destination is on the · 4d310f24
Rob Pike authored Nov 02, 2009
```
left, like an assignment, like strcpy, etc.

R=rsc
CC=go-dev
http://go/go-review/1016011
```
4d310f24
fixups for memory model document · 4e5296d4
Rob Pike authored Nov 02, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1016018
```
4e5296d4
correct a few things in Go for C++ Programmers · 6ac19ece
Rob Pike authored Nov 02, 2009
```
R=iant, rsc
CC=go-dev
http://go/go-review/1016015
```
6ac19ece
fixups to "effective go" · c2b6418c
Rob Pike authored Nov 02, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1016020
```
c2b6418c
a few tweaks to the language design faq · a411cea1
Rob Pike authored Nov 02, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1017007
```
a411cea1
significant cleanup of the main FAQ · 0c2a479a
Rob Pike authored Nov 02, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1017008
```
0c2a479a
save some text from the old FAQ; will get reworked in time · 5b72f9cd
Rob Pike authored Nov 02, 2009
```
R=rsc
http://go/go-review/1018008
```
5b72f9cd

fixups in the tutorial · 83f0b718

Rob Pike authored Nov 02, 2009

also add a section about compiling programs because some found it surprising not to have one

R=rsc
CC=go-dev
http://go/go-review/1018011

83f0b718

code review: avoid subject changes, fix http_proxy submit bug · dde666da
Russ Cox authored Nov 02, 2009
```
R=r
http://go/go-review/1016021
```
dde666da
Permit the CC environment variable to include arguments · f4e3947f
Ian Lance Taylor authored Nov 02, 2009
```
(I should have tested the last change a bit more before
submitting).

R=rsc
http://go/go-review/1017011
```
f4e3947f
Use the environment variable CC as the bootstrap compiler used · fab7ae15
Ian Lance Taylor authored Nov 02, 2009
```
to build 6g, 6l, etc.

R=rsc
CC=go-dev
http://go/go-review/1018015
```
fab7ae15

01 Nov, 2009 3 commits

enable all (but one) test cases in test.sh that · b96ad809

Robert Griesemer authored Nov 01, 2009

were excluded before because of incorrect comment
formatting (comment formatting is mostly idempotent
at this point)

R=rsc
http://go/go-review/1018014

b96ad809

These files were moved to encoding/base64. The directory was · d8efcdcd
Ian Lance Taylor authored Nov 01, 2009
```
already removed from the Makefile.

R=rsc
http://go/go-review/1017006
```
d8efcdcd

split ipsock.go, sock.go, and unixsock.go out of net.go · 35ace1d1

Russ Cox authored Nov 01, 2009

prior to cleanup.  no changes, only moving.

remove dependencies on strconv and strings

R=r
http://go/go-review/1017010

35ace1d1