- 24 Feb, 2014 28 commits
-
-
Rémy Oudompheng authored
Revision c0e0467635ec (cmd/gc: return canonical Node* from temp) exposed original nodes of temporaries, allowing callers to mutate their types. In walkcompare a temporary could be typed as ideal because of this. Additionnally, assignment of a comparison result to a custom boolean type was broken. Fixes #7366. LGTM=rsc R=rsc, iant, khr CC=golang-codereviews https://golang.org/cl/66930044
-
Lucio De Re authored
Fixes the output of go env so that variables can be set more accurately when using Plan 9's rc shell. Specifically, GOPATH may have multiple components and the current representation is plain wrong. In practice, we probably ought to change os. Getenv to produce the right result, but that requires considerably more thought. LGTM=rsc R=golang-codereviews, gobot, rsc CC=golang-codereviews https://golang.org/cl/66600043
-
Rob Pike authored
LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/66900044
-
Dmitriy Vyukov authored
Fatal must not be called from secondary goroutines. Fixes #7401. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/67820047
-
Dmitriy Vyukov authored
LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/68230045
-
Dmitriy Vyukov authored
With concurrent sweeping finc if modified by runfinq and queuefinalizer concurrently. Fixes crashes like this one: http://build.golang.org/log/6ad7b59ef2e93e3c9347eabfb4c4bd66df58fd5a Fixes #7324. Update #7396 LGTM=rsc R=golang-codereviews, minux.ma, rsc CC=golang-codereviews, khr https://golang.org/cl/67980043
-
Dmitriy Vyukov authored
Reinforce the guarantee that MSpan_EnsureSwept actually ensures that the span is swept. I have not observed crashes related to this, but I do not see why it can't crash as well. LGTM=rsc R=golang-codereviews CC=golang-codereviews, khr, rsc https://golang.org/cl/67990043
-
Dmitriy Vyukov authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/68020043
-
Dmitriy Vyukov authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/68060043
-
Dmitriy Vyukov authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/67830044
-
Dmitriy Vyukov authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/67910046
-
Mikio Hara authored
Note that current z-files for linux/amd64,386,arm are based on 3.2 kernel. LGTM=iant R=golang-codereviews, dave, bradfitz, gobot, iant CC=golang-codereviews https://golang.org/cl/59160044
-
Dmitriy Vyukov authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/68030043
-
Dmitriy Vyukov authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/68070043
-
Dmitriy Vyukov authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/68040044
-
Dmitriy Vyukov authored
runfinqv is already defined the same way on line 271. There may also be something to fix in compiler/linker wrt diagnostics. Fixes #7375. LGTM=bradfitz R=golang-codereviews, dave, bradfitz CC=golang-codereviews https://golang.org/cl/67850044
-
Dave Cheney authored
Update #7347 When runtime.panic is called the *Panic is malloced from the heap. This can lead to a gc cycle while panicing which can make a bad situation worse. It appears to be possible to stack allocate the Panic and avoid malloc'ing during a panic. Ref: https://groups.google.com/d/topic/golang-dev/OfxqpklGkh0/discussion LGTM=minux.ma, dvyukov, rsc R=r, minux.ma, gobot, rsc, dvyukov CC=golang-codereviews https://golang.org/cl/66830043
-
Jay Weisskopf authored
This lays the groundwork for making Go robust when the system's calendar time jumps around. All input values to the runtimeTimer struct now use the runtime clock as a common reference point. This affects net.Conn.Set[Read|Write]Deadline(), time.Sleep(), time.Timer, etc. Under normal conditions, behavior is unchanged. Each platform and architecture's implementation of runtime·nanotime() should be modified to use a monotonic system clock when possible. Platforms/architectures modified and tested with monotonic clock: linux/x86 - clock_gettime(CLOCK_MONOTONIC) Update #6007 LGTM=dvyukov, rsc R=golang-codereviews, dvyukov, alex.brainman, stephen.gutekanst, dave, rsc, mikioh.mikioh CC=golang-codereviews https://golang.org/cl/53010043
-
Patrick Mézard authored
LGTM=rsc R=golang-codereviews, gobot, rsc CC=golang-codereviews https://golang.org/cl/64770043
-
Shane Hansen authored
Update #6963 Fixes pretty printing maps and updates functions for interacting with $len(). goroutine $n bt remains not working. Tested on gdb using python 2 and 3. Fixes #7052 Update #6963 Fixes #6698 LGTM=rsc R=golang-codereviews, josharian, rsc CC=golang-codereviews https://golang.org/cl/53590043
-
Patrick Mézard authored
LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://golang.org/cl/60640052
-
Robert Daniel Kortschak authored
One defer was not removed in CL61150043. LGTM=dvyukov R=bradfitz, dvyukov CC=golang-codereviews https://golang.org/cl/64600044
-
Dmitriy Vyukov authored
After "runtime: combine small NoScan allocations" finalizers for small objects run more non deterministically. TestRaceFin episodically fails on my darwin/amd64. LGTM=khr R=golang-codereviews, khr, dave CC=golang-codereviews https://golang.org/cl/56970043
-
Mikio Hara authored
Also updates documentation. LGTM=minux.ma R=iant, bradfitz, nightlyone, minux.ma CC=golang-codereviews https://golang.org/cl/58660044
-
Mikio Hara authored
LGTM=iant R=golang-codereviews, minux.ma, gobot, iant CC=golang-codereviews https://golang.org/cl/67170043
-
Mikio Hara authored
As per request from minux in CL 61520049, this CL consolidates existing test cases for Unix-like systems into one file except Linux-specific credential test. LGTM=bradfitz R=iant, minux.ma, bradfitz CC=golang-codereviews https://golang.org/cl/67800044
-
Anfernee Yongkun Gui authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/66990045
-
Shenghou Ma authored
Fix build for 10.6 Darwin builders and OpenBSD builers. LGTM=jsing R=golang-codereviews, dave, jsing CC=golang-codereviews https://golang.org/cl/67710043
-
- 23 Feb, 2014 4 commits
-
-
Shenghou Ma authored
Fixes #7223. LGTM=rsc R=golang-codereviews, gobot, rsc CC=golang-codereviews https://golang.org/cl/63040043
-
Shenghou Ma authored
Fix build for Dragonfly BSD. Fixes #7318. Fixes #7367. LGTM=jsing, iant R=jsing, iant, mikioh.mikioh CC=golang-codereviews https://golang.org/cl/64340043
-
Patrick Mézard authored
LGTM=minux.ma, r R=golang-codereviews, minux.ma, r CC=golang-codereviews https://golang.org/cl/67280043
-
Rob Pike authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/64100047
-
- 21 Feb, 2014 5 commits
-
-
Rob Pike authored
Fixes #7361. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/66910045
-
Adam Langley authored
crypto/tls has two functions for creating a client connection: Dial, which most users are expected to use, and Client, which is the lower-level API. Dial does what you expect: it gives you a secure connection to the host that you specify and the majority of users of crypto/tls appear to work fine with it. Client gives more control but needs more care. Specifically, if it wasn't given a server name in the tls.Config then it didn't check that the server's certificates match any hostname - because it doesn't have one to check against. It was assumed that users of the low-level API call VerifyHostname on the certificate themselves if they didn't supply a hostname. A review of the uses of Client both within Google and in a couple of external libraries has shown that nearly all of them got this wrong. Thus, this change enforces that either a ServerName or InsecureSkipVerify is given. This does not affect tls.Dial. See discussion at https://groups.google.com/d/msg/golang-nuts/4vnt7NdLvVU/b1SJ4u0ikb0J. Fixes #7342. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/67010043
-
Russ Cox authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/67010044
-
Russ Cox authored
The old error was "call of reflect.Value.Field on ptr Value". http://play.golang.org/p/Zm-ZbQaPeR LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/67020043
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/65340044
-
- 20 Feb, 2014 3 commits
-
-
Russ Cox authored
SetPanicOnFault allows recovery from unexpected memory faults. This can be useful if you are using a memory-mapped file or probing the address space of the current program. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/66590044
-
Russ Cox authored
Package runtime's C functions written to be called from Go started out written in C using carefully constructed argument lists and the FLUSH macro to write a result back to memory. For some functions, the appropriate parameter list ended up being architecture-dependent due to differences in alignment, so we added 'goc2c', which takes a .goc file containing Go func declarations but C bodies, rewrites the Go func declaration to equivalent C declarations for the target architecture, adds the needed FLUSH statements, and writes out an equivalent C file. That C file is compiled as part of package runtime. Native Client's x86-64 support introduces the most complex alignment rules yet, breaking many functions that could until now be portably written in C. Using goc2c for those avoids the breakage. Separately, Keith's work on emitting stack information from the C compiler would require the hand-written functions to add #pragmas specifying how many arguments are result parameters. Using goc2c for those avoids maintaining #pragmas. For both reasons, use goc2c for as many Go-called C functions as possible. This CL is a replay of the bulk of CL 15400047 and CL 15790043, both of which were reviewed as part of the NaCl port and are checked in to the NaCl branch. This CL is part of bringing the NaCl code into the main tree. No new code here, just reformatting and occasional movement into .h files. LGTM=r R=dave, alex.brainman, r CC=golang-codereviews https://golang.org/cl/65220044
-
Russ Cox authored
Match used len(ar.files) == 0 to mean "match everything" but it also deleted matched things from the list, so once you had matched everything you asked for, match returned true for whatever was left in the archive too. Concretely, if you have an archive containing f1, f2, then pack t foo.a f1 would match f1 and then, because len(ar.files) == 0 after deleting f1 from the match list, also match f2. Avoid the problem by recording explicitly whether match matches everything. LGTM=r, dsymonds R=r, dsymonds CC=golang-codereviews https://golang.org/cl/65630046
-