- 15 Aug, 2013 4 commits
-
-
Rob Pike authored
One sentence says they're ignored, another says they take part. Fix the first. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/12741046
-
Alex Brainman authored
whatever "end-to-end" means here R=golang-dev, dvyukov CC=golang-dev https://golang.org/cl/12898044
-
Rob Pike authored
Was checking for nil map; must check for empty map instead. Fixes #6065 Before: go test -cover # testmain /var/folders/00/013l0000h01000cxqpysvccm0004fc/T/go-build233480051/_/Users/r/issue/_test/_testmain.go:11: imported and not used: "_/Users/r/issue" FAIL _/Users/r/issue [build failed] Now: go test -cover testing: warning: no tests to run PASS coverage: 0.0% of statements ok _/Users/r/issue 0.021s R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/12916043
-
Rob Pike authored
Update #3790 Handle time zones like GMT-8. The more general time zone-matching problem is not yet resolved. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/12922043
-
- 14 Aug, 2013 36 commits
-
-
David Symonds authored
Fixes #6042. R=adg CC=golang-dev https://golang.org/cl/12923043
-
Dominik Honnef authored
R=golang-dev, adonovan, bradfitz CC=golang-dev https://golang.org/cl/12721043
-
Russ Cox authored
Remove custom support for time.Time. No new tests: the tests for the time.Time special case now test the general case. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/12751045
-
Carl Shapiro authored
The baseline architecture had been left to the GCC configured default which can be more accomodating than the rest of the Go toolchain. This prevented instructions used by the 5g compiler, like BLX, from being used in GCC compiled assembler code. R=golang-dev, dave, rsc, elias.naur, cshapiro CC=golang-dev https://golang.org/cl/12954043
-
Andrew Gerrand authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/12957044
-
Brad Fitzpatrick authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/12953043
-
Mikio Hara authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/12884044
-
Elias Naur authored
CL 12741044 added an extra iself condition to an if statement that already contained it. Remove it. R=rsc CC=golang-dev https://golang.org/cl/12949043
-
Dmitriy Vyukov authored
It doughtily misses all possible corner cases. In particular on machines with <1GHz processors, SetBlockProfileRate(1) disables profiling. Fixes #6114. R=golang-dev, bradfitz, rsc CC=golang-dev https://golang.org/cl/12936043
-
Mikio Hara authored
Also does less buffer allocation in case of TCP fallback. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/12925043
-
Mikio Hara authored
R=golang-dev, dvyukov, dave CC=golang-dev https://golang.org/cl/12766044
-
Russ Cox authored
Will submit once I can fill in the CL XXX number. R=golang-dev, r CC=golang-dev https://golang.org/cl/12912044
-
Rémy Oudompheng authored
R=golang-dev, bradfitz, rsc CC=golang-dev https://golang.org/cl/12842043
-
Russ Cox authored
See golang.org/s/go12xml for design. Repeat of CL 12603044, which was submitted accidentally and then rolled back. Fixes #2771. Fixes #4169. Fixes #5975. Fixes #6125. R=golang-dev CC=golang-dev https://golang.org/cl/12919043
-
Russ Cox authored
See golang.org/s/go12xml for design. R=golang-dev, dominik.honnef, dan.kortschak CC=golang-dev https://golang.org/cl/12556043
-
Russ Cox authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/12703043
-
Russ Cox authored
Originally the requirement was f(x) where f's argument is exactly x's type. CL 11858043 relaxed the requirement in a non-standard way: f's argument must be exactly x's type or interface{}. If we're going to relax the requirement, it should be done in a way consistent with the rest of Go. This CL allows f's argument to have any type for which x is assignable; that's the same requirement the compiler would impose if compiling f(x) directly. Fixes #5368. R=dvyukov, bradfitz, pieter CC=golang-dev https://golang.org/cl/12895043
-
Russ Cox authored
TBR=elias.naur CC=golang-dev https://golang.org/cl/12943043
-
Dmitriy Vyukov authored
R=golang-dev CC=golang-dev https://golang.org/cl/12941043
-
Dmitriy Vyukov authored
Fixes #5584. R=golang-dev, chaishushan, alex.brainman CC=golang-dev https://golang.org/cl/12720043
-
Dmitriy Vyukov authored
It timeouts on freebsd builders: http://build.golang.org/log/3d8169e13bff912bebf6fd3c54b34ad2d29a7221 but there are always runnable goroutines, which suggests that it's slowly progressing. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/12939043
-
Elias Naur authored
The ARM external linking CL used BLX instructions in gcc assembler. Replace with BL to retain support on older ARM processors. R=rsc CC=golang-dev https://golang.org/cl/12938043
-
Dmitriy Vyukov authored
1. Do less iterations in short mode 2. Bound number of times SetDeadline is executed R=golang-dev, rsc CC=golang-dev https://golang.org/cl/12937043
-
Elias Naur authored
The ARM external linking CL left missed changes to sys_freebsd_arm.s and sys_netbsd_arm.s already done to sys_linux_arm.s. R=rsc CC=golang-dev https://golang.org/cl/12842044
-
Russ Cox authored
The TLS block on Darwin is not the same as on ELF. TBR=elias.naur CC=golang-dev https://golang.org/cl/12741044
-
Elias Naur authored
The shared library changes broke the windows build because __attribute__ ((visibility ("hidden"))) is not supported in windows gcc. This change removes the attribute, as it is only needed when building shared libraries. R=rsc CC=golang-dev https://golang.org/cl/12829044
-
Matt Joiner authored
Fixes an issue where prepared statements that outlive many connections become expensive to invoke. Fixes #6081 R=golang-dev CC=bradfitz, golang-dev https://golang.org/cl/12646044
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-dev https://golang.org/cl/12933043
-
Elias Naur authored
This CL is an aggregate of 10271047, 10499043, 9733044. Descriptions of each follow: 10499043 runtime,cmd/ld: Merge TLS symbols and teach 5l about ARM TLS This CL prepares for external linking support to ARM. The pseudo-symbols runtime.g and runtime.m are merged into a single runtime.tlsgm symbol. When external linking, the offset of a thread local variable is stored at a memory location instead of being embedded into a offset of a ldr instruction. With a single runtime.tlsgm symbol for both g and m, only one such offset is needed. The larger part of this CL moves TLS code from gcc compiled to internally compiled. The TLS code now uses the modern MRC instruction, and 5l is taught about TLS fallbacks in case the instruction is not available or appropriate. 10271047 This CL adds support for -linkmode external to 5l. For 5l itself, use addrel to allow for D_CALL relocations to be handled by the host linker. Of the cases listed in rsc's comment in issue 4069, only case 5 and 63 needed an update. One of the TODO: addrel cases was since replaced, and the rest of the cases are either covered by indirection through addpool (cases with LTO or LFROM flags) or stubs (case 74). The addpool cases are covered because addpool emits AWORD instructions, which in turn are handled by case 11. In the runtime, change the argv argument in the rt0* functions slightly to be a pointer to the argv list, instead of relying on a particular location of argv. 9733044 The -shared flag to 6l outputs a shared library, implemented in Go and callable from non-Go programs such as C. The main part of this CL change the thread local storage model. Go uses the fastest and least general mode, local exec. TLS data in shared libraries normally requires at least the local dynamic mode, however, this CL instead opts for using the initial exec mode. Initial exec mode is faster than local dynamic mode and can be used in linux since the linker has reserved a limited amount of TLS space for performance sensitive TLS code. Initial exec mode requires an extra load from the GOT table to determine the TLS offset. This penalty will not be paid if ld is not in -shared mode, since TLS accesses will be reduced to local exec. The elf sections .init_array and .rela.init_array are added to register the Go runtime entry with cgo at library load time. The "hidden" attribute is added to Cgo functions called from Go, since Go does not generate call through the GOT table, and adding non-GOT relocations for a global function is not supported by gcc. Cgo symbols don't need to be global and avoiding the GOT table is also faster. The changes to 8l are only removes code relevant to the old -shared mode where internal linking was used. This CL only address the low level linker work. It can be submitted by itself, but to be useful, the runtime changes in CL 9738047 is also needed. Design discussion at https://groups.google.com/forum/?fromgroups#!topic/golang-nuts/zmjXkGrEx6Q Fixes #5590. R=rsc CC=golang-dev https://golang.org/cl/12871044
-
Dmitriy Vyukov authored
1. Handle select statements. 2. Handle chan close. 3. Show top frame in debug mode (chansend/chanrecv/selectgo). Fixes #6049. R=golang-dev, daniel.morsing, rsc CC=golang-dev https://golang.org/cl/12694050
-
Russ Cox authored
TBR=dvyukov CC=golang-dev https://golang.org/cl/12920043
-
Russ Cox authored
mkvar was taking care of the "LeftAddr" case, effectively hiding it from the temp-merging optimization. Move it into prog.c. R=ken2 CC=golang-dev https://golang.org/cl/12884045
-
Russ Cox authored
See golang.org/s/go12encoding for design. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/12706043
-
Russ Cox authored
See golang.org/s/go12encoding for design. R=golang-dev, bradfitz, mikioh.mikioh CC=golang-dev https://golang.org/cl/12705043
-
Russ Cox authored
fat fingers - did not intend to submit. depends on the Unmarshaler CL anyway. ««« original CL description encoding/xml: add, support Marshaler interface See golang.org/s/go12xml for design. Fixes #2771. Fixes #4169. Fixes #5975. Fixes #6125. R=golang-dev, iant, dan.kortschak CC=golang-dev https://golang.org/cl/12603044 »»» TBR=golang-dev CC=golang-dev https://golang.org/cl/12918043
-
Russ Cox authored
R=r CC=golang-dev https://golang.org/cl/12681044
-