- 07 Nov, 2016 15 commits
-
-
https://go-review.googlesource.com/32870Robert Griesemer authored
For #17812. Change-Id: I58411aaa0e8b2250a16ddb20c951e39da3d601e8 Reviewed-on: https://go-review.googlesource.com/32872Reviewed-by: Alan Donovan <adonovan@google.com>
-
Quentin Smith authored
Windows has a limit of 260 characters on normal paths, but it's possible to use longer paths by using "extended-length paths" that begin with `\\?\`. This commit attempts to transparently convert an absolute path to an extended-length path, following the subtly different rules those paths require. It does not attempt to handle relative paths, which continue to be passed to the operating system unmodified. This adds a new test, TestLongPath, to the os package. This test makes sure that it is possible to write a path at least 400 characters long and runs on every platform. It also tests symlinks and hardlinks, though symlinks are not testable with our builder configuration. HasLink is moved to internal/testenv so it can be used by multiple tests. https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx has Microsoft's documentation on extended-length paths. Fixes #3358. Fixes #10577. Fixes #17500. Change-Id: I4ff6bb2ef9c9a4468d383d98379f65cf9c448218 Reviewed-on: https://go-review.googlesource.com/32451 Run-TryBot: Quentin Smith <quentin@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
-
Shenghou Ma authored
Change-Id: Ie21df37016c90cd0479c23ec4845f8195dd90fda Reviewed-on: https://go-review.googlesource.com/16518Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Russ Cox <rsc@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Shenghou Ma authored
Change-Id: Icd77ccbfe6a31117a11effb949b5826950df75a9 Reviewed-on: https://go-review.googlesource.com/16550Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Russ Cox <rsc@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Adam Langley authored
Support for ChaCha20-Poly1305 ciphers was recently added to crypto/tls. These ciphers are preferable in software, but they cannot beat hardware support for AES-GCM, if present. This change moves detection for hardware AES-GCM support into cipher/internal/cipherhw so that it can be used from crypto/tls. Then, when AES-GCM hardware is present, the AES-GCM cipher suites are prioritised by default in crypto/tls. (Some servers, such as Google, respect the client's preference between AES-GCM and ChaCha20-Poly1305.) Fixes #17779. Change-Id: I50de2be486f0b0b8052c4628d3e3205a1d54a646 Reviewed-on: https://go-review.googlesource.com/32871 Run-TryBot: Adam Langley <agl@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Quentin Smith authored
Some multipart data arrives in a stream, where subsequent parts may not be ready yet. Read should return a complete part as soon as possible. Fixes #15431 Change-Id: Ie8c041b853f3e07f0f2a66fbf4bcab5fe9132a7c Reviewed-on: https://go-review.googlesource.com/32032 Run-TryBot: Quentin Smith <quentin@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Brad Fitzpatrick authored
Cuts tests from 35 to 25 seconds. Many of these could be parallel if the test runner were modified to give each test its own workdir cloned from the tempdir files they use. But later. This helps for now. Updates #17751 Change-Id: Icc2ff87cca60a33ec5fd8abb1eb0a9ca3e85bf95 Reviewed-on: https://go-review.googlesource.com/32850 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Robert Griesemer authored
Fixes #17812. Change-Id: I08202165dd3f72ae04420e7b6129b8b689e74f5c Reviewed-on: https://go-review.googlesource.com/32870Reviewed-by: Alan Donovan <adonovan@google.com>
-
Ian Lance Taylor authored
Fixes #17818. Change-Id: Id7242b0bdd5e1db254b44ae29900fc4f3362c743 Reviewed-on: https://go-review.googlesource.com/32828Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Joe Farrell authored
Change-Id: Ibf73ee7be4591393f4e08d464edfa325c3ec2c11 Reviewed-on: https://go-review.googlesource.com/32798Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Michael Munday authored
The tests all pass (for me at least) so I don't think there is any reason not to enable them. Change-Id: I96e71383e573273f442a849914cf6458ada14f82 Reviewed-on: https://go-review.googlesource.com/32855Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Michael Munday authored
ppc64le supports both internal and external linking so I don't think there is any reason for it to skip this test. Change-Id: I05c80cc25909c0364f0a1fb7d20766b011ea1ebb Reviewed-on: https://go-review.googlesource.com/32854Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Lynn Boger authored
On ppc64x, trampolines are used to resolve too-far branches for internal linking. The external linking, solution on ppc64x is to split text sections when they get too large, allowing the external linker to handle the long branches. On arm trampolines are generanted for too-far branches for internal and external linking. When the change was made recently to enable trampolines for external linking on arm, that broke the ppc64x fix for too-far branches with external linking. The fix adds a check to use trampolines only for internal linking with ppc64x. Fixes #17795 Change-Id: Icce968fb96545f10a913e07654514643bce96261 Reviewed-on: https://go-review.googlesource.com/32853 Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> Reviewed-by: David Chase <drchase@google.com>
-
Brad Fitzpatrick authored
Fixes #17815 Change-Id: I766082d28a14c77f5dfb6cd1974b86cb0a8fe31a Reviewed-on: https://go-review.googlesource.com/32852Reviewed-by: Minux Ma <minux@golang.org>
-
Alex Brainman authored
Fixes #17811 Change-Id: I7bf9cbc5245417047ad28a14d9b9ad6592607d3d Reviewed-on: https://go-review.googlesource.com/32774Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 06 Nov, 2016 1 commit
-
-
Brad Fitzpatrick authored
Was 2.3 seconds. Now 1.4 seconds. Next win would be not running a child process and refactoring main so it could be called from tests easily. But that would also require rewriting the errchk written in Perl. This appears to be the last user of errchk in the tree. Updates #17751 Change-Id: Id7c3cec76f438590789b994e756f55b5397be07f Reviewed-on: https://go-review.googlesource.com/32754 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rob Pike <r@golang.org>
-
- 05 Nov, 2016 11 commits
-
-
Robert Griesemer authored
Fixes #17797. Change-Id: I544df81c4bcf3cbd36a793be40050f14f9a9974f Reviewed-on: https://go-review.googlesource.com/32761Reviewed-by: Dominik Honnef <dominik@honnef.co>
-
Josh Bleecher Snyder authored
net/fd_windows.go:121: syscall.WSABuf composite literal uses unkeyed fields Change-Id: I91cbe38199d5b6828379a854d08f6ceaf687dd82 Reviewed-on: https://go-review.googlesource.com/32760 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Fixes #17805 Change-Id: I30d3e63a82b3690a76f2bb33d59ae34c62a7fa59 Reviewed-on: https://go-review.googlesource.com/32759 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Brad Fitzpatrick authored
A few tests were using the global DefaultTransport implicitly. Be explicit instead. And then make some parallel while I'm there. Change-Id: I3c617e75429ecc8f6d23567d1470f5e5d0cb7cfd Reviewed-on: https://go-review.googlesource.com/32758 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Robert Griesemer authored
These comments were originally introduced together with the changes for alias declarations, and then reverted when we backed out alias support. Reintroduce them. Change-Id: I3ef2c4f4672d6af8a900f5d73df273edf28d1a14 Reviewed-on: https://go-review.googlesource.com/32826Reviewed-by: Matthew Dempsky <mdempsky@google.com>
-
Robert Griesemer authored
This reverts commit 32db3f27. Reason: Decision to back out current alias implementation. For #16339. Change-Id: Ib05e3d96041d8347e49cae292f66bec791a1fdc8 Reviewed-on: https://go-review.googlesource.com/32825Reviewed-by: Matthew Dempsky <mdempsky@google.com>
-
Robert Griesemer authored
This reverts commit 776a9010. Reason: Decision to back out current alias implementation. For #16339. Change-Id: Icb451a122c661ded05d9293356b466fa72b965f3 Reviewed-on: https://go-review.googlesource.com/32824Reviewed-by: Matthew Dempsky <mdempsky@google.com>
-
Robert Griesemer authored
This reverts commit 57ae8330. Reason: Decision to back out current alias implementation. For #16339. Change-Id: I7bcc04ac87ea3590999e58ff65a7f2e1e6c6bc77 Reviewed-on: https://go-review.googlesource.com/32823Reviewed-by: Matthew Dempsky <mdempsky@google.com>
-
Leon Klingele authored
Change-Id: I0520a37a48a56d231a8ac2dc58b2bf1762282760 Reviewed-on: https://go-review.googlesource.com/32795Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Robert Griesemer authored
This reverts commit 59c63c71. Reason: Decision to back out current alias implementation. For #16339. Change-Id: Idd135fe84b7ce4814cb3632f717736fc6985634c Reviewed-on: https://go-review.googlesource.com/32822Reviewed-by: Chris Manghane <cmang@golang.org>
-
Robert Griesemer authored
This reverts commit aa8c8e77. Reason: Decision to back out current alias implementation. For #16339. Change-Id: I4db9a8d6b3625c794be9d2f1ff0e9c047f383d28 Reviewed-on: https://go-review.googlesource.com/32827 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Chris Manghane <cmang@golang.org>
-
- 04 Nov, 2016 13 commits
-
-
Robert Griesemer authored
Reason: Decision to back out current alias implementation. Leaving import/export related code in place for now. For #16339. TBR=mdempsky Change-Id: Ib0897cab2c1c3dc8a541f2efb9893271b0b0efe2 Reviewed-on: https://go-review.googlesource.com/32757Reviewed-by: Robert Griesemer <gri@golang.org>
-
Brad Fitzpatrick authored
Reportedly, -mmacosx-version-min=10.6 -D__MAC_OS_X_VERSION_MAX_ALLOWED=1060 is problematic. It means min 10.6 and max 10.6, thus exactly 10.6. But we only support 10.8+. It never caused us problems, because we build on Macs, but apparently if you cross-compile from Linux with some Mac compiler SDK thing, then things break? This was added in https://golang.org/cl/5700083 for #3131, and the intent at the time was to pin to exactly 10.6. So it wasn't a mistake, but it is definitely outdated. Given that we now support 10.8 as the min, update it to 1080. Fixes #17732 Change-Id: I6cc8ab6ac62b8638a5025952b830f23e8822b2a6 Reviewed-on: https://go-review.googlesource.com/32580Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by: Russ Cox <rsc@golang.org> Reviewed-by: Quentin Smith <quentin@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Robert Griesemer authored
Reason: Decision to back out current alias implementation. For #16339 (comment). Change-Id: Ie04f24e529db2d29c5dd2e36413f5f37f628df39 Reviewed-on: https://go-review.googlesource.com/32819Reviewed-by: Matthew Dempsky <mdempsky@google.com>
-
Alan Donovan authored
Anonymous fields are type expressions, and Checker.typexpr already correctly records uses within them. There's no need for a second call, and the second call caused a bug when we implemented aliases. Change-Id: I1bf2429cd4948d68b085e75dfb1bdc03ad8caffd Reviewed-on: https://go-review.googlesource.com/32837Reviewed-by: Robert Griesemer <gri@golang.org>
-
Michael Munday authored
Continuation of CL 20111. Change-Id: Ie2f62237e6ec316989c021de9b267cc9d6ee6676 Reviewed-on: https://go-review.googlesource.com/32830Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Vladimir Stefanovic authored
Change-Id: Ida4cd647525abce3441bfcb9fdee059344fe717f Reviewed-on: https://go-review.googlesource.com/31477 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
-
Robert Griesemer authored
This reverts commit aff37662. Reason: Decision to back out current alias implementation. https://github.com/golang/go/issues/16339#issuecomment-258527920 Fixes #16339. Fixes #17746. Fixes #17784. Change-Id: I5737b830d7f6fb79cf36f26403b4ad8533ba1dfe Reviewed-on: https://go-review.googlesource.com/32813Reviewed-by: Russ Cox <rsc@golang.org> Reviewed-by: Rob Pike <r@golang.org>
-
Vladimir Stefanovic authored
Change-Id: Ida214ccc5858969ea60abb0787f4d98bab4336d6 Reviewed-on: https://go-review.googlesource.com/31480 TryBot-Result: Gobot Gobot <gobot@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
-
Vladimir Stefanovic authored
Change-Id: Ie7b40cc67e9901e252a4a48225bbd745a66d2673 Reviewed-on: https://go-review.googlesource.com/31511Reviewed-by: Cherry Zhang <cherryyz@google.com>
-
Brad Fitzpatrick authored
I used the slowtests.go tool as described in https://golang.org/cl/32684 on packages that stood out. go test -short std drops from ~56 to ~52 seconds. This isn't a huge win, but it was mostly an exercise. Updates #17751 Change-Id: I9f3402e36a038d71e662d06ce2c1d52f6c4b674d Reviewed-on: https://go-review.googlesource.com/32751 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Vladimir Stefanovic authored
External linking on mips/mipsle is not supported yet (issue #17792). Change-Id: Ic25f4f8fe9e0ec35c72ca9f85c053b398df4952c Reviewed-on: https://go-review.googlesource.com/31512Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
Ian Lance Taylor authored
Change-Id: I5fecdf52e9e3035ea8feb5768985ed5200dbd6af Reviewed-on: https://go-review.googlesource.com/32752 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Martin Möhrmann <martisch@uos.de>
-
Emmanuel Odeke authored
Follow up of CL https://go-review.googlesource.com/32595. Change-Id: I2b3ff7e6b2c764bb6bc5e9aa692d0aed79eb5626 Reviewed-on: https://go-review.googlesource.com/32750Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-