Commits · 1dfe3d1f6e510e7c62cf74240a53d26131042049 · go / golang

20 Dec, 2011 36 commits

os: don't trust O_CLOEXEC on OS X · 1dfe3d1f

Brad Fitzpatrick authored Dec 20, 2011

OS X 10.6 doesn't do O_CLOEXEC.
OS X 10.7 does.

For now, always fall back to using syscall.CloseOnExec on darwin.

This can removed when 10.6 is old news, or if we find a
way to cheaply & reliably detect 10.6 vs 10.7 at runtime.

Fixes #2587

R=golang-dev, rsc, iant
CC=golang-dev
https://golang.org/cl/5500053

1dfe3d1f

build: fix the build with USE_GO_TOOL=false · 0735e06c
Brad Fitzpatrick authored Dec 20, 2011
```
R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/5502051
```
0735e06c
image/ycbcr: move the Y'CbCr types into image and image/color. · d13ce811
Nigel Tao authored Dec 20, 2011
```
R=r, rsc
CC=golang-dev
https://golang.org/cl/5493084
```
d13ce811

html: handle breakout tags in foreign content. · fe28d1aa

Nigel Tao authored Dec 20, 2011

Also recognize that, in the latest version of the HTML5 spec,
foreign content is not an insertion mode, but a separate concern.

Pass tests10.dat, test 13:
<!DOCTYPE html><body><table><caption><svg><g>foo</g><g>bar</g><p>baz</table><p>quux

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <table>
|       <caption>
|         <svg svg>
|           <svg g>
|             "foo"
|           <svg g>
|             "bar"
|         <p>
|           "baz"
|     <p>
|       "quux"

Also pass tests through test 15:
<!DOCTYPE html><body><table><colgroup><svg><g>foo</g><g>bar</g><p>baz</table><p>quux

R=andybalholm
CC=golang-dev
https://golang.org/cl/5494078

fe28d1aa

dashboard: send builder in commit POST query string · b0eb68ad
Andrew Gerrand authored Dec 20, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5498055
```
b0eb68ad
build: a round of fixes · e83cd7f7
Russ Cox authored Dec 20, 2011
```
TBR=r
CC=golang-dev
https://golang.org/cl/5503052
```
e83cd7f7
net: fix Windows build · 01507b9a
Brad Fitzpatrick authored Dec 20, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5505048
```
01507b9a

effective_go: redeclaration · a41006f3

Rob Pike authored Dec 20, 2011

Fixes #2455.
Fixes #2013.

R=rsc, r, gri
CC=golang-dev
https://golang.org/cl/5498053

a41006f3

build: fix on Linux · c037d3f2

Russ Cox authored Dec 20, 2011

On other systems the temporary directory name
will have a .XXXXXX in the middle of it.  Oh well.

R=bradfitz
CC=golang-dev
https://golang.org/cl/5504049

c037d3f2

build: fix build · ac3028f0

Russ Cox authored Dec 20, 2011

Missing file during last CL.

TBR=r
CC=golang-dev
https://golang.org/cl/5505047

ac3028f0

build: use go command during build · 41a6165c

Russ Cox authored Dec 20, 2011

If something goes wrong, it should suffice to set
USE_GO_TOOL=false in env.bash to fall back to the
makefiles.  I will delete the makefiles in January.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5502047

41a6165c

cmd/go: work toward build script · fd1c1b96

Russ Cox authored Dec 20, 2011

The commands in the standard tree are now named
by the pseudo-import paths cmd/gofmt etc.
This avoids ambiguity between cmd/go's directory
and go/token's parent directory.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5503050

fd1c1b96

builder: use go-build.appspot.com instead of godashboard by default · 87201057
Andrew Gerrand authored Dec 20, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5489097
```
87201057

gc: allow use of unsafe.Pointer in generated code · 82a6a4f3

Russ Cox authored Dec 20, 2011

The functions we generate to implement == on structs
or arrays may need to refer to unsafe.Pointer even in
safe mode, in order to handle unexported fields contained
in other packages' structs.

R=ken2
CC=golang-dev
https://golang.org/cl/5505046

82a6a4f3

net: DialTimeout · 964309e2

Brad Fitzpatrick authored Dec 20, 2011

Fixes #240

R=adg, dsymonds, rsc, r, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5491062

964309e2

template: better error message for empty templates · 4869996b

Rob Pike authored Dec 20, 2011

New("x").ParseFiles("y") can result in an empty "x" template.
Make the message clearer that this is the problem. The error
returns from both template packages in this case were
confusing.

I considered making the method use "x" instead of "y" in
this case, but that just made other situations confusing
and harder to explain.

Fixes #2594.

R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/5498048

4869996b

.hgignore: ignore autogenerated files · bbdd2070
Christopher Wedgwood authored Dec 20, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5491077
```
bbdd2070

runtime/cgo: fix build · 5d429ad0

Russ Cox authored Dec 20, 2011

Two forgotten renames from last CL.

TBR=r
CC=golang-dev
https://golang.org/cl/5502046

5d429ad0

go: build runtime/cgo · 54fb9940

Russ Cox authored Dec 20, 2011

Also rename -v to -x in the build and install commands,
to match the flag in go test (which we can't change
because -v is taken).  Matches sh -x anyway.

R=r, iant, ality
CC=golang-dev
https://golang.org/cl/5504045

54fb9940

panics: use the new facilities of testing.B instead · 6b772462

Rob Pike authored Dec 20, 2011

Lots of panics go away.
Also fix a name error in html/template.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5498045

6b772462

go/ast, parser: remember short variable decls. w/ correspoding ident objects · b9697d4a

Robert Griesemer authored Dec 20, 2011

The ast.Object's Decl field pointed back to the corresponding declaration for
all but short variable declarations. Now remember corresponding assignment
statement in the Decl field.

Also: simplified some code for parsing select statements.

R=golang-dev, r, bradfitz
CC=golang-dev
https://golang.org/cl/5492072

b9697d4a

testing: allow benchmarks to print and fail · c50e4f5e

Rob Pike authored Dec 20, 2011

Refactors the benchmarks and test code.
Now benchmarks can call Errorf, Fail, etc.,
and the runner will act accordingly.

Because functionality has been folded into an
embedded type, a number of methods' docs
no longer appear in godoc output. A fix is
underway; if it doesn't happen fast enough,
I'll add wrapper methods to restore the
documentation.

R=bradfitz, adg, rsc
CC=golang-dev
https://golang.org/cl/5492060

c50e4f5e

cgo: support export for built-in types · 7be6229f

Maxim Pimenov authored Dec 20, 2011

This change doesn't pay attention to structs
so they still cannot be exported, see Issue 2552.

Fixes #2462.

R=dvyukov, rsc, iant
CC=golang-dev
https://golang.org/cl/5487058

7be6229f

encoding/binary: add more benchmarks · 16bf7d9e

Roger Peppe authored Dec 20, 2011

Also add a byte count to the varint benchmarks - this
isn't accurate, of course, but it allows a rough comparison to
the other benchmarks.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5496070

16bf7d9e

time: JSON marshaler for Time · 317ad14c

Robert Hencke authored Dec 20, 2011

R=golang-dev, dsymonds, hectorchu, r, r
CC=golang-dev
https://golang.org/cl/5496064

317ad14c

go: build runtime · a1198fcc

Russ Cox authored Dec 20, 2011

R=golang-dev, r, adg
CC=golang-dev
https://golang.org/cl/5495068

a1198fcc

syscall: remove unnecessary semicolon from mksyscall.pl · b4962566
Ian Lance Taylor authored Dec 20, 2011
```
R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/5495098
```
b4962566
strconv: remove obsolete comment. · 36397814
Ian Lance Taylor authored Dec 20, 2011
```
R=r, rsc
CC=golang-dev
https://golang.org/cl/5490078
```
36397814
runtime: correct '.' to '·' in comments · 21af3d86
Ian Lance Taylor authored Dec 20, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5495097
```
21af3d86

dashboard: todo sends full Commit with Kind field · 634f0eda

Andrew Gerrand authored Dec 20, 2011

Permits us to implement other Kinds of todo instruction in the future.

R=rsc
CC=golang-dev
https://golang.org/cl/5495087

634f0eda

encoding/binary: add Write and Read examples · 7bffdc72
Andrew Gerrand authored Dec 20, 2011
```
R=golang-dev, r, adg
CC=golang-dev
https://golang.org/cl/5495095
```
7bffdc72
5l/6l/8l: add support for netbsd signature note section · 5842f7e4
Joel Sing authored Dec 20, 2011
```
R=m4dh4tt3r, jsing, rsc
CC=golang-dev
https://golang.org/cl/5493068
```
5842f7e4
net/http: test should not leave tmp files behind on windows · b7e9d225
Alex Brainman authored Dec 20, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5496067
```
b7e9d225
os: make sure Remove returns correct error on windows · 796a2c19
Alex Brainman authored Dec 20, 2011
```
R=golang-dev, bsiegert, rsc
CC=golang-dev
https://golang.org/cl/5493078
```
796a2c19
old/template: close file in TestAll before deleting it · 448d89d6
Alex Brainman authored Dec 20, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5491073
```
448d89d6

dashboard: display correct package build state · 7c94dc04

Andrew Gerrand authored Dec 20, 2011

Includes some boring whitespace tweaks.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5492067

7c94dc04

19 Dec, 2011 4 commits
- html: ignore <caption>, <col>, <tbody> etc. when parsing table fragments · a0bd46e7
  Andrew Balholm authored Dec 19, 2011
```
Pass tests6.dat, test 36:
<caption><col><colgroup><tbody><tfoot><thead><tr>

| <tr>

Pass tests through test 44:
<body></body></html>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5494055
```
  a0bd46e7
- zip: fix data race in test · 315b361f
  Brad Fitzpatrick authored Dec 19, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5492073
```
  315b361f
- syscall: regenerate z-files for linux/arm · d2933e99
  Mikio Hara authored Dec 19, 2011
```
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5496062
```
  d2933e99
- exec: disable new test to fix build · 355ed5da
  Ian Lance Taylor authored Dec 19, 2011
```
TBR=bradfitz
CC=golang-dev
https://golang.org/cl/5494075
```
  355ed5da