Commits · 236a9de93f691ff77dc90cfcb1b05a7d3fe41602 · go / golang

02 Nov, 2009 26 commits
- remove goroutines from template parsing. · 236a9de9
  Rob Pike authored Nov 02, 2009
```
fix up one usage to take advantage.

R=rsc
CC=go-dev
http://go/go-review/1018023
```
  236a9de9
- Define constants for sizes of Sym structures. · f32cde88
  Ian Lance Taylor authored Nov 02, 2009
```
R=rsc, agl
http://go/go-review/1016028
```
  f32cde88
- Fix cgo for GCC 4.4 · 72ec930f
  Adam Langley authored Nov 02, 2009
```
Firstly, with -Werror, GCC switched to printing warnings starting
with "error:". Widening the string matches solves this as the messages
are otherwise unchanged.

Secondly, GCC 4.4 outputs DWARF sections with with NUL bytes in all
the offsets and requires the relocation section for .debug_info to be
processed in order to result in valid DWARF data. Thus we add minimal
handling for relocation sections, which is sufficient for our needs.

BUG=1
Fixes #1.

R=rsc, iant
CC=go-dev
http://go/go-review/1017003
```
  72ec930f
- We should not silently permit a named type to match an unnamed · 6358cac7
  Ian Lance Taylor authored Nov 02, 2009
```
type.  This is OK in a conversion but not in an assignment.

R=rsc
http://go/go-review/1016024
```
  6358cac7
- use the new routine regexp.MustCompile to clean up some code that uses global regexps. · a8246510
  Rob Pike authored Nov 02, 2009
```
R=rsc, gri
CC=go-dev
http://go/go-review/1016025
```
  a8246510
- rietveld does not like code reviews with subjects longer than 100 characters, so… · 9c132158
  Russ Cox authored Nov 02, 2009
```
rietveld does not like code reviews with subjects longer than 100 characters, so trim the line pulled out of the description to avoid the limit.

R=r
http://go/go-review/1016027
```
  9c132158
- eliminate goroutine from testing/regexp too. · cd82d490
  Rob Pike authored Nov 02, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1018021
```
  cd82d490
- Split constant time functions into crypto/subtle. · ad67a866
  Adam Langley authored Nov 02, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1018020
```
  ad67a866
- do not emit USED for global x when compiling "_ = x;" · d0024898
  Russ Cox authored Nov 02, 2009
```
R=ken@golang.org
CC=r
http://go/go-review/1018019
```
  d0024898
- Recognize gccgo error message. · 102357f0
  Ian Lance Taylor authored Nov 02, 2009
```
runtime.go:19:10: error: reference to undefined identifier ‘runtime.printbool’

R=rsc
http://go/go-review/1018018
```
  102357f0
- take goroutines out of regexp so they can be created · acc54b6c
  Rob Pike authored Nov 02, 2009
```
during initialization.

R=rsc
CC=go-dev
http://go/go-review/1016023
```
  acc54b6c
- cleaning up bug132 · e6f85af2
  Robert Griesemer authored Nov 02, 2009
```
R=rsc
http://go/go-review/1017012
```
  e6f85af2
- - initial steps towards showing directory tree instead of · 49d295d5
  Robert Griesemer authored Nov 02, 2009
```
  just a single directory
- all pieces present but not well integrated
- directory tree served at the moment under /tree

R=rsc
http://go/go-review/1018016
```
  49d295d5
- - collect line comments for methods in interfaces · b6735211
  Robert Griesemer authored Nov 02, 2009
```
  (previously not shown in godoc)
- simplify parsing of struct types (match code structure for parsing interface types)

R=rsc, r
http://go/go-review/1016019
```
  b6735211
- nil pointer checks in 8g. · 9dd2e1e3
  Russ Cox authored Nov 02, 2009
```
fix nil pointer check in 6g.
was dereferencing after the ADD;
dereference before instead.

R=ken@golang.org
CC=iant
http://go/go-review/1016022
```
  9dd2e1e3
- reverse the arguments to io.Copy so the destination is on the · 4d310f24
  Rob Pike authored Nov 02, 2009
```
left, like an assignment, like strcpy, etc.

R=rsc
CC=go-dev
http://go/go-review/1016011
```
  4d310f24
- fixups for memory model document · 4e5296d4
  Rob Pike authored Nov 02, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1016018
```
  4e5296d4
- correct a few things in Go for C++ Programmers · 6ac19ece
  Rob Pike authored Nov 02, 2009
```
R=iant, rsc
CC=go-dev
http://go/go-review/1016015
```
  6ac19ece
- fixups to "effective go" · c2b6418c
  Rob Pike authored Nov 02, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1016020
```
  c2b6418c
- a few tweaks to the language design faq · a411cea1
  Rob Pike authored Nov 02, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1017007
```
  a411cea1
- significant cleanup of the main FAQ · 0c2a479a
  Rob Pike authored Nov 02, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1017008
```
  0c2a479a
- save some text from the old FAQ; will get reworked in time · 5b72f9cd
  Rob Pike authored Nov 02, 2009
```
R=rsc
http://go/go-review/1018008
```
  5b72f9cd
- fixups in the tutorial · 83f0b718
  Rob Pike authored Nov 02, 2009
```
also add a section about compiling programs because some found it surprising not to have one

R=rsc
CC=go-dev
http://go/go-review/1018011
```
  83f0b718
- code review: avoid subject changes, fix http_proxy submit bug · dde666da
  Russ Cox authored Nov 02, 2009
```
R=r
http://go/go-review/1016021
```
  dde666da
- Permit the CC environment variable to include arguments · f4e3947f
  Ian Lance Taylor authored Nov 02, 2009
```
(I should have tested the last change a bit more before
submitting).

R=rsc
http://go/go-review/1017011
```
  f4e3947f
- Use the environment variable CC as the bootstrap compiler used · fab7ae15
  Ian Lance Taylor authored Nov 02, 2009
```
to build 6g, 6l, etc.

R=rsc
CC=go-dev
http://go/go-review/1018015
```
  fab7ae15
01 Nov, 2009 12 commits

enable all (but one) test cases in test.sh that · b96ad809

Robert Griesemer authored Nov 01, 2009

were excluded before because of incorrect comment
formatting (comment formatting is mostly idempotent
at this point)

R=rsc
http://go/go-review/1018014

b96ad809

These files were moved to encoding/base64. The directory was · d8efcdcd
Ian Lance Taylor authored Nov 01, 2009
```
already removed from the Makefile.

R=rsc
http://go/go-review/1017006
```
d8efcdcd

split ipsock.go, sock.go, and unixsock.go out of net.go · 35ace1d1

Russ Cox authored Nov 01, 2009

prior to cleanup.  no changes, only moving.

remove dependencies on strconv and strings

R=r
http://go/go-review/1017010

35ace1d1

syscall cleanup. · fd1add27

Russ Cox authored Nov 01, 2009

 * rename PORT.sh -> mkall.sh (hopefully more obvious),
   change behavior: run commands by default.
 * pull more constants out of #defines automatically,
   instead of editing large lists by hand.
 * add Recvfrom, Sendto

add os.O_EXCL.

R=r
http://go/go-review/1017009

fd1add27

don't update sync time if no files have changed · 52232183
Robert Griesemer authored Nov 01, 2009
```
(and thus avoid re-indexing after every sync attempt)

R=rsc
http://go/go-review/1016010
```
52232183

os cleanup. · a64b69da

Russ Cox authored Nov 01, 2009

dir_* and stat_* are just os specific,
not os+arch-specific.

R=r
http://go/go-review/1018010

a64b69da

misc cleanup · 7732d80c
Russ Cox authored Nov 01, 2009
```
R=r
http://go/go-review/1016017
```
7732d80c

code review fixes · 45495249

Russ Cox authored Nov 01, 2009

* clean up error handling: show Exception info
* white space fixes
* clean up output when creating CL
* simplify hg change command; add hg file
* fix stale cookie bug (thanks iant)
* in LoadAllCL, load each CL in a different thread,
  to parallelize the slow web fetches
* throw away support for Mercurial before version 1.3
* add @CL-number file pattern for commands like diff
* make hg sync show files being sync'ed

R=r
http://go/go-review/1016016

45495249

allow unpacking of json map into Go map, · b7215331
Russ Cox authored Nov 01, 2009
```
now that reflection supports it.

R=r
http://go/go-review/1015008
```
b7215331

Make.pkg: add DEPS= support · bf991bb7

Russ Cox authored Nov 01, 2009

allow Makefiles using Make.pkg to specify a
list of directories that should be installed
before trying to build the package.
this is a stopgap for small package trees
maintained outside the standard tree.

R=r
http://go/go-review/1016012

bf991bb7

more file patterns to ignore · eef3fbb8
Russ Cox authored Nov 01, 2009
```
R=r
http://go/go-review/1016014
```
eef3fbb8
concurrency · bb3e3090
Rob Pike authored Nov 01, 2009
```
R=go-dev, iant, rsc
http://go/go-review/1018004
```
bb3e3090

31 Oct, 2009 2 commits
- return "<nil>" when calling String() on a nil bytes.Buffer. · 63e668d2
  Rob Pike authored Oct 31, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1016005
```
  63e668d2
- add PDF for go talk on Oct 30 2009 · aa0c8113
  Rob Pike authored Oct 31, 2009
```
R=rsc
CC=go-dev
http://go/go-review/1018007
```
  aa0c8113