Commits · 28397befabea2bb984b8eda963d9e7c16ffafd45 · go / golang

31 Jan, 2012 19 commits

net: replace error variable name e, errno with err · 28397bef
Mikio Hara authored Jan 31, 2012
```
R=rsc, r
CC=golang-dev
https://golang.org/cl/5593046
```
28397bef
cmd/ld: fix gdbscript · f8e9bbe4
Wei Guangjing authored Jan 31, 2012
```
R=golang-dev, lvd
CC=golang-dev
https://golang.org/cl/5601058
```
f8e9bbe4

os/exec: TestExtraFiles - close any leaked file descriptors · 1677f1a1

Joel Sing authored Jan 31, 2012

Ensure that file descriptors have not already been leaked into our
environment - close any that are open at the start of the
TestExtraFiles test.

Also use the appropriate command for listing open files.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5574062

1677f1a1

test: float to integer test case · 2d7495d2

Ian Lance Taylor authored Jan 31, 2012

gccgo currently fails this test:

fixedbugs/bug402.go:12:9: error: floating point constant truncated to integer
fixedbugs/bug402.go:13:8: error: floating point constant truncated to integer

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5600050

2d7495d2

runtime: use per-map hash seeds · 85aeeada

Damian Gryski authored Jan 31, 2012

This patch adds a hash seed to the Hmap struct.  Each seed is
initialized by runtime.fastrand1().  This is the first step of a
solution to issue 2630.  Fastrand1 still needs to be updated to provide
us with actually random bits.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5599046

85aeeada

A+C: Damian Gryski (individual CLA) · 4b2dfd6c
Russ Cox authored Jan 31, 2012
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/5600055
```
4b2dfd6c

build: fix again · fdb80ea1

Russ Cox authored Jan 31, 2012

The new cross-compiling bin target was breaking
everything but the system where buildscript.sh ran.

TBR=golang-dev
CC=golang-dev
https://golang.org/cl/5598055

fdb80ea1

build: fix buildscripts · 5e72f3ca
Russ Cox authored Jan 31, 2012
```
TBR=golang-dev
CC=golang-dev
https://golang.org/cl/5600054
```
5e72f3ca

build: remove Make.pkg, Make.tool · 2050a9e4

Russ Cox authored Jan 31, 2012

Consequently, remove many package Makefiles,
and shorten the few that remain.

gomake becomes 'go tool make'.

Turn off test phases of run.bash that do not work,
flagged with $BROKEN.  Future CLs will restore these,
but this seemed like a big enough CL already.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5601057

2050a9e4

go: improvements · 00e9a54d

Russ Cox authored Jan 31, 2012

Add 'go clean'.
Make 'go build' write to pkgname, not a.out.
Make 'go test -c' write to pkgname.test, not test.out.
Make 'go install' write alternate binaries to .../bin/goos_goarch/.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5600048

00e9a54d

build: force numerical comparison in version.bash · 38e37011
Russ Cox authored Jan 31, 2012
```
Fixes #2436.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5576075
```
38e37011

test: attempt at making a test more robust · 0eb647e7

Brad Fitzpatrick authored Jan 31, 2012

A current theory is that this test is too fast for the
time resolution on the VMs where our builders run.

R=rsc
CC=golang-dev
https://golang.org/cl/5581056

0eb647e7

runtime: fix mkasmh.sh for arm? · 56e6a024

Russ Cox authored Jan 31, 2012

The builder is Debian, so maybe running dash,
the shell that time forgot.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5600053

56e6a024

runtime: fix mkasmh.h · bacb1b70

Anthony Martin authored Jan 31, 2012

We weren't properly deleting the various header
files (that were temporarily renamed) if a $CC
for the current $GOARCH didn't exist.  And since
the compiler checks the current directory for
headers before any -I arguments, this had the
unfortunate side effect of including the last
generated headers instead of the correct ones.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5581055

bacb1b70

image: remove image/bmp and image/tiff from std. · 10498f4d

Nigel Tao authored Jan 31, 2012

They have moved to the code.google.com/p/go.image subrepo.

R=rsc
CC=golang-dev
https://golang.org/cl/5552052

10498f4d

doc: add image/{bmp,tiff} renames to go1.tmpl. · ceb1ca6b
Nigel Tao authored Jan 31, 2012
```
R=r
CC=golang-dev
https://golang.org/cl/5598052
```
ceb1ca6b
fix: add image/{bmp,tiff} to go1pkgrename. · 61ac24ce
Nigel Tao authored Jan 31, 2012
```
R=rsc, r
CC=golang-dev
https://golang.org/cl/5581053
```
61ac24ce
doc: update weekly snapshot notes with subrepo changes · 2ea25e24
Andrew Gerrand authored Jan 31, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5599051
```
2ea25e24
dashboard: better ui layout for subrepo status · 1f5f457b
Andrew Gerrand authored Jan 31, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5595048
```
1f5f457b

30 Jan, 2012 21 commits

cmd/pack: change gopack to pack in error messages · 33b6d46a
Rob Pike authored Jan 30, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5598051
```
33b6d46a

run.bash: s/make/gomake · 1f7128e1

Rob Pike authored Jan 30, 2012

attempt to fix freebsd build
TBR=rsc

R=rsc
CC=golang-dev
https://golang.org/cl/5576077

1f7128e1

go/spec: Update language on map types. · 9c3d876d
Robert Griesemer authored Jan 30, 2012
```
Fixes #2803.

R=r
CC=golang-dev
https://golang.org/cl/5601053
```
9c3d876d

go: move compilers into the go-tool directory · 91cb3489

Rob Pike authored Jan 30, 2012

Also delete gotest, since it's messy to fix and slated for deletion anyway.
A couple of things outside src can't be tested any more. "go test" will be
fixed and these tests will be re-enabled. They're noisy for now.

Fixes #284.

R=rsc
CC=golang-dev
https://golang.org/cl/5598049

91cb3489

buildscript.sh: now works correctly on windows · be7a0494
Alex Brainman authored Jan 30, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5569092
```
be7a0494
godoc: sort list of "other packages" · 590f948b
Robert Griesemer authored Jan 30, 2012
```
Fixes #2786.

R=r, bradfitz
CC=golang-dev
https://golang.org/cl/5581050
```
590f948b

godoc: add URL mode m=methods · ff451e86

Robert Griesemer authored Jan 30, 2012

If set, all methods are shown, not just those
of non-exported anonynous fields.

This change will only become functional once
CL 5576057 is submitted.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5599048

ff451e86

build: fix buildscript breakage after all.bash · 260db6ea

Brad Fitzpatrick authored Jan 30, 2012

Fix from Russ. Tested that multiple builds in a row
work again.

R=rsc, rsc
CC=golang-dev
https://golang.org/cl/5599047

260db6ea

doc: use consistent receiver names, when it makes sense. · eb53d472
Brad Fitzpatrick authored Jan 30, 2012
```
Makes for prettier docs.

R=golang-dev, dsymonds, r, rsc
CC=golang-dev
https://golang.org/cl/5576056
```
eb53d472
json: remove old optimization that inlining covers now · 25c96cba
Brad Fitzpatrick authored Jan 30, 2012
```
Benchmarks look the same.

R=golang-dev, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5572080
```
25c96cba

go: don't clobber command install paths · d2599b43

Anthony Martin authored Jan 30, 2012

This fixes a regression that was made when adding
support for building with gccgo (in d6a14e6fac0c).

External commands (those not from the Go tree) were
being installed to the package directory instead of
the binary directory.

R=golang-dev, rsc, adg, remyoudompheng, rsc
CC=golang-dev
https://golang.org/cl/5564072

d2599b43

test: add test of NaN in map · 6ebf8a64
Russ Cox authored Jan 30, 2012
```
R=iant, r
CC=golang-dev
https://golang.org/cl/5576071
```
6ebf8a64
codereview: ignore test files during 'hg gofmt' · deeb1b36
Russ Cox authored Jan 30, 2012
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5581047
```
deeb1b36
encoding/xml: fix decoding of xml.Name with sub-elements · 9c497443
Gustavo Niemeyer authored Jan 30, 2012
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5569090
```
9c497443
gopack: rename pack, move to go-tool directory · ff8133d4
Rob Pike authored Jan 30, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5598045
```
ff8133d4

compress/flate: undo misuse of skipNever · cb34f5c3

Russ Cox authored Jan 30, 2012

I assume this was a too aggressive search-and-replace.

R=imkrasin
CC=golang-dev
https://golang.org/cl/5580047

cb34f5c3

fmt: add test of NaN map keys · e451fb8f
Russ Cox authored Jan 30, 2012
```
R=r
CC=golang-dev
https://golang.org/cl/5564063
```
e451fb8f
8g: use uintptr for local pc · f3492a7d
Russ Cox authored Jan 30, 2012
```
Fixes #2478.

R=ken2
CC=golang-dev
https://golang.org/cl/5593051
```
f3492a7d
make.bash: don't remove hgpatch · 2d6c0116
Rob Pike authored Jan 30, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5598046
```
2d6c0116

cmd/go: fix including of _cgo_export.h · d59c8878

Gustavo Niemeyer authored Jan 30, 2012

This will add the temporary object directory into the lookup
path so that cgo-exported function declarations may be
included from C files.

R=golang-dev, rogpeppe, rsc
CC=golang-dev
https://golang.org/cl/5600043

d59c8878

pkg/go/scanner: Fix Typical use output · 74e8a130
Olivier Duperray authored Jan 30, 2012
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5595045
```
74e8a130