- 05 Nov, 2016 11 commits
-
-
Robert Griesemer authored
Fixes #17797. Change-Id: I544df81c4bcf3cbd36a793be40050f14f9a9974f Reviewed-on: https://go-review.googlesource.com/32761Reviewed-by:
Dominik Honnef <dominik@honnef.co>
-
Josh Bleecher Snyder authored
net/fd_windows.go:121: syscall.WSABuf composite literal uses unkeyed fields Change-Id: I91cbe38199d5b6828379a854d08f6ceaf687dd82 Reviewed-on: https://go-review.googlesource.com/32760 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Fixes #17805 Change-Id: I30d3e63a82b3690a76f2bb33d59ae34c62a7fa59 Reviewed-on: https://go-review.googlesource.com/32759 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Brad Fitzpatrick authored
A few tests were using the global DefaultTransport implicitly. Be explicit instead. And then make some parallel while I'm there. Change-Id: I3c617e75429ecc8f6d23567d1470f5e5d0cb7cfd Reviewed-on: https://go-review.googlesource.com/32758 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Robert Griesemer authored
These comments were originally introduced together with the changes for alias declarations, and then reverted when we backed out alias support. Reintroduce them. Change-Id: I3ef2c4f4672d6af8a900f5d73df273edf28d1a14 Reviewed-on: https://go-review.googlesource.com/32826Reviewed-by:
Matthew Dempsky <mdempsky@google.com>
-
Robert Griesemer authored
This reverts commit 32db3f27. Reason: Decision to back out current alias implementation. For #16339. Change-Id: Ib05e3d96041d8347e49cae292f66bec791a1fdc8 Reviewed-on: https://go-review.googlesource.com/32825Reviewed-by:
Matthew Dempsky <mdempsky@google.com>
-
Robert Griesemer authored
This reverts commit 776a9010. Reason: Decision to back out current alias implementation. For #16339. Change-Id: Icb451a122c661ded05d9293356b466fa72b965f3 Reviewed-on: https://go-review.googlesource.com/32824Reviewed-by:
Matthew Dempsky <mdempsky@google.com>
-
Robert Griesemer authored
This reverts commit 57ae8330. Reason: Decision to back out current alias implementation. For #16339. Change-Id: I7bcc04ac87ea3590999e58ff65a7f2e1e6c6bc77 Reviewed-on: https://go-review.googlesource.com/32823Reviewed-by:
Matthew Dempsky <mdempsky@google.com>
-
Leon Klingele authored
Change-Id: I0520a37a48a56d231a8ac2dc58b2bf1762282760 Reviewed-on: https://go-review.googlesource.com/32795Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Robert Griesemer authored
This reverts commit 59c63c71. Reason: Decision to back out current alias implementation. For #16339. Change-Id: Idd135fe84b7ce4814cb3632f717736fc6985634c Reviewed-on: https://go-review.googlesource.com/32822Reviewed-by:
Chris Manghane <cmang@golang.org>
-
Robert Griesemer authored
This reverts commit aa8c8e77. Reason: Decision to back out current alias implementation. For #16339. Change-Id: I4db9a8d6b3625c794be9d2f1ff0e9c047f383d28 Reviewed-on: https://go-review.googlesource.com/32827 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Chris Manghane <cmang@golang.org>
-
- 04 Nov, 2016 19 commits
-
-
Robert Griesemer authored
Reason: Decision to back out current alias implementation. Leaving import/export related code in place for now. For #16339. TBR=mdempsky Change-Id: Ib0897cab2c1c3dc8a541f2efb9893271b0b0efe2 Reviewed-on: https://go-review.googlesource.com/32757Reviewed-by:
Robert Griesemer <gri@golang.org>
-
Brad Fitzpatrick authored
Reportedly, -mmacosx-version-min=10.6 -D__MAC_OS_X_VERSION_MAX_ALLOWED=1060 is problematic. It means min 10.6 and max 10.6, thus exactly 10.6. But we only support 10.8+. It never caused us problems, because we build on Macs, but apparently if you cross-compile from Linux with some Mac compiler SDK thing, then things break? This was added in https://golang.org/cl/5700083 for #3131, and the intent at the time was to pin to exactly 10.6. So it wasn't a mistake, but it is definitely outdated. Given that we now support 10.8 as the min, update it to 1080. Fixes #17732 Change-Id: I6cc8ab6ac62b8638a5025952b830f23e8822b2a6 Reviewed-on: https://go-review.googlesource.com/32580Reviewed-by:
Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by:
Russ Cox <rsc@golang.org> Reviewed-by:
Quentin Smith <quentin@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Robert Griesemer authored
Reason: Decision to back out current alias implementation. For #16339 (comment). Change-Id: Ie04f24e529db2d29c5dd2e36413f5f37f628df39 Reviewed-on: https://go-review.googlesource.com/32819Reviewed-by:
Matthew Dempsky <mdempsky@google.com>
-
Alan Donovan authored
Anonymous fields are type expressions, and Checker.typexpr already correctly records uses within them. There's no need for a second call, and the second call caused a bug when we implemented aliases. Change-Id: I1bf2429cd4948d68b085e75dfb1bdc03ad8caffd Reviewed-on: https://go-review.googlesource.com/32837Reviewed-by:
Robert Griesemer <gri@golang.org>
-
Michael Munday authored
Continuation of CL 20111. Change-Id: Ie2f62237e6ec316989c021de9b267cc9d6ee6676 Reviewed-on: https://go-review.googlesource.com/32830Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Vladimir Stefanovic authored
Change-Id: Ida4cd647525abce3441bfcb9fdee059344fe717f Reviewed-on: https://go-review.googlesource.com/31477 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Robert Griesemer authored
This reverts commit aff37662. Reason: Decision to back out current alias implementation. https://github.com/golang/go/issues/16339#issuecomment-258527920 Fixes #16339. Fixes #17746. Fixes #17784. Change-Id: I5737b830d7f6fb79cf36f26403b4ad8533ba1dfe Reviewed-on: https://go-review.googlesource.com/32813Reviewed-by:
Russ Cox <rsc@golang.org> Reviewed-by:
Rob Pike <r@golang.org>
-
Vladimir Stefanovic authored
Change-Id: Ida214ccc5858969ea60abb0787f4d98bab4336d6 Reviewed-on: https://go-review.googlesource.com/31480 TryBot-Result: Gobot Gobot <gobot@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Vladimir Stefanovic authored
Change-Id: Ie7b40cc67e9901e252a4a48225bbd745a66d2673 Reviewed-on: https://go-review.googlesource.com/31511Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Brad Fitzpatrick authored
I used the slowtests.go tool as described in https://golang.org/cl/32684 on packages that stood out. go test -short std drops from ~56 to ~52 seconds. This isn't a huge win, but it was mostly an exercise. Updates #17751 Change-Id: I9f3402e36a038d71e662d06ce2c1d52f6c4b674d Reviewed-on: https://go-review.googlesource.com/32751 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Vladimir Stefanovic authored
External linking on mips/mipsle is not supported yet (issue #17792). Change-Id: Ic25f4f8fe9e0ec35c72ca9f85c053b398df4952c Reviewed-on: https://go-review.googlesource.com/31512Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Ian Lance Taylor authored
Change-Id: I5fecdf52e9e3035ea8feb5768985ed5200dbd6af Reviewed-on: https://go-review.googlesource.com/32752 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Martin Möhrmann <martisch@uos.de>
-
Emmanuel Odeke authored
Follow up of CL https://go-review.googlesource.com/32595. Change-Id: I2b3ff7e6b2c764bb6bc5e9aa692d0aed79eb5626 Reviewed-on: https://go-review.googlesource.com/32750Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Brad Fitzpatrick authored
Before: 8.9 seconds for go test -short After: 2.8 seconds There are still 250 tests without t.Parallel, but I got the important onces using a script: $ go test -short -v 2>&1 | go run ~/slowtests.go Where slowtests.go is https://play.golang.org/p/9mh5Wg1nLN The remaining 250 (the output lines from slowtests.go) all have a reported duration of 0ms, except one 50ms test which has to be serial. Where tests can't be parallel, I left a comment at the top saying why, so people don't add t.Parallel later and get surprised at failures. Updates #17751 Change-Id: Icbe32cbe2b996e23c89f1af6339287fa22af5115 Reviewed-on: https://go-review.googlesource.com/32684 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Josh Bleecher Snyder <josharian@gmail.com>
-
Josh Bleecher Snyder authored
Change-Id: I6bb594576e174cb0df8d25d11b84f5a4752ebfd6 Reviewed-on: https://go-review.googlesource.com/32683Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Brad Fitzpatrick authored
Change-Id: Ia03f993287d2929f35b4c92d00fe25c7243bd8b3 Reviewed-on: https://go-review.googlesource.com/32685Reviewed-by:
Josh Bleecher Snyder <josharian@gmail.com>
-
Brad Fitzpatrick authored
This CL tweaks the new (unreleased) 307/308 support added in https://golang.org/cl/29852 for #10767. Change 1: if a 307/308 response doesn't have a Location header in its response (as observed in the wild in #17773), just do what we used to do in Go 1.7 and earlier, and don't try to follow that redirect. Change 2: don't follow a 307/308 if we sent a body on the first request and the caller's Request.GetBody func is nil so we can't "rewind" the body to send it again. Updates #17773 (will be fixed more elsewhere) Change-Id: I183570f7346917828a4b6f7f1773094122a30406 Reviewed-on: https://go-review.googlesource.com/32595Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Josh Bleecher Snyder authored
Rebuild cmd/objdump once instead of twice. Speeds up standalone 'go test cmd/objdump' on my machine from ~1.4s to ~1s. Updates #17751 Change-Id: I15fd79cf18c310f892bc28a9e9ca47ee010c989a Reviewed-on: https://go-review.googlesource.com/32673 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Matthew Dempsky authored
Use a separate symbol for reflect metadata for types with Noalg set. Fixes #17752. Change-Id: Icb6cade7e3004fc4108f67df61105dc4085cd7e2 Reviewed-on: https://go-review.googlesource.com/32679Reviewed-by:
David Crawshaw <crawshaw@golang.org> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 03 Nov, 2016 10 commits
-
-
Vladimir Stefanovic authored
Change-Id: I6288f1fca1ae4c64b3907af700811ee842053020 Reviewed-on: https://go-review.googlesource.com/31472Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Vladimir Stefanovic authored
Change-Id: I8c6b8839c68818430510702719dca15b8d748fb8 Reviewed-on: https://go-review.googlesource.com/31473Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Vladimir Stefanovic authored
Change-Id: I76c62a7b79ea526f59f281e933e4fd431539d2da Reviewed-on: https://go-review.googlesource.com/31486Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Vladimir Stefanovic authored
mheap_.heap_live is an atomically accessed uint64. It is currently not 8-byte aligned on 32-bit platforms, which has been okay because it's only accessed via Xadd64, which doesn't require alignment on 386 or ARM32. However, Xadd64 on MIPS32 does require 8-byte alignment. Add a padding field to force 8-byte alignment of heap_live and prevent an alignment check crash on MIPS32. Change-Id: I7eddf7883aec7a0a7e0525af5d58ed4338a401d0 Reviewed-on: https://go-review.googlesource.com/31635 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Vladimir Stefanovic authored
Change-Id: I39a46b2a9412981db1780b688a86fec791f68b6f Reviewed-on: https://go-review.googlesource.com/31488 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Brad Fitzpatrick authored
Change-Id: I7a51d5d96a7cb87c40ade5be276136c465010bb9 Reviewed-on: https://go-review.googlesource.com/32596Reviewed-by:
Cherry Zhang <cherryyz@google.com> Reviewed-by:
Vladimir Stefanovic <vladimir.stefanovic@imgtec.com> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
-
Vladimir Stefanovic authored
Change-Id: I8b0c4bfe1e4c401d5c36a51b937671e6362c73a4 Reviewed-on: https://go-review.googlesource.com/31485Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Vladimir Stefanovic authored
Change-Id: I47c6867fc653c8388ad32e210a8027baa592eda3 Reviewed-on: https://go-review.googlesource.com/31483 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Vladimir Stefanovic authored
Change-Id: I54e100cced5b49674937fb87d1e0f585f962aeb7 Reviewed-on: https://go-review.googlesource.com/31484Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-
Vladimir Stefanovic authored
Change-Id: I10f36710dd95b9bd31b3b82a3c32edcadb90ffa9 Reviewed-on: https://go-review.googlesource.com/31510 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Cherry Zhang <cherryyz@google.com>
-