Commits · 382c461a89bf2ee1ab91ba9c193f5cb7d257246c · go / golang

20 Jun, 2014 5 commits

strings: speed up byteReplacer.Replace · 382c461a

Rui Ueyama authored Jun 20, 2014

benchmark                         old ns/op    new ns/op    delta
BenchmarkByteReplacerWriteString       7359         3661  -50.25%

LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/102550043

382c461a

sync: detect incorrect usages of RWMutex · 22d46d53
Dmitriy Vyukov authored Jun 20, 2014
```
Fixes #7858.

LGTM=ruiu
R=ruiu
CC=golang-codereviews
https://golang.org/cl/92720045
```
22d46d53

net: simplify code · 5ce98da1

Dmitriy Vyukov authored Jun 20, 2014

Single-case select with a non-nil channel is pointless.

LGTM=mikioh.mikioh
R=mikioh.mikioh
CC=golang-codereviews
https://golang.org/cl/103920044

5ce98da1

runtime: remove obsolete afterprologue check · cc817121

Dmitriy Vyukov authored Jun 20, 2014

Afterprologue check was required when did not know
about return arguments of functions and/or they were not zeroed.
Now 100% precision is required for stacks due to stack copying,
so it must work w/o afterprologue one way or another.
I can limit this change for 1.3 to merely adding a TODO,
but this check is super confusing so I don't want this knowledge to get lost.

LGTM=rsc
R=golang-codereviews, gobot, rsc, khr
CC=golang-codereviews, khr, rsc
https://golang.org/cl/96580045

cc817121

strings: define byteBitmap.isSet · 26282e40

Rui Ueyama authored Jun 20, 2014

LGTM=dave
R=golang-codereviews, bradfitz, dave
CC=golang-codereviews
https://golang.org/cl/109090048

26282e40

19 Jun, 2014 8 commits

encoding/base64, encoding/base32: speed up Encode · 24f8919a

Rui Ueyama authored Jun 19, 2014

Avoid unnecessary bitwise-OR operations.

benchmark                      old MB/s     new MB/s  speedup
BenchmarkEncodeToStringBase64  179.02       205.74    1.15x
BenchmarkEncodeToStringBase32  155.86       167.82    1.08x

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/109090043

24f8919a

strings: reduce allocation in byteStringReplacer.WriteString · 1ca10de3

Rui Ueyama authored Jun 19, 2014

Use WriteString instead of allocating a byte slice as a
buffer. This was a TODO.

benchmark               old ns/op    new ns/op    delta
BenchmarkWriteString        40139        19991  -50.20%

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/107190044

1ca10de3

image/jpeg: encode *image.Gray as grayscale JPEGs. · 57964db3
Bill Thiede authored Jun 19, 2014
```
Fixes #8201.

LGTM=nigeltao
R=nigeltao
CC=golang-codereviews
https://golang.org/cl/105990046
```
57964db3
testing/quick: brought Check parameter name in line with function doc · 705a028d
Caleb Spare authored Jun 19, 2014
```
LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/102830043
```
705a028d

image/jpeg: use a look-up table to speed up Huffman decoding. This · 4ecf0b10

Nigel Tao authored Jun 19, 2014

requires a decoder to do its own byte buffering instead of using
bufio.Reader, due to byte stuffing.

benchmark                      old MB/s     new MB/s     speedup
BenchmarkDecodeBaseline        33.40        50.65        1.52x
BenchmarkDecodeProgressive     24.34        31.92        1.31x

On 6g, unsafe.Sizeof(huffman{}) falls from 4872 to 964 bytes, and
the decoder struct contains 8 of those.

LGTM=r
R=r, nightlyone
CC=bradfitz, couchmoney, golang-codereviews, raph
https://golang.org/cl/109050045

4ecf0b10

tag go1.3 · c97ea6be

Andrew Gerrand authored Jun 19, 2014

LGTM=minux
R=golang-codereviews, minux
CC=golang-codereviews
https://golang.org/cl/107200043

c97ea6be

doc: document Go 1.3 · c70c20db

Andrew Gerrand authored Jun 19, 2014

This is a clone of 101370043, which I accidentally applied to the
release branch first.
No big deal, it needed to be applied there anyway.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/108090043

c70c20db

image: add RGBAAt, Gray16At, etc. · ca940641

ChaiShushan authored Jun 19, 2014

Fixes #7694.

LGTM=nigeltao, rsc, r
R=golang-codereviews, nigeltao, rsc, r
CC=golang-codereviews
https://golang.org/cl/109000049

ca940641

18 Jun, 2014 6 commits

encoding/base64, encoding/base32: make Encode faster · 2fbfe55e

Rui Ueyama authored Jun 18, 2014

Storing temporary values to a slice is slower than storing
them to local variables of type byte.

benchmark                         old MB/s     new MB/s  speedup
BenchmarkEncodeToStringBase32       102.21       156.66    1.53x
BenchmarkEncodeToStringBase64       124.25       177.91    1.43x

LGTM=crawshaw
R=golang-codereviews, crawshaw, bradfitz, dave
CC=golang-codereviews
https://golang.org/cl/109820045

2fbfe55e

testing: fix timing format inconsistency · 0e92b538

Robert Dinu authored Jun 18, 2014

Fixes #8175.

LGTM=r
R=golang-codereviews, r, gobot
CC=golang-codereviews
https://golang.org/cl/103320043

0e92b538

fmt: include ±Inf and NaN in the complex format test · 7dcbf4f3

Rob Pike authored Jun 18, 2014

Just to be more thorough.
No need to push this to 1.3; it's just a test change that
worked without any changes to the code being tested.

LGTM=crawshaw
R=golang-codereviews, crawshaw
CC=golang-codereviews
https://golang.org/cl/109080045

7dcbf4f3

go/build: update doc.go for go1.3 build tag. · 5f896ae3
David Symonds authored Jun 18, 2014
```
LGTM=bradfitz
R=adg, rsc, bradfitz
CC=golang-codereviews
https://golang.org/cl/102470045
```
5f896ae3

strings: add fast path to Replace · 14950d89

Rui Ueyama authored Jun 18, 2014

genericReplacer.lookup is called for each byte of an input
string. In many (most?) cases, lookup will fail for the first
byte, and it will return immediately. Adding a fast path for
that case seems worth it.

Benchmark on my Xeon 3.5GHz Linux box:

benchmark                        old ns/op    new ns/op    delta
BenchmarkGenericNoMatch               2691          774  -71.24%
BenchmarkGenericMatch1                7920         8151   +2.92%
BenchmarkGenericMatch2               52336        39927  -23.71%
BenchmarkSingleMaxSkipping            1575         1575   +0.00%
BenchmarkSingleLongSuffixFail         1429         1429   +0.00%
BenchmarkSingleMatch                 56228        55444   -1.39%
BenchmarkByteByteNoMatch               568          568   +0.00%
BenchmarkByteByteMatch                 977          972   -0.51%
BenchmarkByteStringMatch              1669         1687   +1.08%
BenchmarkHTMLEscapeNew                 422          422   +0.00%
BenchmarkHTMLEscapeOld                 692          670   -3.18%
BenchmarkByteByteReplaces             8492         8474   -0.21%
BenchmarkByteByteMap                  2817         2808   -0.32%

LGTM=rsc
R=golang-codereviews, bradfitz, dave, rsc
CC=golang-codereviews
https://golang.org/cl/79200044

14950d89

runtime: fix gogetcallerpc. · 14c8143c

Keith Randall authored Jun 18, 2014

Make assembly govet-clean.
Clean up fixes for CL 93380044.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/107160047

14c8143c

17 Jun, 2014 15 commits

fmt: fix signs when zero padding. · b559392e

Rob Pike authored Jun 17, 2014

Bug was introduced recently. Add more tests, fix the bugs.
Suppress + sign when not required in zero padding.
Do not zero pad infinities.
All old tests still pass.
This time for sure!
Fixes #8217.

LGTM=rsc
R=golang-codereviews, dan.kortschak, rsc
CC=golang-codereviews
https://golang.org/cl/103480043

b559392e

misc/emacs: add new function godoc-at-point · 933f272e
Dominik Honnef authored Jun 17, 2014
```
LGTM=adonovan
R=adonovan, ruiu
CC=golang-codereviews
https://golang.org/cl/107160048
```
933f272e

misc/emacs: replace hacky go--delete-whole-line with own implementation · 2005bea7

Dominik Honnef authored Jun 17, 2014

Using flet to replace kill-region with delete-region was a hack,
flet is now (GNU Emacs 24.3) deprecated and at least two people
have reported an issue where using go--delete-whole-line would
permanently break their kill ring. While that issue is probably
caused by faulty third party code (possibly prelude), it's easier
to write a clean implementation than to tweak the hack.

LGTM=ruiu, adonovan
R=adonovan, ruiu
CC=adg, golang-codereviews
https://golang.org/cl/106010043

2005bea7

text/scanner: fix comment · 3d853585

Robert Griesemer authored Jun 17, 2014

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/105300044

3d853585

runtime: fix stringw test. · 2b309c6e

Keith Randall authored Jun 17, 2014

Null terminate string.  Make it endian-agnostic.

TBR=bradfitz
R=golang-codereviews
CC=golang-codereviews
https://golang.org/cl/106060044

2b309c6e

test: speed up chan/select5 · 63393fae

Josh Bleecher Snyder authored Jun 17, 2014

No functional changes.

Generating shorter functions improves compilation time. On my laptop, this test's running time goes from 5.5s to 1.5s; the wall clock time to run all tests goes down 1s. On Raspberry Pi, this CL cuts 50s off the wall clock time to run all tests.

Fixes #7503.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/72590045

63393fae

go/parser: don't accept trailing explicit semicolon · 4f14d152

Robert Griesemer authored Jun 17, 2014

Fixes #8207.

LGTM=gordon.klaus, bradfitz
R=golang-codereviews, wandakkelly, gordon.klaus, bradfitz
CC=golang-codereviews
https://golang.org/cl/106010046

4f14d152

undo CL 105260044 / afd6f214cc81 · 5ce6d3e0

Keith Randall authored Jun 17, 2014

The go:nosplit change wasn't the problem, reinstating.

««« original CL description
undo CL 93380044 / 7f0999348917

Partial undo, just of go:nosplit annotation.  Somehow it
is breaking the windows builders.

TBR=bradfitz

««« original CL description
runtime: implement string ops in Go

Also implement go:nosplit annotation.  Not really needed
for now, but we'll definitely need it for other conversions.

benchmark                 old ns/op     new ns/op     delta
BenchmarkRuneIterate      534           474           -11.24%
BenchmarkRuneIterate2     535           470           -12.15%

LGTM=bradfitz
R=golang-codereviews, dave, bradfitz, minux
CC=golang-codereviews
https://golang.org/cl/93380044
»»»

TBR=bradfitz
CC=golang-codereviews
https://golang.org/cl/105260044
»»»

TBR=bradfitz
R=bradfitz, golang-codereviews
CC=golang-codereviews
https://golang.org/cl/103490043

5ce6d3e0

runtime: disable funky wide string test for now. · f2147cd7
Keith Randall authored Jun 17, 2014
```
TBR=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/105280045
```
f2147cd7

runtime: reconstitute runetochar for use by gostringw. · 0f4b53c1

Keith Randall authored Jun 17, 2014

Fixes windows builds (hopefully).

LGTM=bradfitz
R=golang-codereviews, bradfitz, alex.brainman
CC=golang-codereviews
https://golang.org/cl/103470045

0f4b53c1

undo CL 93380044 / 7f0999348917 · ee8e6878

Keith Randall authored Jun 17, 2014

Partial undo, just of go:nosplit annotation.  Somehow it
is breaking the windows builders.

TBR=bradfitz

««« original CL description
runtime: implement string ops in Go

Also implement go:nosplit annotation.  Not really needed
for now, but we'll definitely need it for other conversions.

benchmark                 old ns/op     new ns/op     delta
BenchmarkRuneIterate      534           474           -11.24%
BenchmarkRuneIterate2     535           470           -12.15%

LGTM=bradfitz
R=golang-codereviews, dave, bradfitz, minux
CC=golang-codereviews
https://golang.org/cl/93380044
»»»

TBR=bradfitz
CC=golang-codereviews
https://golang.org/cl/105260044

ee8e6878

cmd/5c, cmd/6c, cmd/8c, cmd/cc: remove unused global variable retok. · e9da5fe2
Shenghou Ma authored Jun 17, 2014
```
LGTM=bradfitz
R=rsc, iant
CC=golang-codereviews
https://golang.org/cl/107160046
```
e9da5fe2

runtime: implement string ops in Go · 61dca94e

Keith Randall authored Jun 17, 2014

Also implement go:nosplit annotation.  Not really needed
for now, but we'll definitely need it for other conversions.

benchmark                 old ns/op     new ns/op     delta
BenchmarkRuneIterate      534           474           -11.24%
BenchmarkRuneIterate2     535           470           -12.15%

LGTM=bradfitz
R=golang-codereviews, dave, bradfitz, minux
CC=golang-codereviews
https://golang.org/cl/93380044

61dca94e

runtime: implement eqstring in assembly. · b36ed905

Keith Randall authored Jun 17, 2014

BenchmarkCompareStringEqual               10.4          7.33          -29.52%
BenchmarkCompareStringIdentical           3.99          3.67          -8.02%
BenchmarkCompareStringSameLength          9.80          6.84          -30.20%
BenchmarkCompareStringDifferentLength     1.09          0.95          -12.84%
BenchmarkCompareStringBigUnaligned        75220         76071         +1.13%
BenchmarkCompareStringBig                 69843         74746         +7.02%

LGTM=bradfitz, josharian
R=golang-codereviews, bradfitz, josharian, dave, khr
CC=golang-codereviews
https://golang.org/cl/105280044

b36ed905

net: avoid array copy when shuffling SRV records · 38eea5b2

Rui Ueyama authored Jun 17, 2014

We don't need to shift array elements to shuffle them.
We just have to swap a selected element with 0th element.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/91750044

38eea5b2

16 Jun, 2014 3 commits

text/scanner: provide facility for custom identifiers · 60c0b3b5
Robert Griesemer authored Jun 16, 2014
```
LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://golang.org/cl/108030044
```
60c0b3b5
bufio: handle excessive white space in ScanWords · 54bc760a
Matthew Dempsky authored Jun 16, 2014
```
LGTM=r
R=golang-codereviews, bradfitz, r
CC=golang-codereviews
https://golang.org/cl/109020043
```
54bc760a

fmt: don't put 0x on every byte of a compact hex-encoded string · 311e2863

Rob Pike authored Jun 16, 2014

Printf("%x", "abc") was "0x610x620x63"; is now "0x616263", which
is surely better.
Printf("% #x", "abc") is still "0x61 0x62 0x63".

Fixes #8080.

LGTM=bradfitz, gri
R=golang-codereviews, bradfitz, gri
CC=golang-codereviews
https://golang.org/cl/106990043

311e2863

14 Jun, 2014 3 commits

os: disable TestGetppid on plan9 · be0079ab

Alex Brainman authored Jun 14, 2014

Fixes build.

LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews
https://golang.org/cl/105140047

be0079ab

syscall: implement syscall.Getppid() on Windows · 6f6f1bd0

Alan Shreve authored Jun 14, 2014

Also added a test to verify os.Getppid() works across all platforms

LGTM=alex.brainman
R=golang-codereviews, alex.brainman, shreveal, iant
CC=golang-codereviews
https://golang.org/cl/102320044

6f6f1bd0

A+C: Alan Shreve (individual CLA) · f303b496
Ian Lance Taylor authored Jun 14, 2014
```
Generated by addca.

R=gobot
CC=golang-codereviews
https://golang.org/cl/102410044
```
f303b496