- 12 Mar, 2012 14 commits
-
-
Russ Cox authored
Execute's data is untrusted regardless of package. R=golang-dev, gri CC=golang-dev https://golang.org/cl/5797062
-
Russ Cox authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5794061
-
Brad Fitzpatrick authored
Fixes #3298 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5783080
-
Russ Cox authored
Undo CL 5783076 and apply correct fix. The /doc hack is wrong. The code to handle this case was already there and just needs a simple fix: // We didn't find any directories containing Go files. // If some directory returned successfully, use that. - if len(all) == 0 && first != nil { + if !haveGo { for _, d := range first { haveName[d.Name()] = true all = append(all, d) R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5783079
-
Russ Cox authored
They were necessary to produce a canonical script when we checked in build scripts, but now they're just getting in the way. Fixes #3279. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5796068
-
David Symonds authored
Also make error messages consistent throughout. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5777064
-
Brad Fitzpatrick authored
For people untarring with -p or as root, preserving file permissions. This way we don't make tars owned by adg/eng or adg/staff or whatever machine Andrew was on. Instead, we always build tarballs owned by predictable users. Except archive/tar doesn't seem to work. Updates #3209. R=golang-dev, adg CC=dsymonds, golang-dev https://golang.org/cl/5796064
-
Andrew Gerrand authored
Makes Path rewrites work, as the metadata was never being scanned. Fixes #3282. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5783076
-
Brad Fitzpatrick authored
Use archive/zip instead of 7z on Windows. Look for all Windows deps before starting build, and include looking for them in their common locations instead of making users update their PATHs. Add an --upload flag that, if set to false, doesn't require credential files. R=golang-dev, alex.brainman, adg CC=golang-dev https://golang.org/cl/5794046
-
Robert Hencke authored
R=golang-dev, bradfitz, minux.ma, rsc, bradfitz CC=golang-dev https://golang.org/cl/5787069
-
David Symonds authored
This is a minor change that made it easier for me; if you hate it I can drop it. R=nigeltao CC=golang-dev https://golang.org/cl/5798060
-
Shenghou Ma authored
As we've dropped support for Mac OS X 10.5, I think the generated .pkg should reflect that decision. But this CL make it impossible to generate pkg on Mac OS X 10.6, at least for me. R=adg, bradfitz CC=golang-dev https://golang.org/cl/5798051
-
Brad Fitzpatrick authored
handle string and []byte conversions. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/5754082
-
David Symonds authored
The generated syscall files for Windows are still breaking "go tool api" (unknown function []byte); I'll look at fixing that separately. Fixes #3285. R=bradfitz CC=golang-dev https://golang.org/cl/5777062
-
- 11 Mar, 2012 1 commit
-
-
Russ Cox authored
1) The -D argument should always be a pseudo-import path, like _/Users/rsc/foo/bar, never a standard import path, because we want local imports to always resolve to pseudo-paths. 2) Disallow local imports in non-local packages. Otherwise everything works but you get two copies of a package (the real one and the "local" one) in your binary. R=golang-dev, bradfitz, yiyu.jgl CC=golang-dev https://golang.org/cl/5787055
-
- 10 Mar, 2012 6 commits
-
-
Gwenael Treguier authored
To make sure that there is no resource leak, I suggest to fix the 'fakedb' driver such as it fails when any Stmt is not closed. First, add a check in fakeConn.Close(). Then, fix all missing Stmt.Close()/Rows.Close(). I am not sure that the strategy choose in fakeConn.Prepare/prepare* is ok. The weak point in this patch is the change in Tx.Query: - Tests pass without this change, - I found it by manually analyzing the code, - I just try to make Tx.Query look like DB.Query. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5759050
-
Jeremy Jackins authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5795050
-
Brad Fitzpatrick authored
R=golang-dev, wcn CC=golang-dev https://golang.org/cl/5777052
-
Brad Fitzpatrick authored
In a transaction, on a Stmt.Query error, it was possible for a connection to be added to a db's freelist twice. Should use the local releaseConn function instead. Thanks to Gwenael Treguier for the failing test. Also in this CL: propagate driver errors through releaseConn into *DB.putConn, which conditionally ignores the freelist addition if the driver signaled ErrBadConn, introduced in a previous CL. R=golang-dev, gary.burd CC=golang-dev https://golang.org/cl/5798049
-
David Symonds authored
R=golang-dev, mikioh.mikioh CC=golang-dev https://golang.org/cl/5796050
-
Brad Fitzpatrick authored
Thanks Michael Lore for the bug report! Fixes #3266 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5754068
-
- 09 Mar, 2012 12 commits
-
-
Brad Fitzpatrick authored
We should check the CRC32s of files on EOF, even if there's no data descriptor (in streamed files), as long as there's a non-zero CRC32 in the file header / TOC. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5794045
-
Alex Brainman authored
R=golang-dev, krautz, rsc CC=golang-dev https://golang.org/cl/5783059
-
Brad Fitzpatrick authored
We now always write the "optional" streaming data descriptor signature, which turns out to be required for OS X. Also, handle reading the data descriptor with or without the signature, per the spec's recommendation. Fix data descriptor reading bugs found in the process. Fixes #3252 R=golang-dev, alex.brainman, nigeltao, rsc CC=golang-dev https://golang.org/cl/5787062
-
Robert Griesemer authored
R=golang-dev, dsymonds, rsc CC=golang-dev https://golang.org/cl/5785057
-
Shenghou Ma authored
For CL 5756065. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5784065
-
Shenghou Ma authored
So that we don't duplicate knowledge about which OS/ARCH combination supports cgo. Also updated src/run.bash and src/sudo.bash to use 'go env'. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5792055
-
Jeremy Jackins authored
familiy -> family R=golang-dev, gri CC=golang-dev https://golang.org/cl/5783061
-
Robert Griesemer authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5783063
-
Robert Griesemer authored
This affects corner (test) cases only; gofmt -w src misc doesn't cause any changes. - added additional test cases - removed doIndent parameter from printer.valueSpec (was always false) - gofmt -w src misc causes no changes Fixes #1207. R=dsymonds, rsc CC=golang-dev https://golang.org/cl/5786060
-
Russ Cox authored
It may have to switch stacks, since we are calling a DLL instead of a system call. badcallback says where it is, because it is being called on a Windows stack already. R=golang-dev, alex.brainman CC=golang-dev https://golang.org/cl/5782060
-
Mikio Hara authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/5782063
-
Andrew Gerrand authored
Updates #3254. R=golang-dev, bradfitz, alex.brainman CC=golang-dev https://golang.org/cl/5783058
-
- 08 Mar, 2012 7 commits
-
-
Russ Cox authored
R=dsymonds CC=golang-dev https://golang.org/cl/5781063
-
Russ Cox authored
Implement runtime·write, like on the other systems, and also runtime·badcallback, in assembly to reduce stack footprint. TBR=golang-dev CC=golang-dev https://golang.org/cl/5785055
-
Brad Fitzpatrick authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5787059
-
Russ Cox authored
Fixes 386 build on 64-bit machines. R=golang-dev, bradfitz, minux.ma CC=golang-dev https://golang.org/cl/5785053
-
Russ Cox authored
When a very low-level system call that should never fail does fail, we call notok, which crashes the program. Often, we are then left with only the program counter as information about the crash, and it is in notok. Instead, inline calls to notok (it is just one instruction on most systems) so that the program counter will tell us which system call is unhappy. R=golang-dev, gri, minux.ma, bradfitz CC=golang-dev https://golang.org/cl/5792048
-
Russ Cox authored
Xcode generates ._foo.go files. R=golang-dev, gri CC=golang-dev https://golang.org/cl/5786055
-
Robert Griesemer authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/5781058
-