- 02 May, 2011 2 commits
-
-
Brad Fitzpatrick authored
With Linux/8g on a 2006 Mac Mini (1.66 GHz Intel Core Duo, 2KB L1, 2MB L2, 2G main memory), GOMAXPROCS unset: start: png.BenchmarkEncodePaletted 50 44772820 ns/op png.BenchmarkEncodeRGBOpaque 10 208395900 ns/op png.BenchmarkEncodeRGBA 5 331088000 ns/op remove interface method calls: png.BenchmarkEncodePaletted 50 44722880 ns/op png.BenchmarkEncodeRGBOpaque 10 139042600 ns/op png.BenchmarkEncodeRGBA 5 334033600 ns/op flate inline min/max(): png.BenchmarkEncodePaletted 50 40631180 ns/op png.BenchmarkEncodeRGBOpaque 10 124894900 ns/op png.BenchmarkEncodeRGBA 5 312099000 ns/op after adler change: png.BenchmarkEncodePaletted 50 40181760 ns/op png.BenchmarkEncodeRGBOpaque 20 121781950 ns/op png.BenchmarkEncodeRGBA 5 313890800 ns/op In comparison to 121 ms on this 2006 machine, on my Core2 Duo 2.66 GHz laptop, the final BenchmarkEncodeRGBOpaque runs in 27 ms. (these are all for 640x480 images) R=nigeltao, rsc, r CC=golang-dev https://golang.org/cl/4432077
-
Brad Fitzpatrick authored
R=rsc, adg CC=golang-dev https://golang.org/cl/4430074
-
- 01 May, 2011 4 commits
-
-
Evan Shaw authored
R=brainman, rsc1, rsc CC=golang-dev https://golang.org/cl/4375046
-
Andrew Gerrand authored
R=bradfitz, dsymonds CC=golang-dev https://golang.org/cl/4432085
-
Brad Fitzpatrick authored
The previous change to make multipart use ReadSlice out of paranoia broke multipart to not deal with large lines in the bodies. We should only be paranoid about long lines in the header sections. Fixes http://code.google.com/p/camlistore/issues/detail?id=4 R=adg CC=golang-dev https://golang.org/cl/4432083
-
Brad Fitzpatrick authored
R=adg CC=golang-dev https://golang.org/cl/4433094
-
- 29 Apr, 2011 7 commits
-
-
Robert Griesemer authored
R=rsc CC=golang-dev https://golang.org/cl/4439082
-
Robert Griesemer authored
The CL introduces inconsistencies with respect to the use of parentheses/grouping of receive operations. ««« original CL description spec: narrow syntax for expression and select statements This is not a language change, it simply expresses the accepted cases explicitly in the respective productions. R=rsc, r, iant CC=golang-dev https://golang.org/cl/4428057 »»» R=golang-dev, rsc1 CC=golang-dev https://golang.org/cl/4444080
-
Brad Fitzpatrick authored
No code changes in this CL. R=r CC=golang-dev https://golang.org/cl/4445074
-
Ian Lance Taylor authored
Used by gccgo. R=bradfitz CC=golang-dev https://golang.org/cl/4435080
-
Robert Griesemer authored
This is not a language change, it simply expresses the accepted cases explicitly in the respective productions. R=rsc, r, iant CC=golang-dev https://golang.org/cl/4428057
-
Evan Shaw authored
R=bradfitz CC=golang-dev https://golang.org/cl/4433087
-
Robert Griesemer authored
R=r, dfc, bradfitzwork, bradfitz CC=golang-dev https://golang.org/cl/4441078
-
- 28 Apr, 2011 18 commits
-
-
Brad Fitzpatrick authored
R=agl, eds, rsc1, rsc CC=golang-dev https://golang.org/cl/4432079
-
Evan Shaw authored
R=rsc, bradfitz CC=golang-dev https://golang.org/cl/4452056
-
Ross Light authored
R=bradfitz, agl1, rsc CC=golang-dev https://golang.org/cl/4435055
-
Russ Cox authored
Fixes #1749. R=bradfitz CC=golang-dev https://golang.org/cl/4431075
-
Brad Fitzpatrick authored
R=rsc, r2 CC=golang-dev https://golang.org/cl/4442100
-
Gustavo Niemeyer authored
Also remove some left over copy & paste in the test of reflect.Copy for arrays. R=golang-dev, rsc1 CC=golang-dev https://golang.org/cl/4431074
-
Russ Cox authored
Fixes #1722. R=ken2 CC=golang-dev https://golang.org/cl/4442099
-
Evan Shaw authored
R=golang-dev, bradfitz, dsymonds CC=golang-dev https://golang.org/cl/4426069
-
Andrew Gerrand authored
R=golang-dev CC=golang-dev https://golang.org/cl/4439081
-
Andrew Gerrand authored
R=rsc CC=golang-dev https://golang.org/cl/4437077
-
Andrew Gerrand authored
R=rsc, bradfitz CC=golang-dev https://golang.org/cl/4431068
-
Brad Fitzpatrick authored
before & after: adler32.BenchmarkGolden 100000 14747 ns/op adler32.BenchmarkGolden 200000 8761 ns/op Found by profiling PNG encoding. R=rsc, bradfitzwork, eds CC=golang-dev https://golang.org/cl/4441073
-
Russ Cox authored
This time for sure. R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4437078
-
Lorenzo Stoakes authored
Previously, whether declaring a type which copied the structure of a type it was referenced in via a pointer field would work depended on whether you declared it before or after the type it copied, e.g. type T2 T1; type T1 struct { F *T2 } would work, however type T1 struct { F *T2 }; type T2 T1 wouldn't. Fixes #667. R=rsc CC=golang-dev https://golang.org/cl/4313064
-
Russ Cox authored
The g->sched.sp saved stack pointer and the g->stackbase and g->stackguard stack bounds can change even while "the world is stopped", because a goroutine has to call functions (and therefore might split its stack) when exiting a system call to check whether the world is stopped (and if so, wait until the world continues). That means the garbage collector cannot access those values safely (without a race) for goroutines executing system calls. Instead, save a consistent triple in g->gcsp, g->gcstack, g->gcguard during entersyscall and have the garbage collector refer to those. The old code was occasionally seeing (because of the race) an sp and stk that did not correspond to each other, so that stk - sp was not the number of stack bytes following sp. In that case, if sp < stk then the call scanblock(sp, stk - sp) scanned too many bytes (anything between the two pointers, which pointed into different allocation blocks). If sp > stk then stk - sp wrapped around. On 32-bit, stk - sp is a uintptr (uint32) converted to int64 in the call to scanblock, so a large (~4G) but positive number. Scanblock would try to scan that many bytes and eventually fault accessing unmapped memory. On 64-bit, stk - sp is a uintptr (uint64) promoted to int64 in the call to scanblock, so a negative number. Scanblock would not scan anything, possibly causing in-use blocks to be freed. In short, 32-bit platforms would have seen either ineffective garbage collection or crashes during garbage collection, while 64-bit platforms would have seen either ineffective or incorrect garbage collection. You can see the invalid arguments to scanblock in the stack traces in issue 1620. Fixes #1620. Fixes #1746. R=iant, r CC=golang-dev https://golang.org/cl/4437075
-
Russ Cox authored
Fixes #1397. R=iant CC=golang-dev https://golang.org/cl/4444064
-
Russ Cox authored
runtime: memory allocated by OS not in usable range runtime: out of memory: cannot allocate 1114112-byte block (2138832896 in use) throw: out of memory runtime.throw+0x40 /Users/rsc/g/go/src/pkg/runtime/runtime.c:102 runtime.throw(0x1fffd, 0x101) runtime.mallocgc+0x2af /Users/rsc/g/go/src/pkg/runtime/malloc.c:60 runtime.mallocgc(0x100004, 0x0, 0x1, 0x1, 0xc093, ...) runtime.mal+0x40 /Users/rsc/g/go/src/pkg/runtime/malloc.c:289 runtime.mal(0x100004, 0x20bc4) runtime.new+0x26 /Users/rsc/g/go/src/pkg/runtime/malloc.c:296 runtime.new(0x100004, 0x8fe84000, 0x20bc4) main.main+0x29 /Users/rsc/x.go:11 main.main() runtime.mainstart+0xf /Users/rsc/g/go/src/pkg/runtime/386/asm.s:93 runtime.mainstart() runtime.goexit /Users/rsc/g/go/src/pkg/runtime/proc.c:178 runtime.goexit() ----- goroutine created by ----- _rt0_386+0xbf /Users/rsc/g/go/src/pkg/runtime/386/asm.s:80 R=iant, r CC=golang-dev https://golang.org/cl/4444073
-
Andrew Gerrand authored
R=brad_danga_com, rsc, dfc, r, dchest, bradfitz CC=golang-dev https://golang.org/cl/4439075
-
- 27 Apr, 2011 9 commits
-
-
Brad Fitzpatrick authored
This one didn't come up in previous greps. R=adg CC=golang-dev https://golang.org/cl/4430071
-
Brad Fitzpatrick authored
This also removes an unnecessary allocation in http/transfer.go R=r, rsc1, r2, adg CC=golang-dev https://golang.org/cl/4426066
-
Brad Fitzpatrick authored
R=rsc CC=golang-dev https://golang.org/cl/4432076
-
Brad Fitzpatrick authored
Fixes #1725 R=rsc CC=golang-dev https://golang.org/cl/4442086
-
Gustavo Niemeyer authored
R=golang-dev, rsc1 CC=golang-dev https://golang.org/cl/4438077
-
Brad Fitzpatrick authored
Add local URI path support, which isn't as fringe as I originally thought. (it's supported by Apache) Send an implicit 302 status on redirects (not 200). Fixes #1597 R=rsc, r CC=golang-dev https://golang.org/cl/4442089
-
Peter Mundy authored
In a GOROOT path a backslash is a path separator not an escape character. For example, `C:\go`. Fixes gotest error: version.go:3: unknown escape sequence: g R=rsc CC=golang-dev https://golang.org/cl/4437076
-
Evan Shaw authored
R=golang-dev, bradfitzgo, bradfitzwork, nigeltao, rog CC=golang-dev https://golang.org/cl/4271078
-
Rob Pike authored
Fixes #1742. I hope. Also this picks up an update to go_tutorial.html that should already have happened. R=brainman, rsc, peterGo CC=golang-dev https://golang.org/cl/4452050
-