Commits · 4435c8bf2a7d4fcc33fd15903487958590a157f9 · go / golang

10 Jan, 2012 23 commits

exp/sql: close Rows on EOF · 4435c8bf
Brad Fitzpatrick authored Jan 10, 2012
```
Fixes #2624

R=rsc
CC=golang-dev
https://golang.org/cl/5530068
```
4435c8bf
gc: test that asserts closures are not wrapped when they don't have closure vars. · 25cf9bde
Luuk van Dijk authored Jan 10, 2012
```
R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5529060
```
25cf9bde

Luuk van Dijk authored Jan 10, 2012

flag -l means: inlining on, -ll inline with early typecheck
-l lazily typechecks imports on use and re-export, nicer for debugging
-lm produces output suitable for errchk tests, repeated -mm... increases inl.c's verbosity
export processed constants, instead of originals
outparams get ->inlvar too, and initialized to zero
fix shared rlist bug, that lead to typecheck messing up the patched tree
properly handle non-method calls to methods T.meth(t, a...)
removed embryonic code to handle closures in inlined bodies
also inline calls inside closures (todo: move from phase 6b to 4)

Fixes #2579.

R=rsc
CC=golang-dev
https://golang.org/cl/5489106

97fd7d5f

runtime: distinct panic message for call of nil func value · 5032a7dc
Russ Cox authored Jan 10, 2012
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5531062
```
5032a7dc
A+C: add Shenghou Ma (Individual CLA) · 57f15a3d
Brad Fitzpatrick authored Jan 10, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5528065
```
57f15a3d

runtime: regenerate defs_darwin_{386,amd64}.h · bc1f4c18

Dave Cheney authored Jan 10, 2012

Regenerated under Lion 10.7.2 amd64.
Also tested on Snow Leopart 10.6.8 386.

R=golang-dev, dsymonds, minux.ma
CC=golang-dev
https://golang.org/cl/5533058

bc1f4c18

go: fix typo in comment · 800c4982
Maxim Pimenov authored Jan 10, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5531060
```
800c4982

gc: Nicer errors before miscompiling. · a6c49098

Luuk van Dijk authored Jan 10, 2012

This fixes issue 2444.

A big cleanup of all 31/32bit size boundaries i'll leave for another cl though.  (see also issue 1700).

R=rsc
CC=golang-dev
https://golang.org/cl/5484058

a6c49098

gc: disallow declaration of variables outside package. · 4bcc9c6b

Luuk van Dijk authored Jan 10, 2012

Fixes #2231.

Declaring main.i in package main in the same way already triggers syntax errors.

R=rsc
CC=golang-dev
https://golang.org/cl/5483078

4bcc9c6b

gc: fix stray %#N in error message · 556258e5
Luuk van Dijk authored Jan 10, 2012
```
Fixes #2639.

R=rsc
CC=bradfitz, golang-dev
https://golang.org/cl/5489140
```
556258e5

gc: omit runtime.closure wrap for closures without closure variables · ba25778f

Luuk van Dijk authored Jan 10, 2012

Fixes #1894.

test/closure.go's test for newfunc already covers this.

R=rsc, dsymonds, bradfitz
CC=golang-dev
https://golang.org/cl/5516051

ba25778f

undo CL 5530063 / 1d7295fdf62e · ad3e82e7

Mikio Hara authored Jan 10, 2012

runtime: enable runtime.ncpu on FreeBSD

««« original CL description
cmd/go: fix freebsd build

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5530063
»»»

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5531059

ad3e82e7

runtime: enable runtime.ncpu on FreeBSD · 12bf0005
Devon H. O'Dell authored Jan 10, 2012
```
R=adg, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5528062
```
12bf0005
cmd/go: fix freebsd build · 8cad9251
Mikio Hara authored Jan 10, 2012
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5530063
```
8cad9251

cmd/go: add -p flag for parallelism (like make -j) · 8d8829c6

Russ Cox authored Jan 10, 2012

On my MacBookAir4,1:

19.94r 	 go install -a -p 1 std
12.36r 	 go install -a -p 2 std
9.76r 	 go install -a -p 3 std
10.77r 	 go install -a -p 4 std

86.57r 	 go test -p 1 std -short
52.69r 	 go test -p 2 std -short
43.75r 	 go test -p 3 std -short
40.44r 	 go test -p 4 std -short

157.50r 	 go test -p 1 std
99.58r 	 go test -p 2 std
87.24r 	 go test -p 3 std
80.18r 	 go test -p 4 std

R=golang-dev, adg, r
CC=golang-dev
https://golang.org/cl/5531057

8d8829c6

runtime: add NumCPU · 6dfdd4c1

Russ Cox authored Jan 10, 2012

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5528061

6dfdd4c1

strconv: return ErrSyntax when unquoting illegal octal sequences. This · cbf4f4b8

Sameer Ajmani authored Jan 10, 2012

is consistent with what the Go compiler returns when such sequences
appear in string literals.

Fixes #2658.

R=golang-dev, rsc, r, r, nigeltao
CC=golang-dev
https://golang.org/cl/5530051

cbf4f4b8

spec: pointer comparison for pointers to 0-sized variables · 1320ce00

Robert Griesemer authored Jan 10, 2012

- define "0-sized"
- add clarifying sentence to pointer comparison
- removed notion "location" which was used only in pointer comparisons
  and which was never defined

Fixes #2620.

R=r, rsc, iant
CC=golang-dev
https://golang.org/cl/5528053

1320ce00

syscall: make Environ return original order · 024952fb
Brad Fitzpatrick authored Jan 10, 2012
```
Fixes #2619

R=r, rsc
CC=golang-dev
https://golang.org/cl/5528058
```
024952fb

cmd/go: add -v flag to build and install · 146a703c

Russ Cox authored Jan 10, 2012

The -v flag prints the names of packages as they are built/installed.

Use -v in make.bash/run.bash to avoid a silent pause during
the build while Go code is being compiled.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5532055

146a703c

go: add ... patterns in import path arguments · b8615a09
Russ Cox authored Jan 10, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5530058
```
b8615a09

go/doc: first steps towards cleaning up go/doc · 22dfc77c

Robert Griesemer authored Jan 10, 2012

- separated exported data structures from doc reader
  by extracting all exported data structures into doc.go
  and moving the implementation into reader.go
- added missing documentation comments
- no API or semantic changes (but moved positions of
  PackageDoc.Doc and TypeDoc.Decl field up for consistency)
- runs all tests

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5527063

22dfc77c

html: foreign element HTML integration points, tag name adjustment, · 748fab9d

Nigel Tao authored Jan 10, 2012

shorten the MathML namespace abbreviation from "mathml" to "math".
Python's html5lib uses "mathml", but I think that that is an internal
implementation detail; the test cases use "math".

Pass tests10.dat, test 30:
<div><svg><path><foreignObject><math></div>a

| <html>
|   <head>
|   <body>
|     <div>
|       <svg svg>
|         <svg path>
|           <svg foreignObject>
|             <math math>
|               "a"

R=andybalholm
CC=golang-dev
https://golang.org/cl/5529044

748fab9d

09 Jan, 2012 17 commits

cmd/go: fix import directory list for compilation · 0ad241dd

Russ Cox authored Jan 09, 2012

This fixes the most annoying bug in the go command,
that 'go build' sometimes ignored packages it had just
rebuilt in favor of stale installed ones.

This part of the code needs more thought, but this small
change is an important improvement.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5531053

0ad241dd

syscall: ignore godefs input when building on Plan 9 · 1421b4ce
Anthony Martin authored Jan 09, 2012
```
R=golang-dev, akumar, rsc
CC=golang-dev
https://golang.org/cl/5534055
```
1421b4ce

os: add ModeCharDevice · cc02ef02

Russ Cox authored Jan 09, 2012

This should make conversion from Unix mode
to os.FileMode and back not lossy.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5531052

cc02ef02

crypto/openpgp: truncate hashes before checking DSA signatures. · f9427364

Adam Langley authored Jan 09, 2012

I didn't believe that OpenPGP allowed > SHA-1 with DSA, but it does and
so we need to perform hash truncation.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5510044

f9427364

text/template: handle panic values that are not errors. · f5d024a7

Rémy Oudompheng authored Jan 09, 2012

The recover code assumes that the panic() argument was
an error, but it is usually a simple string.
Fixes #2663.

R=golang-dev, r, r, gri
CC=golang-dev, remy
https://golang.org/cl/5527046

f5d024a7

encoding/gob: fix panic when decoding []byte to incompatible slice types · 793768e9
Alexey Borzenkov authored Jan 09, 2012
```
Fixes #2662.

R=golang-dev, rogpeppe, r, r
CC=golang-dev, r, rogpeppe
https://golang.org/cl/5515050
```
793768e9
gc: remove now redundant typecheck of ->ninit on switches. · 41806ec2
Luuk van Dijk authored Jan 09, 2012
```
Fixes #2576.

R=rsc
CC=golang-dev
https://golang.org/cl/5498105
```
41806ec2
cgo: if value for constant did not parse, get it from DWARF info · 900b8bec
Ian Lance Taylor authored Jan 09, 2012
```
R=rsc, borman
CC=golang-dev
https://golang.org/cl/5525043
```
900b8bec

math/big: simplify fast string conversion · b4be65bc

Robert Griesemer authored Jan 09, 2012

- use slice ops for convertWords instead of lo/hi boundaries
- always compute leading zeroes (simplifies logic significantly),
  but remove them once, at the end (since leafSize is small, the
  worst-case scenario is not adding significant overhead)
- various comment cleanups (specifically, replaced direct -> iterative,
  and indirect -> recursive)
- slightly faster overall for -bench=String

(This CL incorporates the changes re: my comments to CL 5418047
https://golang.org/cl/5418047/ )

benchmark                          old ns/op    new ns/op    delta
big.BenchmarkString10Base2               519          527   +1.54%
big.BenchmarkString100Base2             2279         2158   -5.31%
big.BenchmarkString1000Base2           18475        17323   -6.24%
big.BenchmarkString10000Base2         178248       166219   -6.75%
big.BenchmarkString100000Base2       1548494      1431587   -7.55%
big.BenchmarkString10Base8               415          422   +1.69%
big.BenchmarkString100Base8             1025          978   -4.59%
big.BenchmarkString1000Base8            6822         6428   -5.78%
big.BenchmarkString10000Base8          64598        61065   -5.47%
big.BenchmarkString100000Base8        593788       549150   -7.52%
big.BenchmarkString10Base10              654          645   -1.38%
big.BenchmarkString100Base10            1863         1835   -1.50%
big.BenchmarkString1000Base10          12099        11981   -0.98%
big.BenchmarkString10000Base10         57601        56888   -1.24%
big.BenchmarkString100000Base10     20123120     19827890   -1.47%
big.BenchmarkString10Base16              358          362   +1.12%
big.BenchmarkString100Base16             815          776   -4.79%
big.BenchmarkString1000Base16           4710         4421   -6.14%
big.BenchmarkString10000Base16         43938        40968   -6.76%
big.BenchmarkString100000Base16       406307       373930   -7.97%

R=michael.jones, mtj
CC=golang-dev
https://golang.org/cl/5432090

b4be65bc

doc: use 2012 for year in model standard copyright header · 834830d2
Peter Mundy authored Jan 09, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5531048
```
834830d2

go-mode.el: fix syntax highlighting of backticks · 70ed0ac5

Florian Weimer authored Jan 09, 2012

Instead of syntax-tables, an extended go-mode-cs is used for
from a font-lock callback.

Cache invalidation must happen in a before-change-function
because font-lock runs in an after-change-function, potentially
before the cache invalidation takes place.

Performance is reasonable, even with src/pkg/html/entity.go
and test/fixedbugs/bug257.go.

Fixes #2330.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5529045

70ed0ac5

undo CL 5504108 / 0edee03791f4 · 8a4bd094

Russ Cox authored Jan 09, 2012

breaks 386 build

««« original CL description
gc: put limit on size of exported recursive interface

Prevents edge-case recursive types from consuming excessive memory.

Fixes #1909.

R=golang-dev, lvd, rsc
CC=golang-dev
https://golang.org/cl/5504108

»»»

R=lvd, lvd
CC=golang-dev
https://golang.org/cl/5534049

8a4bd094

gc: put limit on size of exported recursive interface · aa63a928

Lorenzo Stoakes authored Jan 09, 2012

Prevents edge-case recursive types from consuming excessive memory.

Fixes #1909.

R=golang-dev, lvd, rsc
CC=golang-dev
https://golang.org/cl/5504108

aa63a928

syscall: Linux-only support for parent death signal · 2cb6fcf6

Albert Strasheim authored Jan 09, 2012

As discussed in this thread:

https://groups.google.com/group/golang-dev/browse_thread/thread/5b76b7700265a787

I've tried to come up with a solution that is minimally invasive for the platforms that don't support "parent death signal", without splitting up exec_unix.go.

See also: http://www.win.tue.nl/~aeb/linux/lk/lk-5.html#ss5.8

R=rsc, dave, borman, iant, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5487061

2cb6fcf6

doc: only trim newlines in tmpltohtml, gofmt progs · 468e692e
Andrew Gerrand authored Jan 09, 2012
```
R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5530048
```
468e692e
go/build: handle and warn of duplicate GOPATH entries · c7e91724
Andrew Gerrand authored Jan 09, 2012
```
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/5519050
```
c7e91724
doc: float -> float64 in Effective Go template · 7478bb98
Andrew Gerrand authored Jan 09, 2012
```
R=r, dsymonds
CC=golang-dev
https://golang.org/cl/5530047
```
7478bb98