Commits · 4c113ffe162236d44106a1c44ab8bfb623c1c795 · go / golang

27 Nov, 2011 3 commits

math/big: use recursive subdivision for significant speedup · 4c113ffe

Michael T. Jones authored Nov 27, 2011

This change adds the second aspect to the conversion code, the
use of large divisiors (powers of big base) to greatly speed up
the divsion of large numbers. Speedups of 30x are common in the
large cases. Also includes new tests and tuning code for the
key internal parameters.

R=gri
CC=golang-dev
https://golang.org/cl/5438058

4c113ffe

exp/ssh: messages now contain remote channel's id instead of local id · d859d7de

Gustav Paul authored Nov 27, 2011

According to http://www.ietf.org/rfc/rfc4254.txt most channel messages contain the channel id of the recipient channel, not the sender id. This allows the recipient connection multiplexer to route the message to the correct channel.

This changeset fixes several messages that incorrectly send the local channel id instead of the remote channel's id.

While sessions were being created and closed in sequence channels in the channel pool were freed and reused on the server side of the connection at the same rate as was done on the client, so the channel local and remote channel ids always corresponded. As soon as I had concurrent sessions on the same clientConn the server started to complain of 'uknown channel id N' where N is the local channel id, which is actually paired with server channel id K.

R=golang-dev, dave, rsc, agl
CC=golang-dev
https://golang.org/cl/5433063

d859d7de

html: ignore <head> tags in <head> element · 557ba72e

Andrew Balholm authored Nov 27, 2011

Pass tests3.dat, test 12:
<!DOCTYPE html><HTML><META><HEAD></HEAD></HTML>

| <!DOCTYPE html>
| <html>
|   <head>
|     <meta>
|   <body>

Also pass tests through test 19:
<!DOCTYPE html><html><head></head><body><ul><li><div><p><li></ul></body></html>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5436069

557ba72e

26 Nov, 2011 2 commits

text/template: rename the method Template.Template to Template.Lookup · e9025df7

Rob Pike authored Nov 26, 2011

Calling it Template makes it clumsy to embed the type, which html/template
depends on.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5432079

e9025df7

os: fail if Open("") is called on windows · e38a1053
Alex Brainman authored Nov 26, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5432071
```
e38a1053

25 Nov, 2011 6 commits

exp/sql/driver: Correct package name in comment. · 5519b5d7

Benny Siegert authored Nov 25, 2011

IIRC, package sql used to be called db. There was one occurrence
of the old name in a comment.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5431075

5519b5d7

C+A: add Gustav Paul (individual CLA) · 1f83c2b6
Brad Fitzpatrick authored Nov 25, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5432076
```
1f83c2b6

time: fix timer stop · a899a467

Dmitriy Vyukov authored Nov 25, 2011

Due to data structure corruption,
some timers could not be removed.
Fixes #2495.

R=golang-dev, adg
CC=golang-dev, mdbrown
https://golang.org/cl/5437060

a899a467

html/template: fix documentation indent · 38c082f6
Andrew Gerrand authored Nov 25, 2011
```
R=nigeltao
CC=golang-dev
https://golang.org/cl/5437061
```
38c082f6
dashboard: builder-facing implementation and tests · 49dfaad8
Andrew Gerrand authored Nov 25, 2011
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5431048
```
49dfaad8

text/template: fix bug in Clone · 0197cc49

Rob Pike authored Nov 25, 2011

Cloned template copied the root template incorrectly.
Add test of self-consistency.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5436063

0197cc49

24 Nov, 2011 6 commits

effective_go: remove unused variable from a couple of examples · d1324d8a
Rob Pike authored Nov 24, 2011
```
Fixes #2481.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5435068
```
d1324d8a
strings: Add ContainsAny and ContainsRune to correspond to IndexAny etc. · 0f0c25dc
Scott Lawrence authored Nov 24, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5430046
```
0f0c25dc
gofix: trivial rewrite for template.ParseFiles · da621041
Rob Pike authored Nov 24, 2011
```
Also warn about uses of Set.

R=rsc
CC=golang-dev
https://golang.org/cl/5436051
```
da621041

text/template: new, simpler API · f56db6f5

Rob Pike authored Nov 24, 2011

The Set type is gone. Instead, templates are automatically associated by
being parsed together; nested definitions implicitly create associations.
Only associated templates can invoke one another.

This approach dramatically reduces the breadth of the construction API.

For now, html/template is deleted from src/pkg/Makefile, so this can
be checked in. Nothing in the tree depends on it. It will be updated next.

R=dsymonds, adg, rsc, r, gri, mikesamuel, nigeltao
CC=golang-dev
https://golang.org/cl/5415060

f56db6f5

html: ingore newline at the start of a <pre> block · af081cd4

Andrew Balholm authored Nov 24, 2011

Pass tests3.dat, test 4:
<!DOCTYPE html><html><head></head><body><pre>\n</pre></body></html>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <pre>

Also pass tests through test 11:
<!DOCTYPE html><pre>&#x0a;&#x0a;A</pre>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5437051

af081cd4

go/ast: trivial cleanup (remove superfluous string conversion) · 63e48ccd
Robert Griesemer authored Nov 24, 2011
```
R=iant, bradfitz
CC=golang-dev
https://golang.org/cl/5430059
```
63e48ccd

23 Nov, 2011 6 commits

html: parse DOCTYPE into name and public and system identifiers · 77b0ad1e

Andrew Balholm authored Nov 23, 2011

Pass tests2.dat, test 59:
<!DOCTYPE <!DOCTYPE HTML>><!--<!--x-->-->

| <!DOCTYPE <!doctype>
| <html>
|   <head>
|   <body>
|     ">"
|     <!-- <!--x -->
|     "-->"

Pass all the tests in doctype01.dat.

Also pass tests2.dat, test 60:
<!doctype html><div><form></form><div></div></div>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5437045

77b0ad1e

go/printer, gofmt: more performance tweaks · b3923a27

Robert Griesemer authored Nov 23, 2011

Removed more string conversions and streamlined bottleneck
printing interface by removing unnecessary tests where possible.
About 6% faster AST printing.

Before:
- printer.BenchmarkPrint		50	32056640 ns/op

After:
- printer.BenchmarkPrint		50	30138440 ns/op (-6%)

R=r
CC=golang-dev
https://golang.org/cl/5431047

b3923a27

fmt: don't check for nil when printing arrays as Go syntax. · 8362ee99

Rémy Oudompheng authored Nov 23, 2011

Also add array values to printing test suite.
Fixes #2468.

R=golang-dev, r
CC=golang-dev, remy
https://golang.org/cl/5436053

8362ee99

crypto/openpgp/packet: fix private key checksum · 8281f6bd

Adam Langley authored Nov 23, 2011

I misinterpreted http://tools.ietf.org/html/rfc4880#section-5.5.3
and implemented the sum of 16-bit values, rather than the 16-bit sum
of 8-bit values.

Thanks to Szabolcs Nagy for pointing it out.

R=bradfitz, r, rsc
CC=golang-dev
https://golang.org/cl/5372091

8281f6bd

exp/ssh: add simple tcpip.go functional tests · f2c85874
Dave Cheney authored Nov 23, 2011
```
R=rsc, agl, n13m3y3r, bradfitz
CC=golang-dev
https://golang.org/cl/5385041
```
f2c85874
exp/ssh: remove unused forwarding methods in Server Listener · d5514120
Dave Cheney authored Nov 23, 2011
```
R=agl, rsc
CC=golang-dev
https://golang.org/cl/5436056
```
d5514120

22 Nov, 2011 10 commits

go/printer: remove "written" result value - is never used · 4874d141
Robert Griesemer authored Nov 22, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/5436052
```
4874d141

go/printer, gofmt: 20 to 30% faster gofmt · a0e54aaf

Robert Griesemer authored Nov 22, 2011

Buffer intermediate output via a bytes.Buffer and thus avoid
calling through the entire Writer stack for every item printed.
There is more opportunity for improvements along the same lines.

Before (best of 3 runs):
- printer.BenchmarkPrint	      50	  47959760 ns/op
- time gofmt -l $GOROOT/src	      real	  0m11.517s

After (best of 3 runs):
- printer.BenchmarkPrint	      50	  32056640 ns/op (= -33%)
- time gofmt -l $GOROOT/src	      real	  0m9.070s       (= -21%)

R=r
CC=golang-dev
https://golang.org/cl/5432054

a0e54aaf

html: on EOF in a comment, ignore final dashes (up to 2) · 57ed39fd

Andrew Balholm authored Nov 22, 2011

Pass tests2.dat, test 57:
<!DOCTYPE html><!--x--

| <!DOCTYPE html>
| <!-- x -->
| <html>
|   <head>
|   <body>

Also pass test 58:
<!DOCTYPE html><table><tr><td></p></table>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5436048

57ed39fd

dashboard: new Go dashboard data structure design · 79bce499
Andrew Gerrand authored Nov 22, 2011
```
R=rsc, r, dsymonds, bradfitz
CC=golang-dev
https://golang.org/cl/5416056
```
79bce499

tutorial: update go_tutorial.html · 422e2473

Rob Pike authored Nov 22, 2011

There's version skew with respect to the programs in doc/progs.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5433048

422e2473

encoding/xml: fix copy bug · fe838c2d

Russ Cox authored Nov 22, 2011

Fixes #2484.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5417059

fe838c2d

allow direct conversion between string and named []byte, []rune · 6e3e3809

Russ Cox authored Nov 22, 2011

The allowed conversions before and after are:
        type Tstring string
        type Tbyte []byte
        type Trune []rune

        string <-> string  // ok
        string <-> []byte  // ok
        string <-> []rune // ok
        string <-> Tstring // ok
        string <-> Tbyte // was illegal, now ok
        string <-> Trune // was illegal, now ok

        Tstring <-> string  // ok
        Tstring <-> []byte  // ok
        Tstring <-> []rune // ok
        Tstring <-> Tstring // ok
        Tstring <-> Tbyte // was illegal, now ok
        Tstring <-> Trune // was illegal, now ok

Update spec, compiler, tests.  Use in a few packages.

We agreed on this a few months ago but never implemented it.

Fixes #1707.

R=golang-dev, gri, r
CC=golang-dev
https://golang.org/cl/5421057

6e3e3809

os: make ReadAt comment clearer · c69d6345

Russ Cox authored Nov 22, 2011

Fixes #2486.

R=golang-dev, hanwen
CC=golang-dev
https://golang.org/cl/5417064

c69d6345

cgo: add support for callbacks from dynamic libraries · 11e73b89
Dmitriy Vyukov authored Nov 22, 2011
```
R=golang-dev, rsc
CC=golang-dev, mpimenov
https://golang.org/cl/5375042
```
11e73b89

html: copy attributes from extra <html> tags to root element · 95e60acb

Andrew Balholm authored Nov 22, 2011

Pass tests2.dat, test 50:
<!DOCTYPE html><html><body><html id=x>

| <!DOCTYPE html>
| <html>
|   id="x"
|   <head>
|   <body>

Also pass tests through test 56:
<!DOCTYPE html>X<p/x/y/z>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5432045

95e60acb

21 Nov, 2011 7 commits

html: ignore whitespace before <head> element · 750de28d

Andrew Balholm authored Nov 21, 2011

Pass tests2.dat, test 47:
" \n "
(That is, two spaces separated by a newline)

| <html>
|   <head>
|   <body>

Also pass tests through test 49:
<!DOCTYPE html><script>
</script>  <title>x</title>  </head>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5422043

750de28d

goinstall: support googlecode subrepos and add repo match tests · 86c08e96

Andrew Gerrand authored Nov 21, 2011

goinstall: don't hit network unless a checkout or update is required

R=rsc, rogpeppe
CC=golang-dev
https://golang.org/cl/5343042

86c08e96

crypto/x509, crypto/tls: support PKCS#8 private keys. · 7c161b05

Adam Langley authored Nov 21, 2011

OpenSSL 1.0.0 has switched to generating PKCS#8 format private keys by
default. This change allows http.ListenAndServeTLS to work with either
types of keys.

See http://groups.google.com/group/golang-nuts/browse_thread/thread/84715b5f0c9e3c30/63a8a27b53e102a6

R=bradfitz
CC=golang-dev
https://golang.org/cl/5416059

7c161b05

bcrypt: Correct typo in package comment. · 85255f99
Benny Siegert authored Nov 21, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5415062
```
85255f99

json: speed up encoding, caching reflect calls · 6c9f4662

Brad Fitzpatrick authored Nov 21, 2011

Before
json.BenchmarkCodeEncoder  10  181232100 ns/op  10.71 MB/s
json.BenchmarkCodeMarshal  10  184578000 ns/op  10.51 MB/s

After:
json.BenchmarkCodeEncoder  10  146444000 ns/op  13.25 MB/s
json.BenchmarkCodeMarshal  10  151428500 ns/op  12.81 MB/s

R=rsc, r
CC=golang-dev
https://golang.org/cl/5416046

6c9f4662

math: faster Cbrt · f3aa54e3

Charles L. Dorian authored Nov 21, 2011

For amd64, from 127 to 105 ns/op; for 386, from 208 to 169 ns/op.

R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/5412056

f3aa54e3

syscall: fix for Plan 9 build · 8ec32e8d

Lucio De Re authored Nov 21, 2011

exec_plan9.go:
. Adjusted return argument to match other changes.
#mksyscall.pl:
. Replaced "err = e1" with "err = NewError(e1)".
* Change abandoned, Russ made a better suggestion involving
  syscall_plan9.go.
syscall_plan9.go:
. Removed redundant "err = nil" lines.
. Adjusted //sys lines for mksyscall.pl.
* Replaced "err string" with "err ErrorString" in return arguments.
zsyscall_plan9_386.go:
. This module ought to be generated, but as it exists in the
  repository, I rebuilt it and checked that it matched expectations.
  Anybody is welcome to remove this from the repository if
  they feel it should go, but remember that not all Plan 9
  installations have a working Perl.

R=rsc
CC=ality, golang-dev
https://golang.org/cl/5411046

8ec32e8d