Commits · 4de15a5cdaf94b9e2269fb79008c8c862f355d2a · go / golang

01 May, 2012 1 commit

compress/flate: optimize history-copy decoding. · 4de15a5c

Nigel Tao authored May 01, 2012

The forwardCopy function could be re-written in asm, and the copyHuff
method could probably be rolled into huffmanBlock and copyHist, but
I'm leaving those changes for future CLs.

compress/flate benchmarks:
benchmark                                 old ns/op    new ns/op    delta
BenchmarkDecoderBestSpeed1K                  385327       435140  +12.93%
BenchmarkDecoderBestSpeed10K                1245190      1062112  -14.70%
BenchmarkDecoderBestSpeed100K               8512365      5833680  -31.47%
BenchmarkDecoderDefaultCompression1K         382225       421301  +10.22%
BenchmarkDecoderDefaultCompression10K        867950       613890  -29.27%
BenchmarkDecoderDefaultCompression100K      5658240      2466726  -56.40%
BenchmarkDecoderBestCompression1K            383760       421634   +9.87%
BenchmarkDecoderBestCompression10K           867743       614671  -29.16%
BenchmarkDecoderBestCompression100K         5660160      2464996  -56.45%

image/png benchmarks:
benchmark                       old ns/op    new ns/op    delta
BenchmarkDecodeGray               2540834      2389624   -5.95%
BenchmarkDecodeNRGBAGradient     10052700      9534565   -5.15%
BenchmarkDecodeNRGBAOpaque        8704710      8163430   -6.22%
BenchmarkDecodePaletted           1458779      1325017   -9.17%
BenchmarkDecodeRGB                7183606      6794668   -5.41%

Wall time for Denis Cheremisov's PNG-decoding program given in
https://groups.google.com/group/golang-nuts/browse_thread/thread/22aa8a05040fdd49
Before: 3.07s
After:  2.32s
Delta:  -24%

Before profile:
Total: 304 samples
         159  52.3%  52.3%      251  82.6% compress/flate.(*decompressor).huffmanBlock
          58  19.1%  71.4%       76  25.0% compress/flate.(*decompressor).huffSym
          32  10.5%  81.9%       32  10.5% hash/adler32.update
          16   5.3%  87.2%       22   7.2% bufio.(*Reader).ReadByte
          16   5.3%  92.4%       37  12.2% compress/flate.(*decompressor).moreBits
           7   2.3%  94.7%        7   2.3% hash/crc32.update
           7   2.3%  97.0%        7   2.3% runtime.memmove
           5   1.6%  98.7%        5   1.6% scanblock
           2   0.7%  99.3%        9   3.0% runtime.copy
           1   0.3%  99.7%        1   0.3% compress/flate.(*huffmanDecoder).init

After profile:
Total: 230 samples
          59  25.7%  25.7%       70  30.4% compress/flate.(*decompressor).huffSym
          45  19.6%  45.2%       45  19.6% hash/adler32.update
          35  15.2%  60.4%       35  15.2% compress/flate.forwardCopy
          20   8.7%  69.1%      151  65.7% compress/flate.(*decompressor).huffmanBlock
          16   7.0%  76.1%       24  10.4% compress/flate.(*decompressor).moreBits
          15   6.5%  82.6%       15   6.5% runtime.memmove
          11   4.8%  87.4%       50  21.7% compress/flate.(*decompressor).copyHist
           7   3.0%  90.4%        7   3.0% hash/crc32.update
           6   2.6%  93.0%        9   3.9% bufio.(*Reader).ReadByte
           4   1.7%  94.8%        4   1.7% runtime.slicearray

R=rsc, rogpeppe, dave
CC=golang-dev, krasin
https://golang.org/cl/6127064

4de15a5c

30 Apr, 2012 7 commits
- cmd/go: do not ignore DepsErrors in 'go run' · 84ce0f76
  Robert Hencke authored Apr 30, 2012
```
Fixes #3490.

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6040046
```
  84ce0f76
- runtime: give proper messages when user defined DYLD_INSERT_LIBRARIES on Darwin · 44fd1d1a
  Shenghou Ma authored Apr 30, 2012
```
       also gives clear error when bsdthread_register fails on Darwin
       Fixes #2992.

R=rsc, krautz
CC=golang-dev
https://golang.org/cl/5966067
```
  44fd1d1a
- misc/dashboard/codereview: record Message-ID of code review thread mails. · 1bdb788b
  David Symonds authored Apr 30, 2012
```
This will allow us to properly thread "R=..." mails at a later time.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6135053
```
  1bdb788b
- misc/dashboard/codereview: add handy logout URL. · 5d331964
  David Symonds authored Apr 30, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6135052
```
  5d331964
- misc/dashboard/codereview: send mail to assigned reviewers if they aren't already looped in. · 4335ec9e
  David Symonds authored Apr 30, 2012
```
R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/6128054
```
  4335ec9e
- encoding/base64: don't ignore underlying souce read error in decode · ed90fbc7
  Brad Fitzpatrick authored Apr 30, 2012
```
Fixes #3577

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6137054
```
  ed90fbc7
- syscall: add a test for passing an fd over a unix socket · fe2ce528
  Brad Fitzpatrick authored Apr 30, 2012
```
Re-submitting previously reverted change 160ec5506cb7.

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/6129052
```
  fe2ce528
29 Apr, 2012 1 commit

compress/flate: add Encoder/Decoder benchmarks · d5b299ed

Dave Cheney authored Apr 29, 2012

In CL 6127051, nigeltao suggested that further gains
were possible by improving the performance of flate.
This CL adds a set of benchmarks (based on compress/lzw)
that can be used to judge any future improvements.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6128049

d5b299ed

27 Apr, 2012 10 commits

misc/dashboard/codereview: don't depend on map iteration order for unit calculation. · 24cce5c6
David Symonds authored Apr 27, 2012
```
Fix auth requirements for /gc endpoint too.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6133049
```
24cce5c6

os/exec: close all internal descriptors when Cmd.Start() fails. · a0f7c6c6

Brian Dellisanti authored Apr 27, 2012

This closes any internal descriptors (pipes, etc) that Cmd.Start() had
opened before it failed.

Fixes #3468.

R=golang-dev, iant, bradfitz
CC=golang-dev
https://golang.org/cl/5986044

a0f7c6c6

A+C: add Brian Dellisanti (individual CLA) · 6d1face5
Ian Lance Taylor authored Apr 27, 2012
```
R=golang-dev, bsiegert, r
CC=golang-dev
https://golang.org/cl/6127056
```
6d1face5
misc/dashboard/codereview: simplify parallel operations for front page, and capture timing info. · fe252584
David Symonds authored Apr 27, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6128044
```
fe252584

net: consolidate common socket functions · f72c828c

Dave Cheney authored Apr 27, 2012

In resolving 3507, the fix had to be applied individually to
the four *Conn types, tcp, udp, rawip and unix, due to the
duplicate code in each Conn type.

This CL consolidates the common net.Conn methods that all four
*Conn types implement into a base conn type.

Pros:
* The fix for 3507 would have only needed to be applied to one
method. Further improvements, such as possibly removing the
c.fd != nil check in c.ok(), would benefit from this CL.
* Nearly 300 lines removed from the net package.
* The public interface and documentation are not changed.
* I think this is an excellent example of the power of embedding.

Cons:
* The net package is already distributed over many files, this
CL adds another place to look.
* The fix for 3507 was a total of 16 lines changed, this follow
up CL could be considered to be an overreaction as new Conn types
are unlikely to be added in the near future.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6098047

f72c828c

misc/dashboard/codereview: more abbreviated modification duration. · 1a790537
David Symonds authored Apr 27, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6131044
```
1a790537

misc/dashboard/codereview: new app. · 0175e3f1

David Symonds authored Apr 27, 2012

This is live at http://gocodereview.appspot.com/.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6134043

0175e3f1

image/png: speed up PNG decoding for common color models: Gray, NRGBA, · dd294fbd

Nigel Tao authored Apr 27, 2012

Paletted, RGBA.

benchmark                       old ns/op    new ns/op    delta
BenchmarkDecodeGray               3681144      2536049  -31.11%
BenchmarkDecodeNRGBAGradient     12108660     10020650  -17.24%
BenchmarkDecodeNRGBAOpaque       10699230      8677165  -18.90%
BenchmarkDecodePaletted           2562806      1458798  -43.08%
BenchmarkDecodeRGB                8468175      7180730  -15.20%

benchmark                        old MB/s     new MB/s  speedup
BenchmarkDecodeGray                 17.80        25.84    1.45x
BenchmarkDecodeNRGBAGradient        21.65        26.16    1.21x
BenchmarkDecodeNRGBAOpaque          24.50        30.21    1.23x
BenchmarkDecodePaletted             25.57        44.92    1.76x
BenchmarkDecodeRGB                  30.96        36.51    1.18x

$ file $GOROOT/src/pkg/image/png/testdata/bench*
benchGray.png:           PNG image, 256 x 256, 8-bit grayscale, non-interlaced
benchNRGBA-gradient.png: PNG image, 256 x 256, 8-bit/color RGBA, non-interlaced
benchNRGBA-opaque.png:   PNG image, 256 x 256, 8-bit/color RGBA, non-interlaced
benchPaletted.png:       PNG image, 256 x 256, 8-bit colormap, non-interlaced
benchRGB.png:            PNG image, 256 x 256, 8-bit/color RGB, non-interlaced

R=r
CC=golang-dev
https://golang.org/cl/6127051

dd294fbd

old/regexp, old/template: delete. · 9ce770af

David Symonds authored Apr 27, 2012

Both of these have replacements.

R=golang-dev, r, rsc, r, adg
CC=golang-dev
https://golang.org/cl/5979046

9ce770af

path/filepath: fix typo · 0bad08cb
Anthony Martin authored Apr 27, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6117063
```
0bad08cb

26 Apr, 2012 13 commits

misc/dist: drop repetition in filenames, default to release tag · 029d62f5
Andrew Gerrand authored Apr 26, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6117066
```
029d62f5
re-tag go1.0.1 · d8443d2e
Andrew Gerrand authored Apr 26, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6115056
```
d8443d2e
tag go1.0.1 · 4d0bb13b
Andrew Gerrand authored Apr 26, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6125048
```
4d0bb13b
doc: go1.0.1 release notes · 314df522
Andrew Gerrand authored Apr 26, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6123055
```
314df522

cmd/go: new tag selection logic · d09943ae

Russ Cox authored Apr 26, 2012

The new logic is "use go1 if it's there, otherwise no tag."
Nothing needs to say "I require go1.0.1", and I want to
preserve some flexibility in defining what tags mean.

Right now (before go1.0.1) there is only one possible tag,
"go1", and I'd like to keep it that way.

R=golang-dev, bradfitz, r, adg
CC=golang-dev
https://golang.org/cl/6112060

d09943ae

syscall: remove sysctl workaround for openbsd · e5f2662c

Joel Sing authored Apr 26, 2012

Now that Go will no longer work on OpenBSD versions prior to 5.1,
remove the sysctl workaround that was needed for 5.0 and earlier.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6116050

e5f2662c

syscall: fix a number of exec bugs on Plan 9 · 54916234

Anthony Martin authored Apr 26, 2012

1. Readdirnames was erroneously returning an
   empty slice on every invocation.

2. The logic for determining which files to
   close before exec was incorrect.  If the
   set of files to be kept open (provided by
   the caller) did not include the files
   opened at startup, those files would be
   accidentally closed.

I also cleaned up readdupdevice while I was
in the vicinity.

R=golang-dev, seed, rsc
CC=golang-dev
https://golang.org/cl/6016044

54916234

gc: use correct line number for EOF syntax error · 42aa9aba

Anthony Martin authored Apr 26, 2012

I also added some debugging code that's turned
on with -xx.

Fixes #3392.

R=rsc, lvd
CC=golang-dev
https://golang.org/cl/5909058

42aa9aba

doc: update wiki article to use html/template properly. · 4d3db77c
David Symonds authored Apr 26, 2012
```
Fixes #3569.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6116055
```
4d3db77c
doc: simplify the image_draw article example for converting an image to · b28431ec
Nigel Tao authored Apr 26, 2012
```
RGBA.

R=adg, r, bsiegert
CC=golang-dev
https://golang.org/cl/6119054
```
b28431ec
cmd/godoc: update App Engine README and script for Go 1 · e4127614
Shenghou Ma authored Apr 26, 2012
```
R=adg, dsymonds
CC=golang-dev
https://golang.org/cl/5849053
```
e4127614

exp/html: adjust inTableBodyIM to match spec · a09e9811

Andrew Balholm authored Apr 26, 2012

Clean up flow of control.

Handle </tbody>, </tfoot>, and </thead>.

Pass 5 additional tests.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6117057

a09e9811

time: doc fix. · 555ca36c
David Symonds authored Apr 26, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6127050
```
555ca36c

25 Apr, 2012 8 commits

codereview: look for new release branches · d2e70054
Russ Cox authored Apr 25, 2012
```
R=adg
CC=golang-dev
https://golang.org/cl/6127048
```
d2e70054
dashboard: sort user interface by internal counter, not date · b6522c43
Andrew Gerrand authored Apr 25, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6114053
```
b6522c43
net/http: ignore paths on CONNECT requests in ServeMux · 61a8eb07
Brad Fitzpatrick authored Apr 25, 2012
```
Fixes #3538

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/6117058
```
61a8eb07
mime: make ParseMediaType return zero results on error · 7f7a70f2
Brad Fitzpatrick authored Apr 25, 2012
```
Fixes #3562

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/6119051
```
7f7a70f2

runtime: use __tfork() syscall on openbsd · 689d5b91

Joel Sing authored Apr 25, 2012

Switch from using the rfork() syscall on OpenBSD, to the __tfork()
syscall.  The __tfork() syscall is the preferred way of creating
system threads and the rfork() syscall has recently been removed.

Note: this will break compatibility with OpenBSD releases prior to 5.1.

R=golang-dev, bradfitz, devon.odell, rsc
CC=golang-dev
https://golang.org/cl/6037048

689d5b91

exp/locale/collate: Added Builder type for generating a complete · fdce27f7

Marcel van Lohuizen authored Apr 25, 2012

collation table. At this moment, it only implements the generation of
a root table.

R=r
CC=golang-dev
https://golang.org/cl/6039047

fdce27f7

exp/locale/collate: Added skeleton for the higher-level types to provide · 52f0afe0

Marcel van Lohuizen authored Apr 25, 2012

context for change lists of lower-level types. The public APIs are defined
in builder.go and collate.go. Type table is the glue between the lower and
higher level code and might be a good starting point for understanding the
collation code.

R=r, r
CC=golang-dev
https://golang.org/cl/5999053

52f0afe0

exp/locale/collate: added trie for associating colElems to runes. · bcf48c79

Marcel van Lohuizen authored Apr 25, 2012

The trie code looks a lot like the trie in exp/norm. It uses different
types, however.  Also, there is only a lookup for []byte and the unsafe
lookup methods have been dropped, as well as sparse mode.
There is now a method for generating a trie. To output Go code, one now needs
to first generate a trie and then call print() on it.

R=r, r, mpvl
CC=golang-dev
https://golang.org/cl/5966064

bcf48c79