Commits · 5166013f75a7dbab53482292f99c3b6c26cddd0b · go / golang

28 May, 2013 2 commits

runtime: inline MCache_Alloc() into mallocgc() · 5166013f

Dmitriy Vyukov authored May 28, 2013

benchmark                    old ns/op    new ns/op    delta
BenchmarkMalloc8                    68           62   -8.63%
BenchmarkMalloc16                   75           69   -7.94%
BenchmarkMallocTypeInfo8           102           98   -3.73%
BenchmarkMallocTypeInfo16          108          103   -4.63%

R=golang-dev, dave, khr
CC=golang-dev
https://golang.org/cl/9790043

5166013f

runtime: introduce helper persistentalloc() function · 47e0a3d7

Dmitriy Vyukov authored May 28, 2013

It is a caching wrapper around SysAlloc() that can allocate small chunks.
Use it for symtab allocations. Reduces number of symtab walks from 4 to 3
(reduces buildfuncs time from 10ms to 7.5ms on a large binary,
reduces initial heap size by 680K on the same binary).
Also can be used for type info allocation, itab allocation.
There are also several places in GC where we do the same thing,
they can be changed to use persistentalloc().
Also can be used in FixAlloc, because each instance of FixAlloc allocates
in 128K regions, which is too eager.

R=golang-dev, daniel.morsing, khr
CC=golang-dev
https://golang.org/cl/9805043

47e0a3d7

27 May, 2013 6 commits

runtime: fix runtime·netpoll() to call runtime·netpollready() only once per event. · 82ef961a
Bill Neubauer authored May 27, 2013
```
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/9808043
```
82ef961a

runtime: make arm signal handler call runtime.badsignal · ae73b903

Shenghou Ma authored May 27, 2013

In preparation for CL 9249043 (already submitted).

Fixes #5553.

R=golang-dev, iant, capnm9, dave
CC=golang-dev
https://golang.org/cl/9251043

ae73b903

runtime: introduce cnewarray() to simplify allocation of typed arrays · 5782f411
Dmitriy Vyukov authored May 27, 2013
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/9648044
```
5782f411

runtime: flag static variables as no-pointers · e017e0cb

Jan Ziak authored May 27, 2013

Variables in data sections of 32-bit executables interfere with
garbage collector's ability to free objects and/or unnecessarily
slow down the garbage collector.

This changeset moves some static variables to .noptr sections.
'files' in symtab.c is now allocated dynamically.

R=golang-dev, dvyukov, minux.ma
CC=golang-dev
https://golang.org/cl/9786044

e017e0cb

effective_go.html: Fix two links · 20c524c5

Brian G. Merrell authored May 27, 2013

This fixes two intra-page "type assertion" links that were broken in
different ways.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/9797043

20c524c5

A+C: Brian G. Merrell (individual CLA) · 1276e507
David Symonds authored May 27, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/9797044
```
1276e507

25 May, 2013 2 commits
- runtime: update comment on stack allocator · 46137f22
  Dmitriy Vyukov authored May 25, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/9665046
```
  46137f22
- cmd/cgo: do not output empty struct for -cdefs · a2ec8abd
  Alex Brainman authored May 25, 2013
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/9574043
```
  a2ec8abd
24 May, 2013 13 commits

fmt.Printf: introduce notation for random access to arguments. · 7472ce0e

Rob Pike authored May 24, 2013

This text is added to doc.go:

        Explicit argument indexes:

        In Printf, Sprintf, and Fprintf, the default behavior is for each
        formatting verb to format successive arguments passed in the call.
        However, the notation [n] immediately before the verb indicates that the
        nth one-indexed argument is to be formatted instead. The same notation
        before a '*' for a width or precision selects the argument index holding
        the value. After processing a bracketed expression [n], arguments n+1,
        n+2, etc. will be processed unless otherwise directed.

        For example,
                fmt.Sprintf("%[2]d %[1]d\n", 11, 22)
        will yield "22, 11", while
                fmt.Sprintf("%[3]*[2].*[1]f", 12.0, 2, 6),
        equivalent to
                fmt.Sprintf("%6.2f", 12.0),
        will yield " 12.00". Because an explicit index affects subsequent verbs,
        this notation can be used to print the same values multiple times
        by resetting the index for the first argument to be repeated:
                fmt.Sprintf("%d %d %#[1]x %#x", 16, 17)
        will yield "16 17 0x10 0x11".

The notation chosen differs from that in C, but I believe it's easier to read
and to remember (we're indexing the arguments), and compatibility with
C's printf was never a strong goal anyway.

While we're here, change the word "field" to "arg" or "argument" in the
code; it was being misused and was confusing.

R=rsc, bradfitz, rogpeppe, minux.ma, peter.armitage
CC=golang-dev
https://golang.org/cl/9680043

7472ce0e

build: fix make.rc on Plan 9 · ffe8a3c5

David du Colombier authored May 24, 2013

Set $status as null to prevent rc from exiting
on the last --no-banner argument checking when
used with rc -e. It allows all.rc to not exit
before executing run.rc

R=golang-dev, lucio.dere, rsc
CC=golang-dev
https://golang.org/cl/9611045

ffe8a3c5

doc: start go 1.2 notes · 30fde1b2

Russ Cox authored May 24, 2013

This is a file of hints, not a file of polished text.
Let's not try to do polished text until we start the
release process.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/9750043

30fde1b2

crypto/x509: harmonise error prefixes. · ddc86791

Adam Langley authored May 24, 2013

crypto/x509 has ended up with a variety of error formats. This change makes them all start with "x509: ".

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/9736043

ddc86791

cmd/cov: delete · 650a1ef6

Rob Pike authored May 24, 2013

It doesn't work, it's not portable, it's not part of the released
binaries, and a better tool is due.

Fixes #1319.
Fixes #4621.

R=golang-dev, bradfitz, dave, rsc
CC=golang-dev
https://golang.org/cl/9681044

650a1ef6

path/filepath: Skip TestEvalSymlinks. Plan 9 doesn't have symlinks. · ee78a707
Christopher Nielsen authored May 24, 2013
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/9713044
```
ee78a707

asn1: Stricter checks for DER encoded booleans · af48543c

Gerasimos Dimitriadis authored May 24, 2013

According to X.690, only 0 and 255 are allowed as values
for encoded booleans. Also added some test for parsing
booleans

R=golang-dev, agl, r
CC=golang-dev
https://golang.org/cl/9692043

af48543c

A+C: Gerasimos Dimitriadis (individual CLA) · 64e98171
Adam Langley authored May 24, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/9734043
```
64e98171

log/syslog: fix deadlock in test · 0806c972

Dmitriy Vyukov authored May 24, 2013

The problem was that server handlers block on done<-,
the goroutine that reads from done blocks on count<-,
and the main goroutine that is supposed to read from count
waits for server handlers to exit.
Fixes #5547.

R=golang-dev, dave, bradfitz
CC=golang-dev
https://golang.org/cl/9722043

0806c972

misc/cgo/testso: use bash to run test.bash · 2ca589d4
Dave Cheney authored May 24, 2013
```
R=golang-dev, minux.ma, capnm9
CC=golang-dev
https://golang.org/cl/9717043
```
2ca589d4
cmd/cgo: change GoStringN and GoBytes from intgo to int32 · 598de87b
Ian Lance Taylor authored May 24, 2013
```
Fixes build.

R=golang-dev
CC=golang-dev
https://golang.org/cl/9667047
```
598de87b
cmd/cgo: use intgo, not int, for string and slice structures · 8f7863d6
Ian Lance Taylor authored May 24, 2013
```
Fixes #5548.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/9643044
```
8f7863d6
test/bench/shootout/timing.log: update to Go 1.1 · 9bdb7e19
Rob Pike authored May 24, 2013
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/9656045
```
9bdb7e19

23 May, 2013 8 commits

runtime: faster range on empty map · 7b9df092

Frederick Kelly Mayle III authored May 23, 2013

benchmark                old ns/op    new ns/op    delta
BenchmarkMapIter               191          190   -0.52%
BenchmarkMapIterEmpty           22            4  -78.96%

R=golang-dev, minux.ma, dvyukov, iant, khr
CC=golang-dev
https://golang.org/cl/9637043

7b9df092

A+C: Frederick Kelly Mayle III (individual CLA) · c6b6c4ac
Brad Fitzpatrick authored May 23, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/9669044
```
c6b6c4ac
codereview: close the head tag · 3b7dcf07
Brad Fitzpatrick authored May 23, 2013
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/9695045
```
3b7dcf07

misc/emacs: Do not modify kill ring when programmatically deleting text · 4e15dbe0

Dominik Honnef authored May 23, 2013

Operations like gofmt and go-remove-unused-imports delete entire
lines of text. Previously this put them on the kill-ring,
negatively affecting user experience.

R=adonovan
CC=gobot, golang-dev
https://golang.org/cl/9605043

4e15dbe0

io: Prioritize WriterTos over ReaderFroms in Copy. · fdc4ce6e

Daniel Morsing authored May 23, 2013

This only affects calls where both ReaderFrom and WriterTo are implemented. WriterTo can issue one large write, while ReaderFrom must Read until EOF, potentially reallocating when out of memory. With one large Write, the Writer only needs to allocate once.

This also helps in ioutil.Discard since we can avoid copying memory when the Reader implements WriterTo.

R=golang-dev, dsymonds, remyoudompheng, bradfitz
CC=golang-dev, minux.ma
https://golang.org/cl/9462044

fdc4ce6e

crypto/rsa: implement PSS signatures. · 876455f3

Nan Deng authored May 23, 2013

This change contains an implementation of the RSASSA-PSS signature
algorithm described in RFC 3447.

R=agl, agl
CC=gobot, golang-dev, r
https://golang.org/cl/9438043

876455f3

syscall: add IPv6 socket options for Unix variants · adbe59e3

Mikio Hara authored May 23, 2013

This CL adds missing IPv6 socket options which are required
to control IPv6 as described in RFC 3493, RFC 3542.

Update #5538

R=golang-dev, dave, iant
CC=golang-dev
https://golang.org/cl/9373046

adbe59e3

cmd/go: check GOROOT directory is present before acting · d67e300f
Alex Brainman authored May 23, 2013
```
Fixes #5042.

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/7786047
```
d67e300f

22 May, 2013 9 commits

codereview.py: improve error message when user is not a committer · 4b2eb3f9
Francesc Campoy authored May 22, 2013
```
R=adg, bradfitz, r
CC=golang-dev
https://golang.org/cl/9626045
```
4b2eb3f9

go/doc: fix build · e3a72b05

Robert Griesemer authored May 22, 2013

1) go/doc:
   - create correct ast.FuncType
   - use more commonly used variable names in a test case

2) make ast.FuncType.Pos robust in case of incorrect ASTs

R=golang-dev
CC=golang-dev
https://golang.org/cl/9651044

e3a72b05

A+C: Nan Deng (individual CLA) · 8f37e419
Adam Langley authored May 22, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/9678043
```
8f37e419
test: add test for issue 3888. · 3577398f
Rémy Oudompheng authored May 22, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/9676043
```
3577398f

test/errchk: use "#!/usr/bin/env perl" shebang line · 1beb7919

Shenghou Ma authored May 22, 2013

fix test failure of go.tools sub-repo on NetBSD.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/9662044

1beb7919

bufio: fix SplitFunc docs · cb8782e8

Shenghou Ma authored May 22, 2013

Fixes #5532.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/9672044

cb8782e8

go/ast: fix FuncType.Pos() impl. and FuncType.Params documentation · 75b62e36
Robert Griesemer authored May 22, 2013
```
As pointed out by adonovan.

R=golang-dev, adonovan
CC=golang-dev
https://golang.org/cl/9662045
```
75b62e36

doc: GCC 4.8.1 is not updated to Go 1.1 · 452f3bc7

Ian Lance Taylor authored May 22, 2013

I will try again for 4.8.2.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/9663045

452f3bc7

log/syslog: report errors from write · e17a6d4b

Rob Pike authored May 22, 2013

Fixes #5541.
This time for sure.

R=golang-dev, minux.ma, iant
CC=golang-dev
https://golang.org/cl/9668043

e17a6d4b