Skip to content

G
golang
Switch branch/tag
  1. 07 Dec, 2010 28 commits
  3. 06 Dec, 2010 12 commits
    • Robert Griesemer's avatar
      godoc: don't call flush if position is not valid · 2fd2991e
      Robert Griesemer authored 
      (fixes new godoc crash when looking at spec)

R=rsc, r, iant
CC=golang-dev
https://golang.org/cl/3488041
      2fd2991e
    • Robert Griesemer's avatar
      go/ast: use token.Pos instead of token.Position; adjust all dependent code · 5a9ad8b9
      Robert Griesemer authored 
      	Specifically:

	* lib/godoc:
	- provide file set (FSet) argument to formatters where needed

	* src/cmd:
	- cgo, ebnflint, godoc, gofmt, goinstall: provide file set (fset) where needed
	- godoc: remove local binary search with sort.Search (change by rsc),
	  extract file set for formatters

	* src/pkg:
	- exp/eval: remove embedded token.Position fields from nodes and replace
	  with named token.Pos fields; add corresponding Pos() accessor methods
	- go/token: added file.Line(), changed signature of File.Position()

	* test/fixedbugs/:
	- bug206.go: change test to not rely on token.Pos details

	* added various extra comments
	* Runs all.bash
	* gofmt formats all of src, misc w/o changes
	* godoc runs

	* performance:
	- The new version of godoc consumes about the same space after indexing
	  has completed, but indexing is half the speed. Significant space savings
	  are expected from smaller ASTs, but since they are thrown away after a
	  file has been indexed, this is not visible anymore. The slower indexing
	  time is due to the much more expensive computation of line information.
	  However, with the new compressed position information, indexing can be
	  rewritten and simplified. Furthermore, computing the line info can be
	  done more efficiently.

        New godoc, immediately after indexing completed (best of three runs):

	  PID COMMAND      %CPU   TIME   #TH #PRTS #MREGS RPRVT  RSHRD  RSIZE  VSIZE
	44381 godoc        0.0%  0:38.00   4    19    149  145M   184K   148M   176M

	2010/12/03 17:58:35 index updated (39.231s, 18505 unique words, 386387 spots)
	2010/12/03 17:58:35 bytes=90858456 footprint=199182584
	2010/12/03 17:58:36 bytes=47858568 footprint=167295224

	Old godoc, immediately after indexing completed (best of three runs):

	  PID COMMAND      %CPU   TIME   #TH #PRTS #MREGS RPRVT  RSHRD  RSIZE  VSIZE
	23167 godoc        0.0%  0:22.02   4    17    132  129M   184K   132M   173M

	2010/12/03 14:51:32 index updated (24.892s, 18765 unique words, 393830 spots)
	2010/12/03 14:51:32 bytes=66404528 footprint=163907832
	2010/12/03 14:51:32 bytes=46282224 footprint=163907832

	The different numbers for unique words/spots stem from the fact the the
	two workspaces are not exactly identical. The new godoc maintains a large
	file set data structure during indexing which (probably) is the reason
	for the larger heap (90858456 vs 66404528) before garbage collection.

R=rsc, r
CC=golang-dev
https://golang.org/cl/3050041
      5a9ad8b9
    • Russ Cox's avatar
      net: fix TestDialGoogle · 92bfd850
      Russ Cox authored 
      TBR=r
CC=golang-dev
https://golang.org/cl/3417042
      92bfd850
    • Yuval Pavel Zholkover's avatar
      8l, runtime: fix Plan 9 386 build. · 8221eb91
      Yuval Pavel Zholkover authored 
      8l was broken by commit 7ac0d2eed9, it caused .data to be page aligned in the file - which is not how Plan 9 expects things to be.
Also .rodata was layed out in a similar fashion.

Not sure when signame was introduced, but added a stub.
Removed the symo assignment in asm.c as it is not currently used.

Fix runtime breakage after commit 629c065d36 which prefixes all external symbols with runtime·.

R=rsc
CC=golang-dev
https://golang.org/cl/2674041
      8221eb91
    • Russ Cox's avatar
      LICENSE: separate, change PATENTS text · 4468e5b3
      Russ Cox authored 
      Split patent grant clause out of LICENSE file
and update text to be more like that used by WebM.
These changes should make Go more acceptable
to the Fedora project and they are acceptable to the FSF.

R=iant
CC=golang-dev
https://golang.org/cl/3103042
      4468e5b3
    • Eoghan Sherry's avatar
      math: improve accuracy of Exp2 · ff4e08f6
      Eoghan Sherry authored 
      Note:
* Exp2 doesn't have a special case for very small arguments
* Exp2 hasn't been subject to a proper error analysis

Also:
* add tests for Exp2 with integer argument
* always test Go versions of Exp and Exp2

R=rsc
CC=Charlie Dorian, PeterGo, golang-dev
https://golang.org/cl/3481041
      ff4e08f6
    • Russ Cox's avatar
      time: fix build · 6eee9ed5
      Russ Cox authored 
      Allow less precise timing on build machines.

TBR=r
CC=golang-dev
https://golang.org/cl/3391043
      6eee9ed5
    • Rob Pike's avatar
      use the new %U format for runes · 42cfe48f
      Rob Pike authored 
      R=rsc
CC=golang-dev
https://golang.org/cl/3483041
      42cfe48f
    • Rob Pike's avatar
      netchan: fix dumb locking bug introduced in recent editing. · 53eaf40e
      Rob Pike authored 
      -found by Dave Cheney

R=rsc
CC=golang-dev
https://golang.org/cl/3460042
      53eaf40e
    • Rob Pike's avatar
      flag: fix format error in boolean error report. just use %q; the values are strings. · e26f9b34
      Rob Pike authored 
      R=rsc
CC=golang-dev
https://golang.org/cl/3418043
      e26f9b34
    • Rob Pike's avatar
      fmt: add %U format for standard Unicode representation of integer values. · 730e39cd
      Rob Pike authored 
      	fmt.Printf("%U", 1) yields "U+0001"
It's essentially "U+%.4x" but lets you override the precision works in scan, too.

R=rsc
CC=golang-dev
https://golang.org/cl/3423043
      730e39cd
    • Roger Peppe's avatar
      time: make After use fewer goroutines and host processes. · e2d1595c
      Roger Peppe authored 
      With credit to Gustavo Niemeyer, who hinted at this approach
in #go-nuts.

R=adg, rsc, niemeyer, r
CC=golang-dev
https://golang.org/cl/3416043
      e2d1595c