Commits · 56024fa64ebe87d5b209fa5d126b71ab27f7cf3d · go / golang

05 Apr, 2012 14 commits

net/url: Correctly escape URL as per RFC 3986 · 56024fa6

Stéphane Travostino authored Apr 05, 2012

The shouldEscape function did not correctly escape the reserved characters listed in RFC 3986 §2.2, breaking some strict web servers.
Fixes #3433.

R=rsc
CC=golang-dev
https://golang.org/cl/5970050

56024fa6

A+C: Stéphane Travostino (individual CLA) · 81f534b2
Russ Cox authored Apr 05, 2012
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/5991048
```
81f534b2

runtime: minor refactoring in preparation for parallel GC · 9903d687

Dmitriy Vyukov authored Apr 05, 2012

factor sweepspan() out of sweep(), no logical changes

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5991047

9903d687

runtime: make GC stats per-M · d839a809

Dmitriy Vyukov authored Apr 05, 2012

This is factored out part of:
https://golang.org/cl/5279048/
(Parallel GC)

benchmark                             old ns/op    new ns/op    delta
garbage.BenchmarkParser              3999106750   3975026500   -0.60%
garbage.BenchmarkParser-2            3720553750   3719196500   -0.04%
garbage.BenchmarkParser-4            3502857000   3474980500   -0.80%
garbage.BenchmarkParser-8            3375448000   3341310500   -1.01%
garbage.BenchmarkParserLastPause      329401000    324097000   -1.61%
garbage.BenchmarkParserLastPause-2    208953000    214222000   +2.52%
garbage.BenchmarkParserLastPause-4    110933000    111656000   +0.65%
garbage.BenchmarkParserLastPause-8     71969000     78230000   +8.70%
garbage.BenchmarkParserPause          230808842    197237400  -14.55%
garbage.BenchmarkParserPause-2        123674365    125197595   +1.23%
garbage.BenchmarkParserPause-4         80518525     85710333   +6.45%
garbage.BenchmarkParserPause-8         58310243     56940512   -2.35%
garbage.BenchmarkTree2                 31471700     31289400   -0.58%
garbage.BenchmarkTree2-2               21536800     21086300   -2.09%
garbage.BenchmarkTree2-4               11074700     10880000   -1.76%
garbage.BenchmarkTree2-8                7568600      7351400   -2.87%
garbage.BenchmarkTree2LastPause       314664000    312840000   -0.58%
garbage.BenchmarkTree2LastPause-2     215319000    210815000   -2.09%
garbage.BenchmarkTree2LastPause-4     110698000    108751000   -1.76%
garbage.BenchmarkTree2LastPause-8      75635000     73463000   -2.87%
garbage.BenchmarkTree2Pause           174280857    173147571   -0.65%
garbage.BenchmarkTree2Pause-2         131332714    129665761   -1.27%
garbage.BenchmarkTree2Pause-4          93803095     93422904   -0.41%
garbage.BenchmarkTree2Pause-8          86242333     85146761   -1.27%

R=rsc
CC=golang-dev
https://golang.org/cl/5987045

d839a809

test/bench/garbage: fix parser benchmark · 77e1227a

Dmitriy Vyukov authored Apr 05, 2012

+add standard bench output to tree2
+print GOMAXPROCS as go test does

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5992044

77e1227a

runtime: replace XOR AX, AX with MOV $0, AX · fd04f05f
Dmitriy Vyukov authored Apr 05, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5985048
```
fd04f05f

runtime: add 64-bit atomics · 46675716

Dmitriy Vyukov authored Apr 05, 2012

This is factored out part of:
https://golang.org/cl/5279048/
(Parallel GC)

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5985047

46675716

runtime: remove redundant code · a28a10e1
Dmitriy Vyukov authored Apr 05, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/5987046
```
a28a10e1
doc/go_spec: fix typo · 8374e678
Hong Ruiqi authored Apr 05, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5990043
```
8374e678
path/filepath: move out of temp directory before deleting it in TestAbs · 4b943bde
Alex Brainman authored Apr 05, 2012
```
Fixes #3476.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5986045
```
4b943bde
misc/dist: include directories in distribution tar and zip files. · 4e9f7047
Dave Cheney authored Apr 05, 2012
```
Fixes #3458.

R=adg, dsymonds
CC=golang-dev
https://golang.org/cl/5969071
```
4e9f7047

doc: shorten project dashboard link · b16ec46c

Andrew Gerrand authored Apr 05, 2012

Fixes #3420.
(which was already fixed)

R=golang-dev, bradfitz, dsymonds
CC=golang-dev
https://golang.org/cl/5987043

b16ec46c

misc/dist: label 386 and amd64 as "32-bit x86" and "64-bit x86" · 0f775d6b
Andrew Gerrand authored Apr 05, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5986043
```
0f775d6b

syscall, net: use native endianness for Linux netlink messages · 35bc9d17

Ian Lance Taylor authored Apr 05, 2012

Tested using 6g and gccgo on x86_64 GNU/Linux and using gccgo
on PowerPC GNU/Linux (which is big-endian).

R=golang-dev, bradfitz, mikioh.mikioh, iant
CC=golang-dev
https://golang.org/cl/5975073

35bc9d17

04 Apr, 2012 5 commits

crypto/rsa: only enforce that de ≡ 1 mod |(ℤ/nℤ)*| in order to load private keys… · 22690e66

Adam Langley authored Apr 04, 2012

crypto/rsa: only enforce that de ≡ 1 mod |(ℤ/nℤ)*| in order to load private keys generated by GnuTLS.

Previously we checked that de ≡ 1 mod φ(n). Since φ(n) is a multiple
of |(ℤ/nℤ)*|, this encompassed the new check, but it was too strict as
keys generated by GnuTLS would be rejected when gcd(p-1,q-1)≠1.

(Also updated the error strings in crypto/rsa to contain the package name, which some were missing.)

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5867043

22690e66

build: unset GOROOT_FINAL before tests · 34ace104

Shenghou Ma authored Apr 04, 2012

        Fix the builders.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5976068

34ace104

cmd/go: in go get, don't try to perform discovery on non-hosts · a8197456

Brad Fitzpatrick authored Apr 04, 2012

Before, "go get -v foo/bar" was assuming "foo" was a hostname
and trying to perform discovery on it. Now, require a dot in
the first path component (the hostname).

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5981057

a8197456

encoding/ascii85: fix panic caused by special case · ac51c138

Dmitry Chestnykh authored Apr 04, 2012

Special case for encoding 4 zeros as 'z' didn't
update source slice, causing 'index out of bounds'
panic in destination slice.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5970078

ac51c138

math: update Gamma special cases · 5496e941

Charles L. Dorian authored Apr 04, 2012

Match new C99 values for special cases.

Fixes #2977.

R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/5972058

5496e941

03 Apr, 2012 10 commits

sql: Propagate error from subsetTypeArgs in Exec · 86092b3d
Michael Lewis authored Apr 03, 2012
```
Fixes #3449

R=golang-dev
CC=bradfitz, golang-dev
https://golang.org/cl/5970076
```
86092b3d

time.RFC822: make the string standard-compliant · 7a33265c

Rob Pike authored Apr 03, 2012

For mysterious reasons, the existing string was just wrong: it was missing a colon.
There is no apparent reason for this discrepancy.

This should be safe to fix because existing uses would not be RFC822-compliant;
people cannot be depending on it to generate correct mail headers.

Fixes #3444.

R=golang-dev, dsymonds, iant, rsc
CC=golang-dev
https://golang.org/cl/5969072

7a33265c

A+C: add Michael Lewis (Individual CLA) · 49397fe1
Brad Fitzpatrick authored Apr 03, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5970077
```
49397fe1

misc/dist: check return value from filepath.Walk · 0fd53d8b

Brad Fitzpatrick authored Apr 03, 2012

Doesn't fix any known issue. This bit me in some unrelated
code and I thought of this tool.

R=golang-dev, krautz, mikkel
CC=golang-dev
https://golang.org/cl/5976067

0fd53d8b

5c, 6c, 8c: take GOROOT_FINAL into consideration · bcdafaa5
Shenghou Ma authored Apr 03, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5936050
```
bcdafaa5
5a, 6a, 8a: take GOROOT_FINAL into consideration · 6af069f3
Shenghou Ma authored Apr 03, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5940052
```
6af069f3
godoc: update appinit.go, apply !appengine build constrain to main.go · 96da953d
Shenghou Ma authored Apr 03, 2012
```
R=adg, dsymonds
CC=golang-dev
https://golang.org/cl/5969063
```
96da953d
encoding/base64: fix panic when input len is not a multiple of 4 · 951a97e4
Dave Cheney authored Apr 03, 2012
```
Fixes #3442.

R=for.go.yong, dsymonds, sougou, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/5975052
```
951a97e4

text/template: pipelined arg was not typechecked · 065db4ea

Rob Pike authored Apr 03, 2012

Without this fix, an erroneous template causes a panic; should be caught safely.
The bug did not affect correct templates.

Fixes #3267.

R=golang-dev, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5900065

065db4ea

time: fix handling of locations with no dst on windows · d3c92b7c
Alex Brainman authored Apr 03, 2012
```
Fixes #3437.

R=rsc
CC=golang-dev
https://golang.org/cl/5967063
```
d3c92b7c

02 Apr, 2012 11 commits
- misc/dashboard: set api_version to go1 · 48a76e13
  Andrew Gerrand authored Apr 02, 2012
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/5952046
```
  48a76e13
- doc: sync playground.js · f1a39ff0
  Andrew Gerrand authored Apr 02, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5956043
```
  f1a39ff0
- doc/code.html: change 'affect' to 'effect'. · a978ead6
  Peter Weinberger authored Apr 02, 2012
```
Fixes #3429.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5966047
```
  a978ead6
- misc/emacs: fix go-mode syntax table and whitespace handling. · b0f4d805
  Sameer Ajmani authored Apr 02, 2012
```
- flag * and / as comment characters
- mark newline as a comment-ender
- include newline in go-mode-whitespace-p

Thanks Jonathan Amsterdam and Steve Yegge for the patch!

R=golang-dev, rsc
CC=golang-dev, jba, stevey
https://golang.org/cl/5938056
```
  b0f4d805
- C: add Peter Weinberger (Google CLA) · e7095851
  Russ Cox authored Apr 02, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5976059
```
  e7095851
- codereview: give advice on 'cannot create CL outside default branch' · 3b7feb70
  Russ Cox authored Apr 02, 2012
```
Fixes #3430.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5981047
```
  3b7feb70
- exp/utf8string: Correct package name in error messages · 512aeb30
  Benny Siegert authored Apr 02, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5969051
```
  512aeb30
- runtime: fix a comment · 6727a2ad
  Maxim Pimenov authored Apr 02, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5975043
```
  6727a2ad
- gc: improve error message for composite literals with unexpected newlines · 8a686792
  Ryan Hitchman authored Apr 02, 2012
```
R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/5857045
```
  8a686792
- cmd/dist, sudo.bash: don't mention sudo.bash if cov or prof is not present · a9de5bb3
  Shenghou Ma authored Apr 02, 2012
```
        Fixes #3422.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5967057
```
  a9de5bb3
- gobuilder: work with codereview plugin enabled in .hgrc · a84056da
  Shenghou Ma authored Apr 02, 2012
```
        Fixes #3312.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5907065
```
  a84056da