- 31 Jul, 2014 1 commit
-
-
Matthew Dempsky authored
LGTM=khr R=khr CC=golang-codereviews https://golang.org/cl/121910043
-
- 30 Jul, 2014 11 commits
-
-
Keith Randall authored
Stand-alone this test is fine. Run together with others, however, the stack used can actually go negative because other tests are freeing stack during its execution. This behavior is new with the new stack allocator. The old allocator never returned (min-sized) stacks. This test is fairly poor - it needs to run in isolation to be accurate. Maybe we should delete it. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/119330044
-
Rob Pike authored
The DISPATCH and CALLFN macro definitions depend on an inconsistency between the internal cpp mini-implementation and the language proper in whether center-dot is an identifier character. The macro depends on it not being an identifier character, but the resulting code depends on it being one. Remove the dependence on the inconsistency by placing the center-dot into the macro invocation rather that the body. No semantic change. This is just renaming macro arguments. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/119320043
-
Keith Randall authored
machines and int64* on 64 bit machines. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/117330044
-
Keith Randall authored
This change introduces gomallocgc, a Go clone of mallocgc. Only a few uses have been moved over, so there are still lots of uses from C. Many of these C uses will be moved over to Go (e.g. in slice.goc), but probably not all. What should remain of C's mallocgc is an open question. LGTM=rsc, dvyukov R=rsc, khr, dave, bradfitz, dvyukov CC=golang-codereviews https://golang.org/cl/108840046
-
Rui Ueyama authored
If a user sets his/her own boundary string with SetBoundary, we don't need to call randomBoundary at all. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/95760043
-
Mikio Hara authored
preparing for the syscall package freeze. ««« original CL description syscall: consolidate, simplify socket options for Unix-like systems Also exposes common socket option functions on Solaris. Update #7174 Update #7175 LGTM=aram R=golang-codereviews, aram CC=golang-codereviews https://golang.org/cl/107280044 »»» LGTM=r R=r CC=golang-codereviews https://golang.org/cl/121880043
-
Mikio Hara authored
preparing for the syscall package freeze. ««« original CL description syscall: add source-specific multicast socket options for FreeBSD Update #8266 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/104290043 »»» LGTM=r R=r CC=golang-codereviews https://golang.org/cl/113660043
-
Rui Ueyama authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/118410043
-
Mikio Hara authored
preparing for the syscall package freeze. ««« original CL description syscall: regenerate z-files for darwin Updates z-files from 10.7 kernel-based to 10.9 kernel-based. LGTM=iant R=golang-codereviews, bradfitz, iant CC=golang-codereviews https://golang.org/cl/102610045 »»» LGTM=r R=r CC=golang-codereviews https://golang.org/cl/114530044
-
Mikio Hara authored
preparing for the syscall package freeze. ««« original CL description syscall: add source-specific multicast socket options for Darwin Update #8266 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/101460043 »»» LGTM=r R=r CC=golang-codereviews https://golang.org/cl/115350043
-
Rob Pike authored
Delete an erroneously doubled name in both files. Once is enough. LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/118420043
-
- 29 Jul, 2014 12 commits
-
-
Mihai Borobocea authored
This is meant to share my progress on Issue 8275, if it's useful to you. I'm not familiar with the formatter's internals, so this change is likely naive. Change these calls to measure width in runes not bytes: fmt.Printf("(%5q)\n", '§') fmt.Printf("(%3c)\n", '§') Fixes #8275. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/104320043
-
Keith Randall authored
This is a case that was missed in https://golang.org/cl/105280047/ LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/120910043
-
Rob Pike authored
Generated by a+c. R=gobot CC=golang-codereviews https://golang.org/cl/115370044
-
Dmitriy Vyukov authored
LGTM=khr R=golang-codereviews, khr CC=golang-codereviews, khr https://golang.org/cl/115280043
-
Dmitriy Vyukov authored
LGTM=khr R=golang-codereviews, khr CC=golang-codereviews, khr https://golang.org/cl/114510044
-
Dmitriy Vyukov authored
LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/120280044
-
Dmitriy Vyukov authored
LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/119300043
-
Mikio Hara authored
On Linux, adding a socket descriptor to epoll instance before getting the EINPROGRESS return value from connect system call could be a root cause of spurious on-connect events. See golang.org/issue/8276, golang.org/issue/8426 for further information. All credit to Jason Eggleston <jason@eggnet.com> Fixes #8276. Fixes #8426. LGTM=dvyukov R=dvyukov, golang-codereviews, adg, dave, iant, alex.brainman CC=golang-codereviews https://golang.org/cl/120820043
-
Dmitriy Vyukov authored
Want to see why builders are failing. Then decide whether to rollback or fix. TBR=khr R=khr CC=golang-codereviews https://golang.org/cl/114510043
-
Dmitriy Vyukov authored
Implement the design described in: https://docs.google.com/document/d/1v4Oqa0WwHunqlb8C3ObL_uNQw3DfSY-ztoA-4wWbKcg/pub Summary of the changes: GC uses "2-bits per word" pointer type info embed directly into bitmap. Scanning of stacks/data/heap is unified. The old spans types go away. Compiler generates "sparse" 4-bits type info for GC (directly for GC bitmap). Linker generates "dense" 2-bits type info for data/bss (the same as stacks use). Summary of results: -1680 lines of code total (-1000+ in mgc0.c only) -25% memory consumption -3-7% binary size -15% GC pause reduction -7% run time reduction LGTM=khr R=golang-codereviews, rsc, christoph, khr CC=golang-codereviews, rlh https://golang.org/cl/106260045
-
Rui Ueyama authored
benchmark old ns/op new ns/op delta BenchmarkPaeth 5.06 6.02 +18.97% BenchmarkDecodeGray 1010551 956911 -5.31% BenchmarkDecodeNRGBAGradient 3877813 3754160 -3.19% BenchmarkDecodeNRGBAOpaque 3194058 3079094 -3.60% BenchmarkDecodePaletted 699243 700211 +0.14% BenchmarkDecodeRGB 2835733 2692120 -5.06% BenchmarkDecodeInterlacing 3651805 3563124 -2.43% BenchmarkEncodeGray 4399183 4404113 +0.11% BenchmarkEncodeNRGBOpaque 13323627 13306485 -0.13% BenchmarkEncodeNRGBA 15840092 15751188 -0.56% BenchmarkEncodePaletted 4396622 4404373 +0.18% BenchmarkEncodeRGBOpaque 13320475 13279189 -0.31% BenchmarkEncodeRGBA 36898392 36781002 -0.32% LGTM=nigeltao R=nigeltao CC=golang-codereviews https://golang.org/cl/117290043
-
Rob Pike authored
Because the reference time is the reference time but beginners seem to think otherwise, make it clearer you can't choose the reference time. LGTM=josharian, dave R=golang-codereviews, josharian, dave CC=golang-codereviews https://golang.org/cl/117250044
-
- 28 Jul, 2014 4 commits
-
-
Adam Langley authored
This change causes a TLS client and server to verify that received elliptic curve points are on the expected curve. This isn't actually necessary in the Go TLS stack, but Watson Ladd has convinced me that it's worthwhile because it's pretty cheap and it removes the possibility that some change in the future (e.g. tls-unique) will depend on it without the author checking that precondition. LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/115290046
-
Adam Langley authored
ASN.1 elements can be optional, and can have a default value. Traditionally, Go has omitted elements that are optional and that have the zero value. I believe that's a bug (see [1]). This change causes an optional element with a default value to only be omitted when it has that default value. The previous behaviour of omitting optional, zero elements with no default is retained because it's used quite a lot and will break things if changed. [1] https://groups.google.com/d/msg/Golang-nuts/9Ss6o9CW-Yo/KL_V7hFlyOAJ Fixes #7780. R=bradfitz LGTM=bradfitz R=golang-codereviews, bradfitz, rsc CC=golang-codereviews, r https://golang.org/cl/86960045
-
Asim Shankar authored
R=golang-codereviews, bradfitz, agl CC=golang-codereviews https://golang.org/cl/117180043
-
Brad Fitzpatrick authored
Fixes #8367 LGTM=adg R=adg CC=golang-codereviews https://golang.org/cl/116300044
-
- 26 Jul, 2014 5 commits
-
-
Shenghou Ma authored
While we're here, make it lookup the tlsfallback symbol only once. LGTM=crawshaw R=golang-codereviews, crawshaw, dave CC=golang-codereviews https://golang.org/cl/107430044
-
Shenghou Ma authored
It is already called by linknew(). LGTM=dave R=rsc, dave CC=golang-codereviews https://golang.org/cl/120760043
-
Shenghou Ma authored
LGTM=bradfitz, dave R=rsc, bradfitz, dave CC=golang-codereviews https://golang.org/cl/115070043
-
Shenghou Ma authored
LGTM=dave R=rsc, dave CC=golang-codereviews https://golang.org/cl/116330043
-
Shenghou Ma authored
Unused. cmd/dist will generate enams as liblink/anames[568].c. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/119940043
-
- 25 Jul, 2014 5 commits
-
-
Keith Randall authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/116320043
-
Bobby Powers authored
glibc devs have apparently decided _BSD_SOURCE will be deprecated on Linux, and issue a preprocessor warning if declaring _BSD_SOURCE without _DEFAULT_SOURCE. https://sourceware.org/glibc/wiki/Release/2.20 Fixes #8397. LGTM=iant R=dave, gobot, iant CC=golang-codereviews https://golang.org/cl/112530043
-
Bobby Powers authored
selv is created with temp() which calls tempname, which marks the new n with EscNever, so there is no need to explicitly set EscNone on the select descriptor. Fixes #8396. LGTM=dvyukov R=golang-codereviews, dave, dvyukov CC=golang-codereviews https://golang.org/cl/112520043
-
Alex Brainman authored
LGTM=chines R=chines CC=golang-codereviews https://golang.org/cl/118160044
-
Andrew Gerrand authored
golang.org now serves HTTPS with a valid cert, so it's reasonable that users should click through to the HTTPS versions of *.golang.org and other known sites. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/112650043
-
- 24 Jul, 2014 2 commits
-
-
Mathieu Lonjaret authored
LGTM=minux R=golang-codereviews, minux CC=golang-codereviews https://golang.org/cl/120150043
-
Keith Randall authored
Sweepone may be running while a new span is allocating. It must not see the state updated while the sweepgen is unset. Fixes #8399 LGTM=dvyukov R=golang-codereviews, dvyukov CC=golang-codereviews https://golang.org/cl/118050043
-