1. 20 Feb, 2014 4 commits
  2. 19 Feb, 2014 21 commits
  3. 18 Feb, 2014 10 commits
    • Brad Fitzpatrick's avatar
      crypto/rc4: test the portable version too · a7fb3183
      Brad Fitzpatrick authored
      Prevent bitrot. (similar to the previous sha1 and md5 CLs)
      
      Fixes #6642
      
      LGTM=agl
      R=agl, dave
      CC=golang-codereviews
      https://golang.org/cl/65690043
      a7fb3183
    • Brad Fitzpatrick's avatar
      api: whitelist change to unicode.Version · ac40fb44
      Brad Fitzpatrick authored
      Unbreaks the build.
      
      LGTM=r
      R=r
      CC=golang-codereviews
      https://golang.org/cl/65650043
      ac40fb44
    • Rob Pike's avatar
      doc/go1.3.txt: unicode upgrade to 6.3.0 · ad4601d1
      Rob Pike authored
      LGTM=mpvl
      R=mpvl
      CC=golang-codereviews
      https://golang.org/cl/65550044
      ad4601d1
    • Marcel van Lohuizen's avatar
      unicode: upgrade to Unicode 6.3.0 · 746d6368
      Marcel van Lohuizen authored
      This is a relatively minor change.
      
      This does not result in changes to go.text/unicode/norm. The go.text
      packages will therefore be relatively unaffected. It does make the
      way for an upgrade to CLDR 24, though.
      
      The tests of all.bash pass, as well as the tests in go.text after
      this update.
      
      LGTM=r
      R=r
      CC=golang-codereviews
      https://golang.org/cl/65400044
      746d6368
    • Alex Brainman's avatar
      run.bat: use double-colon to comment text · 72f2b56a
      Alex Brainman authored
      LGTM=rsc
      R=golang-codereviews, rsc
      CC=golang-codereviews
      https://golang.org/cl/64980043
      72f2b56a
    • Andrew Gerrand's avatar
      go/doc: document the conditions where examples are "playable" · 13d85668
      Andrew Gerrand authored
      LGTM=r
      R=r
      CC=golang-codereviews
      https://golang.org/cl/64910043
      13d85668
    • Russ Cox's avatar
      undo CL 64100044 / 04d062c2e81c · aad23e70
      Russ Cox authored
      broke 32-bit builds
      
      ««« original CL description
      cmd/gc, runtime: enable precisestack by default
      
      Precisestack makes stack collection completely precise,
      in the sense that there are no "used and not set" errors
      in the collection of stack frames, no times where the collector
      reads a pointer from a stack word that has not actually been
      initialized with a pointer (possibly a nil pointer) in that function.
      
      The most important part is interfaces: precisestack means
      that if reading an interface value, the interface value is guaranteed
      to be initialized, meaning that the type word can be relied
      upon to be either nil or a valid interface type word describing
      the data word.
      
      This requires additional zeroing of certain values on the stack
      on entry, which right now costs about 5% overall execution
      time in all.bash. That cost will come down before Go 1.3
      (issue 7345).
      
      There are at least two known garbage collector bugs right now,
      issues 7343 and 7344. The first happens even without precisestack.
      The second I have only seen with precisestack, but that does not
      mean that precisestack is what causes it. In fact it is very difficult
      to explain by what precisestack does directly. Precisestack may
      be exacerbating an existing problem. Both of those issues are
      marked for Go 1.3 as well.
      
      The reasons for enabling precisestack now are to give it more
      time to soak and because the copying stack work depends on it.
      
      LGTM=r
      R=r
      CC=golang-codereviews, iant, khr
      https://golang.org/cl/64100044
      »»»
      
      TBR=r
      CC=golang-codereviews
      https://golang.org/cl/65230043
      aad23e70
    • Nigel Tao's avatar
      cmd/link: fix comment typo. · d2f61cc6
      Nigel Tao authored
      LGTM=dsymonds
      R=dsymonds
      CC=golang-codereviews
      https://golang.org/cl/64100045
      d2f61cc6
    • Russ Cox's avatar
      cmd/gc, runtime: enable precisestack by default · ecf700b5
      Russ Cox authored
      Precisestack makes stack collection completely precise,
      in the sense that there are no "used and not set" errors
      in the collection of stack frames, no times where the collector
      reads a pointer from a stack word that has not actually been
      initialized with a pointer (possibly a nil pointer) in that function.
      
      The most important part is interfaces: precisestack means
      that if reading an interface value, the interface value is guaranteed
      to be initialized, meaning that the type word can be relied
      upon to be either nil or a valid interface type word describing
      the data word.
      
      This requires additional zeroing of certain values on the stack
      on entry, which right now costs about 5% overall execution
      time in all.bash. That cost will come down before Go 1.3
      (issue 7345).
      
      There are at least two known garbage collector bugs right now,
      issues 7343 and 7344. The first happens even without precisestack.
      The second I have only seen with precisestack, but that does not
      mean that precisestack is what causes it. In fact it is very difficult
      to explain by what precisestack does directly. Precisestack may
      be exacerbating an existing problem. Both of those issues are
      marked for Go 1.3 as well.
      
      The reasons for enabling precisestack now are to give it more
      time to soak and because the copying stack work depends on it.
      
      LGTM=r
      R=r
      CC=golang-codereviews, iant, khr
      https://golang.org/cl/64100044
      ecf700b5
    • Russ Cox's avatar
      runtime: clear f, arg to avoid leak in timerproc · be1c71ec
      Russ Cox authored
      I have seen this cause leaks where not all objects in a sync.Pool
      would be reclaimed during the sync package tests.
      I found it while debugging the '0 of 100 finalized' failure we are
      seeing on arm, but it seems not to be the root cause for that one.
      
      LGTM=dave, dvyukov
      R=golang-codereviews, dave, dvyukov
      CC=golang-codereviews
      https://golang.org/cl/64920044
      be1c71ec
  4. 17 Feb, 2014 5 commits