- 18 Jul, 2014 5 commits
-
-
Dmitriy Vyukov authored
Pre Go1? LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/115870043
-
Dmitriy Vyukov authored
Encoder compilation must be enc-independent, because the resulting program is reused across different encoders. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/115860043
-
Shenghou Ma authored
Breaks build for FreeBSD. Probably clang related? ««« original CL description cmd/cgo: disable inappropriate warnings when the gcc struct is empty package main //#cgo CFLAGS: -Wall //void test() {} import "C" func main() { C.test() } This code will cause gcc issuing warnings about unused variable. This commit use offset of the second return value of Packages.structType to detect whether the gcc struct is empty, and if it's directly invoke the C function instead of writing an unused code. LGTM=dave, minux R=golang-codereviews, iant, minux, dave CC=golang-codereviews https://golang.org/cl/109640045 »»» TBR=dfc R=dave CC=golang-codereviews https://golang.org/cl/114990044
-
snyh authored
package main //#cgo CFLAGS: -Wall //void test() {} import "C" func main() { C.test() } This code will cause gcc issuing warnings about unused variable. This commit use offset of the second return value of Packages.structType to detect whether the gcc struct is empty, and if it's directly invoke the C function instead of writing an unused code. LGTM=dave, minux R=golang-codereviews, iant, minux, dave CC=golang-codereviews https://golang.org/cl/109640045
-
Dave Cheney authored
Fixes #8380. Also update hashmap.go to use throwgo rather than panic. LGTM=khr R=khr, rsc CC=golang-codereviews https://golang.org/cl/115860045
-
- 17 Jul, 2014 10 commits
-
-
Keith Randall authored
redo stack allocation. This is mostly the same as the original CL with a few bug fixes. 1. add racemalloc() for stack allocations 2. fix poolalloc/poolfree to terminate free lists correctly. 3. adjust span ref count correctly. 4. don't use cache for sizes >= StackCacheSize. Should fix bugs and memory leaks in original changelist. ««« original CL description undo CL 104200047 / 318b04f28372 Breaks windows and race detector. TBR=rsc ««« original CL description runtime: stack allocator, separate from mallocgc In order to move malloc to Go, we need to have a separate stack allocator. If we run out of stack during malloc, malloc will not be available to allocate a new stack. Stacks are the last remaining FlagNoGC objects in the GC heap. Once they are out, we can get rid of the distinction between the allocated/blockboundary bits. (This will be in a separate change.) Fixes #7468 Fixes #7424 LGTM=rsc, dvyukov R=golang-codereviews, dvyukov, khr, dave, rsc CC=golang-codereviews https://golang.org/cl/104200047 »»» TBR=rsc CC=golang-codereviews https://golang.org/cl/101570044 »»» LGTM=dvyukov R=dvyukov, dave, khr, alex.brainman CC=golang-codereviews https://golang.org/cl/112240044
-
Josh Bleecher Snyder authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/118860043
-
Dmitriy Vyukov authored
Resolves TODO for not walking all goroutines in NumGoroutines. LGTM=khr R=golang-codereviews, khr CC=golang-codereviews, rsc https://golang.org/cl/107290044
-
Dmitriy Vyukov authored
1. Add select on sync channels benchmark. 2. Make channels in BenchmarkSelectNonblock shared. With GOMAXPROCS=1 it is the same, but with GOMAXPROCS>1 it becomes a more interesting benchmark. LGTM=khr R=golang-codereviews, khr CC=golang-codereviews https://golang.org/cl/115780043
-
Rui Ueyama authored
Previously we had a bitmap to check whether or not a byte appears in a string should be replaced. But we don't actually need a separate bitmap for that purpose. Removing the bitmap makes the code simpler. LGTM=dave, iant, nigeltao R=golang-codereviews, dave, gobot, nigeltao, iant, bradfitz, rsc CC=golang-codereviews https://golang.org/cl/110100043
-
Robert Griesemer authored
LGTM=adonovan, rsc R=rsc, adonovan CC=golang-codereviews https://golang.org/cl/117800043
-
Michael Fraenkel authored
Fixes #5750. https://code.google.com/p/go/issues/detail?id=5750 os: Separate windows from posix. Implement windows support. path/filepath: Use the same implementation as other platforms syscall: Add/rework new APIs for Windows LGTM=alex.brainman R=golang-codereviews, alex.brainman, gobot, rsc, minux CC=golang-codereviews https://golang.org/cl/86160044
-
Shenghou Ma authored
Generated by a+c. R=gobot CC=golang-codereviews https://golang.org/cl/114890043
-
Keith Randall authored
Fixes #8378 LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/114880043
-
Cristian Staretu authored
"archive/tar: reuse temporary buffer in writeHeader" introduced a change which was supposed to help lower the number of allocations from 512 bytes for every call to writeHeader. This change broke the writing of PAX headers. writeHeader calls writePAXHeader and writePAXHeader calls writeHeader again. writeHeader will end up writing the PAX header twice. example broken header: PaxHeaders.4007/NetLock_Arany_=Class_Gold=_Ftanstvny.crt0000000000000000000000000000007112301216634021512 xustar0000000000000000 PaxHeaders.4007/NetLock_Arany_=Class_Gold=_Ftanstvny.crt0000000000000000000000000000007112301216634021512 xustar0000000000000000 example correct header: PaxHeaders.4290/NetLock_Arany_=Class_Gold=_Ftanstvny.crt0000000000000000000000000000007112301216634021516 xustar0000000000000000 0100644000000000000000000000270412301216634007250 0ustar0000000000000000 This commit adds a dedicated buffer for pax headers to the Writer struct. This change increases the size of the struct by 512 bytes, but allows tar/writer to avoid allocating 512 bytes for all written headers and it avoids allocating 512 more bytes for pax headers. LGTM=dsymonds R=dsymonds, dave, iant CC=golang-codereviews https://golang.org/cl/110480043
-
- 16 Jul, 2014 11 commits
-
-
Robert Griesemer authored
Pending CL 113120043. LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/112290043
-
Russ Cox authored
Fixes #6102. LGTM=gri R=ken, r, gri CC=golang-codereviews https://golang.org/cl/113120043
-
Russ Cox authored
The garbage collector and stack scans are good enough now. Fixes #7446. LGTM=r R=r, dvyukov CC=golang-codereviews, mdempsky, mtj https://golang.org/cl/112870046
-
Russ Cox authored
As written, the ! applies before the &1. This would crash writing out missing pcdata tables if we ever used non-contiguous IDs in a function. We don't, but fix anyway. LGTM=iant, minux R=minux, iant CC=golang-codereviews https://golang.org/cl/117810047
-
Keith Randall authored
It's a bit slower, but not painfully so. There is still room for improvement (saving space so we can use nosplit, and removing the requirement for hash/eq stubs). benchmark old ns/op new ns/op delta BenchmarkMegMap 23.5 24.2 +2.98% BenchmarkMegOneMap 14.9 15.7 +5.37% BenchmarkMegEqMap 71668 72234 +0.79% BenchmarkMegEmptyMap 4.05 4.93 +21.73% BenchmarkSmallStrMap 21.9 22.5 +2.74% BenchmarkMapStringKeysEight_16 23.1 26.3 +13.85% BenchmarkMapStringKeysEight_32 21.9 25.0 +14.16% BenchmarkMapStringKeysEight_64 21.9 25.1 +14.61% BenchmarkMapStringKeysEight_1M 21.9 25.0 +14.16% BenchmarkIntMap 21.8 12.5 -42.66% BenchmarkRepeatedLookupStrMapKey32 39.3 30.2 -23.16% BenchmarkRepeatedLookupStrMapKey1M 322353 322675 +0.10% BenchmarkNewEmptyMap 129 136 +5.43% BenchmarkMapIter 137 107 -21.90% BenchmarkMapIterEmpty 7.14 8.71 +21.99% BenchmarkSameLengthMap 5.24 6.82 +30.15% BenchmarkBigKeyMap 34.5 35.3 +2.32% BenchmarkBigValMap 36.1 36.1 +0.00% BenchmarkSmallKeyMap 26.9 26.7 -0.74% LGTM=rsc R=golang-codereviews, dave, dvyukov, rsc, gobot, khr CC=golang-codereviews https://golang.org/cl/99380043
-
Volker Dobler authored
A byte order mark (BOM) cannot be backquoted. LGTM=r R=golang-codereviews, gobot, r CC=golang-codereviews https://golang.org/cl/112310043
-
Matthew Cottingham authored
LGTM=r R=golang-codereviews, gobot, r CC=golang-codereviews https://golang.org/cl/114850043
-
Rob Pike authored
DWARF says only one is necessary. The count is preferable because it admits 0-length arrays. Update debug/dwarf to handle either form. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/111230044
-
Yasuhiro Matsumoto authored
code.org exists LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/95500043
-
Dmitriy Vyukov authored
LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews, khr https://golang.org/cl/117810043
-
Adam Langley authored
Fixes 8363. LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/114810043
-
- 15 Jul, 2014 13 commits
-
-
Rob Pike authored
They can be large, so use a varint encoding rather than only one byte. LGTM=iant, rsc R=rsc, iant CC=golang-codereviews https://golang.org/cl/113180043
-
Matthew Dempsky authored
LGTM=minux, rsc R=golang-codereviews, minux, rsc CC=golang-codereviews https://golang.org/cl/113970044
-
Matthew Dempsky authored
LGTM=iant R=rsc, iant CC=golang-codereviews https://golang.org/cl/112320043
-
Dmitriy Vyukov authored
The issue is discovered during testing of a change to runtime. Even if it is unlikely to happen, the comment can safe an hour next person who hits it. LGTM=khr R=golang-codereviews, khr CC=golang-codereviews, rlh, rsc https://golang.org/cl/116790043
-
Dmitriy Vyukov authored
I don't see how it can lead to bad things today. But it's better to kill it before it does. LGTM=khr R=golang-codereviews, khr CC=golang-codereviews, rsc https://golang.org/cl/111130045
-
Jakob Borg authored
Fixes #8252. LGTM=adg R=ruiu, josharian, adg CC=golang-codereviews https://golang.org/cl/102470046
-
Dave Cheney authored
Fixes build failures on nacl/* and android/* platforms. LGTM=adg R=golang-codereviews, adg CC=golang-codereviews https://golang.org/cl/113140043
-
Volker Dobler authored
Make CanBackquote(invalid UTF-8) return false. Also add two test which show that CanBackquote reports true for strings containing a BOM. Fixes #7572. LGTM=r R=golang-codereviews, bradfitz, r CC=golang-codereviews https://golang.org/cl/111780045
-
Robert Griesemer authored
LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/117790043
-
Rob Pike authored
LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/115820043
-
Chris McGee authored
LGTM=adg R=golang-codereviews, adg, minux CC=golang-codereviews https://golang.org/cl/106740044
-
Andrew Gerrand authored
TBR=dsymonds R=golang-codereviews CC=golang-codereviews https://golang.org/cl/112300043
-
Russ Cox authored
This CL adds 'dropg', which is called to drop the association between m and its current goroutine, and it makes schedule handle locked goroutines correctly, instead of requiring all callers of schedule to do that. The effect is that if you want to take over an m for, say, garbage collection work while still allowing the current g to run on some other m, you can do an mcall to a function that is: // dissociate gp dropg(); gp->status = Gwaiting; // for ready // put gp on run queue for others to find runtime·ready(gp); /* ... do other work here ... */ // done with m, let it run goroutines again schedule(); Before this CL, the dropg() body had to be written explicitly, and the check for lockedg before schedule had to be written explicitly too, both of which make the code a bit more fragile than it needs to be. LGTM=iant R=dvyukov, iant CC=golang-codereviews, rlh https://golang.org/cl/113110043
-
- 14 Jul, 2014 1 commit
-
-
Robert Griesemer authored
LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/112970044
-