- 13 May, 2011 3 commits
-
-
Robert Griesemer authored
parser: - resolve embedded interface type names ast: - clarify some comments - correctly unquote import paths R=rsc CC=golang-dev https://golang.org/cl/4528060
-
Russ Cox authored
TBR=gri CC=golang-dev https://golang.org/cl/4534052
-
Benny Siegert authored
The TIFF spec says that a baseline TIFF reader must gracefully terminate when the image has a SampleFormat tag which it does not support. For baseline compatibility, only SampleFormat=1 (the default) is needed. Images with other sample formats (e.g. floating-point color values) are very rare in practice. R=nigeltao CC=golang-dev https://golang.org/cl/4515073
-
- 12 May, 2011 14 commits
-
-
Brad Fitzpatrick authored
Fixes #1391 R=nigeltao CC=golang-dev https://golang.org/cl/4453054
-
Robert Griesemer authored
This CL proposes some subtle language changes in an attempt to clarify the semantics of range clauses and simplify uses of maps. - nil maps behave like empty maps; but attempting to set a value in a nil map causes a run-time panic - nil channels are never ready for communication; sending or reading from a nil channel blocks forever - if there is only one index iteration variable in a range clause and len(range expression) would be a constant, the range expression is not evaluated. (was discrepancy with len/cap before) - the notion of what is a constant expression len(x) for (pointer to) arrays x has been generalized and simplified (can still be syntactically decided) (before: more restrictive syntactic rule that was not consistently implemented) Fixes #1713. R=r, rsc, iant, ken2, r2, bradfitz, rog CC=golang-dev https://golang.org/cl/4444050
-
Robert Griesemer authored
A struct or interface type node is marked incomplete if fields or methods have been removed through any kind of filtering, not just because entries are not exported. The current message was misleading in some cases (for instance: "godoc -src reflect Implements"). This CL requires CL 4527050 . R=rsc, bradfitz CC=golang-dev https://golang.org/cl/4529054
-
Robert Griesemer authored
Also: - fieldListExports: don't require internal pointer to StructType/InterfaceType node - filterFieldLists: make structure match fieldListExports R=rsc CC=golang-dev https://golang.org/cl/4527050
-
Robert Griesemer authored
Partially revert CL 4518050. In go/doc.go, instead of calling the go/ast filter functions, implement the corresponding match functions that do no remove declaration elements. Fixes #1803. R=rsc CC=golang-dev https://golang.org/cl/4517055
-
Russ Cox authored
In the new world, one builder runs gobuilder -commit which uploads information about commits to the dashboard, which then hands the work out to the builders by hash. There is no assumption anymore that the commit numbers are consistent across builders. New builders will need to be deployed. For now darwin-amd64 is running the new builder to test the code. The new JSON-based protocol for handing out work via /todo should be easy to extend if we want to add support for sending trial CLs to the builders. This code is already running on godashboard.appspot.com. R=adg, dave CC=golang-dev https://golang.org/cl/4519047
-
Johan Euphrosine authored
s/Sprintf/Fprintf/ R=golang-dev, rsc CC=adg, golang-dev https://golang.org/cl/4519053
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/4515070
-
Russ Cox authored
Should have been added long ago. Thanks to Alex Brainman for noticing. R=ken2 CC=golang-dev https://golang.org/cl/4538046
-
Anthony Martin authored
This was causing a panic in the reflect package since type.* pointers with their low bits set are assumed to have certain flags set that disallow the use of reflection. Thanks to Pavel and Taru for help tracking down this bug. R=rsc, paulzhol, taruti CC=golang-dev https://golang.org/cl/4511041
-
Lorenzo Stoakes authored
Fixes #1606. R=rsc CC=golang-dev https://golang.org/cl/4532045
-
Russ Cox authored
Fixes hg clpatch. R=golang-dev, r, r CC=golang-dev https://golang.org/cl/4524045
-
Anthony Martin authored
Also, clean *.out files for commands written in Go. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/4535051
-
Brad Fitzpatrick authored
There were a couple issues: -- HEAD requests were attempting to be ungzipped, despite having no content. That was fixed in the previous patch version, but ultimately was fixed as a result of other refactoring: -- persist.go's ClientConn "lastbody" field was remembering the wrong body, since we were mucking with it later. Instead, ditch ClientConn's readRes func field and add a new method passing it in, so we can use a closure and do all our bodyEOFSignal + gunzip stuff in one place, simplifying a lot of code and not requiring messing with ClientConn's innards. -- closing the gzip reader didn't consume its contents. if the caller wasn't done reading all the response body and ClientConn closed it (thinking it'd move past those bytes in the TCP stream), it actually wouldn't. so introduce a new wrapper just for gzip reader to have its Close method do an ioutil.Discard on its body first, before the close. Fixes #1725 Fixes #1804 R=rsc, eivind CC=golang-dev https://golang.org/cl/4523058
-
- 11 May, 2011 10 commits
-
-
Adam Langley authored
R=rsc, bradfitz, bradfitzgoog CC=golang-dev https://golang.org/cl/4518056
-
Christian Himpel authored
RFC 6265 requires that user agents MUST NOT send more than one Cookie header in a request. Note, this change also fixes an issue when sending requests with more than one cookie header line to a php script served by an apache web server. Apache concatenates the cookies with ", ", but php tries to split them only at ";". E.g. two cookies: "a=b, c=d" are seen by php as one cookie "a" with the value "b, c=d". Fixes #1801 R=bradfitz CC=golang-dev https://golang.org/cl/4535048
-
Brad Fitzpatrick authored
An optimization in Transport which re-uses TCP connections early in the case where there is no response body interacted poorly with ErrBodyReadAfterClose. Upon recycling the TCP connection early we would Close the Response.Body (in case the user forgot to), but in the case of a zero-lengthed body, the user's handler might not have run yet. This CL makes sure the Transport doesn't try to Close requests when we're about to immediately re-use the TCP connection. This also includes additional tests I wrote while debugging. R=rsc, bradfitzgoog CC=golang-dev https://golang.org/cl/4529050
-
Nigel Tao authored
R=r CC=golang-dev https://golang.org/cl/4521054
-
Nigel Tao authored
R=r CC=golang-dev https://golang.org/cl/4523054
-
Rob Pike authored
Fixes #1796. R=rsc, r2, niemeyer CC=golang-dev https://golang.org/cl/4539049
-
Adam Langley authored
crl parses CRLs and exposes their details. In the future, Verify should be able to use this for revocation checking. R=bradfitz CC=golang-dev https://golang.org/cl/4485045
-
Luuk van Dijk authored
issue 1604 R=rsc, bradfitz CC=golang-dev https://golang.org/cl/4313062
-
Brad Fitzpatrick authored
R=adg, rsc, kevlar, r CC=golang-dev https://golang.org/cl/4476045
-
Andrew Gerrand authored
R=rsc, dsymonds CC=golang-dev https://golang.org/cl/4528053
-
- 10 May, 2011 4 commits
-
-
Russ Cox authored
Fixes #1608. Fixes #1787. R=ken2 CC=golang-dev https://golang.org/cl/4530045
-
Robert Griesemer authored
So far, only top-level names where considered when trimming ASTs using a filter function. For instance, "godoc reflect Implements" didn't show the "Implements" method of the type Interface because the local method name was not considered (on the other hand, "top- level" declared methods associated with types were considered). With this CL, AST filter functions look also at struct fields and interface methods. R=rsc, r CC=golang-dev https://golang.org/cl/4518050
-
Albert Strasheim authored
R=rsc, bradfitz CC=golang-dev https://golang.org/cl/4523047
-
Nigel Tao authored
writing the idct result directly to the image buffer instead of storing it in an intermediate d.blocks field. Writing to d.blocks was necessary when decoding to an image.RGBA image, but now that we decode to a ycbcr.YCbCr we can write each component directly to the image buffer. Crude "time ./6.out" scores to decode a specific 2592x1944 JPEG 20 times show a 16% speed-up: BEFORE user 0m10.410s user 0m10.400s user 0m10.480s user 0m10.480s user 0m10.460s AFTER user 0m9.050s user 0m9.050s user 0m9.050s user 0m9.070s user 0m9.020s R=r CC=golang-dev https://golang.org/cl/4523052
-
- 09 May, 2011 4 commits
-
-
Robert Griesemer authored
gofmt -w src misc Fixes #1414. R=rsc, r CC=golang-dev https://golang.org/cl/4456054
-
Robert Griesemer authored
When traversing parameter lists (e.g. for type checking), we want the invariant that all identifers have associated objects (even _ idents), so that we can associate a type with each object. R=rsc CC=golang-dev https://golang.org/cl/4490042
-
Rob Pike authored
Had bit test wrong on transparency; no excuses. R=nigeltao CC=golang-dev https://golang.org/cl/4526044
-
Rob Pike authored
At least, as I understand it. The spec is unclear about what happens with a local color map. R=nigeltao, r2 CC=golang-dev https://golang.org/cl/4515045
-
- 08 May, 2011 5 commits
-
-
Rob Pike authored
Fixes #1786. R=gri, adg CC=golang-dev https://golang.org/cl/4517043
-
Rob Pike authored
Fixes #1788. R=rsc, adg CC=golang-dev https://golang.org/cl/4519042
-
Alex Brainman authored
R=golang-dev, r, r2 CC=golang-dev https://golang.org/cl/4471046
-
Alex Brainman authored
This change fixes generation of "shadow" variables for bool parameters. Before the change, it was naming all bool variables with the same name of _p0. Now it calls them _p0, _p1, ... So the code could compile. R=golang-dev, r CC=golang-dev https://golang.org/cl/4479047
-
Rob Pike authored
It's incomplete but sufficient to decode 8-bit GIFs without interlacing or transparency. More to come. I'll put in more tests as the feature set grows. R=nigeltao, r2 CC=golang-dev https://golang.org/cl/4522041
-