- 02 Jul, 2013 12 commits
-
-
Adam Langley authored
This does not include AES-GCM yet. Also, it assumes that the handshake and certificate signature hash are always SHA-256, which is true of the ciphersuites that we currently support. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/10762044
-
David Symonds authored
R=gri, r CC=golang-dev https://golang.org/cl/10679047
-
Shenghou Ma authored
using m->tls[0] to save ucontext pointer is not re-entry safe, and the old code didn't set it before the early return when signal is received on non-Go threads. so misc/cgo/test used to hang when testing issue 5337. R=golang-dev, bradfitz, rsc CC=golang-dev https://golang.org/cl/10076045
-
Daniel Morsing authored
Escape analysis needs the right curfn value on a dclfunc node, otherwise it will not analyze the function. When generating method value wrappers, we forgot to set the curfn correctly. Fixes #5753. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/10383048
-
Rémy Oudompheng authored
A struct with a single field was considered as equivalent to the field type, which is incorrect is the field is blank. Fields with padding could make the compiler think some types are comparable when they are not. Fixes #5698. R=rsc, golang-dev, daniel.morsing, bradfitz, gri, r CC=golang-dev https://golang.org/cl/10271046
-
Yasuhiro Matsumoto authored
R=golang-dev, dsymonds, dominik.honnef CC=golang-dev https://golang.org/cl/9293043
-
Russ Cox authored
TBR=golang-dev CC=golang-dev https://golang.org/cl/10856043
-
Jeff R. Allen authored
When deleting a timer, a panic due to nil deref would leave a lock held, possibly leading to a deadlock in a defer. Instead return false on a nil timer. Fixes #5745. R=golang-dev, daniel.morsing, dvyukov, rsc, iant CC=golang-dev https://golang.org/cl/10373047
-
ChaiShushan authored
R=golang-dev, dave, rsc CC=golang-dev https://golang.org/cl/10458045
-
Volker Dobler authored
This CL provides stable in-place sorting by use of bottom up merge sort with in-place merging done by the SymMerge algorithm from P.-S. Kim and A. Kutzner. The additional space needed for stable sorting (in the form of stack space) is logarithmic in the inputs size n. Number of calls to Less and Swap grow like O(n * log n) and O(n * log n * log n): Stable sorting random data uses significantly more calls to Swap than the unstable quicksort implementation (5 times more on n=100, 10 times more on n=1e4 and 23 times more on n=1e8). The number of calls to Less is practically the same for Sort and Stable. Stable sorting 1 million random integers takes 5 times longer than using Sort. BenchmarkSortString1K 50000 328662 ns/op BenchmarkStableString1K 50000 380231 ns/op 1.15 slower BenchmarkSortInt1K 50000 157336 ns/op BenchmarkStableInt1K 50000 191167 ns/op 1.22 slower BenchmarkSortInt64K 1000 14466297 ns/op BenchmarkStableInt64K 500 16190266 ns/op 1.12 slower BenchmarkSort1e2 200000 64923 ns/op BenchmarkStable1e2 50000 167128 ns/op 2.57 slower BenchmarkSort1e4 1000 14540613 ns/op BenchmarkStable1e4 100 58117289 ns/op 4.00 slower BenchmarkSort1e6 5 2429631508 ns/op BenchmarkStable1e6 1 12077036952 ns/op 4.97 slower R=golang-dev, bradfitz, iant, 0xjnml, rsc CC=golang-dev https://golang.org/cl/9612044
-
Russ Cox authored
Design doc at golang.org/s/go12slice. R=golang-dev, r, nightlyone CC=golang-dev https://golang.org/cl/10761045
-
Russ Cox authored
Design doc at golang.org/s/go12slice. This is an experimental feature and may not be included in the release. R=golang-dev, r CC=golang-dev https://golang.org/cl/10743046
-
- 01 Jul, 2013 7 commits
-
-
Andrew Gerrand authored
This fixes an issue where linking directly to an example makes it not runnable and visible only in a tiny window. To see the bug in action, visit this link: http://golang.org/pkg/strings/#example_Map R=golang-dev, r CC=golang-dev https://golang.org/cl/10679050
-
Russ Cox authored
TBR=golang-dev CC=golang-dev https://golang.org/cl/10849043
-
Russ Cox authored
There are various problems, and both Dmitriy and I will be away for the next week. Make the runtime a bit more stable while we're gone. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/10848043
-
Dmitriy Vyukov authored
fn can clearly hold a closure in memory. argp/pc point into stack and so can hold in memory a block that was previously a large stack serment. R=golang-dev, dave, rsc CC=golang-dev https://golang.org/cl/10784043
-
Russ Cox authored
Depending on net/http means depending on cgo. When the tree is in a shaky state it's nice to see sync/atomic pass even if cgo or net causes broken binaries. R=golang-dev, dave, r CC=golang-dev https://golang.org/cl/10753044
-
David Bürgin authored
This change adds a basic compiler plugin for Go. The plugin integrates "go build" with Vim's ":make" command and the quickfix list. Fixes #5751. R=golang-dev, dsymonds, niklas.schnelle, 0xjnml CC=golang-dev https://golang.org/cl/10466043
-
Jeff R. Allen authored
After loading a frame of a GIF, check that each pixel is inside the frame's palette. Fixes #5401. R=nigeltao, r CC=golang-dev https://golang.org/cl/10597043
-
- 30 Jun, 2013 1 commit
-
-
Russ Cox authored
A casualty of https://golang.org/cl/10195044. If x is an 32-bit int and u is a 64-bit ulong, u = (uint)x // converts to uint before extension, so zero fills u = (ulong)x // sign-extends TBR=iant, r CC=golang-dev https://golang.org/cl/10814043
-
- 28 Jun, 2013 10 commits
-
-
Rémy Oudompheng authored
Exported inlined functions that perform a string conversion using a non-exported named type may miss it in export data. Fixes #5755. R=rsc, golang-dev, ality, r CC=golang-dev https://golang.org/cl/10464043
-
Rémy Oudompheng authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/10741043
-
Russ Cox authored
On amd64 the frames are very close to the limit for a nosplit (textflag 7) function, in part because the C compiler does not make any attempt to reclaim space allocated for completely registerized variables. Avoid a few short-lived variables to reclaim two words. R=golang-dev, r CC=golang-dev https://golang.org/cl/10758043
-
Brad Fitzpatrick authored
Fixes #5794 R=golang-dev, r CC=golang-dev https://golang.org/cl/10747044
-
Rick Arnold authored
If authentication failed, the initial error was being thrown away. Fixes #5700. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/10744043
-
Ian Lance Taylor authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/10760043
-
Russ Cox authored
Keeping the string "compactframe" because that's what I always search for to find this code. But point to the real place too. TBR=iant CC=golang-dev https://golang.org/cl/10676047
-
Dmitriy Vyukov authored
Currently it replaces GOGCTRACE env var (GODEBUG=gctrace=1). The plan is to extend it with other type of debug tracing, e.g. GODEBUG=gctrace=1,schedtrace=100. R=rsc CC=bradfitz, daniel.morsing, gobot, golang-dev https://golang.org/cl/10026045
-
Dmitriy Vyukov authored
The last patch for preemptive scheduler, with this change stoptheworld issues preemption requests every 100us. Update #543. R=golang-dev, daniel.morsing, rsc CC=golang-dev https://golang.org/cl/10264044
-
Ian Lance Taylor authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/10730045
-
- 27 Jun, 2013 10 commits
-
-
Rick Arnold authored
Fixes #5383. R=golang-dev, 0xjnml, r, rsc CC=golang-dev https://golang.org/cl/10472043
-
Paul van Brouwershaven authored
R=agl, agl CC=gobot, golang-dev https://golang.org/cl/10245048
-
Russ Cox authored
The new -coverpkg flag allows computing coverage in one set of packages while running the tests of a different set. Also clean up some of the previous CL's recompileForTest, using packageList to avoid the clumsy recursion. R=golang-dev, r CC=golang-dev https://golang.org/cl/10705043
-
Russ Cox authored
On x86 it is a few words lower on the stack than m->morebuf.sp so it is a more precise check. Enabling the check requires recording a valid gp->sched in reflect.call too. This is a good thing in general, since it will make stack traces during reflect.call work better, and it may be useful for preemption too. R=dvyukov CC=golang-dev https://golang.org/cl/10709043
-
Dmitriy Vyukov authored
runtime.entersyscall() sets g->status = Gsyscall, then calls runtime.lock() which causes stack split. runtime.newstack() resets g->status to Grunning. This will lead to crash during GC (world is not stopped) or GC will scan stack incorrectly. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/10696043
-
Frithjof Schulze authored
Also use 2048-bit RSA keys as default in generate_cert.go, as recommended by the NIST. R=golang-dev, rsc, bradfitz CC=golang-dev https://golang.org/cl/10676043
-
Brad Fitzpatrick authored
Generated by addca, but then manually merged the two lines onto one. R=gobot CC=golang-dev https://golang.org/cl/10701043
-
Adam Langley authored
On my 64-bit machine, despite being 32-bit code, fixed-base multiplications are 7.1x faster and arbitary multiplications are 2.6x faster. It is difficult to review this change. However, the code is essentially the same as code that has been open-sourced in Chromium. There it has been successfully performing P-256 operations for several months on many machines so the arithmetic of the code should be sound. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/10551044
-
Dmitriy Vyukov authored
Failure on bot: http://build.golang.org/log/f4c648906e1289ec2237c1d0880fb1a8b1852a08 ««« original CL description runtime: fix CPU underutilization runtime.newproc/ready are deliberately sloppy about waking new M's, they only ensure that there is at least 1 spinning M. Currently to compensate for that, schedule() checks if the current P has local work and there are no spinning M's, it wakes up another one. It does not work if goroutines do not call schedule. With this change a spinning M wakes up another M when it finds work to do. It's also not ideal, but it fixes the underutilization. A proper check would require to know the exact number of runnable G's, but it's too expensive to maintain. Fixes #5586. R=rsc TBR=rsc CC=gobot, golang-dev https://golang.org/cl/9776044 »»» R=golang-dev CC=golang-dev https://golang.org/cl/10692043
-
Dmitriy Vyukov authored
runtime.newproc/ready are deliberately sloppy about waking new M's, they only ensure that there is at least 1 spinning M. Currently to compensate for that, schedule() checks if the current P has local work and there are no spinning M's, it wakes up another one. It does not work if goroutines do not call schedule. With this change a spinning M wakes up another M when it finds work to do. It's also not ideal, but it fixes the underutilization. A proper check would require to know the exact number of runnable G's, but it's too expensive to maintain. Fixes #5586. R=rsc CC=gobot, golang-dev https://golang.org/cl/9776044
-