Commits · 8281f6bd1b02b52c8233fbcc6b54b697896d0155 · go / golang

23 Nov, 2011 3 commits

crypto/openpgp/packet: fix private key checksum · 8281f6bd

Adam Langley authored Nov 23, 2011

I misinterpreted http://tools.ietf.org/html/rfc4880#section-5.5.3
and implemented the sum of 16-bit values, rather than the 16-bit sum
of 8-bit values.

Thanks to Szabolcs Nagy for pointing it out.

R=bradfitz, r, rsc
CC=golang-dev
https://golang.org/cl/5372091

8281f6bd

exp/ssh: add simple tcpip.go functional tests · f2c85874
Dave Cheney authored Nov 23, 2011
```
R=rsc, agl, n13m3y3r, bradfitz
CC=golang-dev
https://golang.org/cl/5385041
```
f2c85874
exp/ssh: remove unused forwarding methods in Server Listener · d5514120
Dave Cheney authored Nov 23, 2011
```
R=agl, rsc
CC=golang-dev
https://golang.org/cl/5436056
```
d5514120

22 Nov, 2011 10 commits

go/printer: remove "written" result value - is never used · 4874d141
Robert Griesemer authored Nov 22, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/5436052
```
4874d141

go/printer, gofmt: 20 to 30% faster gofmt · a0e54aaf

Robert Griesemer authored Nov 22, 2011

Buffer intermediate output via a bytes.Buffer and thus avoid
calling through the entire Writer stack for every item printed.
There is more opportunity for improvements along the same lines.

Before (best of 3 runs):
- printer.BenchmarkPrint	      50	  47959760 ns/op
- time gofmt -l $GOROOT/src	      real	  0m11.517s

After (best of 3 runs):
- printer.BenchmarkPrint	      50	  32056640 ns/op (= -33%)
- time gofmt -l $GOROOT/src	      real	  0m9.070s       (= -21%)

R=r
CC=golang-dev
https://golang.org/cl/5432054

a0e54aaf

html: on EOF in a comment, ignore final dashes (up to 2) · 57ed39fd

Andrew Balholm authored Nov 22, 2011

Pass tests2.dat, test 57:
<!DOCTYPE html><!--x--

| <!DOCTYPE html>
| <!-- x -->
| <html>
|   <head>
|   <body>

Also pass test 58:
<!DOCTYPE html><table><tr><td></p></table>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5436048

57ed39fd

dashboard: new Go dashboard data structure design · 79bce499
Andrew Gerrand authored Nov 22, 2011
```
R=rsc, r, dsymonds, bradfitz
CC=golang-dev
https://golang.org/cl/5416056
```
79bce499

tutorial: update go_tutorial.html · 422e2473

Rob Pike authored Nov 22, 2011

There's version skew with respect to the programs in doc/progs.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5433048

422e2473

encoding/xml: fix copy bug · fe838c2d

Russ Cox authored Nov 22, 2011

Fixes #2484.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5417059

fe838c2d

allow direct conversion between string and named []byte, []rune · 6e3e3809

Russ Cox authored Nov 22, 2011

The allowed conversions before and after are:
        type Tstring string
        type Tbyte []byte
        type Trune []rune

        string <-> string  // ok
        string <-> []byte  // ok
        string <-> []rune // ok
        string <-> Tstring // ok
        string <-> Tbyte // was illegal, now ok
        string <-> Trune // was illegal, now ok

        Tstring <-> string  // ok
        Tstring <-> []byte  // ok
        Tstring <-> []rune // ok
        Tstring <-> Tstring // ok
        Tstring <-> Tbyte // was illegal, now ok
        Tstring <-> Trune // was illegal, now ok

Update spec, compiler, tests.  Use in a few packages.

We agreed on this a few months ago but never implemented it.

Fixes #1707.

R=golang-dev, gri, r
CC=golang-dev
https://golang.org/cl/5421057

6e3e3809

os: make ReadAt comment clearer · c69d6345

Russ Cox authored Nov 22, 2011

Fixes #2486.

R=golang-dev, hanwen
CC=golang-dev
https://golang.org/cl/5417064

c69d6345

cgo: add support for callbacks from dynamic libraries · 11e73b89
Dmitriy Vyukov authored Nov 22, 2011
```
R=golang-dev, rsc
CC=golang-dev, mpimenov
https://golang.org/cl/5375042
```
11e73b89

html: copy attributes from extra <html> tags to root element · 95e60acb

Andrew Balholm authored Nov 22, 2011

Pass tests2.dat, test 50:
<!DOCTYPE html><html><body><html id=x>

| <!DOCTYPE html>
| <html>
|   id="x"
|   <head>
|   <body>

Also pass tests through test 56:
<!DOCTYPE html>X<p/x/y/z>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5432045

95e60acb

21 Nov, 2011 8 commits

html: ignore whitespace before <head> element · 750de28d

Andrew Balholm authored Nov 21, 2011

Pass tests2.dat, test 47:
" \n "
(That is, two spaces separated by a newline)

| <html>
|   <head>
|   <body>

Also pass tests through test 49:
<!DOCTYPE html><script>
</script>  <title>x</title>  </head>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5422043

750de28d

goinstall: support googlecode subrepos and add repo match tests · 86c08e96

Andrew Gerrand authored Nov 21, 2011

goinstall: don't hit network unless a checkout or update is required

R=rsc, rogpeppe
CC=golang-dev
https://golang.org/cl/5343042

86c08e96

crypto/x509, crypto/tls: support PKCS#8 private keys. · 7c161b05

Adam Langley authored Nov 21, 2011

OpenSSL 1.0.0 has switched to generating PKCS#8 format private keys by
default. This change allows http.ListenAndServeTLS to work with either
types of keys.

See http://groups.google.com/group/golang-nuts/browse_thread/thread/84715b5f0c9e3c30/63a8a27b53e102a6

R=bradfitz
CC=golang-dev
https://golang.org/cl/5416059

7c161b05

bcrypt: Correct typo in package comment. · 85255f99
Benny Siegert authored Nov 21, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5415062
```
85255f99

json: speed up encoding, caching reflect calls · 6c9f4662

Brad Fitzpatrick authored Nov 21, 2011

Before
json.BenchmarkCodeEncoder  10  181232100 ns/op  10.71 MB/s
json.BenchmarkCodeMarshal  10  184578000 ns/op  10.51 MB/s

After:
json.BenchmarkCodeEncoder  10  146444000 ns/op  13.25 MB/s
json.BenchmarkCodeMarshal  10  151428500 ns/op  12.81 MB/s

R=rsc, r
CC=golang-dev
https://golang.org/cl/5416046

6c9f4662

math: faster Cbrt · f3aa54e3

Charles L. Dorian authored Nov 21, 2011

For amd64, from 127 to 105 ns/op; for 386, from 208 to 169 ns/op.

R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/5412056

f3aa54e3

syscall: fix for Plan 9 build · 8ec32e8d

Lucio De Re authored Nov 21, 2011

exec_plan9.go:
. Adjusted return argument to match other changes.
#mksyscall.pl:
. Replaced "err = e1" with "err = NewError(e1)".
* Change abandoned, Russ made a better suggestion involving
  syscall_plan9.go.
syscall_plan9.go:
. Removed redundant "err = nil" lines.
. Adjusted //sys lines for mksyscall.pl.
* Replaced "err string" with "err ErrorString" in return arguments.
zsyscall_plan9_386.go:
. This module ought to be generated, but as it exists in the
  repository, I rebuilt it and checked that it matched expectations.
  Anybody is welcome to remove this from the repository if
  they feel it should go, but remember that not all Plan 9
  installations have a working Perl.

R=rsc
CC=ality, golang-dev
https://golang.org/cl/5411046

8ec32e8d

gofix: test and fix missorted renames · 2e9d7a6d

Russ Cox authored Nov 21, 2011

Also introduce a new insertion heuristic:
insert new import next to existing import
with the longest matching prefix.

R=golang-dev, adg, gri
CC=golang-dev
https://golang.org/cl/5412053

2e9d7a6d

20 Nov, 2011 4 commits

sql: more driver docs & tests; no functional changes · 750d0e33
Brad Fitzpatrick authored Nov 20, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5415055
```
750d0e33

exp/ssh: alter Session to match the exec.Cmd API · fb57134d

Dave Cheney authored Nov 20, 2011

This CL inverts the direction of the Stdin/out/err members of the
Session struct so they reflect the API of the exec.Cmd. In doing so
it borrows heavily from the exec package.

Additionally Shell now returns immediately, wait for completion using
Wait. Exec calls Wait internally and so blocks until the remote
command is complete.

Credit to Gustavo Niemeyer for the impetus for this CL.

R=rsc, agl, n13m3y3r, huin, bradfitz
CC=cw, golang-dev
https://golang.org/cl/5322055

fb57134d

html: refactor parse test infrastructure · 05d8d112

Andrew Balholm authored Nov 20, 2011

My excuse for doing this is that test cases with newlines in them didn't
work. But instead of just fixing that, I rearranged everything in
parse_test.go to use fewer channels and pipes, and just call a
straightforward function to read test cases from a file.

R=nigeltao
CC=golang-dev
https://golang.org/cl/5410049

05d8d112

exp/gui: delete exp/gui and exp/gui/x11. They are moving to · dbb591d8
Nigel Tao authored Nov 20, 2011
```
x-go-binding.googlecode.com.

R=rsc, rogpeppe
CC=golang-dev
https://golang.org/cl/5406041
```
dbb591d8

19 Nov, 2011 6 commits

syscall: add SUSv3 RLIMIT/RUSAGE constants · e2467f04
Sébastien Paolacci authored Nov 19, 2011
```
R=golang-dev, mikioh.mikioh, rsc
CC=golang-dev
https://golang.org/cl/5369092
```
e2467f04

go/printer: cleanup more string/byte conversions · 82182514

Robert Griesemer authored Nov 19, 2011

Slight slow-down for printer benchmark (-0.7%) before
applying CL 5416049 (which will wash it out). Code is
cleaner and simpler.

R=rsc
CC=golang-dev
https://golang.org/cl/5417053

82182514

A+C: Sébastien Paolacci (individual CLA) · 0b396a17
Mikio Hara authored Nov 19, 2011
```
R=adg, golang-dev
CC=golang-dev
https://golang.org/cl/5417052
```
0b396a17
libmach: fix for Plan 9 build · 7f417d8d
Lucio De Re authored Nov 19, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5316059
```
7f417d8d

go/printer: remove gratuitous string/[]byte conversions · 17e493a2

Robert Griesemer authored Nov 19, 2011

Cleanup and slight performance improvement (1.5%).

Before (best of 3 runs):
printer.BenchmarkPrint	      50	  47377420 ns/op

After (best of 3 runs):
printer.BenchmarkPrint	      50	  46707180 ns/op

R=rsc
CC=golang-dev
https://golang.org/cl/5416049

17e493a2

misc/osx: Add scripts to create OS X package and disk image · dd731478
Scott Lawrence authored Nov 19, 2011
```
Fixes #2327.

R=golang-dev, rsc, roberto, jdpoirier
CC=golang-dev
https://golang.org/cl/5375049
```
dd731478

18 Nov, 2011 9 commits

html/template: fix documentation formatting · 6c864210

Andrew Gerrand authored Nov 18, 2011

See http://weekly.golang.org/pkg/html/template/

R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/5413055

6c864210

html/template, net/http, websocket: fix import paths in comments · 5b9d7825
Lucio De Re authored Nov 18, 2011
```
R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/5411048
```
5b9d7825
cgo: document export of Go functions to C. · 29e3ef88
Rémy Oudompheng authored Nov 18, 2011
```
R=mpimenov, rsc
CC=golang-dev, remy
https://golang.org/cl/5376082
```
29e3ef88

template/parse: rename Set to Parse · 10e012c8

Rob Pike authored Nov 18, 2011

Preamble to the simplification of the template API.
Although the signature of Parse (nee Set) changes,
it's really an internal function, used only by
text/template.

R=golang-dev, rsc, gri, r
CC=golang-dev
https://golang.org/cl/5415052

10e012c8

crypto/x509: fix documentation typos · 5cad8611

Adam Langley authored Nov 18, 2011

Thanks to Jeff R. Allen for pointing them out.

R=bradfitz, gri
CC=golang-dev
https://golang.org/cl/5412052

5cad8611

codereview: gofmt check for non-src/ files · 28cead8b

David Crawshaw authored Nov 18, 2011

Gives other projects the benefit of the gofmt presubmit.
Results in minor changes in the doc/ directory:
        find doc -name \*.go -exec gofmt -d {} \;

R=rsc, gri
CC=golang-dev
https://golang.org/cl/5158042

28cead8b

tag weekly.2011-11-18 · 95474b62
Andrew Gerrand authored Nov 18, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/5413052
```
95474b62

weekly.2011-11-18 · 3af28bd8

Andrew Gerrand authored Nov 18, 2011

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/5416045

3af28bd8

codereview: put message back in post-commit mails · cf5a1c09
Russ Cox authored Nov 18, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5417049
```
cf5a1c09