1. 06 Oct, 2014 6 commits
  2. 05 Oct, 2014 1 commit
  3. 04 Oct, 2014 4 commits
  4. 03 Oct, 2014 7 commits
  5. 02 Oct, 2014 7 commits
    • Rob Pike's avatar
      fmt: make the %#v verb a special flag · 7c8e057a
      Rob Pike authored
      The %#v verb is special: it says all values below need to print as %#v.
      However, for some situations the # flag has other meanings and this
      causes some issues, particularly in how Formatters work. Since %#v
      dominates all formatting, translate it into actual state of the formatter
      and decouple it from the # flag itself within the calculations (although
      it must be restored when methods are doing the work.)
      The result is cleaner code and correct handling of # for Formatters.
      TODO: Apply the same thinking to the + flag in a followup CL.
      
      Also, the wasString return value in handleMethods is always false,
      so eliminate it.
      
      Update #8835
      
      LGTM=iant
      R=golang-codereviews, iant
      CC=golang-codereviews
      https://golang.org/cl/146650043
      7c8e057a
    • Robert Griesemer's avatar
      math/big: math.Exp should return result >= 0 for |m| > 0 · 28ddfb09
      Robert Griesemer authored
      The documentation states that Exp(x, y, m)
      computes x**y mod |m| for m != nil && m > 0.
      In math.big, Mod is the Euclidean modulus,
      which is always >= 0.
      
      Fixes #8822.
      
      LGTM=agl, r, rsc
      R=agl, r, rsc
      CC=golang-codereviews
      https://golang.org/cl/145650043
      28ddfb09
    • Robert Griesemer's avatar
      encoding/binary: fix error message · 1dba6eb4
      Robert Griesemer authored
      In the process, simplified internal sizeOf and
      dataSize functions. Minor positive impact on
      performance. Added test case.
      
      benchmark                         old ns/op     new ns/op     delta
      BenchmarkReadSlice1000Int32s      14006         14122         +0.83%
      BenchmarkReadStruct               2508          2447          -2.43%
      BenchmarkReadInts                 921           928           +0.76%
      BenchmarkWriteInts                2086          2081          -0.24%
      BenchmarkWriteSlice1000Int32s     13440         13497         +0.42%
      BenchmarkPutUvarint32             28.5          26.3          -7.72%
      BenchmarkPutUvarint64             81.3          76.7          -5.66%
      
      benchmark                         old MB/s     new MB/s     speedup
      BenchmarkReadSlice1000Int32s      285.58       283.24       0.99x
      BenchmarkReadStruct               27.90        28.60        1.03x
      BenchmarkReadInts                 32.57        32.31        0.99x
      BenchmarkWriteInts                14.38        14.41        1.00x
      BenchmarkWriteSlice1000Int32s     297.60       296.36       1.00x
      BenchmarkPutUvarint32             140.55       151.92       1.08x
      BenchmarkPutUvarint64             98.36        104.33       1.06x
      
      Fixes #6818.
      
      LGTM=r
      R=r
      CC=golang-codereviews
      https://golang.org/cl/149290045
      1dba6eb4
    • Mrunal Patel's avatar
      syscall: support UID/GID map files for Linux user namespaces · f9d7e139
      Mrunal Patel authored
      Fixes #8447.
      
      LGTM=iant
      R=golang-codereviews, bradfitz, iant
      CC=golang-codereviews
      https://golang.org/cl/126190043
      f9d7e139
    • Ian Lance Taylor's avatar
      A+C: add Mrunal Patel (Red Hat corporate CLA) · ea491c5f
      Ian Lance Taylor authored
      LGTM=bradfitz
      R=golang-codereviews, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/152010043
      ea491c5f
    • Nicolas Owens's avatar
      syscall: fix Setenv for plan 9 · e9d5fca9
      Nicolas Owens authored
      envi needs to be updated during Setenv so the key can be correctly deleted later with Unsetenv.
      
      Update #8849.
      
      LGTM=0intro
      R=bradfitz, 0intro
      CC=golang-codereviews
      https://golang.org/cl/149300046
      e9d5fca9
    • Alex Brainman's avatar
      run.bat: comment text properly · 71446174
      Alex Brainman authored
      LGTM=bradfitz
      R=golang-codereviews, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/153830044
      71446174
  6. 01 Oct, 2014 11 commits
  7. 30 Sep, 2014 4 commits