- 06 Oct, 2014 6 commits
-
-
Russ Cox authored
Generated using re2/doc/mksyntaxgo. Fixes #8505. LGTM=iant R=r, iant CC=golang-codereviews https://golang.org/cl/155890043
-
Russ Cox authored
For example, fixes 'go vet syscall', which has source files in package syscall_test. Fixes #8511. LGTM=r R=golang-codereviews, r CC=golang-codereviews, iant https://golang.org/cl/152220044
-
Russ Cox authored
At last minute before 1.3 we relaxed SetFinalizer to avoid crashes when you pass the result of a global alloc to it. This avoids the crash but makes SetFinalizer a bit too relaxed. Document that the finalizer of a global allocation may not run. Tighten the SetFinalizer check to ignore a global allocation but not ignore everything else. Fixes #7656. LGTM=r, iant R=golang-codereviews, iant, r CC=dvyukov, golang-codereviews, khr, rlh https://golang.org/cl/145930043
-
Russ Cox authored
Fixes #8382. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/149540045
-
Brad Fitzpatrick authored
Generated by a+c. R=gobot CC=golang-codereviews https://golang.org/cl/151450043
-
Russ Cox authored
This test is flaky, just like TestDualStackTCPListener. That one was disabled. Disable this one too. Update #5001 LGTM=bradfitz R=rlh, bradfitz CC=golang-codereviews https://golang.org/cl/154950043
-
- 05 Oct, 2014 1 commit
-
-
Alex Brainman authored
This approach was suggested in https://golang.org/cl/138250043/#msg15. Unlike current version of mksyscall_windows.go, new code could be used in go.sys and other external repos without help from asm. LGTM=iant R=golang-codereviews, iant, r CC=golang-codereviews https://golang.org/cl/143160046
-
- 04 Oct, 2014 4 commits
-
-
Dmitriy Vyukov authored
R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/149370043
-
Rob Pike authored
CC=golang-codereviews https://golang.org/cl/152160043
-
Rob Pike authored
It was inconsistent. Also test these better. Also document the default format for types. This wasn't written down. Fixes #8470. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/154870043
-
Ian Lance Taylor authored
Update #8750 CC=golang-codereviews https://golang.org/cl/153950044
-
- 03 Oct, 2014 7 commits
-
-
Dave Cheney authored
Fixes #8349. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/147320043
-
Russ Cox authored
The test doesn't work with GOTRACEBACK != 2. Diagnose that failure mode. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews, r https://golang.org/cl/152970043
-
Rob Pike authored
Apply a similar transformation to %+v that we did to %#v, making it a top-level setting separate from the + flag itself. This fixes the appearance of flags in Formatters and cleans up the code too, probably making it a little faster. Fixes #8835. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/154820043
-
Russ Cox authored
Removes another dangling pointer that might cause a memory leak in 1.4 or crash the GC in 1.5. LGTM=rlh R=golang-codereviews CC=golang-codereviews, iant, khr, r, rlh https://golang.org/cl/150520043
-
Russ Cox authored
This change was necessary on the dev.garbage branch to keep the garbage collector from seeing pointers into invalid heap areas. On this default (Go 1.4) branch, the change removes some possibility for memory leaks. LGTM=khr R=golang-codereviews, khr CC=golang-codereviews, iant, r, rlh https://golang.org/cl/155760043
-
Russ Cox authored
Structs without tags have no unique name to use in the Go definitions generated from the C types. This caused issue 8812, fixed by CL 149260043. Avoid future problems by requiring struct tags. Update runtime as needed. (There is no other C code in the tree.) LGTM=bradfitz, iant R=golang-codereviews, bradfitz, dave, iant CC=golang-codereviews, khr, r https://golang.org/cl/150360043
-
Alex Brainman authored
I will use different approach to solve this problem. See CL 143160046 for details. ««« original CL description syscall: keep Windows syscall pointers live too Like https://golang.org/cl/139360044 LGTM=rsc, alex.brainman R=alex.brainman, rsc CC=golang-codereviews https://golang.org/cl/138250043 »»» LGTM=r R=golang-codereviews, bradfitz, r CC=golang-codereviews https://golang.org/cl/147440043
-
- 02 Oct, 2014 7 commits
-
-
Rob Pike authored
The %#v verb is special: it says all values below need to print as %#v. However, for some situations the # flag has other meanings and this causes some issues, particularly in how Formatters work. Since %#v dominates all formatting, translate it into actual state of the formatter and decouple it from the # flag itself within the calculations (although it must be restored when methods are doing the work.) The result is cleaner code and correct handling of # for Formatters. TODO: Apply the same thinking to the + flag in a followup CL. Also, the wasString return value in handleMethods is always false, so eliminate it. Update #8835 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/146650043
-
Robert Griesemer authored
The documentation states that Exp(x, y, m) computes x**y mod |m| for m != nil && m > 0. In math.big, Mod is the Euclidean modulus, which is always >= 0. Fixes #8822. LGTM=agl, r, rsc R=agl, r, rsc CC=golang-codereviews https://golang.org/cl/145650043
-
Robert Griesemer authored
In the process, simplified internal sizeOf and dataSize functions. Minor positive impact on performance. Added test case. benchmark old ns/op new ns/op delta BenchmarkReadSlice1000Int32s 14006 14122 +0.83% BenchmarkReadStruct 2508 2447 -2.43% BenchmarkReadInts 921 928 +0.76% BenchmarkWriteInts 2086 2081 -0.24% BenchmarkWriteSlice1000Int32s 13440 13497 +0.42% BenchmarkPutUvarint32 28.5 26.3 -7.72% BenchmarkPutUvarint64 81.3 76.7 -5.66% benchmark old MB/s new MB/s speedup BenchmarkReadSlice1000Int32s 285.58 283.24 0.99x BenchmarkReadStruct 27.90 28.60 1.03x BenchmarkReadInts 32.57 32.31 0.99x BenchmarkWriteInts 14.38 14.41 1.00x BenchmarkWriteSlice1000Int32s 297.60 296.36 1.00x BenchmarkPutUvarint32 140.55 151.92 1.08x BenchmarkPutUvarint64 98.36 104.33 1.06x Fixes #6818. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/149290045
-
Mrunal Patel authored
Fixes #8447. LGTM=iant R=golang-codereviews, bradfitz, iant CC=golang-codereviews https://golang.org/cl/126190043
-
Ian Lance Taylor authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/152010043
-
Nicolas Owens authored
envi needs to be updated during Setenv so the key can be correctly deleted later with Unsetenv. Update #8849. LGTM=0intro R=bradfitz, 0intro CC=golang-codereviews https://golang.org/cl/149300046
-
Alex Brainman authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/153830044
-
- 01 Oct, 2014 11 commits
-
-
Robert Griesemer authored
Fixes #8776. LGTM=bradfitz R=rsc, bradfitz CC=golang-codereviews https://golang.org/cl/145710043
-
Robert Griesemer authored
Fixes #8305. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/145680044
-
Robert Griesemer authored
Fixes #7306. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/153820044
-
Rob Pike authored
This new text won't stop the whining but it might focus the whining a little more. LGTM=adg R=golang-codereviews, adg CC=golang-codereviews https://golang.org/cl/146680044
-
Rob Pike authored
This thing should never be called, but before 151960044 it was being called, incorrectly. This is now just a precaution but let's pretend it Fixes #8843 even though that was fixed by 151960044. The test case was already there and ran, another mystery. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/151970043
-
Russ Cox authored
LGTM=r R=r CC=golang-codereviews https://golang.org/cl/151960044
-
Robert Griesemer authored
Fixes #8797. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/146680043
-
Rob Pike authored
The nicest solution would be to buffer the message and only write it if it encodes correctly, but that adds considerable memory and CPU overhead for a very rare condition. Instead, we just shut down the connection if this happens. Fixes #7689. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/146670043
-
Brad Fitzpatrick authored
Also address a TODO, making Clearenv pass through to cgo. Based largely on Minux's earlier https://golang.org/cl/82040044 Fixes #6423 LGTM=iant, alex.brainman, r, rsc R=rsc, iant, r, alex.brainman CC=golang-codereviews https://golang.org/cl/148370043
-
Andrew Gerrand authored
LGTM=crawshaw R=golang-codereviews, crawshaw CC=golang-codereviews https://golang.org/cl/146610043
-
Mikio Hara authored
LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/151870043
-
- 30 Sep, 2014 4 commits
-
-
Andrew Gerrand authored
LGTM=r R=r CC=golang-codereviews https://golang.org/cl/149280044
-
Paul van Brouwershaven authored
The ASN.1 encoding of the CRL Distribution Points extension showed an invalid false 'IsCompound' which caused a display problem in the Windows certificate viewer. LGTM=agl R=agl CC=golang-codereviews https://golang.org/cl/143320043
-
Alan Donovan authored
+ static test NB: there's a preexisting (dynamic) failure of test issue7978.go. LGTM=iant R=rsc, iant CC=golang-codereviews https://golang.org/cl/144650045
-
Robert Griesemer authored
This is a minor cleanup following CL 142360043: The internal parse and format functions in both packages were almost identical - made them identical by adding an extra parameter, and documented them as identical. Eventually we should find a nice way to factor these functions out, but we cannot do this now while in prep for 1.4. No functionality change. LGTM=adonovan R=adonovan CC=golang-codereviews https://golang.org/cl/146520043
-