- 29 Oct, 2013 2 commits
-
-
Andrew Gerrand authored
R=rsc CC=golang-dev https://golang.org/cl/18080045
-
Russ Cox authored
This flag was added in January 2010, in CL 181102, to fix issue 497. (Numbers were just shorter back then.) The fix was for OS X machines and the llvm-gcc frontend. In July 2011 we had to change the way we get enum values, because there were no flags available to force Xcode's llvm-gcc to include the enum names and values in DWARF debug output. We now use clang, not llvm-gcc, on OS X machines. Earlier versions of clang printed a warning about not knowing the flag. Newer versions of clang now make that an error. That is: - The flag was added for OS X machines. - The flag is no longer necessary on OS X machines. - The flag now breaks some OS X machines. Remove it. I have run the original program from issue 497 successfully without the flag on both OS X and Linux machines. Fixes #6678. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/18850043
-
- 28 Oct, 2013 2 commits
-
-
Russ Cox authored
The case can happen when starttheworld is calling acquirep to get things moving again and acquirep gets preempted. The stack trace is in golang.org/issue/6644. It is difficult to build a short test case for this, but the person who reported issue 6644 confirms that this solves the problem. Fixes #6644. R=golang-dev, r CC=golang-dev https://golang.org/cl/18740044
-
Josh Bleecher Snyder authored
Fixes #6646. R=rsc, bradfitz CC=golang-dev https://golang.org/cl/15960047
-
- 25 Oct, 2013 2 commits
-
-
Andrew Gerrand authored
Encoded query strings are always sorted by key; the example wasn't. R=golang-dev, dsymonds, minux.ma, bradfitz CC=golang-dev https://golang.org/cl/16430043
-
Andrew Gerrand authored
Prevent linkcheck from following redirects that lead beyond the outside the root URL. Return a non-zero exit code when there are problems. Some minor refactoring for clarity. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/14425049
-
- 24 Oct, 2013 3 commits
-
-
Brad Fitzpatrick authored
singleStringReplacer had a bug where if a string was replaced at the beginning and no output had yet been produced into the temp buffer before matching ended, an invalid nil check (used as a proxy for having matched anything) meant it always returned its input. Fixes #6659 R=golang-dev, r CC=golang-dev https://golang.org/cl/16880043
-
Matthew Cottingham authored
Update #5886 R=golang-dev, kamil.kisiel, adg, r, rsc, dave, arnehormann, bradfitz CC=golang-dev https://golang.org/cl/14087043
-
Brad Fitzpatrick authored
Done by addca, but codereview failed with a Python stacktrace, so submitting by hand. R=golang-dev CC=golang-dev https://golang.org/cl/16650043
-
- 23 Oct, 2013 2 commits
-
-
Jeff Sickel authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/15360045
-
Andrew Gerrand authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/15450047
-
- 22 Oct, 2013 6 commits
-
-
Russ Cox authored
Avoids a dependency on a somewhat nonstandard part of package syscall. R=golang-dev, dave, r CC=golang-dev https://golang.org/cl/15570046
-
Russ Cox authored
Suggested by iant in earlier CL. R=golang-dev, bradfitz, iant CC=golang-dev https://golang.org/cl/14920052
-
Shenghou Ma authored
Fixes #6617. R=golang-dev, rsc, r CC=golang-dev https://golang.org/cl/15080043
-
Dominik Honnef authored
R=adonovan CC=golang-dev https://golang.org/cl/14454058
-
Russ Cox authored
The routines in this file are dregs from a very early copy of the math API. There are no Go prototypes and no non-amd64 implementations. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/15750046
-
Bill Neubauer authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/14930046
-
- 21 Oct, 2013 3 commits
-
-
Adam Langley authored
The code was requiring that all constraints be met, but it should be satisfied by meeting *any* of them. R=golang-dev, bradfitz, r CC=golang-dev https://golang.org/cl/15570044
-
Adam Langley authored
Despite SHA256 support being required for TLS 1.2 handshakes, some servers are aborting handshakes that don't offer SHA1 support. This change adds support for signing TLS 1.2 ServerKeyExchange messages with SHA1. It does not add support for signing TLS 1.2 client certificates with SHA1 as that would require the handshake to be buffered. Fixes #6618. R=golang-dev, r CC=golang-dev https://golang.org/cl/15650043
-
David Symonds authored
R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/15510043
-
- 20 Oct, 2013 1 commit
-
-
Shenghou Ma authored
Fixes #6620. R=golang-dev, dave, r CC=golang-dev https://golang.org/cl/15330043
-
- 18 Oct, 2013 9 commits
-
-
Russ Cox authored
Fixes #6563. R=golang-dev, iant CC=golang-dev https://golang.org/cl/14870046
-
Russ Cox authored
The old approach to determining whether "name" was a type, constant, or expression was to compile the C program name; and scan the errors and warnings generated by the compiler. This requires looking for specific substrings in the errors and warnings, which ties the implementation to specific compiler versions. As compilers change their errors or drop warnings, cgo breaks. This happens slowly but it does happen. Clang in particular (now required on OS X) has a significant churn rate. The new approach compiles a slightly more complex program that is either valid C or not valid C depending on what kind of thing "name" is. It uses only the presence or absence of an error message on a particular line, not the error text itself. The program is: // error if and only if name is undeclared void f1(void) { typeof(name) *x; } // error if and only if name is not a type void f2(void) { name *x; } // error if and only if name is not an integer constant void f3(void) { enum { x = (name)*1 }; } I had not been planning to do this until Go 1.3, because it is a non-trivial change, but it fixes a real Xcode 5 problem in Go 1.2, and the new code is easier to understand than the old code. It should be significantly more robust. Fixes #6596. Fixes #6612. R=golang-dev, r, james, iant CC=golang-dev https://golang.org/cl/15070043
-
Russ Cox authored
Before: type.struct { buckets *struct { overflow *struct { overflow *struct { overflow *struct { overflow *struct { overflow *<...>; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; oldbuckets *struct { overflow *struct { overflow *struct { overflow *struct { overflow *struct { overflow *<...>; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable } } After: type.map.bucket[string]*"".RangeTable This makes debugging maps a little nicer, and it takes up less space in the binary. R=golang-dev, r CC=golang-dev, khr https://golang.org/cl/15110044
-
Russ Cox authored
Fixes #6614. R=golang-dev, bradfitz, mikioh.mikioh CC=golang-dev https://golang.org/cl/14950045
-
Dmitriy Vyukov authored
Nomemprof seems to be unneeded now, there is no recursion. If the recursion will be re-introduced, it will break loudly by deadlocking. Fixes #6566. R=golang-dev, minux.ma, rsc CC=golang-dev https://golang.org/cl/14695044
-
Andrew Gerrand authored
The "darwin-amd64-osx10.8" target was not matching "darwin-amd64". R=golang-dev CC=golang-dev https://golang.org/cl/14930043
-
Andrew Gerrand authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/14910043
-
Andrew Gerrand authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/14860043
-
Andrew Gerrand authored
Fixes #6607. R=dsymonds CC=golang-dev https://golang.org/cl/14830043
-
- 17 Oct, 2013 6 commits
-
-
Brad Fitzpatrick authored
Only add a slash to path if it's a separator between a host and path. Fixes #6609 R=golang-dev, dsymonds, r CC=golang-dev https://golang.org/cl/14815043
-
Ian Lance Taylor authored
Fixes #6610. R=golang-dev, khr CC=golang-dev https://golang.org/cl/14793043
-
Ian Lance Taylor authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/14792043
-
Russ Cox authored
Fixes #6556. R=golang-dev, iant, adg CC=golang-dev https://golang.org/cl/14747043
-
Alberto García Hierro authored
New test added in CL 14611045 causes a deadlock when running the tests with -cpu=n,n because the fakedb driver always waits when opening a new connection after running TestConnectionLeak. Reset its state after. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/14780043
-
David Symonds authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/14765043
-
- 16 Oct, 2013 4 commits
-
-
Brad Fitzpatrick authored
Found by vet. R=golang-dev, r CC=golang-dev https://golang.org/cl/14762044
-
Robert Griesemer authored
Please note the slight rewording for append: The spec now requires that append reuses the underlying array if it is sufficiently large. Per majority sentiment. This is technically a language change but the current implementation always worked this way. Fixes #5818. Fixes #5180. R=rsc, iant, r, ken, minux.ma, dan.kortschak, rogpeppe, go.peter.90 CC=golang-dev https://golang.org/cl/14419054
-
Alberto García Hierro authored
CL 10726044 introduced a race condition which causes connections to be leaked under certain circumstances. If SetMaxOpenConns is used, the application eventually deadlocks. Otherwise, the number of open connections just keep growing indefinitely. Fixes #6593 R=golang-dev, bradfitz, tad.glines, bketelsen CC=golang-dev https://golang.org/cl/14611045
-
Alberto García Hierro authored
Add a check at the end of every test to make sure there are no leaked connections after running a test. Avoid incorrectly decrementing the number of open connections when the driver connection ends up it a bad state (numOpen was decremented twice). Prevent leaking a Rows struct (which ends up leaking a connection) in Row.Scan() when a *RawBytes destination is improperly used. Close the Rows struct in TestRowsColumns. Update #6593 R=golang-dev, bradfitz, dave CC=golang-dev https://golang.org/cl/14642044
-