Commits · 9a86cc679a5a017af16d2021433754cf5c4495e9 · go / golang

04 Dec, 2009 5 commits
- codereview: do not gofmt deleted files · 9a86cc67
  Russ Cox authored Dec 04, 2009
```
R=r
https://golang.org/cl/164083
```
  9a86cc67
- Make.conf: fix if $HOME has spaces · aaa2374b
  Russ Cox authored Dec 04, 2009
```
R=r
https://golang.org/cl/164086
```
  aaa2374b
- runtime: malloc fixes · 7e5055ce
  Russ Cox authored Dec 04, 2009
```
  * throw away dead code
  * add mlookup counter
  * add malloc counter
  * set up for blocks with no pointers

Fixes #367.

R=r
https://golang.org/cl/165050
```
  7e5055ce
- The String() method requires global state that makes it not work outside of this package, · 10a349a7
  Rob Pike authored Dec 04, 2009
```
so make it a local method (_String()).

R=rsc
CC=golang-dev
https://golang.org/cl/165049
```
  10a349a7
- error propagation in gob/encoder. · fcc4dd6d
  Rob Pike authored Dec 04, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/165048
```
  fcc4dd6d
03 Dec, 2009 16 commits

Add ReadFrom and WriteTo methods to bytes.Buffer, to enable i/o without buffer allocation. · bc3e3475

Rob Pike authored Dec 03, 2009

Use them in Copy and Copyn.
Speed up ReadFile by using ReadFrom and avoiding Copy altogether (a minor win).

R=rsc, gri
CC=golang-dev
https://golang.org/cl/166041

bc3e3475

gc: Allow allow data types up to 1GB · 7e7008fa
Christopher Wedgwood authored Dec 03, 2009
```
R=rsc
https://golang.org/cl/164095
```
7e7008fa
- include type-associated consts and vars when filtering a PackageDoc · 6db683fe
Robert Griesemer authored Dec 03, 2009
```
- fixes a godoc issue (for instance, "godoc os EOF" now shows an entry)

R=r
CC=rsc
https://golang.org/cl/165042
```
6db683fe
gc: handle _ = <-c in select. · c6e316a4
Russ Cox authored Dec 03, 2009
```
Fixes #238.

R=ken2
https://golang.org/cl/163098
```
c6e316a4
gc: recursive type error · 05a1eb1a
Russ Cox authored Dec 03, 2009
```
Fixes #245.

R=ken2
https://golang.org/cl/164094
```
05a1eb1a
gc: better diagnosis of initialization loops · 41861a88
Russ Cox authored Dec 03, 2009
```
Fixes bug 292.

R=ken2
https://golang.org/cl/164093
```
41861a88
gc: minor import grammar bug fixes · e733766d
Russ Cox authored Dec 03, 2009
```
Fixes #364.

R=ken2
https://golang.org/cl/164092
```
e733766d
minor improvement to formatting: don't allocate padding strings every time. · d984f989
Rob Pike authored Dec 03, 2009
```
R=rsc
https://golang.org/cl/164090
```
d984f989
gc: function argument ordering bug · 272d1563
Russ Cox authored Dec 03, 2009
```
Fixes #370.

R=ken2
https://golang.org/cl/163097
```
272d1563
gc: make 'invalid rune in string' a little less cryptic · 8777759f
Russ Cox authored Dec 03, 2009
```
Fixes #371.

R=ken2
https://golang.org/cl/164091
```
8777759f
move ReadFile, WriteFile, and ReadDir into a separate io/ioutil package. · b0683bd7
Rob Pike authored Dec 03, 2009
```
this breaks the dependency of package io on package bytes.

R=rsc
CC=golang-dev
https://golang.org/cl/163085
```
b0683bd7
Runes: turn string into []int · 1eba218e
Peter Froehlich authored Dec 03, 2009
```
Split: fixed typo in documentation

R=rsc, r, r1
https://golang.org/cl/157170
```
1eba218e
updated documentation for gofmt · c0efa07c
Robert Griesemer authored Dec 03, 2009
```
R=rsc
https://golang.org/cl/164085
```
c0efa07c

8g: discard tempalloc/tempfree experiment · 69c0edd5

Russ Cox authored Dec 03, 2009

in favor of tempname.
allows optimizer to do more.
unfortunately, optimizer seems to be broken; disable it.

R=ken2
https://golang.org/cl/163091

69c0edd5

6g etc: groundwork for eliminating redundant bounds checks. · fdb030d8

Russ Cox authored Dec 03, 2009

	drop check in range over array.
	drop check in [256]array indexed by byte.

R=ken2
https://golang.org/cl/163088

fdb030d8

Add flag -tabindent to gofmt: forces use of · dc7355a9

Robert Griesemer authored Dec 03, 2009

tabs for indentation even if -spaces is set.

Changes to gofmt:
- added -tabindent flag
- don't recompute parser and printer mode repeatedly

Changes to go/printer:
- provide new printing mode TabIndent

Changes to tabwriter:
- implement new mode TabIndent to use tabs independent
  of the actual padding character for leading empty columns
- distinguish between minimal cell width and tab width
  (tabwidth is only used if the output contains tabs,
  minwidth and padding are always considered)
- fixed and added more comments
- some additional factoring

By default, -tabindent is disabled and the default gofmt
behavior is unchanged. By setting -spaces and -tabindent,
gofmt will use tabs for indentation but do any other
alignment with spaces. This permits a user to change the
visible indentation by simply changing the editor's tab
width and the code will remain properly aligned without
the need to rerun gofmt.

R=rsc
https://golang.org/cl/163068

dc7355a9

02 Dec, 2009 19 commits
- net: test and fix support for 0-length datagram packets. · e89441ba
  Russ Cox authored Dec 02, 2009
```
Fixes #274.

R=r
CC=jonathan.r.hudson
https://golang.org/cl/163072
```
  e89441ba
- change the naming example from Vector to Ring due to loss of vector.New() · acf4dd4d
  Rob Pike authored Dec 02, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/164082
```
  acf4dd4d
- Add copy to the list of predeclared functions. · ccd02648
  Ian Lance Taylor authored Dec 02, 2009
```
R=gri
https://golang.org/cl/164081
```
  ccd02648
- gofmt: race condition in error reporting and setting exit code · 0aa13c99
  Fazlul Shahriar authored Dec 02, 2009
```
How to reproduce:

	$ mkdir /tmp/foo
	$ cp /dev/null /tmp/foo/bar.go
	$ chmod -r /tmp/foo/bar.go
	$ gofmt /tmp/foo
	open /tmp/foo/bar.go: permission denied
	$ echo $?		# should echo 2
	0
	$

Maybe you need to put a call to time.Sleep at the beginning of report().

R=gri
CC=golang-dev
https://golang.org/cl/164073
```
  0aa13c99
- apply gofmt to json files · d8bc797e
  Robert Griesemer authored Dec 02, 2009
```
R=rsc
https://golang.org/cl/164071
```
  d8bc797e
- fix segfault printing errors. add test case and improve messages. · 114f73f8
  Rob Pike authored Dec 02, 2009
```
Fixes #338.

R=rsc
CC=golang-dev
https://golang.org/cl/163083
```
  114f73f8
- test that arrays work properly. · f6c0eba7
  Rob Pike authored Dec 02, 2009
```
can't mix slices and arrays now; perhaps that should be a TODO

R=rsc
https://golang.org/cl/164079
```
  f6c0eba7
- codereview: move reviewers to cc line after submit, · 69f893a1
  Russ Cox authored Dec 02, 2009
```
  so that the issue stops showing up on the
  per-reviewer dashboard page.

R=r
https://golang.org/cl/164075
```
  69f893a1
- time: another bug in SecondsToUTC. · 9e55d0d0
  Russ Cox authored Dec 02, 2009
```
added random test to look for more.

Fixes #363.

R=r, cw
https://golang.org/cl/163071
```
  9e55d0d0
- Add Shutdown to 32-bit GNU/Linux build. · 952b91e4
  Ian Lance Taylor authored Dec 02, 2009
```
Submitting as a TBR to fix the build.

R=dho, rsc
https://golang.org/cl/164078
```
  952b91e4
- lxml.etree is the wrong location for this alt package · e9a8ab03
  Devon H. O'Dell authored Dec 02, 2009
```
  on my linux machine this is the correct one. lxml.etree
  exists with an ElementTree class, but does not contain
  an .XML method.

R=rsc
https://golang.org/cl/163082
```
  e9a8ab03
- xml.etree can also be lxml.etree (e.g. CentOS 5.4 with Python 2.4.3) · 742221d2
  Devon H. O'Dell authored Dec 02, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/164053
```
  742221d2
- time: fix handling of Jan 1 1601, 1201, 801, ... · 8d652ee8
  Russ Cox authored Dec 02, 2009
```
R=r
CC=hurtonm
https://golang.org/cl/164074
```
  8d652ee8
- net: fix netFD.Close races · eb16346d
  Devon H. O'Dell authored Dec 02, 2009
```
Fixes #271.
Fixes #321.

R=rsc, agl, cw
CC=golang-dev
https://golang.org/cl/163052
```
  eb16346d
- explicitly catch attempt to decode into a value - must be a pointer to see the result. · ff3ea68e
  Rob Pike authored Dec 02, 2009
```
R=rsc
https://golang.org/cl/163070
```
  ff3ea68e
- make io.ReadFile use Stat.Size as a hint for preallocation · f9810f1b
  Rob Pike authored Dec 02, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/163069
```
  f9810f1b
- Add syscall.Shutdown to FreeBSD i386/amd64 · 49ebcfbb
  Devon H. O'Dell authored Dec 02, 2009
```
Necessary for 163052

R=rsc
CC=golang-dev
https://golang.org/cl/164068
```
  49ebcfbb
- 8g: Match sgen definition to declaration · 1664e815
  Evan Shaw authored Dec 02, 2009
```
R=rsc
CC=golang-dev
https://golang.org/cl/164069
```
  1664e815
- FreeBSD needs #!/usr/bin/env bash (fixes broken build on FreeBSD) · fd7e1a2d
  Devon H. O'Dell authored Dec 02, 2009
```
R=gri
https://golang.org/cl/163067
```
  fd7e1a2d