- 07 Apr, 2014 8 commits
-
-
Mikio Hara authored
Also makes ErrWriteToConnected more appropriate; it's used not only UDPConn operations but UnixConn operations. Update #4856 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/84800044
-
Mikio Hara authored
The prefix was not uniformly applied and is probably better left off for using with OpError. Update #4856 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/84660046
-
Albert Strasheim authored
LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/85070043
-
Brad Fitzpatrick authored
Takes advantage of CL 83740044, to optimize map[string] lookup from []byte key. Deletes code. No conditional check for gccgo, since Ian plans to add this to gccgo before GCC 4.10 (Go 1.3). benchmark old ns/op new ns/op delta BenchmarkReadMIMEHeader 6066 5086 -16.16% benchmark old allocs new allocs delta BenchmarkReadMIMEHeader 12 12 +0.00% benchmark old bytes new bytes delta BenchmarkReadMIMEHeader 1317 1317 +0.00% Update #3512 LGTM=rsc R=rsc, dave CC=golang-codereviews, iant https://golang.org/cl/84230043
-
Lucio De Re authored
Superficial inconsistencies that trigger warnings in Plan 9. Small enough to be considered trivial and seemingly benign outside of the Plan 9 environment. LGTM=iant R=golang-codereviews, 0intro, iant CC=golang-codereviews https://golang.org/cl/73460043
-
Dmitriy Vyukov authored
If an error happens on a connection, server goroutine can call b.Logf after benchmark finishes. So join both client and server goroutines. Update #7718 LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/84750047
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/84710045
-
Andrew Gerrand authored
LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/84920043
-
- 06 Apr, 2014 2 commits
-
-
Russ Cox authored
TBR=khr CC=golang-codereviews https://golang.org/cl/84570045
-
Alex Brainman authored
Fixes #7171 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/84330043
-
- 04 Apr, 2014 10 commits
-
-
Keith Randall authored
Fixes #7547 LGTM=iant R=iant, khr CC=golang-codereviews https://golang.org/cl/84470046
-
Keith Randall authored
I have no idea what this code is for, but it pretty clearly needs to be uint64, not uint32. LGTM=aram R=0intro, aram CC=golang-codereviews https://golang.org/cl/84410043
-
Jan Ziak authored
Fixes #7214 LGTM=rsc R=golang-codereviews, bradfitz, rsc CC=golang-codereviews, minux.ma https://golang.org/cl/82080044
-
Rémy Oudompheng authored
Native Client forbids jumps/calls to arbitrary locations and enforces a particular alignement, which makes the Duff's device ineffective. LGTM=khr R=rsc, dave, khr CC=golang-codereviews https://golang.org/cl/84400043
-
Alex Brainman authored
LGTM=mikioh.mikioh R=golang-codereviews, mikioh.mikioh CC=golang-codereviews https://golang.org/cl/84340043
-
Alex Brainman authored
Update #7362 Fixes #7377 Fixes #7570 LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://golang.org/cl/83020043
-
Mikio Hara authored
LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/83880043
-
Mikio Hara authored
LGTM=minux.ma R=rsc, minux.ma CC=golang-codereviews https://golang.org/cl/84260043
-
Russ Cox authored
Trying to make GODEBUG=gcdead=1 work with liveness and in particular ambiguously live variables. 1. In the liveness computation, mark all ambiguously live variables as live for the entire function, except the entry. They are zeroed directly after entry, and we need them not to be poisoned thereafter. 2. In the liveness computation, compute liveness (and deadness) for all parameters, not just pointer-containing parameters. Otherwise gcdead poisons untracked scalar parameters and results. 3. Fix liveness debugging print for -live=2 to use correct bitmaps. (Was not updated for compaction during compaction CL.) 4. Correct varkill during map literal initialization. Was killing the map itself instead of the inserted value temp. 5. Disable aggressive varkill cleanup for call arguments if the call appears in a defer or go statement. 6. In the garbage collector, avoid bug scanning empty strings. An empty string is two zeros. The multiword code only looked at the first zero and then interpreted the next two bits in the bitmap as an ordinary word bitmap. For a string the bits are 11 00, so if a live string was zero length with a 0 base pointer, the poisoning code treated the length as an ordinary word with code 00, meaning it needed poisoning, turning the string into a poison-length string with base pointer 0. By the same logic I believe that a live nil slice (bits 11 01 00) will have its cap poisoned. Always scan full multiword struct. 7. In the runtime, treat both poison words (PoisonGC and PoisonStack) as invalid pointers that warrant crashes. Manual testing as follows: - Create a script called gcdead on your PATH containing: #!/bin/bash GODEBUG=gcdead=1 GOGC=10 GOTRACEBACK=2 exec "$@" - Now you can build a test and then run 'gcdead ./foo.test'. - More importantly, you can run 'go test -short -exec gcdead std' to run all the tests. Fixes #7676. While here, enable the precise scanning of slices, since that was disabled due to bugs like these. That now works, both with and without gcdead. Fixes #7549. LGTM=khr R=khr CC=golang-codereviews https://golang.org/cl/83410044
-
Mikio Hara authored
LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/83910043
-
- 03 Apr, 2014 20 commits
-
-
Mike Andrews authored
runtime.Version() requires a trailing "+" when tree had local modifications at time of build. Fixes #7701 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/84040045
-
Russ Cox authored
The garbage collector poison pointers (0x6969696969696969 and 0x6868686868686868) are malformed addresses on amd64. That is, they are not 48-bit addresses sign extended to 64 bits. This causes a different kind of hardware fault than the usual 'unmapped page' when accessing such an address, and OS X 10.9.2 sends the resulting SIGSEGV incorrectly, making it look like it was user-generated rather than kernel-generated and does not include the faulting address. This means that in GODEBUG=gcdead=1 mode, if there is a bug and something tries to dereference a poisoned pointer, the runtime delivers the SIGSEGV to os/signal and returns to the faulting code, which faults again, causing the process to hang instead of crashing. Fix by rewriting "user-generated" SIGSEGV on OS X to look like a kernel-generated SIGSEGV with fault address 0xb01dfacedebac1e. I chose that address because (1) when printed in hex during a crash, it is obviously spelling out English text, (2) there are no current Google hits for that pointer, which will make its origin easy to find once this CL is indexed, and (3) it is not an altogether inaccurate description of the situation. Add a test. Maybe other systems will break too. LGTM=khr R=golang-codereviews, khr CC=golang-codereviews, iant, ken https://golang.org/cl/83270049
-
Russ Cox authored
Delaying the runtime.throw until here will print more information. In particular it will print the signal and code values, which means it will show the fault address. The canpanic checks were added recently, in CL 75320043. They were just not added in exactly the right place. LGTM=iant R=dvyukov, iant CC=golang-codereviews https://golang.org/cl/83980043
-
Russ Cox authored
Brad has been asking for this for a while. I have resisted because I wanted to find a more general way to do this, one that would keep the performance of code introducing variables the same as the performance of code that did not. (See golang.org/issue/3512#c20). I have not found the more general way, and recent changes to remove ambiguously live temporaries have blown away the property I was trying to preserve, so that's no longer a reason not to make the change. Fixes #3512. LGTM=iant R=iant CC=bradfitz, golang-codereviews, khr, r https://golang.org/cl/83740044
-
Russ Cox authored
Fixes #7476. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/84000043
-
Russ Cox authored
Fixes #7385. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/84010044
-
Russ Cox authored
Cuts hello world by 70kB, because we don't write those names into the symbol table. Update #6853 LGTM=khr R=khr CC=golang-codereviews https://golang.org/cl/80370045
-
Robert Griesemer authored
Fixes #6769. LGTM=bradfitz R=bgarcia, rsc, bradfitz CC=golang-codereviews https://golang.org/cl/84220044
-
Shenghou Ma authored
Fixes #7639. LGTM=rsc R=r, adg, rsc CC=golang-codereviews https://golang.org/cl/81240043
-
Russ Cox authored
Fixes #7271. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/84170043
-
Russ Cox authored
This is just testing the status quo, so that any future attempt to change it will make the test break and redirect the person making the change to look at issue 6027. Fixes #6027. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/83930046
-
David Thomas authored
Supports all the current GNU tar sparse formats, including the old GNU format and the GNU PAX format versions 0.0, 0.1, and 1.0. Fixes #3864. LGTM=rsc R=golang-codereviews, dave, gobot, dsymonds, rsc CC=golang-codereviews https://golang.org/cl/64740043
-
Russ Cox authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/81400045
-
Russ Cox authored
The software floating point runs with m->locks++ to avoid being preempted; recognize this case in panic and undo it so that m->locks is maintained correctly when panicking. Fixes #7553. LGTM=dvyukov R=golang-codereviews, dvyukov CC=golang-codereviews https://golang.org/cl/84030043
-
Brad Fitzpatrick authored
Fixes #7682 LGTM=adg R=golang-codereviews, adg CC=dsymonds, golang-codereviews, iant https://golang.org/cl/83800043
-
Russ Cox authored
The old limit of 5 was chosen because we didn't actually know how many bytes of arguments there were; 5 was a halfway point between printing some useful information and looking ridiculous. Now we know how many bytes of arguments there are, and we stop the printing when we reach that point, so the "looking ridiculous" case doesn't happen anymore: we only print actual argument words. The cutoff now serves only to truncate very long (but real) argument lists. In multiple debugging sessions recently (completely unrelated bugs) I have been frustrated by not seeing more of the long argument lists: 5 words is only 2.5 interface values or strings, and not even 2 slices. Double the max amount we'll show. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews, iant, r https://golang.org/cl/83850043
-
Keith Randall authored
The data field is the generic array that acts as a standin for the keys and values arrays for the generic runtime code. We want to substitute the keys and values arrays for the data array, not just add keys and values in addition to it. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/81160044
-
Dave Cheney authored
Fixes #7550. LGTM=iant R=golang-codereviews, iant, josharian CC=golang-codereviews https://golang.org/cl/83520043
-
Dave Cheney authored
Darwin 10.6 (gcc 4.2) and some older versions of gcc default to C90 mode, not C99 mode. Silence the warning. LGTM=aram, iant R=golang-codereviews, aram, iant CC=golang-codereviews https://golang.org/cl/83090050
-
Ian Lance Taylor authored
There is no way to call them from outside the net package. They are used to implement UCPConn.ReadMsgUDP and similar. LGTM=mikioh.mikioh R=golang-codereviews, mikioh.mikioh CC=golang-codereviews https://golang.org/cl/83730044
-