Skip to content

G
golang
Switch branch/tag
  1. 09 Jul, 2014 7 commits
  3. 08 Jul, 2014 14 commits
  5. 07 Jul, 2014 4 commits
  7. 05 Jul, 2014 2 commits
  9. 04 Jul, 2014 1 commit
  11. 03 Jul, 2014 6 commits
  13. 02 Jul, 2014 6 commits
    • Cristian Staretu's avatar
      archive/tar: reuse temporary buffer in readHeader · 61ccc1f0
      Cristian Staretu authored 
      A temporary 512 bytes buffer is allocated for every call to
readHeader. This buffer isn't returned to the caller and it could
be reused to lower the number of memory allocations.

This CL improves it by using a pool and zeroing out the buffer before
putting it back into the pool.

benchmark                  old ns/op     new ns/op     delta
BenchmarkListFiles100k     545249903     538832687     -1.18%

benchmark                  old allocs    new allocs    delta
BenchmarkListFiles100k     2105167       2005692       -4.73%

benchmark                  old bytes     new bytes     delta
BenchmarkListFiles100k     105903472     54831527      -48.22%

This improvement is very important if your code has to deal with a lot
of tarballs which contain a lot of files.

LGTM=dsymonds
R=golang-codereviews, dave, dsymonds, bradfitz
CC=golang-codereviews
https://golang.org/cl/108240044
      61ccc1f0
    • Cristian Staretu's avatar
      archive/tar: reuse temporary buffer in writeHeader · fe5a358a
      Cristian Staretu authored 
      A temporary 512 bytes buffer is allocated for every call to
writeHeader. This buffer could be reused the lower the number
of memory allocations.

benchmark                   old ns/op     new ns/op     delta
BenchmarkWriteFiles100k     634622051     583810847     -8.01%

benchmark                   old allocs     new allocs     delta
BenchmarkWriteFiles100k     2701920        2602621        -3.68%

benchmark                   old bytes     new bytes     delta
BenchmarkWriteFiles100k     115383884     64349922      -44.23%

This change is very important if your code has to write a lot of
tarballs with a lot of files.

LGTM=dsymonds
R=golang-codereviews, dave, dsymonds
CC=golang-codereviews
https://golang.org/cl/107440043
      fe5a358a
    • Adam Langley's avatar
      crypto/rsa: fix out-of-bound access with short session keys. · 372f399e
      Adam Langley authored 
      Thanks to Cedric Staub for noting that a short session key would lead
to an out-of-bounds access when conditionally copying the too short
buffer over the random session key.

LGTM=davidben, bradfitz
R=davidben, bradfitz
CC=golang-codereviews
https://golang.org/cl/102670044
      372f399e
    • Russ Cox's avatar
      build: annotations and modifications for c2go · ebce7944
      Russ Cox authored 
      The main changes fall into a few patterns:

1. Replace #define with enum.

2. Add /*c2go */ comment giving effect of #define.
This is necessary for function-like #defines and
non-enum-able #defined constants.
(Not all compilers handle negative or large enums.)

3. Add extra braces in struct initializer.
(c2go does not implement the full rules.)

This is enough to let c2go typecheck the source tree.
There may be more changes once it is doing
other semantic analyses.

LGTM=minux, iant
R=minux, dave, iant
CC=golang-codereviews
https://golang.org/cl/106860045
      ebce7944
    • Preetam Jinka's avatar
      crypto/cipher: fix typo in example comment · 4fedb59a
      Preetam Jinka authored 
      LGTM=josharian
R=golang-codereviews, josharian
CC=golang-codereviews
https://golang.org/cl/110330043
      4fedb59a
    • Timo Truyts's avatar
      bufio: Fixed call to Fatal, should be Fatalf. · 22c3f67c
      Timo Truyts authored 
      LGTM=iant
R=golang-codereviews, iant, bradfitz
CC=golang-codereviews
https://golang.org/cl/107390044
      22c3f67c