- 20 Oct, 2013 1 commit
-
-
Shenghou Ma authored
Fixes #6620. R=golang-dev, dave, r CC=golang-dev https://golang.org/cl/15330043
-
- 18 Oct, 2013 9 commits
-
-
Russ Cox authored
Fixes #6563. R=golang-dev, iant CC=golang-dev https://golang.org/cl/14870046
-
Russ Cox authored
The old approach to determining whether "name" was a type, constant, or expression was to compile the C program name; and scan the errors and warnings generated by the compiler. This requires looking for specific substrings in the errors and warnings, which ties the implementation to specific compiler versions. As compilers change their errors or drop warnings, cgo breaks. This happens slowly but it does happen. Clang in particular (now required on OS X) has a significant churn rate. The new approach compiles a slightly more complex program that is either valid C or not valid C depending on what kind of thing "name" is. It uses only the presence or absence of an error message on a particular line, not the error text itself. The program is: // error if and only if name is undeclared void f1(void) { typeof(name) *x; } // error if and only if name is not a type void f2(void) { name *x; } // error if and only if name is not an integer constant void f3(void) { enum { x = (name)*1 }; } I had not been planning to do this until Go 1.3, because it is a non-trivial change, but it fixes a real Xcode 5 problem in Go 1.2, and the new code is easier to understand than the old code. It should be significantly more robust. Fixes #6596. Fixes #6612. R=golang-dev, r, james, iant CC=golang-dev https://golang.org/cl/15070043
-
Russ Cox authored
Before: type.struct { buckets *struct { overflow *struct { overflow *struct { overflow *struct { overflow *struct { overflow *<...>; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; oldbuckets *struct { overflow *struct { overflow *struct { overflow *struct { overflow *struct { overflow *<...>; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable } } After: type.map.bucket[string]*"".RangeTable This makes debugging maps a little nicer, and it takes up less space in the binary. R=golang-dev, r CC=golang-dev, khr https://golang.org/cl/15110044
-
Russ Cox authored
Fixes #6614. R=golang-dev, bradfitz, mikioh.mikioh CC=golang-dev https://golang.org/cl/14950045
-
Dmitriy Vyukov authored
Nomemprof seems to be unneeded now, there is no recursion. If the recursion will be re-introduced, it will break loudly by deadlocking. Fixes #6566. R=golang-dev, minux.ma, rsc CC=golang-dev https://golang.org/cl/14695044
-
Andrew Gerrand authored
The "darwin-amd64-osx10.8" target was not matching "darwin-amd64". R=golang-dev CC=golang-dev https://golang.org/cl/14930043
-
Andrew Gerrand authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/14910043
-
Andrew Gerrand authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/14860043
-
Andrew Gerrand authored
Fixes #6607. R=dsymonds CC=golang-dev https://golang.org/cl/14830043
-
- 17 Oct, 2013 6 commits
-
-
Brad Fitzpatrick authored
Only add a slash to path if it's a separator between a host and path. Fixes #6609 R=golang-dev, dsymonds, r CC=golang-dev https://golang.org/cl/14815043
-
Ian Lance Taylor authored
Fixes #6610. R=golang-dev, khr CC=golang-dev https://golang.org/cl/14793043
-
Ian Lance Taylor authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/14792043
-
Russ Cox authored
Fixes #6556. R=golang-dev, iant, adg CC=golang-dev https://golang.org/cl/14747043
-
Alberto García Hierro authored
New test added in CL 14611045 causes a deadlock when running the tests with -cpu=n,n because the fakedb driver always waits when opening a new connection after running TestConnectionLeak. Reset its state after. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/14780043
-
David Symonds authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/14765043
-
- 16 Oct, 2013 6 commits
-
-
Brad Fitzpatrick authored
Found by vet. R=golang-dev, r CC=golang-dev https://golang.org/cl/14762044
-
Robert Griesemer authored
Please note the slight rewording for append: The spec now requires that append reuses the underlying array if it is sufficiently large. Per majority sentiment. This is technically a language change but the current implementation always worked this way. Fixes #5818. Fixes #5180. R=rsc, iant, r, ken, minux.ma, dan.kortschak, rogpeppe, go.peter.90 CC=golang-dev https://golang.org/cl/14419054
-
Alberto García Hierro authored
CL 10726044 introduced a race condition which causes connections to be leaked under certain circumstances. If SetMaxOpenConns is used, the application eventually deadlocks. Otherwise, the number of open connections just keep growing indefinitely. Fixes #6593 R=golang-dev, bradfitz, tad.glines, bketelsen CC=golang-dev https://golang.org/cl/14611045
-
Alberto García Hierro authored
Add a check at the end of every test to make sure there are no leaked connections after running a test. Avoid incorrectly decrementing the number of open connections when the driver connection ends up it a bad state (numOpen was decremented twice). Prevent leaking a Rows struct (which ends up leaking a connection) in Row.Scan() when a *RawBytes destination is improperly used. Close the Rows struct in TestRowsColumns. Update #6593 R=golang-dev, bradfitz, dave CC=golang-dev https://golang.org/cl/14642044
-
Shenghou Ma authored
Replaces CL 14682044. Fixes #6506. R=rsc, iant, dave CC=golang-dev https://golang.org/cl/14717043
-
Shenghou Ma authored
Fixes #6595. R=golang-dev, adg CC=golang-dev https://golang.org/cl/14425062
-
- 15 Oct, 2013 8 commits
-
-
Russ Cox authored
The preamble may want to #define some special symbols and then #include <sys/types.h> itself. The builtin prolog also #includes <sys/types.h>, which would break such a preamble (because the second #include will be a no-op). The use of sys/types.h in the builtin prolog is new since Go 1.1, so this should preserve the semantics of more existing cgo code than we would otherwise. It also fixes src/pkg/syscall/mkall.sh's use of go tool cgo -godefs on some Linux systems. Thanks to fullung@ for identifying the problem. Fixes #6558. R=golang-dev, iant CC=golang-dev https://golang.org/cl/14684044
-
Alex Brainman authored
undone because the change slows down profile collection significantly and unpredictable at times (see comments at https://golang.org/cl/14231047 for details) ««« original CL description runtime: collect profiles even while on g0 stack Fixes #6417 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/14231047 »»» R=golang-dev, rsc CC=golang-dev https://golang.org/cl/14535046
-
Russ Cox authored
Ensure that clang always exits with a non-zero status by giving it something that it always warns about (the statement "1;"). Fixes #6128. R=golang-dev, iant, minux.ma CC=golang-dev https://golang.org/cl/14702043
-
Russ Cox authored
Otherwise the link fails. Fixes build. TBR=golang-dev CC=golang-dev https://golang.org/cl/14483050
-
Russ Cox authored
TBR=golang-dev CC=golang-dev https://golang.org/cl/14454063
-
Russ Cox authored
Fixes #6506. R=golang-dev, r CC=golang-dev https://golang.org/cl/14682044
-
Oling Cat authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/14516057
-
Alex Brainman authored
Update #6417 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/14604043
-
- 14 Oct, 2013 5 commits
-
-
Keith Randall authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/14441070
-
Michael Piatek authored
Fixes #5953 R=dsymonds, bradfitz, rsc CC=golang-dev https://golang.org/cl/14434044
-
David Symonds authored
R=golang-dev, r CC=golang-dev, piatek https://golang.org/cl/14681043
-
Ian Lance Taylor authored
R=golang-dev, r, minux.ma CC=golang-dev https://golang.org/cl/14669045
-
Shenghou Ma authored
make use of $USER or %USERNAME% to determine the current user. Fixes #6578. R=golang-dev, bradfitz, alex.brainman CC=golang-dev https://golang.org/cl/14649043
-
- 12 Oct, 2013 1 commit
-
-
Shenghou Ma authored
R=golang-dev, dave CC=golang-dev https://golang.org/cl/14629043
-
- 11 Oct, 2013 4 commits
-
-
Rob Pike authored
Why doesn't tidy complain about these? Found by manlio.perillo. Fixes #6571 R=golang-dev, adg CC=golang-dev https://golang.org/cl/14608044
-
Ian Lance Taylor authored
This matches the behaviour of builder.includeArgs in cmd/go/build.go. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/14535048
-
Ian Lance Taylor authored
Fixes #6567. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/14502060
-
Ian Lance Taylor authored
R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/14611043
-