Commits · ccdca2cd6b84f290b0cf8709b11353e58cafdba9 · go / golang

04 May, 2012 8 commits

pkg/runtime: Plan 9 signal handling in Go · ccdca2cd

Akshat Kumar authored May 04, 2012

This adds proper note handling for Plan 9,
and fixes the issue of properly killing go procs.
Without this change, the first go proc that dies
(using runtime·exit()) would kill all the running
go procs. Proper signal handling is needed.

R=golang-dev, ality, rminnich, rsc
CC=golang-dev, john, mirtchovski
https://golang.org/cl/5617048

ccdca2cd

syscall: remove the Signal type on Plan 9 · fe5005f7

Anthony Martin authored May 04, 2012

Instead use a new type, "Note", whose underlying
type is just a string.  This change allows us to
remove the exported os.Plan9Note type.

R=bradfitz, seed, rsc
CC=golang-dev
https://golang.org/cl/6015046

fe5005f7

go/build: cgo is supported on Linux/ARM · 2bed8a7e

Shenghou Ma authored May 04, 2012

        Last Part of CL 5601044 (cgo: Linux/ARM support)
        Fixes #1880.

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5988057

2bed8a7e

cmd/go: cgo for Linux/ARM · e7a0a759

Shenghou Ma authored May 04, 2012

        Part 4 of CL 5601044 (cgo: Linux/ARM support)

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5989058

e7a0a759

cmd/cgo: support Linux/ARM · 9602dd5e

Shenghou Ma authored May 04, 2012

        Part 3 of CL 5601044 (cgo: Linux/ARM support)

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5991066

9602dd5e

runtime: cgo support for Linux/ARM · 5cffce61

Shenghou Ma authored May 04, 2012

        Part 2 of CL 5601044 (cgo: Linux/ARM support)

R=dave, rsc
CC=golang-dev
https://golang.org/cl/5989057

5cffce61

cmd/5l, cmd/ld: dynamic linking library support · 452a9e45

Shenghou Ma authored May 04, 2012

        Part 1 of CL 5601044 (cgo: Linux/ARM support)
        Limitation: doesn't support thumb library yet.

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5991065

452a9e45

misc/dashboard/codereview: remove transitional code. · c44a22cc

David Symonds authored May 04, 2012

All current CLs have subject lines, so we don't need to check any more.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6196044

c44a22cc

03 May, 2012 7 commits
- encoding/json: Fix panic when trying to unmarshal the empty string into an integer · 3fab2a97
  Michael Chaten authored May 03, 2012
```
Fixes #3450.

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/6035050
```
  3fab2a97
- syscall: add Termios support on darwin · 61060acd
  Francisco Souza authored May 03, 2012
```
Update #3316.

R=dave, kevlar, devon.odell, rsc, minux.ma
CC=golang-dev
https://golang.org/cl/6063053
```
  61060acd
- test: add bug437, a test that used to fail with gccgo at link time · 890be5ce
  Ian Lance Taylor authored May 03, 2012
```
Updates #3391.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6177045
```
  890be5ce
- crypto/x509: fix panic when using unavailable hash function. · c8e1946f
  Adam Langley authored May 03, 2012
```
crypto.Hash.New() changed to panicking when the hash function isn't
linked in, but crypto/x509 still expects it to return nil.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6175047
```
  c8e1946f
- cmd/5c, cmd/5a, cmd/5l: ARM support for PREFETCH built-in · 278d4a58
  Shenghou Ma authored May 03, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/6174049
```
  278d4a58
- test: add bug436, valid code that crashed gccgo · df644489
  Ian Lance Taylor authored May 03, 2012
```
R=golang-dev, bsiegert, rsc
CC=golang-dev
https://golang.org/cl/6158046
```
  df644489
- cmd/dist: remove stray src/pkg/runtime/z* when cleaning · 52ec4aa2
  Shenghou Ma authored May 03, 2012
```
R=golang-dev, bradfitz, dave, rsc, lstoakes, rsc
CC=golang-dev
https://golang.org/cl/6180044
```
  52ec4aa2
02 May, 2012 10 commits

misc/dashboard/codereview: add copyright notices to Go files · 7a77645a
Andrew Gerrand authored May 02, 2012
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6177043
```
7a77645a

cmd/cc: add PREFETCH built-in (like SET, USED) · d42495aa

Russ Cox authored May 02, 2012

This makes it possible to inline the prefetch of upcoming
memory addresses during garbage collection, instead of
needing to flush registers, make a function call, and
reload registers.  On garbage collection-heavy workloads,
this results in a 5% speedup.

Fixes #3493.

R=dvyukov, ken, r, dave
CC=golang-dev
https://golang.org/cl/5990066

d42495aa

exp/locale/collate: fixed two bugs uncovered by regression tests. · 10838165

Marcel van Lohuizen authored May 02, 2012

The first bug was that tertiary ignorables had the same colElem as
implicit colElems, yielding unexpected results. The current encoding
ensures that a non-implicit colElem is never 0.  This fix uncovered
another bug of the trie that indexed incorrectly into the null block.
This was caused by an unfinished optimization that would avoid the
need to max out the most-significant bits of continuation bytes.
This bug was also present in the trie used in exp/norm and has been
fixed there as well. The appearence of the bug was rare, as the lower
blocks happened to be nearly nil.

R=r
CC=golang-dev
https://golang.org/cl/6127070

10838165

cmd/gc: test for issue 3552 · 81d96215
Luuk van Dijk authored May 02, 2012
```
R=rsc
CC=golang-dev
https://golang.org/cl/6128051
```
81d96215
runtime: avoid unnecessary zeroization of huge memory blocks · c1c851bb
Dmitriy Vyukov authored May 02, 2012
```
+move zeroization out of the heap mutex

R=golang-dev, iant, rsc
CC=golang-dev
https://golang.org/cl/6094050
```
c1c851bb
os/signal: run windows TestCtrlBreak during build · 0d55d983
Alex Brainman authored May 02, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6136054
```
0d55d983
os: conform to Go 1 API on Plan 9 · 90626864
Anthony Martin authored May 02, 2012
```
R=golang-dev, r, bradfitz, r
CC=golang-dev
https://golang.org/cl/6117062
```
90626864
build: dist-based build for Plan 9 · 38590329
Anthony Martin authored May 02, 2012
```
R=rsc, iant, iant, seed
CC=golang-dev
https://golang.org/cl/5608059
```
38590329
misc/dashboard/codereview: LGTM favicon · ce30769c
Rob Pike authored May 02, 2012
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/6158043
```
ce30769c

bytes: add assembly version of Equal for ARM · d472d3fa

Dave Cheney authored May 02, 2012

BenchmarkEqual32                       662          159  -75.98%
BenchmarkEqual4K                     76545        13719  -82.08%
BenchmarkEqual4M                  90136700     23588870  -73.83%
BenchmarkEqual64M               2147483647   1419616000  -42.63%

BenchmarkEqual32                     48.32       201.15    4.16x
BenchmarkEqual4K                     53.51       298.56    5.58x
BenchmarkEqual4M                     46.53       177.81    3.82x
BenchmarkEqual64M                    27.12        47.27    1.74x

R=golang-dev, qyzhai, minux.ma, rsc, iant, nigeltao
CC=golang-dev
https://golang.org/cl/6118049

d472d3fa

01 May, 2012 7 commits

cgo: rename C names for Go types to avoid conflicting with package · 82e30c68
Ian Lance Taylor authored May 01, 2012
```
Fixes #3371.

R=rsc, bsiegert, r, mtj, iant
CC=golang-dev
https://golang.org/cl/6131060
```
82e30c68
misc/dashboard/codereview: preserve CL ordering. · cc9a5c3b
David Symonds authored May 01, 2012
```
R=r
CC=golang-dev
https://golang.org/cl/6136056
```
cc9a5c3b
compress/flate: add a copy overrun test. · 86a91539
Nigel Tao authored May 01, 2012
```
R=rsc, r
CC=golang-dev
https://golang.org/cl/6143043
```
86a91539
misc/dashboard/codereview: de-dup LGTMs. · 83aa040c
David Symonds authored May 01, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6127066
```
83aa040c
encoding/json: don't match field name if a JSON struct tag is present. · c3c8e35a
David Symonds authored May 01, 2012
```
Fixes #3566.

R=rsc
CC=golang-dev
https://golang.org/cl/6139048
```
c3c8e35a

misc/dashboard/codereview: send mail immediately, and fill in time.Time fields. · dae2992c

David Symonds authored May 01, 2012

If we delay the mail sending, we can't send as the current user.
If we don't fill in the time.Time fields, datastore.Put will fail
because the zero time.Time value is out of its range.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6136053

dae2992c

compress/flate: optimize history-copy decoding. · 4de15a5c

Nigel Tao authored May 01, 2012

The forwardCopy function could be re-written in asm, and the copyHuff
method could probably be rolled into huffmanBlock and copyHist, but
I'm leaving those changes for future CLs.

compress/flate benchmarks:
benchmark                                 old ns/op    new ns/op    delta
BenchmarkDecoderBestSpeed1K                  385327       435140  +12.93%
BenchmarkDecoderBestSpeed10K                1245190      1062112  -14.70%
BenchmarkDecoderBestSpeed100K               8512365      5833680  -31.47%
BenchmarkDecoderDefaultCompression1K         382225       421301  +10.22%
BenchmarkDecoderDefaultCompression10K        867950       613890  -29.27%
BenchmarkDecoderDefaultCompression100K      5658240      2466726  -56.40%
BenchmarkDecoderBestCompression1K            383760       421634   +9.87%
BenchmarkDecoderBestCompression10K           867743       614671  -29.16%
BenchmarkDecoderBestCompression100K         5660160      2464996  -56.45%

image/png benchmarks:
benchmark                       old ns/op    new ns/op    delta
BenchmarkDecodeGray               2540834      2389624   -5.95%
BenchmarkDecodeNRGBAGradient     10052700      9534565   -5.15%
BenchmarkDecodeNRGBAOpaque        8704710      8163430   -6.22%
BenchmarkDecodePaletted           1458779      1325017   -9.17%
BenchmarkDecodeRGB                7183606      6794668   -5.41%

Wall time for Denis Cheremisov's PNG-decoding program given in
https://groups.google.com/group/golang-nuts/browse_thread/thread/22aa8a05040fdd49
Before: 3.07s
After:  2.32s
Delta:  -24%

Before profile:
Total: 304 samples
         159  52.3%  52.3%      251  82.6% compress/flate.(*decompressor).huffmanBlock
          58  19.1%  71.4%       76  25.0% compress/flate.(*decompressor).huffSym
          32  10.5%  81.9%       32  10.5% hash/adler32.update
          16   5.3%  87.2%       22   7.2% bufio.(*Reader).ReadByte
          16   5.3%  92.4%       37  12.2% compress/flate.(*decompressor).moreBits
           7   2.3%  94.7%        7   2.3% hash/crc32.update
           7   2.3%  97.0%        7   2.3% runtime.memmove
           5   1.6%  98.7%        5   1.6% scanblock
           2   0.7%  99.3%        9   3.0% runtime.copy
           1   0.3%  99.7%        1   0.3% compress/flate.(*huffmanDecoder).init

After profile:
Total: 230 samples
          59  25.7%  25.7%       70  30.4% compress/flate.(*decompressor).huffSym
          45  19.6%  45.2%       45  19.6% hash/adler32.update
          35  15.2%  60.4%       35  15.2% compress/flate.forwardCopy
          20   8.7%  69.1%      151  65.7% compress/flate.(*decompressor).huffmanBlock
          16   7.0%  76.1%       24  10.4% compress/flate.(*decompressor).moreBits
          15   6.5%  82.6%       15   6.5% runtime.memmove
          11   4.8%  87.4%       50  21.7% compress/flate.(*decompressor).copyHist
           7   3.0%  90.4%        7   3.0% hash/crc32.update
           6   2.6%  93.0%        9   3.9% bufio.(*Reader).ReadByte
           4   1.7%  94.8%        4   1.7% runtime.slicearray

R=rsc, rogpeppe, dave
CC=golang-dev, krasin
https://golang.org/cl/6127064

4de15a5c

30 Apr, 2012 7 commits
- cmd/go: do not ignore DepsErrors in 'go run' · 84ce0f76
  Robert Hencke authored Apr 30, 2012
```
Fixes #3490.

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6040046
```
  84ce0f76
- runtime: give proper messages when user defined DYLD_INSERT_LIBRARIES on Darwin · 44fd1d1a
  Shenghou Ma authored Apr 30, 2012
```
       also gives clear error when bsdthread_register fails on Darwin
       Fixes #2992.

R=rsc, krautz
CC=golang-dev
https://golang.org/cl/5966067
```
  44fd1d1a
- misc/dashboard/codereview: record Message-ID of code review thread mails. · 1bdb788b
  David Symonds authored Apr 30, 2012
```
This will allow us to properly thread "R=..." mails at a later time.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6135053
```
  1bdb788b
- misc/dashboard/codereview: add handy logout URL. · 5d331964
  David Symonds authored Apr 30, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6135052
```
  5d331964
- misc/dashboard/codereview: send mail to assigned reviewers if they aren't already looped in. · 4335ec9e
  David Symonds authored Apr 30, 2012
```
R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/6128054
```
  4335ec9e
- encoding/base64: don't ignore underlying souce read error in decode · ed90fbc7
  Brad Fitzpatrick authored Apr 30, 2012
```
Fixes #3577

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6137054
```
  ed90fbc7
- syscall: add a test for passing an fd over a unix socket · fe2ce528
  Brad Fitzpatrick authored Apr 30, 2012
```
Re-submitting previously reverted change 160ec5506cb7.

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/6129052
```
  fe2ce528
29 Apr, 2012 1 commit

compress/flate: add Encoder/Decoder benchmarks · d5b299ed

Dave Cheney authored Apr 29, 2012

In CL 6127051, nigeltao suggested that further gains
were possible by improving the performance of flate.
This CL adds a set of benchmarks (based on compress/lzw)
that can be used to judge any future improvements.

R=nigeltao
CC=golang-dev
https://golang.org/cl/6128049

d5b299ed