- 21 Nov, 2012 3 commits
-
-
Joel Sing authored
Update OpenBSD runtime to use the new version of the sys___tfork syscall and switch TLS initialisation from sys_arch to sys___set_tcb (note that both of these syscalls are available in OpenBSD 5.2). R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/6843058
-
Rémy Oudompheng authored
Fixes #4399. R=golang-dev, nigeltao CC=golang-dev https://golang.org/cl/6845053
-
Dave Cheney authored
Putting aside the unguarded access to fd.sysfile, the condition will never be true as fd.incref above handles the closed condition. R=mikioh.mikioh, dvyukov CC=golang-dev https://golang.org/cl/6845062
-
- 20 Nov, 2012 5 commits
-
-
Shenghou Ma authored
R=fullung, bradfitz, dave CC=golang-dev https://golang.org/cl/6846081
-
Ian Lance Taylor authored
The exp/types packages does not support the gccgo export data format. At some point it should, but not yet. R=gri, bradfitz, r, iant, dsymonds CC=golang-dev https://golang.org/cl/6854068
-
Alex Brainman authored
Also enables TestDirWindows test on windows. Fixes #4401. R=golang-dev, bradfitz CC=golang-dev, krautz https://golang.org/cl/6847072
-
Brad Fitzpatrick authored
Noticed this while closing tabs. Yesterday I thought I could ignore this garbage and hope that a fix for issue 2205 handled it, but I just realized that's the opposite case, string->[]byte, whereas this is []byte->string. I'm having a hard time convincing myself that an Issue 2205-style fix with static analysis and faking a string header would be safe in all cases without violating the memory model (callee assumes frozen memory; are there non-racy ways it could keep being modified?) R=dsymonds CC=dave, gobot, golang-dev https://golang.org/cl/6850067
-
Brad Fitzpatrick authored
Fixes #4411 R=dsymonds CC=gobot, golang-dev https://golang.org/cl/6854067
-
- 19 Nov, 2012 7 commits
-
-
Brad Fitzpatrick authored
Saves 5 seconds on my machine. If Issue 4380 is fixed this clone can be removed. Update #4380 R=golang-dev, remyoudompheng, minux.ma, gri CC=golang-dev https://golang.org/cl/6845058
-
Robert Griesemer authored
There's no good reason to make any printer state adjustments simply because the file name in node position information has changed. Eliminate the relevant code. R=r CC=golang-dev https://golang.org/cl/6856054
-
Brad Fitzpatrick authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/6853069
-
Brad Fitzpatrick authored
Don't rely on finding cmd.exe in a particular spot. Fixes #4401 R=golang-dev, krautz CC=golang-dev https://golang.org/cl/6842066
-
Christian Himpel authored
This enables to loop over some goroutines, e.g. to print the backtrace of goroutines 1 to 9: set $i = 1 while $i < 10 printf "backtrace of goroutine %d:\n", $i goroutine $i++ bt end R=lvd, lvd CC=golang-dev https://golang.org/cl/6843071
-
Robert Griesemer authored
Fixes #4405. R=rsc, bradfitz CC=golang-dev https://golang.org/cl/6855060
-
Brad Fitzpatrick authored
Update #4401 R=golang-dev, mattn.jp CC=golang-dev https://golang.org/cl/6853067
-
- 18 Nov, 2012 2 commits
-
-
Dave Cheney authored
Fixes #4369. Remove the check for fd.sysfd < 0, the first line of fd.accept() tests if the fd is open correctly and will handle the fd being closed during accept. R=dvyukov, bradfitz CC=golang-dev https://golang.org/cl/6843076
-
Dave Cheney authored
This is part 1 of a series of proposals to fix issue 4369. In resolving issue 3507 it was decided not to nil out the inner conn.fd field to avoid a race. This implies the checks for fd == nil inside incref/decref are never true. Removing this logic removes one source of errClosing error values, which affects issue 4373 and moves towards bradfitz's request that fd.accept() return io.EOF when closed concurrently. Update #4369. Update #4373. R=mikioh.mikioh, bradfitz, dvyukov, rsc CC=golang-dev https://golang.org/cl/6852057
-
- 17 Nov, 2012 9 commits
-
-
Dave Cheney authored
Enable warnings as errors during the cgo portion of runtime/cgo. iant requested that the list of flags match cmd/dist/build.c, but I would like to avoid the set of disabled warnings if possible. ref: https://groups.google.com/d/topic/golang-nuts/TrCoVzIIG4M/discussion requires: 6843061 R=minux.ma, iant CC=golang-dev https://golang.org/cl/6852055
-
Robert Griesemer authored
Fixes #4400. R=r, mirtchovski CC=golang-dev https://golang.org/cl/6782084
-
Shenghou Ma authored
R=dave, remyoudompheng CC=golang-dev https://golang.org/cl/6854056
-
Robert Griesemer authored
Replacement CL for 6813061; thanks to minux for prototyping. Fixes #4300. R=minux.ma CC=golang-dev https://golang.org/cl/6782082
-
Shenghou Ma authored
now we load jquery in its parent--godoc.html. R=golang-dev, adg CC=golang-dev https://golang.org/cl/6814112
-
Shenghou Ma authored
Write() can safely use uint32 loads when input is aligned. Also add test and benchmarks for unaligned writes. Benchmark result obtained by Dave Cheney on ARMv5TE @ 1.2GHz: benchmark old ns/op new ns/op delta BenchmarkHash8Bytes 4104 3417 -16.74% BenchmarkHash1K 22061 11208 -49.20% BenchmarkHash8K 146630 65148 -55.57% BenchmarkHash8BytesUnaligned 4128 3436 -16.76% BenchmarkHash1KUnaligned 22054 21473 -2.63% BenchmarkHash8KUnaligned 146658 146909 +0.17% benchmark old MB/s new MB/s speedup BenchmarkHash8Bytes 1.95 2.34 1.20x BenchmarkHash1K 46.42 91.36 1.97x BenchmarkHash8K 55.87 125.74 2.25x BenchmarkHash8BytesUnaligned 1.94 2.33 1.20x BenchmarkHash1KUnaligned 46.43 47.69 1.03x BenchmarkHash8KUnaligned 55.86 55.76 1.00x R=golang-dev, dave, bradfitz CC=golang-dev https://golang.org/cl/6782072
-
Shenghou Ma authored
also fix one out-of-date comment in cmd/ld/pe.c as well. R=golang-dev, alex.brainman CC=golang-dev https://golang.org/cl/6843061
-
Dave Cheney authored
Fixes #4393. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6854058
-
Robin Eklind authored
All of the errors were located using "go vet ./..." in "src/pkg". R=golang-dev, iant CC=golang-dev https://golang.org/cl/6856056
-
- 16 Nov, 2012 7 commits
-
-
Brad Fitzpatrick authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/6847063
-
Robert Griesemer authored
ASTs may be created by various tools and built from nodes of different files. An incorrectly constructed AST will likely not print at all, but a (structurally) correct AST with bad position information should still print structurally correct. One heuristic used was to reset indentation when the filename in the position information of nodes changed. However, this can lead to wrong indentation for structurally correct ASTs. Fix: Don't change the indentation in this case. Related to issue 4300. R=r CC=golang-dev https://golang.org/cl/6849066
-
Robert Griesemer authored
ast.Walk needs to check for it or it will crash. R=r CC=golang-dev https://golang.org/cl/6852062
-
Dmitriy Vyukov authored
This significantly decreases amount of shadow memory mapped by race detector. I haven't tested on Windows, but on Linux it reduces virtual memory size from 1351m to 330m for fmt.test. Fixes #4379. R=golang-dev, alex.brainman, iant CC=golang-dev https://golang.org/cl/6849057
-
Oling Cat authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6843069
-
Joel Sing authored
Add support for loading X.509 key pairs that consist of a certificate with an EC public key and its corresponding EC private key. R=agl CC=golang-dev https://golang.org/cl/6776043
-
Dmitriy Vyukov authored
Reincarnation of https://golang.org/cl/6817086 (sent from another account). It is ugly because sync.Once will cause allocation of a closure. Fixes #4343. R=golang-dev, bradfitz, alex.brainman CC=golang-dev https://golang.org/cl/6856046
-
- 15 Nov, 2012 7 commits
-
-
Marcel van Lohuizen authored
compare incrementally. Also modified collation API to be more high-level by removing the need for an explicit buffer to be passed as an argument. This considerably speeds up Compare and CompareString. This change also eliminates the need to reinitialize the normalization buffer for each use of an iter. This also significantly improves performance for Key and KeyString. R=r, rsc CC=golang-dev https://golang.org/cl/6842050
-
Brad Fitzpatrick authored
API change. R=golang-dev, r, iant, rsc CC=golang-dev https://golang.org/cl/6844048
-
Andrew Gerrand authored
R=golang-dev, bradfitz, ftrvxmtrx, franciscossouza, r, minux.ma CC=golang-dev https://golang.org/cl/6843044
-
Rob Pike authored
Fixes #4386. R=golang-dev, iant CC=golang-dev https://golang.org/cl/6854050
-
Dmitriy Vyukov authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/6782075
-
Ian Lance Taylor authored
R=golang-dev, dave, jsing CC=golang-dev https://golang.org/cl/6847051
-
Dave Cheney authored
Revert to the shell builtin to avoid hosts that do not have /usr/bin/time. R=golang-dev, iant CC=golang-dev https://golang.org/cl/6848054
-