Commits · dab268fac34baaa93c41e7239c4412b11ca1e567 · go / golang

30 Jan, 2013 8 commits

cmd/cgo: allow for stdcall decorated dynimport names · dab268fa

James Gray authored Jan 30, 2013

To allow for stdcall decorated names on Windows, two changes were needed:
1. Change the symbol versioning delimiter '@' in cgo's dynimport output to a '#', and in cmd/ld when it parses dynimports.
2. Remove the "@N" decorator from the first argument of cgo's dynimport output (PE only).

Fixes #4607.

R=minux.ma, adg, rsc
CC=golang-dev
https://golang.org/cl/7047043

dab268fa

crypto/rc4: add simple amd64 asm implementation. · 475d86b6

Adam Langley authored Jan 30, 2013

(Although it's still half the speed of OpenSSL.)

benchmark           old ns/op    new ns/op    delta
BenchmarkRC4_128         1409          398  -71.75%
BenchmarkRC4_1K         10920         2898  -73.46%
BenchmarkRC4_8K        131323        23083  -82.42%

benchmark            old MB/s     new MB/s  speedup
BenchmarkRC4_128        90.83       321.43    3.54x
BenchmarkRC4_1K         93.77       353.28    3.77x
BenchmarkRC4_8K         61.65       350.73    5.69x

R=rsc, remyoudompheng
CC=golang-dev, jgrahamc
https://golang.org/cl/7234055

475d86b6

encoding/xml: add (*Encoder).Indent · ee908748

Russ Cox authored Jan 30, 2013

Exposing this on the Encoder allows streaming generation of indented XML.

R=golang-dev, rogpeppe
CC=golang-dev
https://golang.org/cl/7221075

ee908748

cmd/vet: detect misuse of atomic.Add* · 60731765

Rodrigo Rafael Monti Kochenburger authored Jan 30, 2013

Re-assigning the return value of an atomic operation to the same variable being operated is a common mistake:

x = atomic.AddUint64(&x, 1)

Add this check to go vet.

Fixes #4065.

R=dvyukov, golang-dev, remyoudompheng, rsc
CC=golang-dev
https://golang.org/cl/7097048

60731765

include: Plan 9: hide any previous definition of Runemax · 660c4cde

Akshat Kumar authored Jan 30, 2013

Runemax is already defined in libc on 64-bit version of
Plan 9, but is not defined on other versions.
To accommodate, we make sure to rename any previous
instance of Runemax and re-define it subsequently.

R=rsc, ality, rminnich
CC=golang-dev
https://golang.org/cl/7232059

660c4cde

runtime: add support for panic/recover in Plan 9 note handler · c74f3c45

Akshat Kumar authored Jan 30, 2013

This change also resolves some issues with note handling: we now make
sure that there is enough room at the bottom of every goroutine to
execute the note handler, and the `exitstatus' is no longer a global
entity, which resolves some race conditions.

R=rminnich, npe, rsc, ality
CC=golang-dev
https://golang.org/cl/6569068

c74f3c45

C: add Hossein Sheikh Attar (Google CLA) · c5da34ea
Andrew Gerrand authored Jan 30, 2013
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/7241048
```
c5da34ea

runtime: implement range access functions in race detector. · ccc61ead

Rémy Oudompheng authored Jan 30, 2013

Range access functions are already available in TSan library
but were not yet used.

Time for go test -race -short:

Before:
compress/flate 24.244s
exp/norm       >200s
go/printer     78.268s

After:
compress/flate 17.760s
exp/norm        5.537s
go/printer      5.738s

Fixes #4250.

R=dvyukov, golang-dev, fullung
CC=golang-dev
https://golang.org/cl/7229044

ccc61ead

29 Jan, 2013 15 commits

A+C: Rodrigo Rafael Monti Kochenburger (individual CLA) · 76c18a8c
Russ Cox authored Jan 29, 2013
```
Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/7247043
```
76c18a8c
go/misc/dist: Keep file modes when copying. · ba419785
Francesc Campoy authored Jan 29, 2013
```
R=adg
CC=golang-dev
https://golang.org/cl/7221055
```
ba419785
go/build: clean up after rollback · 3bf3ba2d
Andrew Gerrand authored Jan 29, 2013
```
R=rsc
CC=golang-dev
https://golang.org/cl/7237049
```
3bf3ba2d

encoding/json: add test for Unmarshal of malformed data · ad37081b

Russ Cox authored Jan 29, 2013

Roll back CL making primitive type unmarshal faster,
because it broke the Unmarshal of malformed data.

Add benchmarks for unmarshal of primitive types.

Update #3949.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7228061

ad37081b

runtime: clear up lr comments · ec1948a4
Russ Cox authored Jan 29, 2013
```
R=cshapiro
CC=golang-dev
https://golang.org/cl/7230052
```
ec1948a4
codereview: show 'not lgtms' in hg p output (with lgtms) · e1448c07
Russ Cox authored Jan 29, 2013
```
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/7245043
```
e1448c07
cmd/go: add helpful error message when vcs is not found. · 56517aed
Gustavo Franco authored Jan 29, 2013
```
Fixes #4652.

R=bradfitz, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/7094049
```
56517aed

exp/ssa: make Parameters values, not addresses. · aa0b573a

Alan Donovan authored Jan 29, 2013

We explicitly spill all parameters to the frame during initial
SSA construction.  (Later passes will remove spills.)
We now properly handle local Allocs escaping via Captures.

Also: allocate BasicBlock.Succs inline.

R=iant, iant
CC=golang-dev
https://golang.org/cl/7231050

aa0b573a

runtime: dump the full stack of a throwing goroutine · 81221f51

Dmitriy Vyukov authored Jan 29, 2013

Useful for debugging of runtime bugs.
+ Do not print "stack segment boundary" unless GOTRACEBACK>1.
+ Do not traceback system goroutines unless GOTRACEBACK>1.

R=rsc, minux.ma
CC=golang-dev
https://golang.org/cl/7098050

81221f51

go/misc: Adding go-tour to the generated packages for every distribution. · 6c035469
Francesc Campoy authored Jan 29, 2013
```
R=adg, minux.ma
CC=golang-dev
https://golang.org/cl/6976045
```
6c035469
cmd/gc: document more of the declaration context enumeration · 10da5260
Carl Shapiro authored Jan 29, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7231051
```
10da5260
cmd/api: normalize byte to uint8 and rune to int32 · 0e1305ab
Brad Fitzpatrick authored Jan 29, 2013
```
R=golang-dev, adg, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/7195049
```
0e1305ab

encoding/json: add Decoder.Buffered accessor to get overread data · 91e99c13

Brad Fitzpatrick authored Jan 29, 2013

Otherwise it's impossible to know how much data from the
json.Decoder's underlying Reader was actually consumed.

The old fix from golang.org/issue/1955 just added docs. This
provides an actual mechanism.

Update #1955

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/7181053

91e99c13

exp/ssa: fix breakage due to https://code.google.com/p/go/source/detail?r=ca5e5de48173 · 55cac539
Alan Donovan authored Jan 29, 2013
```
I don't understand why this didn't show up during my testing.

R=bradfitz
TBR=bradfitz
CC=golang-dev
https://golang.org/cl/7237047
```
55cac539
test: add test case miscompiled by gccgo · e38339e3
Ian Lance Taylor authored Jan 29, 2013
```
R=golang-dev, bradfitz, rsc, iant
CC=golang-dev
https://golang.org/cl/7240043
```
e38339e3

28 Jan, 2013 14 commits

cmd/ld: avoid a segfault when dumping the symbol table · 1c6b6b12

Carl Shapiro authored Jan 28, 2013

The dumping routine incorrectly assumed that all incoming
symbols would be non-nil and load through it to retrieve the
symbol name.  Instead of using the symbol to retrieve a name,
use the name provided by the caller.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7224043

1c6b6b12

exp/gotype: fix build breakage due to https://code.google.com/p/go/source/detail?r=ca5e5de48173 · 3c51a699

Alan Donovan authored Jan 28, 2013

Add 'math/big' to blacklist of packages that use shift
operations as yet unsupported by go/types.

(The failure was masked due to local bugfixes in my client.)

R=rsc, bradfitz, bradfitz
CC=golang-dev
https://golang.org/cl/7220057

3c51a699

exp/ssa: (#3 of 5): Function, BasicBlock and optimisations · 8f909156
Alan Donovan authored Jan 28, 2013
```
R=gri, iant, iant
CC=golang-dev
https://golang.org/cl/7202051
```
8f909156

exp/ssa: (#2 of 5): core utilities · 66bf5971

Alan Donovan authored Jan 28, 2013

This CL includes the implementation of Literal, all the
Value.String and Instruction.String methods, the sanity
checker, and other misc utilities.

R=gri, iant, iant
CC=golang-dev
https://golang.org/cl/7199052

66bf5971

math/big: add Rat.{,Set}Float64 methods for IEEE 754 conversions. · 961195ae

Alan Donovan authored Jan 28, 2013

Added tests, using input data from strconv.ParseFloat.
Thanks to rsc for most of the test code.

math/big could use some good package-level documentation.

R=remyoudompheng, rsc
CC=golang-dev
https://golang.org/cl/6930059

961195ae

test: add support for build tags. · 4f6a2b98

Rémy Oudompheng authored Jan 28, 2013

This enables a few tests that were only executed
unconditionnally.

R=rsc, minux.ma, bradfitz
CC=golang-dev
https://golang.org/cl/7103051

4f6a2b98

xml: differentiate between float32 and float64 for marshalSimple · cf1f5424
Vega Garcia Luis Alfonso authored Jan 28, 2013
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7235045
```
cf1f5424

runtime: earlier detection of unused spans. · 09ea3b51

Sébastien Paolacci authored Jan 28, 2013

Mark candidate spans one GC pass earlier.

Move scavenger's code out from mgc0 and constrain it into mheap (where it belongs).

R=rsc, dvyukov, minux.ma
CC=golang-dev
https://golang.org/cl/7002049

09ea3b51

go/build: undo CL 7129048 · a8e0a757

Russ Cox authored Jan 28, 2013

This broke 'godoc net/http'.

TBR=adg
CC=golang-dev
https://golang.org/cl/7235052

a8e0a757

net: fix windows build · 2cd5b014
Ian Lance Taylor authored Jan 28, 2013
```
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/7229050
```
2cd5b014
net, syscall: use accept4 and SOCK_CLOEXEC on Linux · 31f58dce
Ian Lance Taylor authored Jan 28, 2013
```
R=golang-dev, bradfitz, mikioh.mikioh, dave, minux.ma
CC=golang-dev
https://golang.org/cl/7227043
```
31f58dce

src: add race.bash · b53e95ac

Dave Cheney authored Jan 28, 2013

Add race.bash so anyone with suitable hardware can run a race detector build. race.bash can be called from the dashboard builder by passing -cmd="race.bash".

Original source for race.bash is here, http://code.google.com/p/go-wiki/wiki/DashboardBuilders

TODO: add race.bat for windows/amd64

R=dvyukov, minux.ma, adg, rsc
CC=fullung, golang-dev
https://golang.org/cl/7179052

b53e95ac

go/ast: Fix typo for the godoc of ObjKind · 1da07a78
Vega Garcia Luis Alfonso authored Jan 28, 2013
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/7232045
```
1da07a78
CONTRIBUTORS: Add Gustavo Franco (Google CLA) · 23c12c9d
Brad Fitzpatrick authored Jan 28, 2013
```
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/7235047
```
23c12c9d

27 Jan, 2013 1 commit

runtime: use new CNT_MASK in lfstack · e65c0a82

Ian Lance Taylor authored Jan 27, 2013

This is for SPARC64, a 64-bit processor that uses all 64-bits
of virtual addresses.  The idea is to use the low order 3 bits
to at least get a small ABA counter.  That should work since
pointers are aligned.  The idea is for SPARC64 to set CNT_MASK
== 7, PTR_BITS == 0, PTR_MASK == 0xffffffffffffff8.

Also add uintptr casts to avoid GCC warnings.  The gccgo
runtime code is compiled with GCC, and GCC warns when casting
between a pointer and a type of a different size.

R=dvyukov
CC=golang-dev
https://golang.org/cl/7225043

e65c0a82

26 Jan, 2013 2 commits

all: make tests able to run multiple times. · 75104237

Rémy Oudompheng authored Jan 26, 2013

It is now possible to run "go test -cpu=1,2,4 std"
successfully.

Fixes #3185.

R=golang-dev, dave, minux.ma, bradfitz
CC=golang-dev
https://golang.org/cl/7196052

75104237

cmd/go: add missing tests · c48f7d6b

Dave Cheney authored Jan 26, 2013

These changes to test.bash were intended to be submitted with CL 6941058, but were accidentally excluded from the original CL.

R=golang-dev
CC=golang-dev
https://golang.org/cl/7232043

c48f7d6b