1. 11 Nov, 2015 13 commits
  2. 10 Nov, 2015 17 commits
  3. 09 Nov, 2015 6 commits
  4. 08 Nov, 2015 4 commits
    • Keith Randall's avatar
      runtime: simplify chan ops, take 2 · e410a527
      Keith Randall authored
      This change is the same as CL #9345 which was reverted,
      except for a small bug fix.
      
      The only change is to the body of sendDirect and its callsite.
      Also added a test.
      
      The problem was during a channel send operation.  The target
      of the send was a sleeping goroutine waiting to receive.  We
      basically do:
      1) Read the destination pointer out of the sudog structure
      2) Copy the value we're sending to that destination pointer
      Unfortunately, the previous change had a goroutine suspend
      point between 1 & 2 (the call to sendDirect).  At that point
      the destination goroutine's stack could be copied (shrunk).
      The pointer we read in step 1 is no longer valid for step 2.
      
      Fixed by not allowing any suspension points between 1 & 2.
      I suspect the old code worked correctly basically by accident.
      
      Fixes #13169
      
      The original 9345:
      
      This change removes the retry mechanism we use for buffered channels.
      Instead, any sender waking up a receiver or vice versa completes the
      full protocol with its counterpart.  This means the counterpart does
      not need to relock the channel when it wakes up.  (Currently
      buffered channels need to relock on wakeup.)
      
      For sends on a channel with waiting receivers, this change replaces
      two copies (sender->queue, queue->receiver) with one (sender->receiver).
      For receives on channels with a waiting sender, two copies are still required.
      
      This change unifies to a large degree the algorithm for buffered
      and unbuffered channels, simplifying the overall implementation.
      
      Fixes #11506
      
      Change-Id: I57dfa3fc219cffa4d48301ee15fe5479299efa09
      Reviewed-on: https://go-review.googlesource.com/16740Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
      e410a527
    • Michael Hudson-Doyle's avatar
      cmd/link, runtime: arm implementation of addmoduledata · 1b4d28f8
      Michael Hudson-Doyle authored
      Change-Id: I3975e10c2445e23c2798a7203a877ff2de3427c7
      Reviewed-on: https://go-review.googlesource.com/14189Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
      1b4d28f8
    • Dominik Honnef's avatar
      cmd/go: send all go build -n output to stderr · 3953c1d8
      Dominik Honnef authored
      Also change a -v print, for consistency.
      
      Fixes #12913
      
      Change-Id: I6cc067d9f8dac66b1f9d1a675e0fbe0528371d0d
      Reviewed-on: https://go-review.googlesource.com/16737Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      3953c1d8
    • Michael Hudson-Doyle's avatar
      cmd/go, cmd/link: allow -buildmode=pie on linux/ppc64le · 2ffdbd7c
      Michael Hudson-Doyle authored
      Change-Id: I0d0abbb9503c3a3c35d846fc0379836b2c483dea
      Reviewed-on: https://go-review.googlesource.com/15962Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
      Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      2ffdbd7c