- 30 Jan, 2013 22 commits
-
-
Marcel van Lohuizen authored
ICU and collate package: ICU requires strings to be in FCD form. Not all NFC strings are in this form, leading to incorrect results. Change to NFD instead. R=rsc CC=golang-dev https://golang.org/cl/7201043
-
Rémy Oudompheng authored
Export data was broken after revision 6b602ab487d6 when -l is specified at least 3 times: it makes the compiler write out func (*T).Method() declarations in export data, which is not supported. Also fix the formatting of recover() in export data. It was not treated like panic() and was rendered as "<node RECOVER>". R=golang-dev, lvd, minux.ma, rsc CC=golang-dev https://golang.org/cl/7067051
-
Daniel Morsing authored
Fixes #4264. R=cldorian, rsc CC=golang-dev https://golang.org/cl/6845113
-
Jeff R. Allen authored
Handle return values from recvfrom correctly when the kernel decides to not return an address. Fixes #4636. Fixes #4352. R=rsc, mikioh.mikioh, dave CC=golang-dev https://golang.org/cl/7058062
-
Akshat Kumar authored
If os.OpenFile holds ForkLock on files that block opens, then threads that simultaneously try to do fork-exec will get hung up (until the open succeeds). Blocked opens are common enough on Plan 9 that protecting against fd leaks into fork-execs means not being able to do fork-execs properly in the general case. Thus, we forgo taking the lock. R=rsc, ality CC=golang-dev https://golang.org/cl/7235066
-
Michael Teichgräber authored
An hostport of "[::1]" now results in the same error message "missing port in address" as the hostport value "127.0.0.1", so SplitHostPort won't complain about "too many colons in address" anymore for an IPv6 address missing a port. Added tests checking the error values. Fixes #4526. R=dave, rsc, mikioh.mikioh CC=golang-dev https://golang.org/cl/7038045
-
Russ Cox authored
Generated by addca. R=gobot CC=golang-dev https://golang.org/cl/7237057
-
Russ Cox authored
I am still not convinced this is a change we should make, but at least documenting it will keep us from forgetting it as we get closer to Go 1.1. R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/7226064
-
Andrey Mirtchovski authored
The JSON unmarshaller failed to allocate an array when there are no values for the input causing the `[]` unmarshalled to []interface{} to generate []interface{}(nil) rather than []interface{}{}. This wasn't caught in the tests because Decode() works correctly and because jsonBig never generated zero-sized arrays. The modification to scanner_test.go quickly triggers the error: without the change to decoder.go, but with the change to scanner_test.go: $ go test --- FAIL: TestUnmarshalMarshal (0.10 seconds) decode_test.go:446: Marshal jsonBig scanner_test.go:206: diverge at 70: «03c1OL6$":null},{"[=» vs «03c1OL6$":[]},{"[=^\» FAIL exit status 1 FAIL encoding/json 0.266s Also added a simple regression to decode_test.go. R=adg, dave, rsc CC=golang-dev https://golang.org/cl/7196050
-
Russ Cox authored
R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/7226063
-
Jan Ziak authored
Binary data in mprof.goc may prevent the garbage collector from freeing memory blocks. This patch replaces all calls to runtime·mallocgc() with calls to an allocator private to mprof.goc, thus making the private memory invisible to the garbage collector. The addrhash variable is moved outside of the .bss section. R=golang-dev, dvyukov, rsc, minux.ma CC=dave, golang-dev, remyoudompheng https://golang.org/cl/7135063
-
Elias Naur authored
Added the -shared flag to 5l/6l to output a PIC executable with the required dynamic relocations and RIP-relative addressing in machine code. Added dummy support to 8l to avoid compilation errors See also: https://golang.org/cl/6822078 https://golang.org/cl/7064048 and https://groups.google.com/d/topic/golang-nuts/P05BDjLcQ5k/discussion R=rsc, iant CC=golang-dev https://golang.org/cl/6926049
-
Russ Cox authored
Fixes #4729. R=golang-dev, iant CC=golang-dev https://golang.org/cl/7232060
-
Russ Cox authored
Generated by addca. R=gobot CC=golang-dev https://golang.org/cl/7230054
-
James Gray authored
To allow for stdcall decorated names on Windows, two changes were needed: 1. Change the symbol versioning delimiter '@' in cgo's dynimport output to a '#', and in cmd/ld when it parses dynimports. 2. Remove the "@N" decorator from the first argument of cgo's dynimport output (PE only). Fixes #4607. R=minux.ma, adg, rsc CC=golang-dev https://golang.org/cl/7047043
-
Adam Langley authored
(Although it's still half the speed of OpenSSL.) benchmark old ns/op new ns/op delta BenchmarkRC4_128 1409 398 -71.75% BenchmarkRC4_1K 10920 2898 -73.46% BenchmarkRC4_8K 131323 23083 -82.42% benchmark old MB/s new MB/s speedup BenchmarkRC4_128 90.83 321.43 3.54x BenchmarkRC4_1K 93.77 353.28 3.77x BenchmarkRC4_8K 61.65 350.73 5.69x R=rsc, remyoudompheng CC=golang-dev, jgrahamc https://golang.org/cl/7234055
-
Russ Cox authored
Exposing this on the Encoder allows streaming generation of indented XML. R=golang-dev, rogpeppe CC=golang-dev https://golang.org/cl/7221075
-
Rodrigo Rafael Monti Kochenburger authored
Re-assigning the return value of an atomic operation to the same variable being operated is a common mistake: x = atomic.AddUint64(&x, 1) Add this check to go vet. Fixes #4065. R=dvyukov, golang-dev, remyoudompheng, rsc CC=golang-dev https://golang.org/cl/7097048
-
Akshat Kumar authored
Runemax is already defined in libc on 64-bit version of Plan 9, but is not defined on other versions. To accommodate, we make sure to rename any previous instance of Runemax and re-define it subsequently. R=rsc, ality, rminnich CC=golang-dev https://golang.org/cl/7232059
-
Akshat Kumar authored
This change also resolves some issues with note handling: we now make sure that there is enough room at the bottom of every goroutine to execute the note handler, and the `exitstatus' is no longer a global entity, which resolves some race conditions. R=rminnich, npe, rsc, ality CC=golang-dev https://golang.org/cl/6569068
-
Andrew Gerrand authored
R=golang-dev CC=golang-dev https://golang.org/cl/7241048
-
Rémy Oudompheng authored
Range access functions are already available in TSan library but were not yet used. Time for go test -race -short: Before: compress/flate 24.244s exp/norm >200s go/printer 78.268s After: compress/flate 17.760s exp/norm 5.537s go/printer 5.738s Fixes #4250. R=dvyukov, golang-dev, fullung CC=golang-dev https://golang.org/cl/7229044
-
- 29 Jan, 2013 15 commits
-
-
Russ Cox authored
Generated by addca. R=gobot CC=golang-dev https://golang.org/cl/7247043
-
Francesc Campoy authored
R=adg CC=golang-dev https://golang.org/cl/7221055
-
Andrew Gerrand authored
R=rsc CC=golang-dev https://golang.org/cl/7237049
-
Russ Cox authored
Roll back CL making primitive type unmarshal faster, because it broke the Unmarshal of malformed data. Add benchmarks for unmarshal of primitive types. Update #3949. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7228061
-
Russ Cox authored
R=cshapiro CC=golang-dev https://golang.org/cl/7230052
-
Russ Cox authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/7245043
-
Gustavo Franco authored
Fixes #4652. R=bradfitz, minux.ma, rsc CC=golang-dev https://golang.org/cl/7094049
-
Alan Donovan authored
We explicitly spill all parameters to the frame during initial SSA construction. (Later passes will remove spills.) We now properly handle local Allocs escaping via Captures. Also: allocate BasicBlock.Succs inline. R=iant, iant CC=golang-dev https://golang.org/cl/7231050
-
Dmitriy Vyukov authored
Useful for debugging of runtime bugs. + Do not print "stack segment boundary" unless GOTRACEBACK>1. + Do not traceback system goroutines unless GOTRACEBACK>1. R=rsc, minux.ma CC=golang-dev https://golang.org/cl/7098050
-
Francesc Campoy authored
R=adg, minux.ma CC=golang-dev https://golang.org/cl/6976045
-
Carl Shapiro authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7231051
-
Brad Fitzpatrick authored
R=golang-dev, adg, mikioh.mikioh CC=golang-dev https://golang.org/cl/7195049
-
Brad Fitzpatrick authored
Otherwise it's impossible to know how much data from the json.Decoder's underlying Reader was actually consumed. The old fix from golang.org/issue/1955 just added docs. This provides an actual mechanism. Update #1955 R=golang-dev, adg, rsc CC=golang-dev https://golang.org/cl/7181053
-
https://code.google.com/p/go/source/detail?r=ca5e5de48173Alan Donovan authored
I don't understand why this didn't show up during my testing. R=bradfitz TBR=bradfitz CC=golang-dev https://golang.org/cl/7237047
-
Ian Lance Taylor authored
R=golang-dev, bradfitz, rsc, iant CC=golang-dev https://golang.org/cl/7240043
-
- 28 Jan, 2013 3 commits
-
-
Carl Shapiro authored
The dumping routine incorrectly assumed that all incoming symbols would be non-nil and load through it to retrieve the symbol name. Instead of using the symbol to retrieve a name, use the name provided by the caller. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7224043
-
https://code.google.com/p/go/source/detail?r=ca5e5de48173Alan Donovan authored
Add 'math/big' to blacklist of packages that use shift operations as yet unsupported by go/types. (The failure was masked due to local bugfixes in my client.) R=rsc, bradfitz, bradfitz CC=golang-dev https://golang.org/cl/7220057
-
Alan Donovan authored
R=gri, iant, iant CC=golang-dev https://golang.org/cl/7202051
-