- 30 Jul, 2014 7 commits
-
-
Rui Ueyama authored
If a user sets his/her own boundary string with SetBoundary, we don't need to call randomBoundary at all. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/95760043
-
Mikio Hara authored
preparing for the syscall package freeze. ««« original CL description syscall: consolidate, simplify socket options for Unix-like systems Also exposes common socket option functions on Solaris. Update #7174 Update #7175 LGTM=aram R=golang-codereviews, aram CC=golang-codereviews https://golang.org/cl/107280044 »»» LGTM=r R=r CC=golang-codereviews https://golang.org/cl/121880043
-
Mikio Hara authored
preparing for the syscall package freeze. ««« original CL description syscall: add source-specific multicast socket options for FreeBSD Update #8266 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/104290043 »»» LGTM=r R=r CC=golang-codereviews https://golang.org/cl/113660043
-
Rui Ueyama authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/118410043
-
Mikio Hara authored
preparing for the syscall package freeze. ««« original CL description syscall: regenerate z-files for darwin Updates z-files from 10.7 kernel-based to 10.9 kernel-based. LGTM=iant R=golang-codereviews, bradfitz, iant CC=golang-codereviews https://golang.org/cl/102610045 »»» LGTM=r R=r CC=golang-codereviews https://golang.org/cl/114530044
-
Mikio Hara authored
preparing for the syscall package freeze. ««« original CL description syscall: add source-specific multicast socket options for Darwin Update #8266 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/101460043 »»» LGTM=r R=r CC=golang-codereviews https://golang.org/cl/115350043
-
Rob Pike authored
Delete an erroneously doubled name in both files. Once is enough. LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/118420043
-
- 29 Jul, 2014 12 commits
-
-
Mihai Borobocea authored
This is meant to share my progress on Issue 8275, if it's useful to you. I'm not familiar with the formatter's internals, so this change is likely naive. Change these calls to measure width in runes not bytes: fmt.Printf("(%5q)\n", '§') fmt.Printf("(%3c)\n", '§') Fixes #8275. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/104320043
-
Keith Randall authored
This is a case that was missed in https://golang.org/cl/105280047/ LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/120910043
-
Rob Pike authored
Generated by a+c. R=gobot CC=golang-codereviews https://golang.org/cl/115370044
-
Dmitriy Vyukov authored
LGTM=khr R=golang-codereviews, khr CC=golang-codereviews, khr https://golang.org/cl/115280043
-
Dmitriy Vyukov authored
LGTM=khr R=golang-codereviews, khr CC=golang-codereviews, khr https://golang.org/cl/114510044
-
Dmitriy Vyukov authored
LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/120280044
-
Dmitriy Vyukov authored
LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/119300043
-
Mikio Hara authored
On Linux, adding a socket descriptor to epoll instance before getting the EINPROGRESS return value from connect system call could be a root cause of spurious on-connect events. See golang.org/issue/8276, golang.org/issue/8426 for further information. All credit to Jason Eggleston <jason@eggnet.com> Fixes #8276. Fixes #8426. LGTM=dvyukov R=dvyukov, golang-codereviews, adg, dave, iant, alex.brainman CC=golang-codereviews https://golang.org/cl/120820043
-
Dmitriy Vyukov authored
Want to see why builders are failing. Then decide whether to rollback or fix. TBR=khr R=khr CC=golang-codereviews https://golang.org/cl/114510043
-
Dmitriy Vyukov authored
Implement the design described in: https://docs.google.com/document/d/1v4Oqa0WwHunqlb8C3ObL_uNQw3DfSY-ztoA-4wWbKcg/pub Summary of the changes: GC uses "2-bits per word" pointer type info embed directly into bitmap. Scanning of stacks/data/heap is unified. The old spans types go away. Compiler generates "sparse" 4-bits type info for GC (directly for GC bitmap). Linker generates "dense" 2-bits type info for data/bss (the same as stacks use). Summary of results: -1680 lines of code total (-1000+ in mgc0.c only) -25% memory consumption -3-7% binary size -15% GC pause reduction -7% run time reduction LGTM=khr R=golang-codereviews, rsc, christoph, khr CC=golang-codereviews, rlh https://golang.org/cl/106260045
-
Rui Ueyama authored
benchmark old ns/op new ns/op delta BenchmarkPaeth 5.06 6.02 +18.97% BenchmarkDecodeGray 1010551 956911 -5.31% BenchmarkDecodeNRGBAGradient 3877813 3754160 -3.19% BenchmarkDecodeNRGBAOpaque 3194058 3079094 -3.60% BenchmarkDecodePaletted 699243 700211 +0.14% BenchmarkDecodeRGB 2835733 2692120 -5.06% BenchmarkDecodeInterlacing 3651805 3563124 -2.43% BenchmarkEncodeGray 4399183 4404113 +0.11% BenchmarkEncodeNRGBOpaque 13323627 13306485 -0.13% BenchmarkEncodeNRGBA 15840092 15751188 -0.56% BenchmarkEncodePaletted 4396622 4404373 +0.18% BenchmarkEncodeRGBOpaque 13320475 13279189 -0.31% BenchmarkEncodeRGBA 36898392 36781002 -0.32% LGTM=nigeltao R=nigeltao CC=golang-codereviews https://golang.org/cl/117290043
-
Rob Pike authored
Because the reference time is the reference time but beginners seem to think otherwise, make it clearer you can't choose the reference time. LGTM=josharian, dave R=golang-codereviews, josharian, dave CC=golang-codereviews https://golang.org/cl/117250044
-
- 28 Jul, 2014 4 commits
-
-
Adam Langley authored
This change causes a TLS client and server to verify that received elliptic curve points are on the expected curve. This isn't actually necessary in the Go TLS stack, but Watson Ladd has convinced me that it's worthwhile because it's pretty cheap and it removes the possibility that some change in the future (e.g. tls-unique) will depend on it without the author checking that precondition. LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/115290046
-
Adam Langley authored
ASN.1 elements can be optional, and can have a default value. Traditionally, Go has omitted elements that are optional and that have the zero value. I believe that's a bug (see [1]). This change causes an optional element with a default value to only be omitted when it has that default value. The previous behaviour of omitting optional, zero elements with no default is retained because it's used quite a lot and will break things if changed. [1] https://groups.google.com/d/msg/Golang-nuts/9Ss6o9CW-Yo/KL_V7hFlyOAJ Fixes #7780. R=bradfitz LGTM=bradfitz R=golang-codereviews, bradfitz, rsc CC=golang-codereviews, r https://golang.org/cl/86960045
-
Asim Shankar authored
R=golang-codereviews, bradfitz, agl CC=golang-codereviews https://golang.org/cl/117180043
-
Brad Fitzpatrick authored
Fixes #8367 LGTM=adg R=adg CC=golang-codereviews https://golang.org/cl/116300044
-
- 26 Jul, 2014 5 commits
-
-
Shenghou Ma authored
While we're here, make it lookup the tlsfallback symbol only once. LGTM=crawshaw R=golang-codereviews, crawshaw, dave CC=golang-codereviews https://golang.org/cl/107430044
-
Shenghou Ma authored
It is already called by linknew(). LGTM=dave R=rsc, dave CC=golang-codereviews https://golang.org/cl/120760043
-
Shenghou Ma authored
LGTM=bradfitz, dave R=rsc, bradfitz, dave CC=golang-codereviews https://golang.org/cl/115070043
-
Shenghou Ma authored
LGTM=dave R=rsc, dave CC=golang-codereviews https://golang.org/cl/116330043
-
Shenghou Ma authored
Unused. cmd/dist will generate enams as liblink/anames[568].c. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/119940043
-
- 25 Jul, 2014 5 commits
-
-
Keith Randall authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/116320043
-
Bobby Powers authored
glibc devs have apparently decided _BSD_SOURCE will be deprecated on Linux, and issue a preprocessor warning if declaring _BSD_SOURCE without _DEFAULT_SOURCE. https://sourceware.org/glibc/wiki/Release/2.20 Fixes #8397. LGTM=iant R=dave, gobot, iant CC=golang-codereviews https://golang.org/cl/112530043
-
Bobby Powers authored
selv is created with temp() which calls tempname, which marks the new n with EscNever, so there is no need to explicitly set EscNone on the select descriptor. Fixes #8396. LGTM=dvyukov R=golang-codereviews, dave, dvyukov CC=golang-codereviews https://golang.org/cl/112520043
-
Alex Brainman authored
LGTM=chines R=chines CC=golang-codereviews https://golang.org/cl/118160044
-
Andrew Gerrand authored
golang.org now serves HTTPS with a valid cert, so it's reasonable that users should click through to the HTTPS versions of *.golang.org and other known sites. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/112650043
-
- 24 Jul, 2014 4 commits
-
-
Mathieu Lonjaret authored
LGTM=minux R=golang-codereviews, minux CC=golang-codereviews https://golang.org/cl/120150043
-
Keith Randall authored
Sweepone may be running while a new span is allocating. It must not see the state updated while the sweepgen is unset. Fixes #8399 LGTM=dvyukov R=golang-codereviews, dvyukov CC=golang-codereviews https://golang.org/cl/118050043
-
David du Colombier authored
Following CL 68150047, the goos and goarch variables are not currently set when the GOOS and GOARCH environment variables are not set. This made the content of the build tag to be ignored in this case. This CL sets goos and goarch to runtime.GOOS and runtime.GOARCH when the GOOS and GOARCH environments variables are not set. LGTM=aram, bradfitz R=golang-codereviews, aram, gobot, rsc, dave, bradfitz CC=golang-codereviews, rsc https://golang.org/cl/112490043
-
Brad Fitzpatrick authored
LGTM=josharian, adg R=golang-codereviews, josharian, adg CC=golang-codereviews https://golang.org/cl/119110043
-
- 23 Jul, 2014 3 commits
-
-
ChaiShushan authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/117060043
-
Dmitriy Vyukov authored
This is bad for 2 reasons: 1. if the code under lock ever grows stack, it will deadlock as stack growing acquires mheap lock. 2. It currently deadlocks with SetCPUProfileRate: scavenger locks mheap, receives prof signal and tries to lock prof lock; meanwhile SetCPUProfileRate locks prof lock and tries to grow stack (presumably in runtime.unlock->futexwakeup). Boom. Let's assume that it Fixes #8407. LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews, khr https://golang.org/cl/112640043
-
Dmitriy Vyukov authored
With cl/112640043 TestCgoDeadlockCrash episodically print: unexpected return pc for runtime.newstackcall After adding debug output I see the following trace: runtime: unexpected return pc for runtime.newstackcall called from 0xc208011b00 runtime.throw(0x414da86) src/pkg/runtime/panic.c:523 +0x77 runtime.gentraceback(0x40165fc, 0xba440c28, 0x0, 0xc208d15200, 0xc200000000, 0xc208ddfd20, 0x20, 0x0, 0x0, 0x300) src/pkg/runtime/traceback_x86.c:185 +0xca4 runtime.callers(0x1, 0xc208ddfd20, 0x20) src/pkg/runtime/traceback_x86.c:438 +0x98 mcommoninit(0xc208ddfc00) src/pkg/runtime/proc.c:369 +0x5c runtime.allocm(0xc208052000) src/pkg/runtime/proc.c:686 +0xa6 newm(0x4017850, 0xc208052000) src/pkg/runtime/proc.c:933 +0x27 startm(0xc208052000, 0x100000001) src/pkg/runtime/proc.c:1011 +0xba wakep() src/pkg/runtime/proc.c:1071 +0x57 resetspinning() src/pkg/runtime/proc.c:1297 +0xa1 schedule() src/pkg/runtime/proc.c:1366 +0x14b runtime.gosched0(0xc20808e240) src/pkg/runtime/proc.c:1465 +0x5b runtime.newstack() src/pkg/runtime/stack.c:891 +0x44d runtime: unexpected return pc for runtime.newstackcall called from 0xc208011b00 runtime.newstackcall(0x4000cbd, 0x4000b80) src/pkg/runtime/asm_amd64.s:278 +0x6f I suspect that it can happen on any stack split. So don't unwind g0 stack. Also, that comment is lying -- we can traceback w/o mcache, CPU profiler does that. LGTM=rsc R=golang-codereviews CC=golang-codereviews, khr, rsc https://golang.org/cl/120040043
-