• Josh Bleecher Snyder's avatar
    cmd/vet: allow any printf verb with any interface · 11e93aa2
    Josh Bleecher Snyder authored
    fmt treats interfaces as being transparent.
    As a result, we cannot say with confidence
    that any particular verb is wrong.
    
    This fixes the following vet false positives
    in the standard library:
    
    database/sql/sql_test.go:210: arg dep for printf verb %p of wrong type: sql.finalCloser
    fmt/fmt_test.go:1663: arg nil for printf verb %s of wrong type: untyped nil
    go/ast/commentmap.go:328: arg node for printf verb %p of wrong type: ast.Node
    net/http/transport_test.go:120: arg c for printf verb %p of wrong type: net.Conn
    net/http/httptest/server.go:198: arg c for printf verb %p of wrong type: net.Conn
    net/http/httputil/dump_test.go:258: arg body for printf verb %p of wrong type: io.Reader
    reflect/set_test.go:81: arg x for printf verb %p of wrong type: io.Writer
    reflect/set_test.go:141: arg bb for printf verb %p of wrong type: io.Reader
    
    Updates #11041
    Updates #16314
    
    Change-Id: I76df01abb3c34a97b6960f551bed9c1c91377cfc
    Reviewed-on: https://go-review.googlesource.com/27127
    Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarRob Pike <r@golang.org>
    11e93aa2
Name
Last commit
Last update
.github Loading commit data...
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...