• Josh Bleecher Snyder's avatar
    cmd/vet: allow any printf verb with any interface · 11e93aa2
    Josh Bleecher Snyder authored
    fmt treats interfaces as being transparent.
    As a result, we cannot say with confidence
    that any particular verb is wrong.
    
    This fixes the following vet false positives
    in the standard library:
    
    database/sql/sql_test.go:210: arg dep for printf verb %p of wrong type: sql.finalCloser
    fmt/fmt_test.go:1663: arg nil for printf verb %s of wrong type: untyped nil
    go/ast/commentmap.go:328: arg node for printf verb %p of wrong type: ast.Node
    net/http/transport_test.go:120: arg c for printf verb %p of wrong type: net.Conn
    net/http/httptest/server.go:198: arg c for printf verb %p of wrong type: net.Conn
    net/http/httputil/dump_test.go:258: arg body for printf verb %p of wrong type: io.Reader
    reflect/set_test.go:81: arg x for printf verb %p of wrong type: io.Writer
    reflect/set_test.go:141: arg bb for printf verb %p of wrong type: io.Reader
    
    Updates #11041
    Updates #16314
    
    Change-Id: I76df01abb3c34a97b6960f551bed9c1c91377cfc
    Reviewed-on: https://go-review.googlesource.com/27127
    Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarRob Pike <r@golang.org>
    11e93aa2
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x/net Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...