• Russ Cox's avatar
    cmd/go: fix disallow of p/vendor/x during vendor experiment · 45971c60
    Russ Cox authored
    The percolation of errors upward in the load process could
    drop errors, meaning that a build tree could, depending on the
    processing order, import the same directory as both "p/vendor/x"
    and as "x". That's not supposed to be allowed. But then, worse,
    the build would generate two jobs for building that directory,
    which would use the same work space and overwrite each other's files,
    leading to very strange failures.
    
    Two fixes:
    
    1. Fix the propagation of errors upward (prefer errors over success).
    2. Check explicitly for duplicated packages before starting a build.
    
    New test for #1.
    Since #2 can't happen, tested #2 by hand after reverting fix for #1.
    
    Fixes #11913.
    
    Change-Id: I6d2fc65f93b8fb5f3b263ace8d5f68d803a2ae5c
    Reviewed-on: https://go-review.googlesource.com/13022Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    45971c60
Name
Last commit
Last update
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...