• Russ Cox's avatar
    cmd/go: fix disallow of p/vendor/x during vendor experiment · 45971c60
    Russ Cox authored
    The percolation of errors upward in the load process could
    drop errors, meaning that a build tree could, depending on the
    processing order, import the same directory as both "p/vendor/x"
    and as "x". That's not supposed to be allowed. But then, worse,
    the build would generate two jobs for building that directory,
    which would use the same work space and overwrite each other's files,
    leading to very strange failures.
    
    Two fixes:
    
    1. Fix the propagation of errors upward (prefer errors over success).
    2. Check explicitly for duplicated packages before starting a build.
    
    New test for #1.
    Since #2 can't happen, tested #2 by hand after reverting fix for #1.
    
    Fixes #11913.
    
    Change-Id: I6d2fc65f93b8fb5f3b263ace8d5f68d803a2ae5c
    Reviewed-on: https://go-review.googlesource.com/13022Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    45971c60
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...