• Josh Bleecher Snyder's avatar
    cmd/compile: convert dxxx to dxxxLSym · 4d600b8e
    Josh Bleecher Snyder authored
    This is an automated refactoring to eliminate
    all dxxx calls in gc/obj.go that accept types.Sym
    instead of obj.LSym parameters.
    
    The refactoring was of the form:
    
    gorename -from '"cmd/compile/internal/gc".duintxx' -to Duintxx
    gorename -from '"cmd/compile/internal/gc".duintxxLSym' -to DuintxxLSym
    eg -t t.go -w cmd/compile/internal/gc
    gofmt -r 'DuintxxLSym -> duintxxLSym' -w cmd/compile/internal/gc
    
    where t.go looked like:
    
    func before(s *types.Sym, off int, v uint64, wid int) int {
    	return gc.Duintxx(s, off, v, wid)
    }
    
    func after(s *types.Sym, off int, v uint64, wid int) int {
    	return gc.DuintxxLSym(s.Linksym(), off, v, wid)
    }
    
    The rename/gofmt shenanigans were to work around
    limitations and bugs in eg and gorename.
    
    The resulting code in reflect.go looks temporarily ugly,
    but it makes refactoring and cleanup opportunities
    much clearer.
    
    Next step is to rename all the dxxx methods to rename the -LSym suffix
    and clean up reflect.go.
    
    The renaming is left for a separate CL to make the changes in
    this CL more obvious, and thus hopefully easier to review.
    
    Passes toolstash-check.
    
    Change-Id: Ib31a2b6fd146ed03a855d20ecb0433f0f74e2f10
    Reviewed-on: https://go-review.googlesource.com/41396
    Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
    Reviewed-by: 's avatarMatthew Dempsky <mdempsky@google.com>
    4d600b8e
Name
Last commit
Last update
.github Loading commit data...
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...