• Josh Bleecher Snyder's avatar
    cmd/compile: convert dxxx to dxxxLSym · 4d600b8e
    Josh Bleecher Snyder authored
    This is an automated refactoring to eliminate
    all dxxx calls in gc/obj.go that accept types.Sym
    instead of obj.LSym parameters.
    
    The refactoring was of the form:
    
    gorename -from '"cmd/compile/internal/gc".duintxx' -to Duintxx
    gorename -from '"cmd/compile/internal/gc".duintxxLSym' -to DuintxxLSym
    eg -t t.go -w cmd/compile/internal/gc
    gofmt -r 'DuintxxLSym -> duintxxLSym' -w cmd/compile/internal/gc
    
    where t.go looked like:
    
    func before(s *types.Sym, off int, v uint64, wid int) int {
    	return gc.Duintxx(s, off, v, wid)
    }
    
    func after(s *types.Sym, off int, v uint64, wid int) int {
    	return gc.DuintxxLSym(s.Linksym(), off, v, wid)
    }
    
    The rename/gofmt shenanigans were to work around
    limitations and bugs in eg and gorename.
    
    The resulting code in reflect.go looks temporarily ugly,
    but it makes refactoring and cleanup opportunities
    much clearer.
    
    Next step is to rename all the dxxx methods to rename the -LSym suffix
    and clean up reflect.go.
    
    The renaming is left for a separate CL to make the changes in
    this CL more obvious, and thus hopefully easier to review.
    
    Passes toolstash-check.
    
    Change-Id: Ib31a2b6fd146ed03a855d20ecb0433f0f74e2f10
    Reviewed-on: https://go-review.googlesource.com/41396
    Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
    Reviewed-by: 's avatarMatthew Dempsky <mdempsky@google.com>
    4d600b8e
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...