• Austin Clements's avatar
    runtime: disallow GC assists in non-preemptible contexts · 4f188c2d
    Austin Clements authored
    Currently it's possible to perform GC work on a system stack or when
    locks are held if there's an allocation that triggers an assist. This
    is generally a bad idea because of the fragility of these contexts,
    and it's incompatible with two changes we're about to make: one is to
    yield after signaling mark completion (which we can't do from a
    non-preemptible context) and the other is to make assists block if
    there's no other way for them to pay off the assist debt.
    
    This commit simply skips the assist if it's called from a
    non-preemptible context. The allocation will still count toward the
    assist debt, so it will be paid off by a later assist. There should be
    little allocation from non-preemptible contexts, so this shouldn't
    harm the overall assist mechanism.
    
    Change-Id: I7bf0e6c73e659fe6b52f27437abf39d76b245c79
    Reviewed-on: https://go-review.googlesource.com/12649Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
    4f188c2d
Name
Last commit
Last update
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...