• Austin Clements's avatar
    runtime: disallow GC assists in non-preemptible contexts · 4f188c2d
    Austin Clements authored
    Currently it's possible to perform GC work on a system stack or when
    locks are held if there's an allocation that triggers an assist. This
    is generally a bad idea because of the fragility of these contexts,
    and it's incompatible with two changes we're about to make: one is to
    yield after signaling mark completion (which we can't do from a
    non-preemptible context) and the other is to make assists block if
    there's no other way for them to pay off the assist debt.
    
    This commit simply skips the assist if it's called from a
    non-preemptible context. The allocation will still count toward the
    assist debt, so it will be paid off by a later assist. There should be
    little allocation from non-preemptible contexts, so this shouldn't
    harm the overall assist mechanism.
    
    Change-Id: I7bf0e6c73e659fe6b52f27437abf39d76b245c79
    Reviewed-on: https://go-review.googlesource.com/12649Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
    4f188c2d
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...