• Heschi Kreinick's avatar
    cmd/link: don't create go.info symbols for non-Go functions · 6d7db25e
    Heschi Kreinick authored
    In writelines the linker uses various auxiliary information about a
    function to create its line table entries. (It also does some unrelated
    stuff, but never mind.) There's no reason to do this for non-Go
    functions, so it bails out if the symbol has no FuncInfo.
    
    However, it does so *after* it looks up (and implicitly creates!) the
    go.info symbol for the function, which doesn't make sense and risks
    creating duplicate symbols for static C functions. Move the check up so
    that it doesn't do that.
    
    Since non-Go functions can't reference Go types, there shouldn't be any
    relocations to type info DIEs that need to be built, so there should be
    no harm not doing that.
    
    I wanted to change the Lookup to an ROLookup but that broke the
    shared-mode tests with an inscrutable error.
    
    No test. It seems too specific to worry about, but if someone disagrees
    I can figure something out.
    
    Fixes #21566
    
    Change-Id: I61f03b7c504a3bf1c4245a8811795b6303469e91
    Reviewed-on: https://go-review.googlesource.com/58630Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    6d7db25e
Name
Last commit
Last update
.github Loading commit data...
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...